From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86160C7EE23 for ; Mon, 22 May 2023 00:01:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 035B3900002; Sun, 21 May 2023 20:01:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F288D6B0075; Sun, 21 May 2023 20:01:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DEF66900002; Sun, 21 May 2023 20:01:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CEE666B0074 for ; Sun, 21 May 2023 20:01:12 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 977A68023C for ; Mon, 22 May 2023 00:01:12 +0000 (UTC) X-FDA: 80815935984.15.DB3D1AB Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf07.hostedemail.com (Postfix) with ESMTP id 992B740013 for ; Mon, 22 May 2023 00:01:10 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Kk4kRfPb; spf=pass (imf07.hostedemail.com: domain of dlemoal@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dlemoal@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684713670; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Bc2SFUlPnAI2ZKM+5CchupBEQ4vBGBqrCqPp9AWv4II=; b=AcaamDg+2m6/DIyXcWwzCGwc0v8xEhzgvnJf3MrGlUMmnvhfLJYhO9+lRNdDJ6WckapI6o 38IaUvg87jjjvPqgK+hhK1rQrVRQ2ngJLYczWwmUyYNXGDCna6vd2NfJpW/JVwk0sK76nR IbY7mamN/7gly7XEGwM1RcdPxrGWCdc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684713670; a=rsa-sha256; cv=none; b=QoYNGWM9pcT7PsSjRcvlaJkc5uppLlQM8x0Wk64S0hbQobJzBpVoFirmaq8ILFoLW6vwFD 8mWdDr3qiMmtYsoEGI8o9W3YWaXkRy7ke4szJBad8qBSYhS351S7d2/jS3CsNCImAMRnwF 6Qh68Eo01wd1noRchrZPAgREqxHEfG4= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Kk4kRfPb; spf=pass (imf07.hostedemail.com: domain of dlemoal@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dlemoal@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 98CB961846; Mon, 22 May 2023 00:01:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5DC2DC433D2; Mon, 22 May 2023 00:01:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684713669; bh=LUd+HLV5GvAukIRTA3zMsj3Wi8CWTQ9goQe7KtJAgHQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Kk4kRfPbbTACy3HBRfR53PIciolvFXLafPUIvBzIIaJxzfuC6EFAkT4x++AFsbuaE UuSH1ecPhhtlnjPxykbWpj2QhKYfH+I9/+UG/FpdlLCzA+Aybo3M/TZL7hKn1etep6 bKTf8mIm/Bqm0iwPBwy/hKYaFXNL6MBg6quCgdeyCI3/SXXIM5E3+FEa8zKs9akvd2 ADmTIg/oK5AjJlytXI1gq43N62j17HXU1JY9EejDLMDRl+7qeYgk7r/CP1e7BguG1a rzyFRiE4z9v686KnqK0luN21wPha2g4uGAQRJJwbeaMhiak/4HLQBy/5ShCOhAST67 I9tsUEuuNKaUQ== Message-ID: <5c66fe46-13eb-d9d2-e107-cc48eb50688f@kernel.org> Date: Mon, 22 May 2023 09:01:05 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 07/13] iomap: update ki_pos in iomap_file_buffered_write Content-Language: en-US To: Christoph Hellwig , Matthew Wilcox Cc: Jens Axboe , Xiubo Li , Ilya Dryomov , Alexander Viro , Christian Brauner , Theodore Ts'o , Jaegeuk Kim , Chao Yu , Miklos Szeredi , Andreas Gruenbacher , "Darrick J. Wong" , Trond Myklebust , Anna Schumaker , Andrew Morton , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, "open list:F2FS FILE SYSTEM" , cluster-devel@redhat.com, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-mm@kvack.org References: <20230519093521.133226-1-hch@lst.de> <20230519093521.133226-8-hch@lst.de> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20230519093521.133226-8-hch@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 992B740013 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 8ig1zzb7xednmra4oh8unptz3anop5mi X-HE-Tag: 1684713670-71090 X-HE-Meta: U2FsdGVkX19W3tmrD2kOCuv4CIbCQHyVMi/PYODv2NElUrshddCfj9RbYzfu7qYLffCw6PR93yXI5wEhOFi51UdWkodRphQhRwbGoNccpNr4PPQsLkW/Qc6pqdkcyvZsTN9JKQVDeL7f1ABWYpxz6RBhG3Uwl89h5l/3ApaUOJXvU0veov9nQpK1ZpxjeCW9LnItNKGz9tcGYDn0wEbjTgKlIRCJcahnnPCY3qZltzm2FI+DaRVOKQFFeflNShPGHSdB5BEiTqQleMrV9OOd08P8x8NrR8E7uowOe1ZyCIqf5c3t4ZxEm+j5ygpHQZ/ZzhgsTSiy8bmIF935RKdbE43NuLS7Oiv+LvrjIlsdnaLucHSrnqnAjXTdi2szN/bikP7khQMMd7rfS2WOV7WGl88TbigFZfFrsrU+iNFW9ro1u9JfE32/Hz7Vagp3LR7M4BVijbXuCKpwcyIOXwucbrYRgdc9K1TUg6ZQvcjXsbneCPhLx+zVeAVktkXwSzBcAUjjhx+DiNdFmhAZdT8e+pKpGwCcib717oQCGcZlD931VnO6Gy/QAJW1imHAoeyK3VVg1BuZ2DEUEqB+3UDFWNw4HsO1sZMiJMtjYAtA9D0b0JlI7S3Wh64Czzcbk0VMgd5dSift/iCuu187UNdyN8pBLL0akBik9V47O/+bBoWRloCV3e+Tdn1Ndz9yOqjx9t9jl0bUqjPQUvq+/FXUj1jhjKtSBITxgkGgTe2kubGaC4cdjo9cqV3ClN3k4Dp9fXC3/40/k1rrzJi07nF3nEDJbIOCa0/eTB1ZRaNUer2xfQAElvw1uXRAjrQMB5gcCnrTX66s+cWIcAmVbwMihLV5AVzk5dKdp2/TsNYTpbsFEAKBajZTDvzMoWABO1vS8T3Z5bC+FxvdRSsk+w3YIhSQY+ZxUF8goKZv8j5Av/mGu6MdXa3eLKH9wNB2Poy4xmGtk1W9WZ4BeOWzZO7 EqtFmwT9 b2hJJd3B8Bv/zSIRYc2HSQJu+/vtC0ukXGLPphSjDlBQ/qBR2XtS/L6k78OEerJswniI28pumqjPeg1D6q3ubXv82ZLsIgoLR73AWsUuJ+j+8+8/XX1uNdNL8+b3fAHxxRAyghH8dre0epX4zRnQCl1wIehxceMmmdNGDmepnipXuBMYdWWAhAo14jPGWdD6X3Gp8aQkzGO7X0F5AaClI6FRvI4bDb4I9VwFP6nq2cEflLIeUBQOOhRK0xL1keSfcECdRyC+Dz2iPeQd5kptEJ1jSRvdUikT2z2XToeABpXQ47srVIEBADQkPh9x+0vftQ/x7lnabbWjP/p57lnz9qD8kBZYooetu2Jhr+Da81jpX/tPQ9ygA1MR9yJ3nH4JrYJa8EVGijeV9ico2J+rdL7zrPVShPu2Ly3OhdzQ3DJ7DEFYQh/EA11COAQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/19/23 18:35, Christoph Hellwig wrote: > All callers of iomap_file_buffered_write need to updated ki_pos, move it > into common code. > > Signed-off-by: Christoph Hellwig One nit below. Acked-by: Damien Le Moal > diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c > index 063133ec77f49e..550525a525c45c 100644 > --- a/fs/iomap/buffered-io.c > +++ b/fs/iomap/buffered-io.c > @@ -864,16 +864,19 @@ iomap_file_buffered_write(struct kiocb *iocb, struct iov_iter *i, > .len = iov_iter_count(i), > .flags = IOMAP_WRITE, > }; > - int ret; > + ssize_t ret; > > if (iocb->ki_flags & IOCB_NOWAIT) > iter.flags |= IOMAP_NOWAIT; > > while ((ret = iomap_iter(&iter, ops)) > 0) > iter.processed = iomap_write_iter(&iter, i); > - if (iter.pos == iocb->ki_pos) > + > + if (unlikely(ret < 0)) Nit: This could be if (unlikely(ret <= 0)), no ? > return ret; > - return iter.pos - iocb->ki_pos; > + ret = iter.pos - iocb->ki_pos; > + iocb->ki_pos += ret; > + return ret; -- Damien Le Moal Western Digital Research