From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0297C433E7 for ; Thu, 3 Sep 2020 06:47:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6C6B72071B for ; Thu, 3 Sep 2020 06:47:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C6B72071B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0789D6B0003; Thu, 3 Sep 2020 02:47:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 028516B0037; Thu, 3 Sep 2020 02:47:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E80996B0055; Thu, 3 Sep 2020 02:47:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0009.hostedemail.com [216.40.44.9]) by kanga.kvack.org (Postfix) with ESMTP id D23A76B0003 for ; Thu, 3 Sep 2020 02:47:31 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 84CE63634 for ; Thu, 3 Sep 2020 06:47:31 +0000 (UTC) X-FDA: 77220819102.29.toad22_101537a270a7 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin29.hostedemail.com (Postfix) with ESMTP id 59355180868EE for ; Thu, 3 Sep 2020 06:47:31 +0000 (UTC) X-HE-Tag: toad22_101537a270a7 X-Filterd-Recvd-Size: 2482 Received: from out30-130.freemail.mail.aliyun.com (out30-130.freemail.mail.aliyun.com [115.124.30.130]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Thu, 3 Sep 2020 06:47:29 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R141e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01355;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---0U7nVAgx_1599115640; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0U7nVAgx_1599115640) by smtp.aliyun-inc.com(127.0.0.1); Thu, 03 Sep 2020 14:47:21 +0800 Subject: Re: [PATCH v3 3/3] mm/armv6: work around armv6 cmpxchg support issue To: Matthew Wilcox Cc: Anshuman Khandual , David Hildenbrand , Andrew Morton , Baolin Wang , Russell King , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <1598928612-68996-1-git-send-email-alex.shi@linux.alibaba.com> <1598928612-68996-3-git-send-email-alex.shi@linux.alibaba.com> <20200901131749.GL14765@casper.infradead.org> From: Alex Shi Message-ID: <5c6020c8-2fdd-13ef-0e83-bea3b32364af@linux.alibaba.com> Date: Thu, 3 Sep 2020 14:47:13 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200901131749.GL14765@casper.infradead.org> Content-Type: text/plain; charset=gbk X-Rspamd-Queue-Id: 59355180868EE X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: =D4=DA 2020/9/1 =CF=C2=CE=E79:17, Matthew Wilcox =D0=B4=B5=C0: > On Tue, Sep 01, 2020 at 02:30:51PM +0800, Alex Shi wrote: >> seems there are couples archs can not do cmpxchg1 >> So update the patch here. And it's easy to fix if more arch issue find= here. >=20 >> +/* >> + * cmpxchg only support 32-bits operands on the following archs ARMv6= , SPARC32 >> + * sh2, XTENSA. >> + */ >> +#if defined(CONFIG_CPU_V6) || defined(CONFIG_CPU_SH2) || \ >> + defined(CONFIG_SPARC32) || defined(CONFIG_XTENSA) >=20 > Looks like we need a HAVE_CMPXCHG_BYTE in Kconfig to parallel > HAVE_CMPXCHG_DOUBLE. >=20 Thanks for reminder! Compare the HAVE_CMPXCHG_BYTE, NO_CMPXCHG_BYTE would= be better for less code change.=20 I will send the v4 for a bit more change on patch 2. Thanks! Alex