From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A47B7C7618D for ; Tue, 4 Apr 2023 07:31:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A20C6B0071; Tue, 4 Apr 2023 03:31:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 253326B0074; Tue, 4 Apr 2023 03:31:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F31E6B0075; Tue, 4 Apr 2023 03:31:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id F00506B0071 for ; Tue, 4 Apr 2023 03:31:29 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C8DF61A0769 for ; Tue, 4 Apr 2023 07:31:29 +0000 (UTC) X-FDA: 80642888298.12.3A278C0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 9CEE2140004 for ; Tue, 4 Apr 2023 07:31:27 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=exycW2ub; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680593487; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UtZR8/RCDui641OHVeuDBdP9asgKQnGNK+6bWZHRowc=; b=6t38zpFDROL5OAPLgh5wLYWNjydsucDMLlV+pAFLTENElrc6MR/IIwZtjFQcJG9joyUWtW XYq26+5NAz/f3pz7JeLcdBtiB9a9UqTfvusp30xeBpzC+KwkREDBrCuGFWlp83kDfWfFKK qRw4mMFZ0kDtEQ/CknZiIOdjnoL1vUI= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=exycW2ub; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680593487; a=rsa-sha256; cv=none; b=XbjyVryn4zRQJShDCLW8bgCASFGSzGJBCSKQhjShagsC1HPsKKe5CvCBaJpT9iWzVrsfLq IONh94LxILakf2/BvW/DOvWRRH8X4yfnSohIMSXAwiMDEkkCh2vh1DsfaDFqU0Wu864Gfh /kQRUpiy9m4lspbnXtnUdJph46JC2/g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680593486; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UtZR8/RCDui641OHVeuDBdP9asgKQnGNK+6bWZHRowc=; b=exycW2ubMvByebVn9AktID1sCQHkiEEZYlNQiVqTurxfmzdcQWnhq1MW3cSR1NcOgAjiRn sBMGjFIWbNxZUQCM/c+1FGGBZjzArLKqdSGZlrG0lDUnHsIKoH/ORnql+gZ7yz12ws9iVn cENYkqiQ4D2MCFKRybfnugn+CW0eQig= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-441-WUH0ZLMDO0iHagtK0Bnvlw-1; Tue, 04 Apr 2023 03:31:18 -0400 X-MC-Unique: WUH0ZLMDO0iHagtK0Bnvlw-1 Received: by mail-wm1-f72.google.com with SMTP id r11-20020a05600c458b00b003eea8d25f06so15899064wmo.1 for ; Tue, 04 Apr 2023 00:31:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680593477; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UtZR8/RCDui641OHVeuDBdP9asgKQnGNK+6bWZHRowc=; b=vKpY7joqpmNDw+KKfhFXN4M2YcLaSfjI5s45jlWFeU7QJymcU2JvnhK/+OkYRLwaKt xArCEaP6xrb2uqO6DRekUBkucruboCj84ji1Hue6+gEyHYG9+0D230lHOwtrtIhrqaWa 6LNHuBiCwYV9PqYu/LgEZCeYxWpG1ByMMdYuDo/1ltfUyLhGMgZJYdsF+62aCzMqerLN EP3cj9+TsWGzEZvBe+o3Ebic202ah5gLg2b8S39jQ6yDnaxpQqx5fcFRCEeaZ7sBMuKL JzjohsFT4PkTK8tRis/sSYrp8+5ehFPYqQpo0LAxonDRe8TmEccLWeGJhv3SI3J68E0H FTxQ== X-Gm-Message-State: AAQBX9fnSNXBXJyUjonhZmSIYMn3vrxRsYPVz8bt52XOIs0WzB0pp0MH ua9BVkdiUNQrwoVqyeEcVqMXpAyEksnWGhsL2jNUafu4kqwWeG/JTKRLmXX9y0rVpla6iVJJfQg AstJl4c0GKgg= X-Received: by 2002:a05:600c:2291:b0:3ee:5d1d:6c4e with SMTP id 17-20020a05600c229100b003ee5d1d6c4emr1349581wmf.16.1680593477072; Tue, 04 Apr 2023 00:31:17 -0700 (PDT) X-Google-Smtp-Source: AKy350bYbI3qNHfFi766ASxpwJRAZ5scFYZVV2/fpRxOFnzGf88jPExHEZWHMpCgQEnRstVcXJdH4w== X-Received: by 2002:a05:600c:2291:b0:3ee:5d1d:6c4e with SMTP id 17-20020a05600c229100b003ee5d1d6c4emr1349562wmf.16.1680593476713; Tue, 04 Apr 2023 00:31:16 -0700 (PDT) Received: from ?IPV6:2003:cb:c709:b600:e63:6c3b:7b5d:f439? (p200300cbc709b6000e636c3b7b5df439.dip0.t-ipconnect.de. [2003:cb:c709:b600:e63:6c3b:7b5d:f439]) by smtp.gmail.com with ESMTPSA id ip21-20020a05600ca69500b003edf2ae2432sm20873735wmb.7.2023.04.04.00.31.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Apr 2023 00:31:16 -0700 (PDT) Message-ID: <5c415fa5-1637-883d-8136-fc4280274406@redhat.com> Date: Tue, 4 Apr 2023 09:31:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] selftests/mm: fix memory leak in child_memcmp_fn To: Feng Jiang , akpm@linux-foundation.org, shuah@kernel.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Ming Xie References: <20230404031234.78272-1-jiangfeng@kylinos.cn> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230404031234.78272-1-jiangfeng@kylinos.cn> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 9CEE2140004 X-Stat-Signature: zfb14boyahnc478yaibeuxd9q95jc6cx X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1680593487-115579 X-HE-Meta: U2FsdGVkX19XUZpjoP4GbqMpBwBx1/FkyhDbSIBIEIrjGnqaGUn35njz9vBTF0DKKapthg0jfj6SMU7h9helHYu/FXHDYFm0V4SYhKCKrXuG++jgQqQxphXDyuDhwIuXV8hzMCB1Dz9chGmipiq6l0oHSI6WhxB2PnLIseZfSgRDBFzhqSBHldtvMdPxrwt0yZW17AASQy4zO50GDcJyPij07koiHvONOR0LASUjrXGWF9e/lt4iL31qsX1hRV53WnBY5BrL43Vj/JDJn1nxQ1QEGoWj5DLzP8cCARHIfvLInRyZsw1rNqvQd1ib+beJb8RFlLgx9CFoxR28q+bgyqL+bOw3Ro7giV2c/ikEoBOhYXnE8qxTw4deBi6HmphxJwALmvjM2Q1AK58f/ipiE1XVcJSHzHCfI1MEXTRYNlbx5j/JPflBIrMoIv10Q09y85VjJhOIzVo9kp4WEJGuPcUJru2urWs4XGd6Qgi1prK37UCKQr3CPO1lQLw8/7LaoFXws0AFDbij2T81L2co/fnk3Hyo4108KjASwEyR58OVdjrk+E8MQANcENJ0nlgzcNXkdj0ciRP9R1pa4bCuS+G+u6rjvdN0OWkBzj2W/vTG2p2wKfaTmAe1klf7UkxV1UANB4jT2WHp1dNm0rYsGSxVUyDWawzJ2tqfCWv9WPMRp1MkeLv/YcZUBi+Qb+qR3JjJqFI/XrB1TV1mTuUSE+wR1TZeEK+3jD/BGkjsXH0WyiOaDKHH9LV1DCySj2q49SxHV279O13TDjyMBc8bz9ZjTi5prsmZusNWt8vGWwnxIYWdDAQO3C/rOQTx7dbxoyI2SCzWDgUEDjaA70//CNonI5V0FAWAOoDqwNHjOv2HlQhPpXby2RUxWMgKHJp9Gk6nXj10VOjqUVn0Qv7wUrOE2O58a2Mebgre8Atp/d6vhEjVGetRgntgKZUVKTERiKe2Mz9xJVXwCYiwMPR jq1F1Z5Y ysqsgzddKv+HGYWIViVKg2vT0jlBu/YNTQjUDITEa0mnKvQnJmmXplvS8FvoX3ydl962pDTcNfwXohSR/E5LmYW6K6siUQ6QeZ99V1EXErP8cc07YKUoqUZBt/5nObsDAhrzpDJWAh6XyJ1c3BO+TS9hbbJysQpM+/VXzD2NCyaKVk2KqSNQHLFda6aiHQM3KA5DWYQwD0ln904Wbrr9T5SDj5WJ6xIoF+9wi3U5EmZLIydGOEB5AXzLC7jysZLBi5Noef0j4eeg236TSzcO8EqXyvYBw3w0zi8m1qgbOw2twmtQeGfA3htlFsGJ06p2ps0A8f+DajkAvdPPFGqiWF+OfVwyx9ZwRj+fHXd1HQKJknvRZi1diP67tRCxxXA9rXGEn7UZdwlQrGYYHliEuJs4Hqy9/vRoHez200/gr/oglW5rh8RPptayQzApytRDcHpAk X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 04.04.23 05:12, Feng Jiang wrote: > The allocated memory should be freed on return. > > Signed-off-by: Feng Jiang > Suggested-by: Ming Xie > --- > tools/testing/selftests/mm/cow.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/cow.c b/tools/testing/selftests/mm/cow.c > index 0eb2e8180aa5..c0dd2dfca51b 100644 > --- a/tools/testing/selftests/mm/cow.c > +++ b/tools/testing/selftests/mm/cow.c > @@ -162,6 +162,10 @@ static int child_memcmp_fn(char *mem, size_t size, > { > char *old = malloc(size); > char buf; > + int ret; > + > + if (!old) > + return -ENOMEM; > > /* Backup the original content. */ > memcpy(old, mem, size); > @@ -172,7 +176,10 @@ static int child_memcmp_fn(char *mem, size_t size, > ; > > /* See if we still read the old values. */ > - return memcmp(old, mem, size); > + ret = memcmp(old, mem, size); > + free(old); > + > + return ret; > } > > static int child_vmsplice_memcmp_fn(char *mem, size_t size, NAK, the whole point of this function is that the child process will exit immediately after executing this function, cleaning up automatically. -- Thanks, David / dhildenb