From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9499C433DB for ; Wed, 24 Mar 2021 20:09:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 35182619F2 for ; Wed, 24 Mar 2021 20:09:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 35182619F2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id ADB676B030F; Wed, 24 Mar 2021 16:09:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A8AE26B0310; Wed, 24 Mar 2021 16:09:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9052A6B0311; Wed, 24 Mar 2021 16:09:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0061.hostedemail.com [216.40.44.61]) by kanga.kvack.org (Postfix) with ESMTP id 7582E6B030F for ; Wed, 24 Mar 2021 16:09:58 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 337CEB7A3 for ; Wed, 24 Mar 2021 20:09:58 +0000 (UTC) X-FDA: 77955858876.08.8423FAE Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by imf12.hostedemail.com (Postfix) with ESMTP id 97BD13C3 for ; Wed, 24 Mar 2021 20:09:56 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: tonyk) with ESMTPSA id 8EEA71F45E6A Subject: Re: [RFC PATCH 1/4] Revert "libfs: unexport generic_ci_d_compare() and generic_ci_d_hash()" To: Matthew Wilcox Cc: Hugh Dickins , Andrew Morton , Alexander Viro , krisman@collabora.com, smcv@collabora.com, kernel@collabora.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Rosenberg References: <20210323195941.69720-1-andrealmeid@collabora.com> <20210323195941.69720-2-andrealmeid@collabora.com> <20210323201530.GL1719932@casper.infradead.org> From: =?UTF-8?Q?Andr=c3=a9_Almeida?= Message-ID: <5c20d261-eef2-aecc-8f1e-58fb5dbfcd72@collabora.com> Date: Wed, 24 Mar 2021 17:09:48 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210323201530.GL1719932@casper.infradead.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Stat-Signature: 979wbbkwpcrq9ekm4nyau8mh5h4sa575 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 97BD13C3 Received-SPF: none (collabora.com>: No applicable sender policy available) receiver=imf12; identity=mailfrom; envelope-from=""; helo=bhuna.collabora.co.uk; client-ip=46.235.227.227 X-HE-DKIM-Result: none/none X-HE-Tag: 1616616596-443355 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Matthew, =C3=80s 17:15 de 23/03/21, Matthew Wilcox escreveu: > On Tue, Mar 23, 2021 at 04:59:38PM -0300, Andr=C3=A9 Almeida wrote: >> This reverts commit 794c43f716845e2d48ce195ed5c4179a4e05ce5f. >> >> For implementing casefolding support at tmpfs, it needs to set dentry >> operations at superblock level, given that tmpfs has no support for >> fscrypt and we don't need to set operations on a per-dentry basis. >> Revert this commit so we can access those exported function from tmpfs >> code. >=20 > But tmpfs / shmem are Kconfig bools, not tristate. They can't be built > as modules, so there's no need to export the symbols. >=20 >> +#ifdef CONFIG_UNICODE >> +extern int generic_ci_d_hash(const struct dentry *dentry, struct qstr= *str); >> +extern int generic_ci_d_compare(const struct dentry *dentry, unsigned= int len, >> + const char *str, const struct qstr *name); >> +#endif >=20 > There's no need for the ifdef (it only causes unnecessary rebuilds) and > the 'extern' keyword is also unwelcome. >=20 Thank you. Instead of reverting the commit, I'll do a new commit doing=20 this in a properly way.