From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8AA0C43461 for ; Wed, 16 Sep 2020 18:50:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 58884205F4 for ; Wed, 16 Sep 2020 18:50:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 58884205F4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CBD8E900009; Wed, 16 Sep 2020 14:50:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C45A1900007; Wed, 16 Sep 2020 14:50:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B0EF6900009; Wed, 16 Sep 2020 14:50:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0055.hostedemail.com [216.40.44.55]) by kanga.kvack.org (Postfix) with ESMTP id 9738C900007 for ; Wed, 16 Sep 2020 14:50:45 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 5AB241DE7 for ; Wed, 16 Sep 2020 18:50:45 +0000 (UTC) X-FDA: 77269816050.03.birds76_1f08a912711c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id 1F8EB28A4E8 for ; Wed, 16 Sep 2020 18:50:45 +0000 (UTC) X-HE-Tag: birds76_1f08a912711c X-Filterd-Recvd-Size: 3466 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Wed, 16 Sep 2020 18:50:44 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A4D40AF6D; Wed, 16 Sep 2020 18:50:58 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 16 Sep 2020 20:50:41 +0200 From: osalvador@suse.de To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-hyperv@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, Andrew Morton , Alexander Duyck , Dave Hansen , Haiyang Zhang , "K. Y. Srinivasan" , Mel Gorman , Michael Ellerman , Michal Hocko , Mike Rapoport , Scott Cheloha , Stephen Hemminger , Vlastimil Babka , Wei Liu , Wei Yang Subject: Re: [PATCH RFC 0/4] mm: place pages to the freelist tail when onling and undoing isolation In-Reply-To: <20200916183411.64756-1-david@redhat.com> References: <20200916183411.64756-1-david@redhat.com> User-Agent: Roundcube Webmail Message-ID: <5c0910c2cd0d9d351e509392a45552fb@suse.de> X-Sender: osalvador@suse.de X-Rspamd-Queue-Id: 1F8EB28A4E8 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2020-09-16 20:34, David Hildenbrand wrote: > When adding separate memory blocks via add_memory*() and onlining them > immediately, the metadata (especially the memmap) of the next block > will be > placed onto one of the just added+onlined block. This creates a chain > of unmovable allocations: If the last memory block cannot get > offlined+removed() so will all dependant ones. We directly have > unmovable > allocations all over the place. > > This can be observed quite easily using virtio-mem, however, it can > also > be observed when using DIMMs. The freshly onlined pages will usually be > placed to the head of the freelists, meaning they will be allocated > next, > turning the just-added memory usually immediately un-removable. The > fresh pages are cold, prefering to allocate others (that might be hot) > also feels to be the natural thing to do. > > It also applies to the hyper-v balloon xen-balloon, and ppc64 dlpar: > when > adding separate, successive memory blocks, each memory block will have > unmovable allocations on them - for example gigantic pages will fail to > allocate. > > While the ZONE_NORMAL doesn't provide any guarantees that memory can > get > offlined+removed again (any kind of fragmentation with unmovable > allocations is possible), there are many scenarios (hotplugging a lot > of > memory, running workload, hotunplug some memory/as much as possible) > where > we can offline+remove quite a lot with this patchset. Hi David, I did not read through the patchset yet, so sorry if the question is nonsense, but is this not trying to fix the same issue the vmemmap patches did? [1] I was about to give it a new respin now that thw hwpoison stuff has been settled. [1] https://patchwork.kernel.org/cover/11059175/ >