From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8716BC4345F for ; Thu, 25 Apr 2024 07:22:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 08B846B00A4; Thu, 25 Apr 2024 03:22:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 03A846B00A6; Thu, 25 Apr 2024 03:22:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF68E6B00A7; Thu, 25 Apr 2024 03:22:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C20726B00A4 for ; Thu, 25 Apr 2024 03:22:46 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 6EF8CA1229 for ; Thu, 25 Apr 2024 07:22:46 +0000 (UTC) X-FDA: 82047211932.19.0953B98 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 39B35A001F for ; Thu, 25 Apr 2024 07:22:44 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=A73zDoPb; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714029764; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1wvj6rHie2mkYIT18Ii5PP5d7RtrSiI7SbILhABnz9g=; b=nSGwuV3xaW3T7lJkdi8qB+nUxSOnxeyGazPy6L7smmSZLtRTa7yQeDc4LMUi7CjSa94Omv O5EbAbozBwxwhTIgvMe7W9qWknp/RA94aJX+7Cnjjm/jYu0Y3wFhIoY71iFi8vYvuK7pv4 rIadJzHlhzhUcVeyOon7MqClhSvNYzs= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=A73zDoPb; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714029764; a=rsa-sha256; cv=none; b=5ngxEeRF+MRztYHiW17Gm298KUO5S0IVcdo/h9Yt+46Ts7ru/b27CtKp3nNiVHRZcjC117 r/n0uSZ6DeuTawO9UDxHDWImLl5ALiWPraCqwGxXWwlxXBHgb0t1R9A6joHURJrVLJIS6X wtnE+NeAUtnxzHAhxsAVpi+Utk3SV4M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714029763; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=1wvj6rHie2mkYIT18Ii5PP5d7RtrSiI7SbILhABnz9g=; b=A73zDoPbn1h4kaKtZxHvqjGoFuKEEcRLD4dGEo6nqXtgZ9DJIT5tvEPKDhiB2E+x/9yHMH 0suSfTMWbMqehjKIVEpfmj2/kcYO6B4Cf+N6PSHu+lM2ksdyRF05wRvAWsHXyjZ4+KelJf Mp8DJmD7KnT3ePUS5fowGn26whAhKNs= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-540-ey_gDKomOIGzfM1WzW8MHg-1; Thu, 25 Apr 2024 03:22:41 -0400 X-MC-Unique: ey_gDKomOIGzfM1WzW8MHg-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-419ec098d81so3342795e9.2 for ; Thu, 25 Apr 2024 00:22:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714029760; x=1714634560; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1wvj6rHie2mkYIT18Ii5PP5d7RtrSiI7SbILhABnz9g=; b=GrrTWt122obxc63cdKSJ0aCZsYacBtAR8dnCLOfYHAQ9PCxlGVASHn1I/4+mITSSiw 4rAu26G2sngC616/jClvF7Rp8kdr5gQmD8pofU1zbUbdqDfIn0hnSZ5P43bZHQlkO7RK M7EXlRzdJho20Kb3znnh4jloiBsJ0c7cRhr8b/pu+nLdGADttla9mZ7WTb3YWTLzqsAe GGHPAKpn9aRcmDGi2R3X+Xql+d2mKdhuicjWd0MUECy1y6tfdfpqolF9+G9p6Ww6iPuB RedwIByoFWrVKxG0qb5C1vlrk+sXVDopQmZAI4opsbWXR1epA/koiaH2/jBFil7hD5vY PxqQ== X-Forwarded-Encrypted: i=1; AJvYcCVgaUyyDGVS5d+gbaY/7LE6zTEBrgCC2dyW9jMgUqWXlb5z0McBSteSmB2zrV7SEdjaFlp3SmPmNQfs/BJCmmtApW0= X-Gm-Message-State: AOJu0Yy9yOA3TMhm3qm1GNE+DJjeFtFlTTY30F3fVBXE0GRaDvtTaNVX Ky0guYzd6nXeU+vXyXNvfOqCcJnOekDXrma2LT2yjl80u7gGNWsevlFsTsxJSGxz46/QDP6VoQC 0nOnKutToiLZYQgsQt/nhbQkZmMA7GutDca7M/LcWT+XNBhuI X-Received: by 2002:a05:600c:444b:b0:417:f5ab:cae with SMTP id v11-20020a05600c444b00b00417f5ab0caemr3649847wmn.10.1714029760782; Thu, 25 Apr 2024 00:22:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEfwiSlxeHF26SH+H+oIXCakuouPZm+3+lUr975cGYvI47bW8k9LAjU9n/spkUC4qGrT89UNQ== X-Received: by 2002:a05:600c:444b:b0:417:f5ab:cae with SMTP id v11-20020a05600c444b00b00417f5ab0caemr3649836wmn.10.1714029760412; Thu, 25 Apr 2024 00:22:40 -0700 (PDT) Received: from ?IPV6:2003:cb:c719:8200:487a:3426:a17e:d7b7? (p200300cbc7198200487a3426a17ed7b7.dip0.t-ipconnect.de. [2003:cb:c719:8200:487a:3426:a17e:d7b7]) by smtp.gmail.com with ESMTPSA id e6-20020a05600c4e4600b0041b43e301e8sm1306500wmq.42.2024.04.25.00.22.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Apr 2024 00:22:39 -0700 (PDT) Message-ID: <5bf467d3-f596-4986-9e27-f2707efbe6a3@redhat.com> Date: Thu, 25 Apr 2024 09:22:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm: add more readable thp_vma_allowable_order_foo() To: Kefeng Wang , Matthew Wilcox Cc: Andrew Morton , Ryan Roberts , linux-mm@kvack.org References: <20240425035108.3063-1-wangkefeng.wang@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 39B35A001F X-Rspam-User: X-Stat-Signature: ppycf1umqkf7sqj5bnoi8nhnemcryr8y X-HE-Tag: 1714029764-118625 X-HE-Meta: U2FsdGVkX19jSoZ6inIhGUiQQzXXrqL3hP/lUhMxTKKylokqhc0udoLssS3uPzd/9uER/R6Yl1vBcSxGSdbLp6fOgdaonzV31/vXtCapqKee4LLy67POGHFRlOb9JFc80zK7Ya0KIZxRnBcRlutJ0rd9zp1fInVfc2+7kc3TP4I1ey/34Oc6+2PIwCXCOmWB9ajWcSTC+uELmcgJ3aoCsOqqht3PUYQjNW1Ogt4U4TOKpMdMi1pDfOHRHc7U5rJlwUx/F4ve0mBI+4K+YcGaB1skpUxBK2NPSBUkCYZEMsub3CveP7ruzhXeQTBjUrmvpvo2h2nIkIFHQmveVE0VTMkR5oLQGL6zyfULrXyqhZqU1FlKqfmjeE1zK6tm8r1VYo4BTa7gQzUVGPhRaSB9V74paTWP45B2DRTXf8OZj+0tT9p81F234pYGEDVNIQEdv4LWYobYPLBThHjXM91AdncqhZidg/XZtgPeTvqeFG1iDJH11FjFHkHOs11W0hWd61NYzNuK9MtnlHzEbeQxo3BTceWcDzxLCHBYUZKSx2S0grBz76ADlRAgvJU9sf/PtB18SnTbFiDXaykY89kSEl96WsNWFCxsx0gs4s/uYW3w0nzooKdNSrcSi+6avUzlKVKIGqpvL6/WdO6wxXbhKxnaQGlN4rT7ylXMnQoCBQN0Pnt9ZXhJ06LfEDN8NpKMYGvhwRKtNihNJspAQUdMf6poJWonw4nAJcMlpXpk9RYFCtRvoea7Vsvpp6kJIfj8k+Csc8LebFBgPLcSDhB8pmDs1lHDHO235dYuY2YHX0KIL5VPxkoeIyxYTHMXmAdzeB6sOGxzNQaTqlU2Ph1J+xkJyU8ztU2WZZIO215nBSf7jPX6J6W9ooyUxB7jGYz967oeeEgYsdC7nzeKxo5zLX3raI8zz6UikzE/uaJ4PbPDqMs+Lft9CTx8QCqIy9Rx/c60kj49ukXoXIZuhH5 tjm4vdnM lmk7LhQDoE+P719p1aZcmdSLdLMAAjDmz75PbZ8uXDUg70ZTLeiE++p8vvdU5I6Qq137bVSF3j4ZKfGxnp7N2FPyyYv5/2EwDhv1fGyym8DX3QdGx/DYUaW3JAaH8yxWXPoQeLzBZnfiZymWjJY8G2PBTyFmaPEo91qkv1NGAfaF7QgeYA8IocBoTceOXJamdGs0yZafk8kdX+MPE+F5CeZT7uPHPNHOxprGGj91o4uhUN/VP38pJJ9Zyl18FuxkSygH0/Usl3r7oxJnY7CQ3EFvI1UOc+78dOA+ti+7oExelLrq3u/Wwl90RwFjifuJzimZQGnkBJr2v/VSC9d8sKa8AoIikv6XLgV+6HhF4rU7dqsNwAv3hdf+j3YR4c5WWVJm55x81+FLHwmkOrdVDy5JoTGmMpVa7UegjuDmNvjlzwfS7cWJbsYWHY+zoCmkSSWXCNywM+UhPY52P68mEOTv0Eg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25.04.24 09:18, Kefeng Wang wrote: > > > On 2024/4/25 12:00, Matthew Wilcox wrote: >> On Thu, Apr 25, 2024 at 11:51:08AM +0800, Kefeng Wang wrote: >>> There are too many bool arguments in thp_vma_allowable_orders(), adding >>> some more readable thp_vma_allowable_order_foo(), >> >> Here's an alternative approach I came up with and forgot to send out. >> I take no position on which is better. > > Always confuse, either way is fine, even combine the two way, let's see > Ryan/David's option. It's shocking how Willy and I sometimes create almost identical patches ;) I played with the same flags idea during mTHP bringup. And I think I prefer the flags version. -- Cheers, David / dhildenb