From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2B42C021BC for ; Tue, 25 Feb 2025 03:46:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B50A6B0085; Mon, 24 Feb 2025 22:46:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 664CE280002; Mon, 24 Feb 2025 22:46:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52CBD280001; Mon, 24 Feb 2025 22:46:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 35FB56B0085 for ; Mon, 24 Feb 2025 22:46:32 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BA26F1C7E25 for ; Tue, 25 Feb 2025 03:46:31 +0000 (UTC) X-FDA: 83157079782.07.7D1521A Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf27.hostedemail.com (Postfix) with ESMTP id E77B040008 for ; Tue, 25 Feb 2025 03:46:29 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=Sj4Vbr65; spf=pass (imf27.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740455190; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=g0Ocxe5/W3x8AaSNUp1nmQA6Ns9xuyK5JD/uD9z0OJg=; b=fGUN/VkHQKeU/dJTOx4ehsbLfly4Dw2ABprkzKhXxY5CvIltAEy7DwL06naFj1JpZIvVK6 tOMsmjzHu4vPLruwj0xdUShCWI+Of3FB4RN+8290G4QO9UoeRTYqFQBJuZ94IiT5XO8G+n Di9Y6UNCAjVsmJGjIheaZ6xofMFgcg0= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=Sj4Vbr65; spf=pass (imf27.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740455190; a=rsa-sha256; cv=none; b=MNLS+api8sGOSegx4G9BsFkTxpsowb/P8ngUj4Ps4XLxro8Mx92RIewoJxTuk3SFTNxPDn b+/9hR1mBQ1JDWWRDUu1J2ut48oduHjWIVRDqwS3rq2xYXR/BKhm/ueYmX+NgfEBNk/+eh u63i510px7BxrTGUpP3/pKhVaEZ8nIQ= Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-220bff984a0so108512015ad.3 for ; Mon, 24 Feb 2025 19:46:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1740455189; x=1741059989; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=g0Ocxe5/W3x8AaSNUp1nmQA6Ns9xuyK5JD/uD9z0OJg=; b=Sj4Vbr65cua7QDj5D4wwWmJl3hFUxW4emqc/JiXf9VTbzKnu+sdaE3u2wKCfp5GMCH bMkCS7smOv3GBde7K534++/JsYqZS63aKeBcdS+lXSGB4TTylJg9ToZqgL4llrFRYC14 hHWl+zqci3/iwy5an4hdp8pz16NFian0kxk0ONsL+a9ywz49A9RHVJ0DjrX+g540XEuB OifGv2eWKEgF6tML+A3t6Kr8/YubIe7XswN6jwtOZLZUj8AJf1VZ0t3+Gmqt+wcn3Se8 Z+OtZCeasD0zM5LDn5SAMdC3P2cggAhKiZG3TKvG3Rw84S0pa2IiUjjBqI45JmgQTTx+ HH9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740455189; x=1741059989; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g0Ocxe5/W3x8AaSNUp1nmQA6Ns9xuyK5JD/uD9z0OJg=; b=tUdjwC9aVt8bIjATRErBLbhQvqe8Vhl6qIrg908Ks8KSQLBKhG63xxA4IKxIoHH7IJ wnrs5/y/mTAP35JTn01+8yiufEPMl0J5peUKPDL1C0Azx4Tb4mHIAfpirXmHcP6xIX5b 6Edz5Oj8uSNwXEzANC867Ad3HU0yarCUSXWaT6E5eaHMfUlw9X0Vf45ZA46yBVE56BCP 9cFw9gMZVcER5nsSAyG7lOJREC06x5+/gjEXuQmQ4fR/ZRC3PRYMzIlPqOBUIa0skVDy tOZHkIsC65UsTFukXDnmhozT5lw/5JjYpIsOFmj7VC3cT2NEp03j6bgXNevvkxsC0Ora 2ncA== X-Gm-Message-State: AOJu0Yy+l1ouLGQcoHkutVtjebnJkXtA8+Hn6Ny53fdxDiniRhAGIYNS l3P5aZPHsKf7Tw/EGdSLzm5j9VthCFjpeOaNkirfAnaKLrJf7EvMohIYlvS8PvM= X-Gm-Gg: ASbGncvJx3t8EsgJGGGvRyPTg8dz+tKFOQSzYPrICpua8vf5UII6Jg8Bo8rHjBK/fx3 MqbZErnJnmlloBeCt7ZH/IbZ22tPf1caIm+DQV4aXpcZK5TVY4rtvxy5b3nq0NsB8alUqXGZyUK wGM4Yzx2J4MTZbK+FjITzR9d5u7lrEzY09073oOc7cFxwYKq2+ImP62CGQtF1AdLB5YanCaxZ/5 E40ZuzR7LE5eHjaUv3kQUbDSm/vp8cRrrwQiwLHyxiNJfFtlh6DoG6gi+lASKXtqhSzxQOVEFsx RGIuk2/ry4qZOKlO6eVpnxYqua1m+T/u1f3uRjGR9eSWLw3gWC+ILywFxmIR8w3Eiw== X-Google-Smtp-Source: AGHT+IGBfXw23ytiI6FvQDqnu6HA+6X81xKlY5Cdi/AJkyrR2YGvsG8wye6vZ+K3tNu1qHLJYKOiEg== X-Received: by 2002:a05:6a00:22c9:b0:731:771:38f2 with SMTP id d2e1a72fcca58-734790de607mr3427312b3a.8.1740455188892; Mon, 24 Feb 2025 19:46:28 -0800 (PST) Received: from C02DW0BEMD6R.bytedance.net ([63.216.146.179]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7347a81f014sm409429b3a.156.2025.02.24.19.46.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Feb 2025 19:46:28 -0800 (PST) From: Qi Zheng To: peterz@infradead.org, kevin.brodsky@arm.com, riel@surriel.com, vishal.moola@gmail.com, david@redhat.com, jannh@google.com, hughd@google.com, willy@infradead.org, yuzhao@google.com, muchun.song@linux.dev, akpm@linux-foundation.org, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, arnd@arndb.de, dave.hansen@linux.intel.com, rppt@kernel.org, alexghiti@rivosinc.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org, x86@kernel.org, linux-riscv@lists.infradead.org, Qi Zheng Subject: [PATCH v2 1/6] mm: pgtable: make generic tlb_remove_table() use struct ptdesc Date: Tue, 25 Feb 2025 11:45:51 +0800 Message-Id: <5be8c3ab7bd68510bf0db4cf84010f4dfe372917.1740454179.git.zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: E77B040008 X-Stat-Signature: emaa94c33pbxjjqua33pptti4g3n1zqc X-Rspamd-Server: rspam03 X-HE-Tag: 1740455189-957054 X-HE-Meta: U2FsdGVkX18WQJdSBnBdAlDQQExnXgJqmVRluAyrJHwh9bFRze+6AkJ30OyLdQcLutWb7usjwC9dXxXwnhN6fyPBDruU9em7PyCB3P8SRvqxeIYyUp3WbzxsR1EMsvRjQs+1qIpZ8qsxnLFRM+lyKdPdCbi45l0GaWJmKAXAqFVLk17cCRnKHB6ONx1PjrEc/WkUrcdP1jDzOk/13qKfZ3YMnne9NNX0n8IIdPqC5tbDUZ817Zn4lngkU+rU+ohy/6c7abGdIBL4BJa41eyXBjFgiF8YctCMvSu3/G6FL6R34yIE879jwU8btHf/Jjp3jlnJn0+/QQpkgvLqL+uGEVkxVmTyHfjrvrx69QHljgdhFEIK5jgeIkPDkirdvhBwVthq83FULqnsEXAAhs/n/qvS2vb2loMYjb912R0n78GX/l2yFce1lHfE4yn+5lQd7zqCXAsos5k/9LEc2YUB+xDC4IjiLVXYk/duR4t78Bji5RMW40vw+qtEwKuIslf5ELCxZFPGLWmNomLq/FRo6GqEJlY0NrMWnwFCUriMsDVRxoZC1MI5P9DupYfQf8+k84qlmlD88iXj7xSr4DEfKq7h/F1Ft6E7m8VtgHBp5VB3RPfJx8pDb5ecwI1cHRV91fiKOJ+xJJC5yWSmHtnD07BFh6gID0RbZrw7mGI1U212j50XHYuAbsy+rm2srP/nCQlKDNNp6RXtguDqYRs4Bu5+uhgzv4uwatBDjcwzqo5gpNEfZZvP4BpqKJvpeD7WC+G1TmhVWx1IIoQ4Frgy/XIN5JeUAZoi6idk/noV5mH5EVEY0U42VnslpRQYUImUqbR1qZzen9N9WPOvMC2L8gIRphIPYLvbuxPO2teoMYrBbwmVlTKjpdgzRfLFiIXQ/MNz/L4D0w65wa3iu5PF27xDSYgeCk0HYoja5McK5EZ2Z2oyYoMnA4Uq2BUJmM9fzFSMKpDJ5BGmpflYHVe t3SCjSKa 31XeveehRhF261jAqF3vaFBytqWEid8jy2xX3ka67hpnB3D06xrI2h3K7tRuORtZTwJETStG9lFUMgpazqcNGTNMWaEAKnPsQv4dPD4ahktCJrlPUU10HL+cvrVGkZsmPnEqaW9cuECXpEVlQ9WZMrUL4NJ93Entb4K5/sfUMF2tkj9qpWD3pop+CJBYG31uKw04VnU7woZCpSH2bssmZK5VrPDnE0xxb6wqK5C4hcwaGCHwOP8pMs8thNfsjrVg0hWlPWsKX8Os5LdMRz7Hm3kFkKeoY8NFjuurudylueV2U+DnFSFYu0kFTTp2N0i8Mc673XRTZvfwHFu9qnKGrYXnxeWNtncIfcM3iCkpxt5yYiOKuOainIHxY6NUBQIyikUUdI0BPNt5OuZ+1+OUw+oR0dO4pviqZgTe0fn9wC5DE4L4/y9iRCcn1XA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Now only arm will call tlb_remove_ptdesc()/tlb_remove_table() when CONFIG_MMU_GATHER_TABLE_FREE is disabled. In this case, the type of the table parameter is actually struct ptdesc * instead of struct page *. Since struct ptdesc still overlaps with struct page and has not been separated from it, forcing the table parameter to struct page * will not cause any problems at this time. But this is definitely incorrect and needs to be fixed. So just like the generic __tlb_remove_table(), let generic tlb_remove_table() use struct ptdesc by default when CONFIG_MMU_GATHER_TABLE_FREE is disabled. Signed-off-by: Qi Zheng --- include/asm-generic/tlb.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/asm-generic/tlb.h b/include/asm-generic/tlb.h index b35b36fa7aabf..54f579750c8e5 100644 --- a/include/asm-generic/tlb.h +++ b/include/asm-generic/tlb.h @@ -232,10 +232,10 @@ static inline void tlb_remove_page(struct mmu_gather *tlb, struct page *page); */ static inline void tlb_remove_table(struct mmu_gather *tlb, void *table) { - struct page *page = (struct page *)table; + struct ptdesc *ptdesc = (struct ptdesc *)table; - pagetable_dtor(page_ptdesc(page)); - tlb_remove_page(tlb, page); + pagetable_dtor(ptdesc); + tlb_remove_page(tlb, ptdesc_page(ptdesc)); } #endif /* CONFIG_MMU_GATHER_TABLE_FREE */ -- 2.20.1