From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2CBBC48260 for ; Mon, 19 Feb 2024 09:17:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 36E436B008A; Mon, 19 Feb 2024 04:17:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 31E5A6B008C; Mon, 19 Feb 2024 04:17:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1988F6B0092; Mon, 19 Feb 2024 04:17:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0232F6B008A for ; Mon, 19 Feb 2024 04:17:42 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C0303A02D6 for ; Mon, 19 Feb 2024 09:17:41 +0000 (UTC) X-FDA: 81808000722.20.9A53908 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf08.hostedemail.com (Postfix) with ESMTP id 86BE316000D for ; Mon, 19 Feb 2024 09:17:38 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="MWMh6DJ/"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=GzteuApn; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=nhZfcUQl; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=8v+r0UKC; dmarc=none; spf=pass (imf08.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708334259; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vIC/a+gVDD7XPQtjCAkXOILzScqhk7P47GEkxD0UDQs=; b=lWj+a7cUJ0hKTA8KpfUCv8qfAFZckDkFL0dfKovCqfsaHCsAOiE53d1kjxTfNMcbs/BzaW g7GjFDZo29tqyXD4V03E60+By7H6OGWZEFc/fqxBX9DZ+HROXVY/odg09ZX9GomD49gLde uhuJDcuflG9cpAw1knQOwX60RW7wY5s= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="MWMh6DJ/"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=GzteuApn; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=nhZfcUQl; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=8v+r0UKC; dmarc=none; spf=pass (imf08.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708334259; a=rsa-sha256; cv=none; b=Kyo4q+Z8d2u59C9hHrXaabcXezMG3zJrF25PAftp82ijcCjkdRCAU9Wyekhl1sTiS+NkXo 1BlBOLahczwjQZojs7YLgRv0HpTtKbp8UdEypPhUgAYDCs7cEV6iK44zz6V73RYh7ASSPy wuU3ap6nwAqmkleYiUqM1vZ4kB3mqcg= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A57101F7E6; Mon, 19 Feb 2024 09:17:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708334256; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vIC/a+gVDD7XPQtjCAkXOILzScqhk7P47GEkxD0UDQs=; b=MWMh6DJ/ibVstvW8CHhxalEdn+EfDp2Pp6CLtUS7w2G8aKm80u24jjbaqFlFeJq3lsm9Ch zmZU9F9fWuq1aSYZnzyc2Nr6Wh+ESMVZCBy+st8OYiqW4rLl90iwbWjzdnPcA6cBBX1juT wQ7oin3joQHdQCFUzFj+7IJwYO/35a0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708334256; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vIC/a+gVDD7XPQtjCAkXOILzScqhk7P47GEkxD0UDQs=; b=GzteuApnghPs8TtGI0ScLwvh9hL/i4LonLgBBl+wck2XX6f4rm3q0fbvXB4+6HxOzNxgPu qyCzH5DeLqoEgEBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708334254; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vIC/a+gVDD7XPQtjCAkXOILzScqhk7P47GEkxD0UDQs=; b=nhZfcUQlK7pH0NXDM7sv2fYcGG6ZDiDb66Gs3exRJKPJtn1oKKXZk7O+L9mcFpHEICfrnI AaunILK2z67g4pS3/czle2C8GcshxFhiA/5Fdd7m6L0ODF+AijttNP+JrMY5ZWs86XQc47 L4h7iwvt+dm0nWThHKdQsKNIJzn5kPA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708334254; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vIC/a+gVDD7XPQtjCAkXOILzScqhk7P47GEkxD0UDQs=; b=8v+r0UKCTIoGKIjYstbF4ma5EEhXx29Kjd7rwRP4H+96aLGc+a6L9kcHVm8j614GlmUDPP qNjxnGR/35wREXDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 18E5713647; Mon, 19 Feb 2024 09:17:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id gyquBa4c02VrEgAAD6G6ig (envelope-from ); Mon, 19 Feb 2024 09:17:34 +0000 Message-ID: <5bd3761f-217d-45bb-bcd2-797f82c8a44f@suse.cz> Date: Mon, 19 Feb 2024 10:17:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 32/35] codetag: debug: skip objext checking when it's for objext itself Content-Language: en-US To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-33-surenb@google.com> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spamd-Bar: / X-Rspamd-Queue-Id: 86BE316000D X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 7egibgrytnrb4ad15hu9uunw9tu3grn4 X-HE-Tag: 1708334258-440879 X-HE-Meta: U2FsdGVkX19n8urI0IRD1uHcXsjutuYLSY4q7CcCnhj9qzY4l+DsZm77oqUyM1YGl2g06+Cbc3JllmOcydyuFueTCY6qQmA8AQYUZZHWNoOTcJ621DfUgWBww6MOFoIPLJqOXElbhj8gC78Iffuh6HkL583hUgr4quzbaCOCwLrs49x4Nf/+3m+mCDs2tKn3EyHjly2FInKgmlOEsKlZvfZi88/a3h/sSGPkfQoZxjLtwXrmbT2wBy0j54FS5HB0R1Xnpb5ayu5DK2LflVQz9C41C21RuR33qMJHgViu6uZuH2uWIZo+Fc17UdCugbzSOJ46YcXJXnNcwSwb3O2q02UeIAN0oVgLBfuFsW4ce43+ruNX2hkvW2Rb0csdKPRWXN84nd7iVp4EJvgMGOwKwY1gNsr7RmTSujE1d/VgzC+s2gUOPEYJYuFnAoN7vJDoDUjkOrHCnxHQR9/lDUsqgaQDkNSdIj36BFu0nzC0+KQCU8JhZyBHYlarNMvfu5wx8GDKPPlJnFfXVyQqPRLX85Ku8fOwLlCaM+mkuso716ZskKXkqM5VW/kCD5SgkzXvq8tJnU2p9c/iS3xw9HkLRPHIgW5OtRMIG1prL4GNrNmFyumv5gWujfdYZPUjJAkRARGnOvlx9m4jptlVuDR8zYkU9Y5JZKSxi4jio5NSK3/6gyeQZehehmX7bf6F5VyWCDIFhwjkl+1zoT1o3RkyWLD7D653RqBsZ9r31VLe5e3AuG5BB96uZhH40t3uluQmgud803osmL45d0fNO2djxsGwm0tot+zIpfdM4GJ+VG3caxH1sMXSBwm74bPgYtMZHCuY92U3mtusJf6h9mfJcSg11TWQj6ONUTN2pZYG3S8OL0NakONVumlSDdF7it0Bn92bv3hhWZ0S5GFDRgiVzfoiDSwtuLljn9bV2G+KjDTxTClA7a4MnBslyBJBWfsO1ftPrgow3Ycy5xy7vPQ 5su5Dlh+ aDJ5SCx7eHwfUXNJry9ZCqsLPwO7bBZeua85s X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/19/24 02:04, Suren Baghdasaryan wrote: > On Fri, Feb 16, 2024 at 6:39 PM Vlastimil Babka wrote: >> >> On 2/12/24 22:39, Suren Baghdasaryan wrote: >> > objext objects are created with __GFP_NO_OBJ_EXT flag and therefore have >> > no corresponding objext themselves (otherwise we would get an infinite >> > recursion). When freeing these objects their codetag will be empty and >> > when CONFIG_MEM_ALLOC_PROFILING_DEBUG is enabled this will lead to false >> > warnings. Introduce CODETAG_EMPTY special codetag value to mark >> > allocations which intentionally lack codetag to avoid these warnings. >> > Set objext codetags to CODETAG_EMPTY before freeing to indicate that >> > the codetag is expected to be empty. >> > >> > Signed-off-by: Suren Baghdasaryan >> > --- >> > include/linux/alloc_tag.h | 26 ++++++++++++++++++++++++++ >> > mm/slab.h | 25 +++++++++++++++++++++++++ >> > mm/slab_common.c | 1 + >> > mm/slub.c | 8 ++++++++ >> > 4 files changed, 60 insertions(+) >> > >> > diff --git a/include/linux/alloc_tag.h b/include/linux/alloc_tag.h >> > index 0a5973c4ad77..1f3207097b03 100644 >> >> ... >> >> > index c4bd0d5348cb..cf332a839bf4 100644 >> > --- a/mm/slab.h >> > +++ b/mm/slab.h >> > @@ -567,6 +567,31 @@ static inline struct slabobj_ext *slab_obj_exts(struct slab *slab) >> > int alloc_slab_obj_exts(struct slab *slab, struct kmem_cache *s, >> > gfp_t gfp, bool new_slab); >> > >> > + >> > +#ifdef CONFIG_MEM_ALLOC_PROFILING_DEBUG >> > + >> > +static inline void mark_objexts_empty(struct slabobj_ext *obj_exts) >> > +{ >> > + struct slabobj_ext *slab_exts; >> > + struct slab *obj_exts_slab; >> > + >> > + obj_exts_slab = virt_to_slab(obj_exts); >> > + slab_exts = slab_obj_exts(obj_exts_slab); >> > + if (slab_exts) { >> > + unsigned int offs = obj_to_index(obj_exts_slab->slab_cache, >> > + obj_exts_slab, obj_exts); >> > + /* codetag should be NULL */ >> > + WARN_ON(slab_exts[offs].ref.ct); >> > + set_codetag_empty(&slab_exts[offs].ref); >> > + } >> > +} >> > + >> > +#else /* CONFIG_MEM_ALLOC_PROFILING_DEBUG */ >> > + >> > +static inline void mark_objexts_empty(struct slabobj_ext *obj_exts) {} >> > + >> > +#endif /* CONFIG_MEM_ALLOC_PROFILING_DEBUG */ >> > + >> >> I assume with alloc_slab_obj_exts() moved to slub.c, mark_objexts_empty() >> could move there too. > > No, I think mark_objexts_empty() belongs here. This patch introduced > the function and uses it. Makes sense to me to keep it all together. Hi, here I didn't mean moving between patches, but files. alloc_slab_obj_exts() in slub.c means all callers of mark_objexts_empty() are in slub.c so it doesn't need to be in slab.h Also same thing with mark_failed_objexts_alloc() and handle_failed_objexts_alloc() in patch 34/35.