From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1251CE77184 for ; Thu, 19 Dec 2024 10:17:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 29EB36B0082; Thu, 19 Dec 2024 05:17:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 24F096B0083; Thu, 19 Dec 2024 05:17:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 117106B0085; Thu, 19 Dec 2024 05:17:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E8C156B0082 for ; Thu, 19 Dec 2024 05:17:55 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 620E81604CF for ; Thu, 19 Dec 2024 10:17:55 +0000 (UTC) X-FDA: 82911306660.30.38F9B81 Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by imf21.hostedemail.com (Postfix) with ESMTP id 161071C0010 for ; Thu, 19 Dec 2024 10:16:48 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf21.hostedemail.com: domain of yukaixiong@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=yukaixiong@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734603458; a=rsa-sha256; cv=none; b=UG7i0CyeqCYB0MZtkiKz0M6Masvg83AjCVIOEjpn52bqsDVyDPe4SLRjvCLl07ntNQwVTf FOQB4n7NtXsoVfOCaqbBFIlP5TIU84Hh2L9J3aJcVrq531d+/LTyWBkJVdHHUh83gCl+Mi wWVCvfassD9HL32ql2irKYOrEgrl6Zc= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf21.hostedemail.com: domain of yukaixiong@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=yukaixiong@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734603458; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LcKnCeI+yatJtLARPxd9dsDGYEwMhJtWi4VLYTclELE=; b=VAI1lZyADqHkk6bGtWJR11nBxKVi2+lzugz+BQD4z5pZiYvriwyZvRqyx+Yj8vZ43OS+tg 4WdPcJoCXloO0xEGbGjxU4Rm6VLvfZO2GSZGPpFAME/rqhFf7Z03CvaAEmf1HX1nZsnIEK 3tyCyIHOnGFkGSqyJ/JmVSyejl2KAcg= Received: from mail.maildlp.com (unknown [172.19.88.214]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4YDRJn5k4mz21nYj; Thu, 19 Dec 2024 18:15:53 +0800 (CST) Received: from kwepemh100016.china.huawei.com (unknown [7.202.181.102]) by mail.maildlp.com (Postfix) with ESMTPS id 3FA571A016C; Thu, 19 Dec 2024 18:17:47 +0800 (CST) Received: from [10.174.179.93] (10.174.179.93) by kwepemh100016.china.huawei.com (7.202.181.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 19 Dec 2024 18:17:43 +0800 Subject: Re: [PATCH v3 -next 11/15] sunrpc: use vfs_pressure_ratio() helper To: NeilBrown , Jeff Layton References: <> <12ec5b63b17b360f2e249a4de0ac7b86e09851a3.camel@kernel.org> <172859659591.444407.1507982523726708908@noble.neil.brown.name> CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , From: yukaixiong Message-ID: <5bcb9ace-de01-e597-92a2-22013aa695ba@huawei.com> Date: Thu, 19 Dec 2024 18:17:36 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <172859659591.444407.1507982523726708908@noble.neil.brown.name> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.93] X-ClientProxiedBy: dggpeml100004.china.huawei.com (7.185.36.247) To kwepemh100016.china.huawei.com (7.202.181.102) X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 161071C0010 X-Stat-Signature: nhuqe8rtm774sy65wh51aongwip1tw71 X-HE-Tag: 1734603408-260762 X-HE-Meta: U2FsdGVkX1+MPtbxm0erSePMendLOSzS8OfJzaTnssisnsBLjVlJMt6MP7dkEkAVfx5f+XkfJT9yw3Wqyu/Sb0poPhYD10Mj1ODN/SjPgkuMa/nhYcmlQX7jGePSr++8l4BydbpZ/TTl7qe5FfLKiz+6nAiG7MG0wwygHbl+/A56pIxnkCTMNWXa1BkmX2cDHkMcOJob1vhcXFVQ+adoPkW9hDurj4E4cbtng6dEaDHRLU73SmQwswvz2K+RNL2T3luYdUe5wxnqzfamkeEsOzi3o3TcKC8nTar279DVrqzI7SvfNfbEzuPHhE3G4N6+T/w8TC+DdCXEXb3xya2fqHc0v/l7ACtxdzkjXzsFir7uSXanMvtboKqrewO0pcJgtyrnE8fr3ZKgF6wVh4PgZ9E6UrTGpu5V22C/In4WSvuNCGSv1b0V+B+pZo009Kd08VLE93ikdqczqRwar3RKxXdi8TErdTcFsaPqQ23ohcQ7tMywGpBp2h3Lq2cdROxQX1gAHBc4bV7uRVemHr2BWD0cSxRzzjvDdASpdPjTwVzKn2r3o+XzHBypQUqlsD7K20WWRHrpd6LmZ6XMLB5JDFcSsX3eBa7SY9SZJq7KSJ2yREEF5bAztFBZplaE8Us6R5ft2p2zRpTyQkj2Wj4VISDkyksHYBrCimj1/j/h5U0yp750Dy+q0g2UmqGxtfmRnpldg2iTvCQEm9Wz9CNx0eD1ScgOzTZhou5006S4N7h5ArBl4knHB/w3l4Sha36ANHmpqgQFVQO7Za5zPANIcfpHQny9vGprALSGeKCSgRIgph2jce2BhOX5vbpTcSkkFLKyxtkLzeP3IPvCV9cOfgpHkxb7CMrC4srVowupvAlfDzSQwYE2uwLA9eRidK06bbBbT0Xmnda5kIuuMJHo2E8n3KEUcsFeiOq2yv26XgPXkxjmWtch/qfg5P/tpBJtniHGWSYUlGViYGcyuVW B7tnPNtv zm+ZdTqVVBezLok7G6BE8jEzAcdQPxMeMS2XNT9PC62AjuaQglJlKNDRjRwlpSEuUNlU8JrVQsWgy/ZBJCyYZqjB1+eeAqEdxIPicg/BQMRN74D7/wuJuC12M7tn/B6q8RqFLgJCSfBEFn3TdmvXeRd88NKQNXPnZWaBcsB1Nncn5V3aGu/dyEYzUNgLpBi1MfSqMfgGf4rstq1Q8SC8rGoKPqGbQziiKX/nQ0ugmyJ236sFpJzbVm/+m+nO3/NTR1gPt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/10/11 5:43, NeilBrown wrote: > On Fri, 11 Oct 2024, Jeff Layton wrote: >> On Thu, 2024-10-10 at 23:22 +0800, Kaixiong Yu wrote: >>> Use vfs_pressure_ratio() to simplify code. >>> >>> Signed-off-by: Kaixiong Yu >>> Reviewed-by: Kees Cook >>> Acked-by: Anna Schumaker >>> --- >>> net/sunrpc/auth.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/net/sunrpc/auth.c b/net/sunrpc/auth.c >>> index 04534ea537c8..3d2b51d7e934 100644 >>> --- a/net/sunrpc/auth.c >>> +++ b/net/sunrpc/auth.c >>> @@ -489,7 +489,7 @@ static unsigned long >>> rpcauth_cache_shrink_count(struct shrinker *shrink, struct shrink_control *sc) >>> >>> { >>> - return number_cred_unused * sysctl_vfs_cache_pressure / 100; >>> + return vfs_pressure_ratio(number_cred_unused); >>> } >>> >>> static void >> Acked-by: Jeff Layton >> > I realise this is a bit of a tangent, and I'm not objecting to this > patch, but I wonder what the justification is for using > vfs_cache_pressure here. The sysctl is documented as > > This percentage value controls the tendency of the kernel to reclaim > the memory which is used for caching of directory and inode objects. > > So it can sensibly be used for dentries and inode, and for anything > directly related like the nfs access cache (which is attached to inodes) > and the nfs xattr cache. > > But the sunrpc cred cache scales with the number of active users, not > the number of inodes/dentries. > > So I think this should simply "return number_cred_unused;". > > What do others think? > > NeilBrown > > . Thank you, I will receive your advice.