From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5BDEC00140 for ; Fri, 19 Aug 2022 01:59:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A991F8D0002; Thu, 18 Aug 2022 21:59:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A487E8D0001; Thu, 18 Aug 2022 21:59:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 90FE88D0002; Thu, 18 Aug 2022 21:59:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 81A458D0001 for ; Thu, 18 Aug 2022 21:59:07 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 564C3140121 for ; Fri, 19 Aug 2022 01:59:07 +0000 (UTC) X-FDA: 79814684334.26.794823B Received: from out199-17.us.a.mail.aliyun.com (out199-17.us.a.mail.aliyun.com [47.90.199.17]) by imf02.hostedemail.com (Postfix) with ESMTP id 598288005D for ; Fri, 19 Aug 2022 01:57:17 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R171e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046056;MF=xhao@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0VMdxZUX_1660874213; Received: from 30.240.99.21(mailfrom:xhao@linux.alibaba.com fp:SMTPD_---0VMdxZUX_1660874213) by smtp.aliyun-inc.com; Fri, 19 Aug 2022 09:56:54 +0800 Message-ID: <5bc7f671-ad41-6a0c-535e-861b130992d9@linux.alibaba.com> Date: Fri, 19 Aug 2022 09:56:53 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.1.0 Subject: Re: [PATCH V2 2/2] mm/damon/lru_sort: Remove struct of damon_lru_sort_ram_walk_arg To: SeongJae Park Cc: akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220818172322.51705-1-sj@kernel.org> From: haoxin In-Reply-To: <20220818172322.51705-1-sj@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660874238; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A23Xnu9P/6lJI+dFn0ug6hKY3+VYzXI/L3h2I75JBSw=; b=fRGW+VlDpIbvV7+taFmohY/lcsxZm+j7+0qFCKSNLl5/wrq8AJoTDZDxzYPe/suelZLPh9 yBnjTn1yW/VSNu8MhhSydleE/HTvc7UFbVq1huxAKicwBUQcyZdQvjob8snCBq3Tb0IsQF BhNoj4kG/fT9c9DokdbSaKgmJPC/TPQ= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of xhao@linux.alibaba.com designates 47.90.199.17 as permitted sender) smtp.mailfrom=xhao@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660874238; a=rsa-sha256; cv=none; b=rJ5HdNssSSkCaMdVySC92yaYGdnqNHXoQhBPuPIi/3bD7yL6/zlFPJwqkpAdnWR5JUFIeh uxDnfZCVNsabMGZSV/fDgVdPnITVC0ke97SesgKYIoat3EAGn+4EzStk0rNjfi/xhwvTG+ X7UqNsxa0pqteDxWN9BK4ybs9gwCOw0= X-Rspam-User: X-Rspamd-Queue-Id: 598288005D Authentication-Results: imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of xhao@linux.alibaba.com designates 47.90.199.17 as permitted sender) smtp.mailfrom=xhao@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com X-Stat-Signature: f1raqndao973qwg4ydycb7ybpg74znxr X-Rspamd-Server: rspam10 X-HE-Tag: 1660874237-463742 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 在 2022/8/19 上午1:23, SeongJae Park 写道: > Hi Xin, > > On Thu, 18 Aug 2022 18:57:32 +0800 Xin Hao wrote: > >> The struct of 'damon_lru_sort_ram_walk_arg' is the same with struct of >> 'damon_addr_range', so, there no need to redefine it, just use struct of >> 'damon_addr_range' instead. > Reducing code is always good, thanks. However, I think the type of the 'start' > and 'end' fields of 'struct damon_addr_range' might be changed in a future. OK,  get it. > It's very unlikely, though. Also, we might add some more fields to the struct > in a future. After all, the purpose of 'struct damon_addr_range' is not saving > the 'start' and 'end' fields of 'struct resource'. I'd like to avoid making > any possible dependency here, sorry. > > > Thanks, > SJ > > [...]