From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF910C83F03 for ; Mon, 7 Jul 2025 02:39:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5B9A48D0003; Sun, 6 Jul 2025 22:39:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 569F78D0002; Sun, 6 Jul 2025 22:39:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 458B78D0003; Sun, 6 Jul 2025 22:39:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 30FB88D0002 for ; Sun, 6 Jul 2025 22:39:20 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D35931281C0 for ; Mon, 7 Jul 2025 02:39:19 +0000 (UTC) X-FDA: 83635912038.01.EF0C51F Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by imf03.hostedemail.com (Postfix) with ESMTP id E81B420009 for ; Mon, 7 Jul 2025 02:39:17 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=FI2nrbxd; spf=pass (imf03.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.173 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751855958; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2eqbUK4FYCJiLH0zvQx8aO0ccOeXGf/PUZ4UYY45Alo=; b=ScbihAY64920VjIRaC6xYQqUTNHT/1Q98VpsxqWweZ9xPDd+hmCyaKj1iT5z6a+4z7LIbh btPyRBBw+SD6MEtS3+Ki++fVldk2YC7C8LEYTn1PxvqRfHILvStaaH4e7iqe1dT4BLlloH ghIlkcJoU/Ky2c2CxBVvENdPNrx43bQ= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=FI2nrbxd; spf=pass (imf03.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.210.173 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751855958; a=rsa-sha256; cv=none; b=BD5B5nxp6D2h5rTwZLpFoX36to/vKJ0kyI8qx5LXpnGGmjyoWV54yaoe51vni5wSMd5eDO L1XlMNb63HSkpRtVIXcZZkkJWp+JaMUmt5sndQNDLZNsuxqg6Vs3PVc0dALFUznkFOSzml X37j0MGuoX1N9mgoN4E2zdFragQknFc= Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-7424ccbef4eso2030636b3a.2 for ; Sun, 06 Jul 2025 19:39:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1751855957; x=1752460757; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2eqbUK4FYCJiLH0zvQx8aO0ccOeXGf/PUZ4UYY45Alo=; b=FI2nrbxdRqQTH6r6wPEEVx9JUqJIl4sRqrzXsx8U0tWhstSxGxqA6Upj3MyfO4EuOk nUIep1gIUqY/6ZVKDz+dBRj/aiaxctNtlifEpxx+fJzfVaeJ2o5Ejrt60uxothk/iqN+ nXZlkAhVBAHPVky5UtyPq+ZTaUZOGRAqdNfqU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751855957; x=1752460757; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2eqbUK4FYCJiLH0zvQx8aO0ccOeXGf/PUZ4UYY45Alo=; b=SMEaKSXoRctPG9ZjfWBqtKmgu82HMLXmt4+WwkaJMNSSre1vqSU6OFszTxwxgovgAt uoewSqq9JmdwfYFEeAxzcEuVpFt9Vp1izYu6SkB8Jp+TCk2izj90PO57KYmDiRazEefk 7/GpEWgKlr//sQWAj+j5vZAdNfUzV+go0eEmEh2CQUJfJpIZ3Xe9GtJUaEsGaY8Cp8As T+PVRWdqtsJPOfLhUWq/mdju7U4AF5cXFGKmGzpENTY/1e3TQ8TJNT0bazGXqtmYVjbo M7apcy3UVVk1QWXMOBq+aLz/6EVzv4r+CvWvg6z/UwLjIixZ/sdR0fCY9lBFF1VsUxLP F4SA== X-Forwarded-Encrypted: i=1; AJvYcCWGhTJBl0epDiwtxVNH3R6be3GQA0hTOBWRmp9t1hhi+yHl0KMOLwhoBw/nvlTh3PP+5OWJsAThmQ==@kvack.org X-Gm-Message-State: AOJu0Yx6LBbjTvllwjKgjy5GcGMIhNU9fEbC2dX+jTTAx/R5HOI8lkYB rC88NVHeAUwL2/lhqqyOum8WK70RpNGsrYS0rRkWf6Qk17t7at9afjZ42aG+UlFfKw== X-Gm-Gg: ASbGnctfpfLnkdL+kh1RixDzNN3y2+UcYSd4X4j3bPLVOWDX+C5kZMoa4GEXldD79Jf MIXeP0YcyMaCIqdx8yNmtkL/NTGiJq2AlPbZeggx4IzQyL76xzbBgEnfx0EBUnIQWkdTJor07z2 CCbh8zU/CI9N40rRzlnSMPzC9OI06OzhxljT5vMe7ecs2TlZ7lahTDnXdKskhIvwVmaeV1t7Wx9 ktxDRgi+oVafHCeYwjj7s7DPwqzeTAUD1Kbp8LYyer0PDI8M+yCJVWi+RUm3kNKkvwcPdBQQhub SXSNXOIN+Mf4NgdoqQMUR30GVpvQK3NzB/VjItv71s2jJJ6qZzRBshRm2mziNFZ+ng== X-Google-Smtp-Source: AGHT+IEurZuttkS95VnXcSGu+b+8TgCle7ih6/mBYzXLZUJ1AXkAhgjCuqtatOUxrSPej26STHUETw== X-Received: by 2002:a05:6a20:4328:b0:1f5:95a7:8159 with SMTP id adf61e73a8af0-226095a5143mr15866459637.10.1751855956675; Sun, 06 Jul 2025 19:39:16 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:5470:7382:9666:68b0]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b38ee74cf48sm7419649a12.77.2025.07.06.19.39.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Jul 2025 19:39:16 -0700 (PDT) Date: Mon, 7 Jul 2025 11:39:04 +0900 From: Sergey Senozhatsky To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Eugenio =?utf-8?B?UMOpcmV6?= , Alexander Viro , Christian Brauner , Jan Kara , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt Subject: Re: [PATCH v2 12/29] mm/zsmalloc: stop using __ClearPageMovable() Message-ID: <5bc5vidilgjb37qypdlinywm64j447wtkirbmqdbmba2bgr3ob@22so3brrpctt> References: <20250704102524.326966-1-david@redhat.com> <20250704102524.326966-13-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250704102524.326966-13-david@redhat.com> X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: E81B420009 X-Rspam-User: X-Stat-Signature: ea6n1rm78rdiy8uhca9zej3op31d8xb5 X-HE-Tag: 1751855957-334215 X-HE-Meta: U2FsdGVkX1/Z8nnZ88TmHlu4qekrcs9R2UEmj3imyX24XdZ4NqQs4gXmraeBqVJ3RNTnnuvUmsXcFyU/D9cW7jHtoKVYD4atPFIG8XJncUly6LExMgte3U1FrEjHFsUQhscbGce3+GGNCwQ3nV61enO1fM9rFUetw8vkMBuk5zgT5qQcwD9Zq/Joi/HFqd90jnJcFveYtNoVkuXDbBGApx2eTw2sHr+kg352G1ZxqneL5Tb81IuYmdWtaCxDTMGNXPSR62nz3H8RzcR0OuA1rIONR8oZKrMEGlg65yOxvkaydxd3WwPSTZ1qvxEWDL/Hr9RkB7LDsIijDdenH/mm0v/ydDpLCbgkwdl1cMQbOfm6pF0Js1MIcTa2OB3C3EDZPAW0sEZSjTqFhe5bBbVopsxfjPVd8DsMH4Z9YuZRdKtP26eYK0T2YHxkjclVQguIQ/AjHh/AU0X8lNLmPC3GUyaddgjk36SaaenwKKaMxhe9MjqX7t69qSARp7GD15eCxN60RHiySbeYbwoZJsOEXGXfvO72uaZm2DGKT+r3zHdj37T5yQedwq8cLSgHsE8zIqIe3KnyHsgxXQLbA0xM/sArXs7tNjBtvltqH3GQOY34hUn8moZVhi3HIWboNjIcQBfDJ19ehE1HF1g9sdKCKzjpWqFVRabcLVT1W+euuyfQTBuoKTpwabAENKNldggTJi3xcYEa04rKEHnRr9ysI5S/fVtseMvQfOnfKHlvXUWDgDNv/QThibwnIOdyp9301L7FfB+a1XcmAhJREkf00sNLJXpch4u/Bv1P+Yo5dkwTss7ObpXe//ChXz9pTgijB+/m9C8882FTwJmzGcKkhvGpe3XLt2k7/6a+e4tX29zvH6wwpO54jRRSmo2UBuIYdz50PVmaLeXVfMKj64xUheDFg4+OLS+Roe5O8HNFpNeLShx8aSElPzA95WR2Y1LaDCwFNICdkQa9mFHK0QX 5xhYsenW +hUiuBkpGn54lUPXlbWh2dtcMgsznWJ+agah98nDncHB1w9atvcFlTJaxAHT7eBWWNJOZrKc+7c1/IYM4a9o4Wd54iWWgnUTvjQsMxCkeTg42RbDsjlSquCHHH1XAYlwUv29i8lff9pryQAICGtCJmvkPvahDnHxCHw3G8EubVxjyPic4KoRjlxT/Up+2h5hns6tiwYwngJ4EMNvLv1NkQ3cNuIRkxB7Lv0N1CE5kWCNzc3l5Ti1m0/WLAZ9whvxkZvAj/XxSaOSQqMDF9az68BHUc1P/bGS7/E4Es8KSzsF5Mafkr4DyhEdGS+lTKKQ6Vuo2ZiQS4nsAMd6mVvTqvtGL0SX73VjCnNDvpwp+28buvGXMN09y637VU21uy3AlPz3UVtCGEHuB4huB3nNFOXEuatjAByS66P38kRd1Pj843f74MEmj86F/HbFnQtjgMp7HgpY7vpeu6zK0ksdtJ4o9GNgEuTDnOUwfIZJA0kscqPXrBNCksQP8rGSf4zWaWNegpAvbFrrhsZA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (25/07/04 12:25), David Hildenbrand wrote: > Instead, let's check in the callbacks if the page was already destroyed, > which can be checked by looking at zpdesc->zspage (see reset_zpdesc()). > > If we detect that the page was destroyed: > > (1) Fail isolation, just like the migration core would > > (2) Fake migration success just like the migration core would > > In the putback case there is nothing to do, as we don't do anything just > like the migration core would do. > > In the future, we should look into not letting these pages get destroyed > while they are isolated -- and instead delaying that to the > putback/migration call. Add a TODO for that. > > Reviewed-by: Harry Yoo > Reviewed-by: Lorenzo Stoakes > Signed-off-by: David Hildenbrand Reviewed-by: Sergey Senozhatsky