From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F424C433FE for ; Mon, 21 Nov 2022 09:22:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 928ED8E0003; Mon, 21 Nov 2022 04:22:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B2738E0001; Mon, 21 Nov 2022 04:22:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 752AF8E0003; Mon, 21 Nov 2022 04:22:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 620DF8E0001 for ; Mon, 21 Nov 2022 04:22:08 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 249501C5B50 for ; Mon, 21 Nov 2022 09:22:08 +0000 (UTC) X-FDA: 80156907936.22.BE06272 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf15.hostedemail.com (Postfix) with ESMTP id 63FC2A0009 for ; Mon, 21 Nov 2022 09:22:06 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id CB1F21F45E; Mon, 21 Nov 2022 09:22:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1669022524; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ncmJy/GrOxJK5KE7kwDWk65UVGjBhwRiMKTJ82IqkTw=; b=w6+ar4YZkbQ+A2y3kkM1KxCoFqHxIEo6nYf5wfVyJnRHGyiSTr8U5wp7gyWc46tWouDe2s R0dYpvSbQcy/6UUfpXLEBktJJgk/8sDy/fS/nK05dO8Z4aLES6MjbKkhZco9IcrMavpCVB UwHiXo2GpURKVl60If7Z8qvtkKKtDok= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1669022524; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ncmJy/GrOxJK5KE7kwDWk65UVGjBhwRiMKTJ82IqkTw=; b=HYhJlYNCaTeeIgK1KItf/zpAg5N8hyZkcZfPM+VsOUGXeyRlGbWOtVtBENPiyfzrkS/8le eR9jgdT7M2xOypAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AC5771377F; Mon, 21 Nov 2022 09:22:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id n+3IKDxDe2NQaQAAMHmgww (envelope-from ); Mon, 21 Nov 2022 09:22:04 +0000 Message-ID: <5bb911d7-bef2-b8ae-147b-d7febf5cbd91@suse.cz> Date: Mon, 21 Nov 2022 10:22:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [linux-next:master 5002/7443] include/linux/compiler_types.h:357:45: error: call to '__compiletime_assert_474' declared with attribute error: BUILD_BUG_ON failed: PERCPU_DYNAMIC_EARLY_SIZE < NR_KMALLOC_TYPES * KMALLOC_SHIFT_HIGH * sizeof(struct kmem_cache_cpu) To: Dennis Zhou Cc: Baoquan He , kernel test robot , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , 42.hyeyoo@gmail.com References: <202211120436.HzD1i2yQ-lkp@intel.com> <97b6c8e7-36f3-1181-7ffb-d94e8a8d293e@suse.cz> Content-Language: en-US From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669022526; a=rsa-sha256; cv=none; b=wALUPK+TFnDrDgxu41UKyJLiRapwjFVKemkWqzRu3dC1CwtE5lnHaiiDnTOQ6I7WiUyUzg 3DRw9/amWc1AjekBJV/Ok18CsxoNRFdGzYKIe7YKcr9CIC5FprVMTmH2B6/qaEKMRruF6x u43j/hrqxhSw+41Y8ouTkC0mX8Y9xyM= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=w6+ar4YZ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=HYhJlYNC; spf=pass (imf15.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669022526; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ncmJy/GrOxJK5KE7kwDWk65UVGjBhwRiMKTJ82IqkTw=; b=EbXMkJjBuFt4MoKtPUWkMpqchRRE13LpxjXqr6r+UsrS8T2h97+DXtbsDsaKN3T+hEnPrS SMgyirXjZIu74ajvLniUWGYJYCY+oNgsV59XGoHtjbjawUjifUi48R4cj1TK9OawKFVu6f AUqh9wl5z4mS77Byh9O/H+wSZBz0RKQ= X-Stat-Signature: gqss47srzeffz39oqpy1oxfsrhwj6wkn X-Rspamd-Queue-Id: 63FC2A0009 Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=w6+ar4YZ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=HYhJlYNC; spf=pass (imf15.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none X-Rspamd-Server: rspam04 X-Rspam-User: X-HE-Tag: 1669022526-505891 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/18/22 20:08, Dennis Zhou wrote: > On Fri, Nov 18, 2022 at 10:49:43AM +0100, Vlastimil Babka wrote: >> > >> > I think I might be overindexing on the out of tree modifications here. >> > Currently, I think it's clear how modifying PERCPU_DYNAMIC_RESERVE >> > affects the system with the lower bound being dictated by >> > PERCPU_DYNAMIC_EARLY_SIZE. If we bump PERCPU_DYNAMIC_EARLY_SIZE, it's >> > not inherently obvious you can drop that value lower depending on your >> > system config. >> > >> > Ultimately, it is only a few pages, so is saving it that big of a deal >> > today? Likely not, just a bit wasteful to potentially orphan a few extra >> > pages unnecessarily. >> > >> > Let's just fix this now and I can massage this in the future if anything >> > comes up. I appreciate you taking the time to have this discussion with >> > me. >> > >> > Vlastimil, can you please pick up this fix. >> >> Sorry, got a bit lost, so do you mean the original uncoditional bump, or the >> modification with BITS_PER_LONG > 32 (or PAGE_SHIFT > 12)? >> > > No I've made this more complicated than necessary. Please pick up the > original unconditional bump. > > There's a small chance you'll see a merge conflict in my percpu#for-6.2 > tree: > d667c94962c1 ("mm/percpu: remove unused PERCPU_DYNAMIC_EARLY_SLOTS") Thanks, picked up. > Thanks, > Dennis > >> > Acked-by: Dennis Zhou >> > >> > Thanks, >> > Dennis