From: Helge Deller <deller@gmx.de>
To: "Zhijian Li (Fujitsu)" <lizhijian@fujitsu.com>
Cc: "oe-kbuild-all@lists.linux.dev" <oe-kbuild-all@lists.linux.dev>,
Linux Memory Management List <linux-mm@kvack.org>,
kernel test robot <lkp@intel.com>
Subject: Re: [linux-next:master 13900/14187] drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c:228:13: warning: unused variable 'ret'
Date: Fri, 22 Mar 2024 07:05:21 +0100 [thread overview]
Message-ID: <5ba282de-d84a-4b06-a26b-548182002996@gmx.de> (raw)
In-Reply-To: <be3df018-7c1c-425b-851f-41427fa2a548@fujitsu.com>
On 3/22/24 03:54, Zhijian Li (Fujitsu) wrote:
> Helge
>
> Should I send a new version(v4) to fix this.
No, it's ok.
I've fixed it up already.
Thanks!
Helge
>
>
>
> Thanks
> Zhijian
>
> On 21/03/2024 19:56, kernel test robot wrote:
>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
>> head: e7528c088874326d3060a46f572252be43755a86
>> commit: 0688d3b1d882dd1dcf73305306e71ebf1653f595 [13900/14187] fbdev: panel-tpo-td043mtea1: Convert sprintf() to sysfs_emit()
>> config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20240321/202403211931.wVl6ymAV-lkp@intel.com/config)
>> compiler: sh4-linux-gcc (GCC) 13.2.0
>> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240321/202403211931.wVl6ymAV-lkp@intel.com/reproduce)
>>
>> If you fix the issue in a separate patch/commit (i.e. not just a new version of
>> the same patch/commit), kindly add following tags
>> | Reported-by: kernel test robot <lkp@intel.com>
>> | Closes: https://lore.kernel.org/oe-kbuild-all/202403211931.wVl6ymAV-lkp@intel.com/
>>
>> All warnings (new ones prefixed by >>):
>>
>> drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c: In function 'tpo_td043_gamma_show':
>>>> drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c:228:13: warning: unused variable 'ret' [-Wunused-variable]
>> 228 | int ret;
>> | ^~~
>>
>>
>> vim +/ret +228 drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c
>>
>> f76ee892a99e68 Tomi Valkeinen 2015-12-09 222
>> f76ee892a99e68 Tomi Valkeinen 2015-12-09 223 static ssize_t tpo_td043_gamma_show(struct device *dev,
>> f76ee892a99e68 Tomi Valkeinen 2015-12-09 224 struct device_attribute *attr, char *buf)
>> f76ee892a99e68 Tomi Valkeinen 2015-12-09 225 {
>> f76ee892a99e68 Tomi Valkeinen 2015-12-09 226 struct panel_drv_data *ddata = dev_get_drvdata(dev);
>> f76ee892a99e68 Tomi Valkeinen 2015-12-09 227 ssize_t len = 0;
>> f76ee892a99e68 Tomi Valkeinen 2015-12-09 @228 int ret;
>> f76ee892a99e68 Tomi Valkeinen 2015-12-09 229 int i;
>> f76ee892a99e68 Tomi Valkeinen 2015-12-09 230
>> 0688d3b1d882dd Li Zhijian 2024-03-19 231 for (i = 0; i < ARRAY_SIZE(ddata->gamma); i++)
>> 0688d3b1d882dd Li Zhijian 2024-03-19 232 len += sysfs_emit_at(buf, len, "%u ", ddata->gamma[i]);
>> 0688d3b1d882dd Li Zhijian 2024-03-19 233 if (len)
>> f76ee892a99e68 Tomi Valkeinen 2015-12-09 234 buf[len - 1] = '\n';
>> f76ee892a99e68 Tomi Valkeinen 2015-12-09 235
>> f76ee892a99e68 Tomi Valkeinen 2015-12-09 236 return len;
>> f76ee892a99e68 Tomi Valkeinen 2015-12-09 237 }
>> f76ee892a99e68 Tomi Valkeinen 2015-12-09 238
>>
>> :::::: The code at line 228 was first introduced by commit
>> :::::: f76ee892a99e68b55402b8d4b8aeffcae2aff34d omapfb: copy omapdss & displays for omapfb
>>
>> :::::: TO: Tomi Valkeinen <tomi.valkeinen@ti.com>
>> :::::: CC: Tomi Valkeinen <tomi.valkeinen@ti.com>
prev parent reply other threads:[~2024-03-22 6:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 11:56 kernel test robot
2024-03-22 2:54 ` Zhijian Li (Fujitsu)
2024-03-22 6:05 ` Helge Deller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ba282de-d84a-4b06-a26b-548182002996@gmx.de \
--to=deller@gmx.de \
--cc=linux-mm@kvack.org \
--cc=lizhijian@fujitsu.com \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox