From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D125EC2BD09 for ; Mon, 1 Jul 2024 07:16:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 469E26B0096; Mon, 1 Jul 2024 03:16:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 418B86B0098; Mon, 1 Jul 2024 03:16:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26B856B0099; Mon, 1 Jul 2024 03:16:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 061F96B0096 for ; Mon, 1 Jul 2024 03:16:25 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 8B0E41C31E9 for ; Mon, 1 Jul 2024 07:16:25 +0000 (UTC) X-FDA: 82290325530.21.24AB163 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id DBF70100007 for ; Mon, 1 Jul 2024 07:16:21 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MhILVJJb; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719818160; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8JfdcBztykHv7SZCf3/9h0jEo4muyHDDQXPVpChEDAA=; b=GiwyfsbP2lLwgpVbnkJDU/DzayJ6XNUMKJmwdtvurhQODfsh3ddhfwJRPOoC/yA/Mv3d9s I4UmiAABZlrDFlXLm4OqZQOi5JIT4RIUREykwWUoVFf3FRJB7BdL+Mg4FPusjZMpfBdikC /s2qpIZ0Lz9hT7PkDH/ZvtWlndz9Flw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719818160; a=rsa-sha256; cv=none; b=yH/9PIAAhEyWbI3T7RgfhI3kyIAE/GhsZKmpbmYKYrcW/QEGY7SAYQjGCJfJB4TddxNRj4 V51Ho06zeYQE3iDzFQkCHhqIovqtXrRy8T2tRJkkDdFCGMtLkfqCcFZkGt0nBxY7IaIuMs ehpddgaAeMVNq1a3rD7r7defLy+mqgI= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MhILVJJb; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719818181; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=8JfdcBztykHv7SZCf3/9h0jEo4muyHDDQXPVpChEDAA=; b=MhILVJJbuFw1mUEYSGMw45pCQ/Ih9/l5give6OywBLL+o2yKQL+vLHWKOzajfSaAzbQqY5 9PSpACF36s1YEs78mvgOpIlmp/kRZXHiEFTeQVxSbDgAzlQTdK80qtiGtmXYkbW9Zdcsxh rIKi6jMtKy+/s1gF3rSIF3V2hJGghZI= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-638-GWDJDOXVP8KuI1HHQvrbhA-1; Mon, 01 Jul 2024 03:16:19 -0400 X-MC-Unique: GWDJDOXVP8KuI1HHQvrbhA-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-52cdbeaafcdso2395444e87.1 for ; Mon, 01 Jul 2024 00:16:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719818177; x=1720422977; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8JfdcBztykHv7SZCf3/9h0jEo4muyHDDQXPVpChEDAA=; b=UeHNJcFg5FvREsxYhsVndwBoQH4UrofVYFp863W7qrhZzJcRRNDoTs0mGPQuoCLYI3 i4XuHqAX0WiRtS+nZKcAXJHkVKHODYUQwfUwRDGIdthybmMDqhUJf7CYQmXNir0haVFd Iag29+qPXqn/3BZmol6lAFAz/frlVYCz6f9pTDkce1rk3iQfUT+jG0et5/yhpvtSp4Q6 eN9c2mcfVVj/sU4YRO5ToQffCkbVAz+HPbW3Dvey7jdeE7/0rJdYMSPfwbm4Nj3YmAUX 0I0A+uUQL5izONzcvHGYTcua7MvPq2lY0CNJ99RKrCl0qfrI/pnbWVFzKtFvGEG/BBaR vl3g== X-Gm-Message-State: AOJu0YxYa+g38pdCEDRAjs88UTKZxnC90x4Io79CwWSxRGNidzfZKqZH llqicLtfnVAdOB3LXXWbVI3cZJnh0EluISYvRXA3DZQiL4BMZ5hq3SjfIHu11BBqkzQ1mHA/iBd O7QP8hP5s1h4H/p6rlKhsquvB/urimxbzvZynNHv782XZ9Gdf X-Received: by 2002:a05:6512:acd:b0:52c:caa6:13b4 with SMTP id 2adb3069b0e04-52e8264e4ecmr3267628e87.3.1719818177623; Mon, 01 Jul 2024 00:16:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGT2V5ZaKNBGJqnuJOddd7plBXqWkJgxY3Mpne6UC9CIUcuEK6PRcUrym0jM3JMNWkpytfwdQ== X-Received: by 2002:a05:6512:acd:b0:52c:caa6:13b4 with SMTP id 2adb3069b0e04-52e8264e4ecmr3267580e87.3.1719818176150; Mon, 01 Jul 2024 00:16:16 -0700 (PDT) Received: from ?IPV6:2003:cb:c72e:2200:7ed7:c239:d423:3b31? (p200300cbc72e22007ed7c239d4233b31.dip0.t-ipconnect.de. [2003:cb:c72e:2200:7ed7:c239:d423:3b31]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4257cad6beasm61234835e9.47.2024.07.01.00.16.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Jul 2024 00:16:15 -0700 (PDT) Message-ID: <5b9dafac-1561-4dfa-a0ff-9445cddc0932@redhat.com> Date: Mon, 1 Jul 2024 09:16:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] mm: gup: add forward declaration for try_grab_folio_fast To: Zhao Mengmeng , akpm@linux-foundation.org, yang@os.amperecomputing.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240701034052.9988-1-zhaomengmeng@kylinos.cn> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240701034052.9988-1-zhaomengmeng@kylinos.cn> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: aie8ncahkon7duy96a97m48njhtbxesr X-Rspamd-Queue-Id: DBF70100007 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1719818181-914108 X-HE-Meta: U2FsdGVkX19Ro+n+cqJHrzpIkrQb9AFFJDCUaqJg4biT1nezxHRtF6K8uDuvLK+8oGiGbLpTuxDObUxJuvt1D6itP335qo3M5TVA4YFpotW/LNswgX83lVj1g8PmS5fmwoN+r98d8/3RMOMWi8jT9l4hPprPOysTrJJYIkqeb8N5mvtNset/SbClou8Y8wVa7x19ks+XZ9/GlrPV0mUKPKA18V/954Ig0WGdZOQouIW401+hhRFoRvNt+Ios6gzJ4BfuLgdk2i6QnCcWoagiLo/Xz9hHLKMFvxN67V5oOGFKr+eEGy+79BR95skrsIPZFSRp/yfFlsYV2ndLVRwhzjoga5nBD3xJdTZSczPaHM2Gjb8B98fV50OlPx1HMtoPYCusodVwVOPKjOcqZ9sgfMrHulL/vTvKZCx8a9fZfo+5yZPxkjIvo4+cS9gO+X3NuqhL39WkVc67MdJuiKkHX+MkV2izWU1y7S7VtEYAMaXqpLDPsRoGVoArgBzWGOiAb0XKohbjOMATb2W5WcuuyaeQZpzdP1KuetetKVRiS+UZFKnuvfwP4fqkJq6g3K5SyW6gEOZJfU+pTQ+a4im7MW9bM5mgjgtiKwlkzIUCdGcgUrqLiqaFrR8LGPexkxCPenwQ4CGlGYOx2g5U7GsIJdjN66h3j21O6hLo7OF1n+JZc1y/4b+YPxcRcTU+XlefBp6M6WTFMREowZqaxUickKpYaH1ZKaNBxN8trdI3rc7F8eg5MOdT2nK0uy+0ilwsc8lQohyRjv+hioS5K9MTf5fbPJ5iVbHW8IdIKlYswLavjpGqrh+G9lout3c6k22xh3pHIfBz+qehb9Dxt/r7xXjpJGrQgbME9JcSvdgDx6A5iA0bnqCXhwyLRtRbX46EIChuk6adROZFcLx/ga2Bek2tOd+S6EHcOzGmCg/H35u1Fogt7VDcNRiMF05VOIDMrA+50jc9xDBmOABwra9 SnsW01af hPad8Wiu8Cg+EryIi8+X7ysKFMER3LSibe+jbN7KWvBsUjMVV/2jq/4XLZMExI2yb9fg1nvRo/gfvc8k7EkPlMVT5bC2fOfpURhwX3VRlzwvnk3MV04ertpqYKEsOdGePktblJi2Ph6WNCBY8WaXTk1ITmfxgwXku5KltEBM2F9pV08+A6jKp5yE9SqDCtPzdWkZf7l7lZ/avdEAFJ3JLWgS5iCeXSIQBQkVkkZWE6lkFtp2ZbslElSXl/3LMK4LlZhCGZ2qqk3UrGdmp6+WeQllHcdPDoRExCPS0VZVw/4ka9+uyMgWhDhekLXxGNV/FsgmQFgKx88l7HZ7u2woB3pNgQfmM1zHDM28xZkrm2Ygsuw3al9zNjtROTChluM/NlvXd8obbBcMKRmGm6oSwsJiPeDfVjiLSqZGh3IrUf0jmgPc221idFyfHIkNUoF6PBkq96rtBUK/tqPLPWn9fxGrJ2K9rAgpZldWVKxX/VxBSIHZ6NViZf0xT8A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 01.07.24 05:40, Zhao Mengmeng wrote: > try_grab_folio_fast() was used in gup_hugepte(), while itself was > defined after gup_hugepte(), so add a forward declaration to eliminate > the -Wimplicit-function-declaration warning. > > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202407010039.D3sIu3fu-lkp@intel.com/ > Signed-off-by: Zhao Mengmeng > --- > mm/gup.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/mm/gup.c b/mm/gup.c > index 7439359d0b71..222b83a87d7d 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -488,6 +488,9 @@ static unsigned long hugepte_addr_end(unsigned long addr, unsigned long end, > return (__boundary - 1 < end - 1) ? __boundary : end; > } > > +static struct folio *try_grab_folio_fast(struct page *page, int refs, > + unsigned int flags); > + This function should really be called "gup_fast_", just like all other gup_fast_ specific functions. I might send some follow-up cleanups later. -- Cheers, David / dhildenb