From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE6EEC54E67 for ; Sun, 17 Mar 2024 14:52:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4732C6B0083; Sun, 17 Mar 2024 10:52:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FC8D6B0088; Sun, 17 Mar 2024 10:52:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29C306B008A; Sun, 17 Mar 2024 10:52:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 170916B0083 for ; Sun, 17 Mar 2024 10:52:09 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id DA52F406D2 for ; Sun, 17 Mar 2024 14:52:08 +0000 (UTC) X-FDA: 81906821136.23.71526CE Received: from smtp.smtpout.orange.fr (smtp-23.smtpout.orange.fr [80.12.242.23]) by imf16.hostedemail.com (Postfix) with ESMTP id 9F893180002 for ; Sun, 17 Mar 2024 14:52:06 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=wanadoo.fr header.s=t20230301 header.b=es3n8pFW; dmarc=pass (policy=quarantine) header.from=wanadoo.fr; spf=pass (imf16.hostedemail.com: domain of christophe.jaillet@wanadoo.fr designates 80.12.242.23 as permitted sender) smtp.mailfrom=christophe.jaillet@wanadoo.fr ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710687127; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rmVj1Zo0ysD4EU1EPoLJ4zF5lxo04akNScGS3Kgu0rg=; b=ppo1ru10Qji1PiPYV1HcbEvlgfKrZhk26U8WNwmCFF1MCCCBXrpWf0Y/U/QZe9eWzG6pn2 cPIZzYbdleQXSeaT0aCv7oU12OSsCAa11eScQPaEheiCzV1QXp3++7fQpTo9kYtc6sf2hG k7EpNvlo8j2aH97GQ/eY+/Pk1vCfarc= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=wanadoo.fr header.s=t20230301 header.b=es3n8pFW; dmarc=pass (policy=quarantine) header.from=wanadoo.fr; spf=pass (imf16.hostedemail.com: domain of christophe.jaillet@wanadoo.fr designates 80.12.242.23 as permitted sender) smtp.mailfrom=christophe.jaillet@wanadoo.fr ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710687127; a=rsa-sha256; cv=none; b=U/sfqPBZq0SwZD2XeR/rRjhdwvGClMgt/x36gu0XIlOOPkrrJ7ddsu4R79ONMwUbp2Szj/ vVSha/Wtq4Luno29CBKnV8jfrO/gylL0jdCOAqMUNNLQkFYt0bpNp+N096ZYrOK2EqSSCe UfQFEcyRb9XOwVKhM+og4Y07QXlHorw= Received: from [192.168.1.18] ([92.140.202.140]) by smtp.orange.fr with ESMTPA id lrrerSoLHBnpilrrerSLfh; Sun, 17 Mar 2024 15:52:04 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wanadoo.fr; s=t20230301; t=1710687124; bh=rmVj1Zo0ysD4EU1EPoLJ4zF5lxo04akNScGS3Kgu0rg=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=es3n8pFWzUybMMGy6wp5nM9KyX/HUzWICIddF4WGuv313uiXYM1raVUThr+qKOvaS hxLOyDZ5CfSfRYnsd5zDBj88XJlcK6mQ0eBP9HLBS3gtC4wNO+tqnoglw43CsjxmOk OTHv2g0AiHuF0hwWJz6qNtGPfqKk5kRJMw7Z0O9XZnFCHgS2K/COX2FCicG/ft5Ahp TT5JJfuUHI1YVyjGh+tjr2LuRPsuceXlAAD7loIgbZWttDKzKEBu9NiqU5tfdOU5sQ GWWpZ8YvhiiSm148kXzVyiSNezNlFrx3MVsJmfaG1mDhEneWREry5/Ujm5/h7EyMVj 9ge5NVWMB9Skg== X-ME-Helo: [192.168.1.18] X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Sun, 17 Mar 2024 15:52:04 +0100 X-ME-IP: 92.140.202.140 Message-ID: <5b98c4a1-26c0-4b69-b000-44ae97eb6edb@wanadoo.fr> Date: Sun, 17 Mar 2024 15:51:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 08/14] fork: separate vmap stack alloction and free calls Content-Language: en-MW To: Pasha Tatashin , linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, x86@kernel.org, bp@alien8.de, brauner@kernel.org, bristot@redhat.com, bsegall@google.com, dave.hansen@linux.intel.com, dianders@chromium.org, dietmar.eggemann@arm.com, eric.devolder@oracle.com, hca@linux.ibm.com, hch@infradead.org, hpa@zytor.com, jacob.jun.pan@linux.intel.com, jgg@ziepe.ca, jpoimboe@kernel.org, jroedel@suse.de, juri.lelli@redhat.com, kent.overstreet@linux.dev, kinseyho@google.com, kirill.shutemov@linux.intel.com, lstoakes@gmail.com, luto@kernel.org, mgorman@suse.de, mic@digikod.net, michael.christie@oracle.com, mingo@redhat.com, mjguzik@gmail.com, mst@redhat.com, npiggin@gmail.com, peterz@infradead.org, pmladek@suse.com, rick.p.edgecombe@intel.com, rostedt@goodmis.org, surenb@google.com, tglx@linutronix.de, urezki@gmail.com, vincent.guittot@linaro.org References: <20240311164638.2015063-1-pasha.tatashin@soleen.com> <20240311164638.2015063-9-pasha.tatashin@soleen.com> From: Christophe JAILLET In-Reply-To: <20240311164638.2015063-9-pasha.tatashin@soleen.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 9F893180002 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: qirzfx14ifaopygqjkaw1jjcapqxxwtw X-HE-Tag: 1710687126-953379 X-HE-Meta: U2FsdGVkX19ZllBaIxeQq2zrxtZD2tBqJ9RUBMTf3Sg86ZIuAjdmojsAdWKAfBJuI9MbwFeB3CQUjZ9fkh2bT3jUPrLP55aToonusZUumIGaUgwcTA7qXHIq9R2UlaJW0jmOQmMmMePwnTkbGJioDD/OCWZ+ybuq+0Gqy9CSubiHZhTxq8SUTjdD+SNZM0nhbMbiInIcOg7sZ5fU0+tMoSwtNnhsFUGSDnoHrTmcVgGI6sKjzTEyAQmonEUmuyxT72fgUw2s1fzS/F54cUcObVgZ9x5vGOjmxht4KPhbETFnIWTKO97xBANpidefPgNeJkxm34kC1ZK7A8/466uAjen3Nj+CVDfmtngtDOizcpxUqPLkRUohzNyxH7SU6Tbk/IfQRpWtSD9Uxd9BoZHvHMLzDebV7cxTZPxHHaFNx/ermIHWsKQW885ayMLYBXz7BW4gPY3R4ERr8SB8CreB/aAaN6DvuQwx4rQ9zsYuI4fsE5Zj3ZUNGBc3+vrpIG+Sz4q4uN7uHDGL0hS7MM7efvXzYxDB9POuyM1skyvNJZG1wK6a/wBmOeFbsSOqj8+soJquc/x68IaMJRk1DgRhP7KN9u87rZBM4cVzF/waRuD3kWkiOyawktXWFk8Auvzw8HRUmAREmqN7PxPDJGFBFsiVwJ762azPxuvbfIdExPxMN0/6SU9GZvUQK1wuPJ27Ggtq8khiHjoeEKfd1oAub2sp3sPDhagFqXTUyak6aclT0XrNFYyx8eiUfO5ArJeLaCn4+4abcjQS0rv//1bdbmma956o91cbPSwymGP+c+TA95vhPUxnU5z8kRzLkME11dszGldhAsNcBPmYcYm5IuTPOTSCdzfKERCgrSKljcISczqgmIizrTUvdinNJdMvXh+VssyI8zAQYaRyJDLD/207/BnNQ8q4M3bRUSIvbqlEo63L6I/GDUKhhni1HbagslAGME9pirG7TOUA3t/ YR6oaxn/ GFzZByqjrIQYj3KLpjr3GQo0IiIGBUdztvnsXhKZwLWGNfQeAOe7oenPySpZ5/rFh6wjLPkuU2ven94WHV+Nk33OB5iMFyiaQskti14nC/g6pECKiK5loyzscYg4nNERJ3VQzv1wbkEGuundwQ3r9AR6uK1pDOV3SLlBxZXxTeW4cKrjQHk7Aym403eKwYJuPIFer0FESm05igRFHC/JCf4j0dgzmixnCFvdi4Q04mey+cy6xRkXY2KEQGR3sp54iwE8m19ju2jfB4cpPoTW3QVu6SarPaPjbxmfneRh0EKPy3oYbc983Lcn25eC5vkuwT6WTEgBtyNp8HzA40gFka6oM/g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000200, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Le 11/03/2024 à 17:46, Pasha Tatashin a écrit : > In preparation for the dynamic stacks, separate out the > __vmalloc_node_range and vfree calls from the vmap based stack > allocations. The dynamic stacks will use their own variants of these > functions. > > Signed-off-by: Pasha Tatashin > --- > kernel/fork.c | 53 ++++++++++++++++++++++++++++++--------------------- > 1 file changed, 31 insertions(+), 22 deletions(-) > > diff --git a/kernel/fork.c b/kernel/fork.c > index 3004e6ce6c65..bbae5f705773 100644 > --- a/kernel/fork.c > +++ b/kernel/fork.c > @@ -204,6 +204,29 @@ static bool try_release_thread_stack_to_cache(struct vm_struct *vm_area) > return false; > } > > +static inline struct vm_struct *alloc_vmap_stack(int node) > +{ > + void *stack; > + > + /* > + * Allocated stacks are cached and later reused by new threads, > + * so memcg accounting is performed manually on assigning/releasing > + * stacks to tasks. Drop __GFP_ACCOUNT. > + */ > + stack = __vmalloc_node_range(THREAD_SIZE, THREAD_ALIGN, > + VMALLOC_START, VMALLOC_END, > + THREADINFO_GFP & ~__GFP_ACCOUNT, > + PAGE_KERNEL, > + 0, node, __builtin_return_address(0)); > + > + return (stack) ? find_vm_area(stack) : NULL; Nit: superfluous () > +} ...