From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5BD3C67861 for ; Tue, 9 Apr 2024 10:50:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A05E6B0083; Tue, 9 Apr 2024 06:50:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 250276B0088; Tue, 9 Apr 2024 06:50:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C9D26B0089; Tue, 9 Apr 2024 06:50:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E3D0B6B0083 for ; Tue, 9 Apr 2024 06:50:10 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9D08AA036D for ; Tue, 9 Apr 2024 10:50:10 +0000 (UTC) X-FDA: 81989673780.14.980926C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 5A65AA001C for ; Tue, 9 Apr 2024 10:50:08 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="X/Vk6wZQ"; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712659808; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rNwfakQBVQWhFQ0CXLmxM/3VqRjCpvwxu8DU5cjjR9c=; b=n8BhjUOEsEbizFhEmeAIKVUf2sFFB4yOB5vXS2De7Zxhywb0TdXFBkcgMRD3q2xZxamhk9 6Tocn/u8CMVULNBDKJOpaXluJVg7TIf2U7itzuH4fSr2iJvgic0aCCP1GGcX04pq+3C00F Zz3ukLceJl76k8pLte2Bc7WssnAgwaE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712659808; a=rsa-sha256; cv=none; b=bSAj1Wce7HCugFgJbdH6nf1NG0HNg9jrYAb19I5YC63aiE435O2gBeMLID7CCEzn7JaTWG pRDgeXiXby7RqVvgR38YFDCfJApclEvgLdFVB4T/Vdr+a9VBgwJspJhlaD7zJ9owTxd8MB J8y/2DW49gEMH7lSXQhQxJv/QNFG7oc= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="X/Vk6wZQ"; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712659807; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=rNwfakQBVQWhFQ0CXLmxM/3VqRjCpvwxu8DU5cjjR9c=; b=X/Vk6wZQWPP9Vas4co9dUgSZVvswngGugIpe6ZxO8F4XZsy2vU//tLTD/8sW8/YUhGxw5W 9zZr1YJC2CLmKMdqCLPU+PLHStXq4iCLC3QeShnxmwqvt1P52PyOj0Vi2nB25KvEGmW3A1 4ScXgF4UkCnodO7Y+5YvEpSOO3DLg14= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-608-1ehOgzrpMgCfQ5WJVhRSFQ-1; Tue, 09 Apr 2024 06:50:06 -0400 X-MC-Unique: 1ehOgzrpMgCfQ5WJVhRSFQ-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-41401f598cfso32172665e9.2 for ; Tue, 09 Apr 2024 03:50:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712659805; x=1713264605; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=rNwfakQBVQWhFQ0CXLmxM/3VqRjCpvwxu8DU5cjjR9c=; b=NARkXQurXx3eHnxm0yuEPowaHkoFICQeL5ZbwrtNVS4RLTaPT922mlw8XJLy353mjo GF5RL1sQWt/HKmoWMuO4lMogoJ5+PL1JnyNf3Jz5LXeQxijvKqykeFgwPLrvaiFg4nZG RWZRSXGhmdeADoMAhBPoYAQ6x/KNg49jfGX4UHlv3KtW6MDbFfQOH3ijEwnxbVEjKL5g SD5R+iZ38ey7f4l9N8sJttrO8rrgQ+zvMtdAnSf1hi+DIy8fjjoQVdim1gNwoljLlFnR osLExSeidU7/GpOm2rRM7bxkiU/Bn8yilxOvdLB1RbIGgIhNjwFPU3ku77sG/ozOFA3f z+AQ== X-Forwarded-Encrypted: i=1; AJvYcCWNpcVC4Vi92q0IBcaQ894kdIqy4s7v5i0WQi3DSQHIzgWp/JB1bqMKiaoqRCvTOW8y1f4u716PE+8ujnvPST/ImTU= X-Gm-Message-State: AOJu0YzoEznr0XdMkUpMBmV2nRVJwES+FgvkeiJ3BufKoXT5N6QG1LL9 tVXG8bUZa1rJVwgPu6tBHfmpLnylzF+owj1pSisFhp3RGDB3UAl7rsYPXSL4hN+wTRRdQsXAzTw AXYv6soWhgQSc2I8RQaPquZNzd7qnlQbf90eVr4ItTUtg9Rch X-Received: by 2002:a05:600c:1d96:b0:416:a5aa:c9af with SMTP id p22-20020a05600c1d9600b00416a5aac9afmr1006886wms.40.1712659805161; Tue, 09 Apr 2024 03:50:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFC+fvnQjnpKwM/wZSzUO7q8ATvnx0VCT24vZ85OnBbMl0BUpL2zZPjEpVvu733YKheu5OzWg== X-Received: by 2002:a05:600c:1d96:b0:416:a5aa:c9af with SMTP id p22-20020a05600c1d9600b00416a5aac9afmr1006867wms.40.1712659804728; Tue, 09 Apr 2024 03:50:04 -0700 (PDT) Received: from ?IPV6:2003:cb:c70a:be00:a285:bc76:307d:4eaa? (p200300cbc70abe00a285bc76307d4eaa.dip0.t-ipconnect.de. [2003:cb:c70a:be00:a285:bc76:307d:4eaa]) by smtp.gmail.com with ESMTPSA id r7-20020a05600c458700b00416b035c2d8sm1239803wmo.3.2024.04.09.03.50.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Apr 2024 03:50:04 -0700 (PDT) Message-ID: <5b90db38-75fe-44fc-b4ca-55dd1b15724d@redhat.com> Date: Tue, 9 Apr 2024 12:50:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/9] mm/ksm: add ksm_get_folio To: alexs@kernel.org, Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Izik Eidus , Matthew Wilcox , Andrea Arcangeli , Hugh Dickins , Chris Wright References: <20240409092826.1733637-1-alexs@kernel.org> <20240409092826.1733637-2-alexs@kernel.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240409092826.1733637-2-alexs@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: wj8yma1j9ios1rym38hdn6mn4f41m3df X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 5A65AA001C X-Rspam-User: X-HE-Tag: 1712659808-153177 X-HE-Meta: U2FsdGVkX1/evfkOZwY5cZU8Xgo4utbOYJLSGeZr1uFgdUUYR1+puJWNDE8lYWWlt2uoqGqzmUawToNY958jh1z9qWWgl1hTXzpOpxiP19rvSCLf5exiTcuVZl985r8KkDhmG7HwwLBC0XDu4cnfeME3UxK1OaYye6U55ZvXLyk6nzOxUotrXr1jjST9sAsh+5ef3e8ZYvqAccSDvs9ZxXNwmcCZdsseT55DGzQCoBIRfLQmU72DsK8sVfcoIw0Bc0XNBNg8QD11zWkJ7Wnz0uPkW3U9CosHogIFmNwpNZCCyetVNxFmmPLgNHJOegMYVNePGEWwXsDOcRlTk8yTJJID9/AwmficM6hG9kUX6TMbU0m/WPd7+QTtLiBy5mT1cixFFYuANkK+2XNPjJzkahzCPFsfEn9g423zTJ3cuttcwDMBDOTUrqIfg/ixQ4j+6YWOwP1BpePGDwzFSIm04TMzowWoobtUCEny7O9IvL6oEiIR/wtYbftbgbS0D1/jfMQ0TyiRmB4OTwALzVz+m5XfZ7vkSIGLyxD4WRZbBF4/cDM0vrbAP1AD/ZvQWdkTwpw0E6zmQFAkxBfkg6BZwYi93myIzxHafg/FLqxDiXLd05GYO/e/iem/vbdpDQz0ZqiUZHdYx3EpGQdq9TKItZrakFwPTkMVKqrKA5E5C60itF9g/5k9rV5AP6enpAHLdtnDK1T0qq6iovpp1oSwuV9IcTuxVezkTkuYDUGYMCV884vXRpykbq+sxm8pGi3LEPzZpaQU8FzaJJIiGsWnFF6HwV1yZ+jKut9DhzVgKBRM0UL6YJVYBSjVHeQ1mGOIkpYSNbyVZ3rEXlCwX2fuCzIGrlpIZiw/6cnBTrAbuN2fO8SnWqSqJuipV/PvOnXxaQLegOxnWNPxukosPpV7TKFIfU4G4rToHdx1RcQagKSygZyoAcQ1CrsiFpgGNgrf5mw1j+PK8ybBGVq7M3G 9KeYv+u0 +xTjMIkNgm5zdiwb7Ly2quPHLfxyJZ5upNiMkyA3RenteIu9asVlGYsp3lf5cvvS5COhaXFPGrnnV6YJfLbCebcJil01Vqps5bg3j6OqzfFydKpKXt6CQoiIxxICYD4ScriIIGiYgSMITAd3rFUuAAl+779wCb3+tYNJQGrklbfJ9L2730o/hkaGekVfcJEkaMQpdJESMklCJhYUeuYbjZ/bhUzO3CzASt8+cDQa6YAr6mLEx50eQa72pU0XNlHhi5/HM9fXAi1bV8Py5iir/m8scxN5Ad2vax5iHIW2eteQWISHznN5yZwmJWT70nsVQs6qXM75tm9QsCJ6WBisiZr9OoMN3NK/rR3kWemx0MVIAKcKJpUlwVUqGZqIaX1E8WPd4jUXdbqBScu+SxUltCs8StlkkUZjdD/WFbfP8H1F6czvA9ygTqdMVbBxwrhvDm0VLqaTPvOdHPXV01ImBSbrARa+Gnqea+XrwXwaJjpVkHvgPH5YH5syoX0uUAwG+I/OqVeBlcFLk96bnwOSgpN0ll/YiL13eDK6YF5E3Yvb0DJFDSoo/9FDJ6U+IeEIzWlOUeUad/xEEDkeASjrllpqfG8MeQrHXtMGT4moraLbBnq492tH0cCyOP/Rvtymx2YSHS93GBekE/vo9lCcOb5AdbKtzfxGU9RPiCFsIE2CjpT9qKD9hQBJZCL3OxL7ApX76e7ulnmh18rSHu2Az2e3pF2B6gOBRt2ikVd7MmvazAFbyJ1+dzn815gPnDLwrWcJyHOoz9ty+ZBJWhdlnNndlOUMcKjQAxvOEUiU7HjAY0sswTKGO98v5zw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09.04.24 11:28, alexs@kernel.org wrote: > From: "Alex Shi (tencent)" > > The ksm only contains single pages, so we could add a new func > ksm_get_folio for get_ksm_page to use folio instead of pages to save a > couple of compound_head calls. > > After all caller replaced, get_ksm_page will be removed. > > Signed-off-by: Alex Shi (tencent) > To: Andrew Morton > Cc: Izik Eidus > Cc: Matthew Wilcox > Cc: Andrea Arcangeli > Cc: Hugh Dickins > Cc: Chris Wright > Reviewed-by: David Hildenbrand Note that the more common way is to have RBs ets fist. Further, I haven't really seen "To:" that often :) -- Cheers, David / dhildenb