From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72A05C3064D for ; Tue, 2 Jul 2024 09:19:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA8826B00B6; Tue, 2 Jul 2024 05:19:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C58396B00B7; Tue, 2 Jul 2024 05:19:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AAA3B6B00B8; Tue, 2 Jul 2024 05:19:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8D8296B00B6 for ; Tue, 2 Jul 2024 05:19:34 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3954616210A for ; Tue, 2 Jul 2024 09:19:34 +0000 (UTC) X-FDA: 82294264668.16.FE572BC Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf12.hostedemail.com (Postfix) with ESMTP id A4EE74000C for ; Tue, 2 Jul 2024 09:19:31 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=drSqDWEg; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=QoAuriyS; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=drSqDWEg; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=QoAuriyS; spf=pass (imf12.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719911960; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nS4hKIOxo6Ar0oCfYeL+3M+6QKMvYD0D8Po5/l7dXz4=; b=V7sj0QbPvJvY+sQLP7FGZKmTH+PyQCDjxMAf2W3PtmcCEUQcyzpen3VmTBj31VCKx9CbZ+ muYOowyeywB6crXXprhLJA9J2B9DGCTofacdvP6ENyEztlw0WL4u3M2SkROBAg6ZtP5qNa gUZEx7qz0Uit7iZKIh/d97RDqwliStI= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=drSqDWEg; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=QoAuriyS; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=drSqDWEg; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=QoAuriyS; spf=pass (imf12.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719911960; a=rsa-sha256; cv=none; b=E2Lins2el1tCVigKJwhfXt63jubAgThTzvwA/4uBLnZKhkfzXflsn2ldMWW6BSAomq+ntM DGb/DI8M00dO8EuOVTYFRRobpvXWH8w3foHx4RaHvvW4poes5Btn7tPeG0s0HS2LF2yzci zmehHTIMyr9qyxpSLW/VhxU6Mv2MSKg= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A160721B28; Tue, 2 Jul 2024 09:19:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1719911969; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=nS4hKIOxo6Ar0oCfYeL+3M+6QKMvYD0D8Po5/l7dXz4=; b=drSqDWEgPPcVGj3od8OoHz8vTGNWk/fx78KtVkkKn9R4tYz9QKxIYPkumyWhx5pJHRmmK5 X1UMU4+oneOPQKrX971Ty61iJ+MLpPywox2HLvKl51j6qdeaiI+XNxvxpDKS+pCicWtVg2 W2+vCG7+GG9lotLMZbmvg/3beQzR3yY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1719911969; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=nS4hKIOxo6Ar0oCfYeL+3M+6QKMvYD0D8Po5/l7dXz4=; b=QoAuriyS0QyZSYQwZav+tbQrPFFyHFJtkNp2Hyx8wkEcJgun+jHN6YmOI0v7c+0XbPvSEq ToR6Tci/k6TbJmCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1719911969; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=nS4hKIOxo6Ar0oCfYeL+3M+6QKMvYD0D8Po5/l7dXz4=; b=drSqDWEgPPcVGj3od8OoHz8vTGNWk/fx78KtVkkKn9R4tYz9QKxIYPkumyWhx5pJHRmmK5 X1UMU4+oneOPQKrX971Ty61iJ+MLpPywox2HLvKl51j6qdeaiI+XNxvxpDKS+pCicWtVg2 W2+vCG7+GG9lotLMZbmvg/3beQzR3yY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1719911969; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=nS4hKIOxo6Ar0oCfYeL+3M+6QKMvYD0D8Po5/l7dXz4=; b=QoAuriyS0QyZSYQwZav+tbQrPFFyHFJtkNp2Hyx8wkEcJgun+jHN6YmOI0v7c+0XbPvSEq ToR6Tci/k6TbJmCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 070231395F; Tue, 2 Jul 2024 09:19:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id tchUASHGg2bPKgAAD6G6ig (envelope-from ); Tue, 02 Jul 2024 09:19:29 +0000 Message-ID: <5b8e6ddc-6472-4acd-a506-98bc3586f1f3@suse.cz> Date: Tue, 2 Jul 2024 11:19:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 4/6] mm/slab: Introduce kmem_buckets_create() and family Content-Language: en-US To: Kees Cook Cc: "GONG, Ruiqi" , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , jvoisin , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Xiu Jianfeng , Suren Baghdasaryan , Kent Overstreet , Jann Horn , Matteo Rizzo , Thomas Graf , Herbert Xu , "Gustavo A. R. Silva" , Jonathan Corbet , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org, netdev@vger.kernel.org References: <20240701190152.it.631-kees@kernel.org> <20240701191304.1283894-4-kees@kernel.org> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20240701191304.1283894-4-kees@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: A4EE74000C X-Stat-Signature: yy9i74qftt63zii5oxfaxepqc7mwwyb9 X-Rspam-User: X-HE-Tag: 1719911971-476911 X-HE-Meta: U2FsdGVkX19Ry320g4uvSy0fqQ/s1oX6/pZw21VrWKp53iJsEBhac813zDJHbQHY+wcU91fadGCMd5n9jVoe07w4kHciyUEzOZjoGbmi10hIvB9qhC0Sf/NBouH8h/hVqcQ+j5tAh0PpZF6ERblW7xkowYkrr7NfhLE/h3Wahm7JgwvyjD7+ZXPKZbQNcD/DMYphDn+LM7VFnIL2f+T2qwCIvSPIZQRsGA7Kcp7C0s2JZR2BvYYAqy+ooo2Sd/l5jHmWTBdhcqXoaqZVlRWALF6mshEkYK0Va9Gd+9PTAZA8oubw8NjkzS7zBhTGO4RhXOm8/ESOkBevR1J226Do/olkFQ2GwGnVmFCRGh/V/lXrDmy4ajC6vPlkMCkCIzaws99FWlrIG7UtCe/G+csmUcFszbihKWNzIRbowteaZJmUw2NB85BjQ8URPEFPX8UK5pvrUp9vSZtn1o+IcVxmcXn70C0KbMEkLz0KWlB2hu1G389Q3wrkn13u2EjyBxUE0SqgQuqrNp4OFuVJHXMBYoZi7/0UoRi6pAXNn1U4SqTsm06DyY/SZtYnTPcIPlPQsYM5fN92dgRPL/T90Ab9Y8GSfofWBYlPyyQnhUHrUAaR9/lC56Bn4iNp/ob62hxv7UG8HmrF6Wc14KLX1BcBMKFlArV1BvweBMwXI7D3yIp7aOLKeBc1/UNHl5NLPx2xcHCzgJ6sPzIpvQ4AfqI8+yKptK6QdhZ3mIRkA31TE8o/MmKZuIue9rFDcgraiC8t17OZkVWOI2MKvcUsKKSLXHWyUtnhRg3ixPzniwQeBjq70GjDCXxMZ8TzniH00iBiq4FyFHz2/rtVNRpcOpnC+jaIM5dUqkLr3imPWaguulxH5mfYF31cdYv8DuS9pi1iR0MpJ2Wx8pvdgnxz7JTEy3eTv9SBNNgE3hZVCBBi/cu2Ja9O/pjxdambOphOR3O2kBjVWoLx2AmJEw/W93S 9Wd4Cpf7 jqzxX2yv0515XAClpRxgN5NRAXiUQ7IZOvlYofW2AHibscabJ4r65qHEfxVgRopQFzRt3Nk8RM0XjMSPu/asPVbnrccKTYy7pmTpr2ZG1myZ7dnqGkolvDfjCnJ5uduzlK8nyMB22WnfLWcLORMfqXrFV59dH4Zl7WMk8k+K1XaSoIY1OrU/tWFEJmZB3IJcu3slYDIBnmku/xc8E1AcBHQjehJzc+L9Lup94FkBxM+v7V9UE5mvgkIhLfEt9/lXNiWs/CQsHbaHTUUZhFhegIDYTmQGd8n4oxBEZozimbsFT3I2k8pJv1Dxu3FvLfMk1LoR6fYxAhS0HruMMsIBqSzV300Cn+ZGG9zm1YwVg9/zx/EqI3126BEzdVPxMZ5EQRnTH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/1/24 9:13 PM, Kees Cook wrote: > #ifdef SLAB_SUPPORTS_SYSFS > /* > * For a given kmem_cache, kmem_cache_destroy() should only be called > @@ -931,6 +1023,10 @@ void __init create_kmalloc_caches(void) > > /* Kmalloc array is now usable */ > slab_state = UP; > + > + kmem_buckets_cache = kmem_cache_create("kmalloc_buckets", > + sizeof(kmem_buckets), > + 0, SLAB_NO_MERGE, NULL); Locally adjusted to put this behind "if (IS_ENABLED(CONFIG_SLAB_BUCKETS))" > } > > /**