From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01C3EC433B4 for ; Thu, 13 May 2021 16:22:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 74FCA6143D for ; Thu, 13 May 2021 16:22:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 74FCA6143D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id ED0D16B006E; Thu, 13 May 2021 12:22:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E80896B0070; Thu, 13 May 2021 12:22:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF9E66B0071; Thu, 13 May 2021 12:22:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0159.hostedemail.com [216.40.44.159]) by kanga.kvack.org (Postfix) with ESMTP id 98E2F6B006E for ; Thu, 13 May 2021 12:22:31 -0400 (EDT) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 2C34EB9F3 for ; Thu, 13 May 2021 16:22:31 +0000 (UTC) X-FDA: 78136725702.31.EE9B5F1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf30.hostedemail.com (Postfix) with ESMTP id B42E1E0001AF for ; Thu, 13 May 2021 16:22:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620922948; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EIx7hWghyOcKHsxnhk7V96UW46vI1Sqd/jZUYBrxrFs=; b=hKlULPkoulYlZIy5SXjnctz4Sn/fCBGk+wDptP8HVw3G1CLr4vTlrSoWCNbO+MokCiYnfW t6b/MX4M2yrnH99zV3UbhNu6svZPrZfrPh+V25oApTFyYDTDYVp3rQ8uj2+5y7lZdXv/vU qQIOphsNd2h7DrjYR7QvJ/aiwHcR0Rk= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-587-jZY3E3HnN02yDWutchAiaw-1; Thu, 13 May 2021 12:22:25 -0400 X-MC-Unique: jZY3E3HnN02yDWutchAiaw-1 Received: by mail-qt1-f199.google.com with SMTP id o5-20020ac872c50000b02901c32e7e3c21so18313727qtp.8 for ; Thu, 13 May 2021 09:22:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=EIx7hWghyOcKHsxnhk7V96UW46vI1Sqd/jZUYBrxrFs=; b=lWnQOIcntlwai/wY9V1oHHvs9dIjL6Xm6niEqDv3FVqXxhn1gSLn80NkQpKInVgBLv sbgNar47hIC5CklSK4OZRtvSoMgQfw4hkd5r+mnTkh/InM7y0UYH+olD/s2rijmRSYSq PmH46k3Aag7KV8RT5Lki2cE15u7MGbIYmqlbDyL9to1nI2o7n5W00IZREC28y/4vQMz5 B7kedsiP+ydqOQKc+JC8bjO25vMmKosL2s1Ba3kX5y74C571kMbSbgTdRXuyKRuKXRfU CT90lvOI5I2I1JJmdwWb/tQQzL+vASe0+QmVYlCIUG9fNvy6IZsunWma0RBeBS9K3ceH ZL3A== X-Gm-Message-State: AOAM531iPj7RGO3R2CMcCQW4+YOakGhsUIlwOwy6ixyg03lRYWEoVYVi LrbHwMo5BUSqj1N8AucOQPdx1knMFkGMHRhq4Q/PQqAo5qNZ5DninWUumUlhkr329Wea5yWcC94 O03JQT+2jr00iEnK/vdIz8W/7geeRrO54ojBA90Z0EjqkTe7ggUyBS1CwG3I= X-Received: by 2002:ae9:c010:: with SMTP id u16mr36002749qkk.133.1620922944425; Thu, 13 May 2021 09:22:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJypW52z4koXjDm+vseDa/OGAuJKFw35V6mcwKGIJDY6x7ocwRRUfji64raykrWzMhJogEoz0Q== X-Received: by 2002:ae9:c010:: with SMTP id u16mr36002717qkk.133.1620922944166; Thu, 13 May 2021 09:22:24 -0700 (PDT) Received: from llong.remote.csb ([2601:191:8500:76c0::cdbc]) by smtp.gmail.com with ESMTPSA id c20sm2816714qtm.52.2021.05.13.09.22.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 May 2021 09:22:23 -0700 (PDT) From: Waiman Long X-Google-Original-From: Waiman Long Subject: Re: [PATCH v5 2/3] mm: memcg/slab: Create a new set of kmalloc-cg- caches To: Andrew Morton , Waiman Long Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Shakeel Butt , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org References: <20210505200610.13943-1-longman@redhat.com> <20210512145107.6208-1-longman@redhat.com> <0919aaab-cc08-f86d-1f9a-8ddfeed7bb31@redhat.com> <20210512173212.738f592c36bf0e4c205f628e@linux-foundation.org> Message-ID: <5b853795-6583-8527-93d2-68ff0b9b5457@redhat.com> Date: Thu, 13 May 2021 12:22:21 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210512173212.738f592c36bf0e4c205f628e@linux-foundation.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Rspamd-Queue-Id: B42E1E0001AF Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hKlULPko; spf=none (imf30.hostedemail.com: domain of llong@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=llong@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam04 X-Stat-Signature: s1ad4czwrjuf5oszks7gahigjwnutic8 X-HE-Tag: 1620922947-510875 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/12/21 8:32 PM, Andrew Morton wrote: > On Wed, 12 May 2021 10:54:19 -0400 Waiman Long wrote= : > >>> include/linux/slab.h | 42 +++++++++++++++++++++++++++++++++-------= -- >>> mm/slab_common.c | 25 +++++++++++++++++-------- >>> 2 files changed, 50 insertions(+), 17 deletions(-) >> The following are the diff's from previous version. It turns out that >> the previous patch doesn't work if CONFIG_ZONE_DMA isn't defined. >> >> diff --git a/include/linux/slab.h b/include/linux/slab.h >> index a51cad5f561c..aa7f6c222a60 100644 >> --- a/include/linux/slab.h >> +++ b/include/linux/slab.h >> @@ -312,16 +312,17 @@ static inline void __check_heap_object(const voi= d >> *ptr, un >> signed long n, >> =C2=A0 */ >> =C2=A0enum kmalloc_cache_type { >> =C2=A0=C2=A0=C2=A0=C2=A0 KMALLOC_NORMAL =3D 0, >> -#ifdef CONFIG_MEMCG_KMEM >> -=C2=A0=C2=A0=C2=A0 KMALLOC_CGROUP, >> -#else >> +#ifndef CONFIG_ZONE_DMA >> +=C2=A0=C2=A0=C2=A0 KMALLOC_DMA =3D KMALLOC_NORMAL, >> +#endif >> +#ifndef CONFIG_MEMCG_KMEM >> =C2=A0=C2=A0=C2=A0=C2=A0 KMALLOC_CGROUP =3D KMALLOC_NORMAL, >> +#else >> +=C2=A0=C2=A0=C2=A0 KMALLOC_CGROUP, >> =C2=A0#endif >> =C2=A0=C2=A0=C2=A0=C2=A0 KMALLOC_RECLAIM, >> =C2=A0#ifdef CONFIG_ZONE_DMA >> =C2=A0=C2=A0=C2=A0=C2=A0 KMALLOC_DMA, >> -#else >> -=C2=A0=C2=A0=C2=A0 KMALLOC_DMA =3D KMALLOC_NORMAL, >> =C2=A0#endif >> =C2=A0=C2=A0=C2=A0=C2=A0 NR_KMALLOC_TYPES >> =C2=A0}; > I assume this fixes > https://lkml.kernel.org/r/20210512152806.2492ca42@canb.auug.org.au? > Yes. Cheers, Longman