From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BC0EC4345F for ; Wed, 24 Apr 2024 06:56:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C40E46B0207; Wed, 24 Apr 2024 02:56:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF1086B020D; Wed, 24 Apr 2024 02:56:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE0606B020E; Wed, 24 Apr 2024 02:56:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 916936B0207 for ; Wed, 24 Apr 2024 02:56:07 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4A7008026F for ; Wed, 24 Apr 2024 06:56:07 +0000 (UTC) X-FDA: 82043515974.29.F6DB537 Received: from out30-110.freemail.mail.aliyun.com (out30-110.freemail.mail.aliyun.com [115.124.30.110]) by imf20.hostedemail.com (Postfix) with ESMTP id 3A9F41C0008 for ; Wed, 24 Apr 2024 06:56:03 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=ZO02DVJQ; spf=pass (imf20.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.110 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713941764; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2LDS+LSReqfsB8JRylwTSVQ4K8jQm0x7cZkTh0Y40I4=; b=Ut5+0sE8+KiA2yxGG0RNOwiWncPMCT0WOdp70w/Vvhe2+sGkAFkGqrWHpZ4BT67ZuU7lRx wK3601HP3ZrKcat8uZ44fqhrOqg4VtaAab2kBszeSO9kRQHF+7mTzmKNYET6MiYn9NFEbY uhQNIzmSMYcK8GukXy3NnBL9lLUz8PE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713941764; a=rsa-sha256; cv=none; b=j4F/iWaatxhKjOb8Y/Y9BocwiPatbbt8xy3vEZexQJvM09UTnLvmmrrYwBlNsPzJJ+lTk9 KccF/7FCvqeB+xL9jIiKgWzo6u+CW4anC8WmNnd1oahDEuausficU8YTUJ5Z4Sd3FwNroK cyygiEDv6I/dxmHiH+4WxlxoFukO6JY= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=ZO02DVJQ; spf=pass (imf20.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.110 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1713941761; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=2LDS+LSReqfsB8JRylwTSVQ4K8jQm0x7cZkTh0Y40I4=; b=ZO02DVJQH7/iegc3wtivE+/BhA/ecAA3YuYzZTf7evTC93cAK3DDBx+2ZS68/AWnzpoHFFYq/MuGlEyK17C7c7Row9edn99hYVu59TKGDwtcJhVaXGV78LCb4+hK7IEnE4RVH2v1e67S8rVy8BmSdpRiYU3+yQd20XnBB3SVWC0= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R871e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033037067109;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=12;SR=0;TI=SMTPD_---0W5BTi-m_1713941728; Received: from 30.97.56.58(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0W5BTi-m_1713941728) by smtp.aliyun-inc.com; Wed, 24 Apr 2024 14:56:00 +0800 Message-ID: <5b663fcc-cace-4091-aa56-e88b00ec1d1c@linux.alibaba.com> Date: Wed, 24 Apr 2024 14:55:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 2/5] mm: shmem: add an 'order' parameter for shmem_alloc_hugefolio() To: Kefeng Wang , akpm@linux-foundation.org, hughd@google.com Cc: willy@infradead.org, david@redhat.com, 21cnbao@gmail.com, ryan.roberts@arm.com, ying.huang@intel.com, shy828301@gmail.com, ziy@nvidia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <2014bf7370d78bc1f5600731af5bf8f569e5868b.1713755580.git.baolin.wang@linux.alibaba.com> From: Baolin Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 3A9F41C0008 X-Rspam-User: X-Stat-Signature: w9diqq6yp3dfe3d1mk477dfj981egyph X-HE-Tag: 1713941763-736161 X-HE-Meta: U2FsdGVkX19jJ6Uzxcwjnzq41RXXgAewVVIyhHeum80XcTBgi5e/Q2LbB/1ci5u12XqQ9+lvWTXDiNqPExbXxoihVMNHgzDhuam8kKSTa8aoYpiOk0W3jkvo39mTdiJeVo/ZfRCFtyrEDgRO92znD3qIaEwdB3w4QuVvWtz8SOxTy9zFWAT+VrVCyY5XGRegpt4j9JPzoK/x2853aTZ2OA/dTiW7X0MmrZ6AD0aji72xlp5OG/TxcmuUNxsSbNErAk5ip6aFed+XwRWs/5p7b0eBcuQBBEpcOJewfIalzWprWo6vGt7OJh/wVqCMz+OGouV/3A9WfL6iYCXMysmmMOYgxAHKAUbHRMriZjCK7qMOEhmNp/l63uQ1+8BoHUlEVOzXrtXKVQwNP4O/x1b9RNAvGG8jPz/GtC3zz9IJExtKuugitSZRtUgPm+H+tY6gtWez4wEYuM5Wxs5SCFijH8RjD62sUFbthX/HtJirSXoAfpnZ8EKfqOOyta1+5hcV00UuWSy3MoWASQe9m/h7BkyVYUXBrm6IovYhipN6Dkbpw40PjRunoWprVaFpmwpO09LlZTntOKX630hLIYuT1cBeGiz+sFqO6AWx9ItiLcrizhCfgkr1OPupwsO1g5mVAEj1eSd4xU7ye3Hv7AF8Rz8FHeR7PAF1oOpwl/3k0hyCpeyjGWymKQLnx2kijl++Ze/nW8JFczAHldPp34X2vZtwEgym82IQFKfP+czTbeWqh9WM94EoOWaFbqMtz8ku7s7+RuvI1x5ll42Qpdodjw4H2U6KBxi9rScQG1YOCJ52rodjYNUhOi+5ey6DmjTA5hrA0SKVlilsL7FxLJfgbDk2i5XPpmD0BzeZmNYmc45FDMnsB/SqvOBGW71IZJESQw8sdra/YYptKi9LBDxMpWaseSx+axL92aETaEVQF0Z2PWCmxRsjhYA+aTWlZXjBPkQqF7TPrCpIVWV4/xP SM9fDxz2 PPKoGHvEHK0Wk3+sZdq8MOeWh9NqAC9ylJK5zLYOxImGn95DkpIJgopz+RorG3QiLqKpaWDyaYRBNAd1cqtZyEOccsQzPoUg9bRxROltUO3VS4OKS5D8YHC3dGNRwJeQT6fuZGs+OUJEe3E8AZ7Vdf6vs1QXP/swWL9yc4YNIz67ISFvBtipkLxFV/ZClQLKCoR/pXdcizblmiklCoJ2O9DEOZvc7jWz3VYcJL7zK/Kss5AV9ewA7lSTdG+C0SByX1CFwFE/qqLlnDT+Q4FDOYaj71dqz7A5629NOSGHFBZAJNVgrFX8e/VmgawVrajNn7v1f8bQCCOuj53X3OI3YBkq+L8r+Ne3iJghH8ZyQxBnMWUjrq84yxxu8eFsukBaYCM6rUQgtN2Wr9l0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/4/24 14:28, Kefeng Wang wrote: > > > On 2024/4/22 15:02, Baolin Wang wrote: >> Add a new parameter to specify the huge page order for >> shmem_alloc_hugefolio(), >> as a preparation to supoort mTHP. >> >> Signed-off-by: Baolin Wang >> --- >>   mm/shmem.c | 11 ++++++----- >>   1 file changed, 6 insertions(+), 5 deletions(-) >> >> diff --git a/mm/shmem.c b/mm/shmem.c >> index fa2a0ed97507..893c88efc45f 100644 >> --- a/mm/shmem.c >> +++ b/mm/shmem.c >> @@ -1604,14 +1604,14 @@ static gfp_t limit_gfp_mask(gfp_t huge_gfp, >> gfp_t limit_gfp) >>   } >>   static struct folio *shmem_alloc_hugefolio(gfp_t gfp, >> -        struct shmem_inode_info *info, pgoff_t index) >> +        struct shmem_inode_info *info, pgoff_t index, int order) >>   { >>       struct mempolicy *mpol; >>       pgoff_t ilx; >>       struct page *page; >> -    mpol = shmem_get_pgoff_policy(info, index, HPAGE_PMD_ORDER, &ilx); >> -    page = alloc_pages_mpol(gfp, HPAGE_PMD_ORDER, mpol, ilx, >> numa_node_id()); >> +    mpol = shmem_get_pgoff_policy(info, index, order, &ilx); >> +    page = alloc_pages_mpol(gfp, order, mpol, ilx, numa_node_id()); >>       mpol_cond_put(mpol); >>       return page_rmappable_folio(page); >> @@ -1639,13 +1639,14 @@ static struct folio >> *shmem_alloc_and_add_folio(gfp_t gfp, >>       struct shmem_inode_info *info = SHMEM_I(inode); >>       struct folio *folio; >>       long pages; >> -    int error; >> +    int error, order; >>       if (!IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) >>           huge = false; >>       if (huge) { >>           pages = HPAGE_PMD_NR; >> +        order = HPAGE_PMD_ORDER; >>           index = round_down(index, HPAGE_PMD_NR); >>           /* >> @@ -1660,7 +1661,7 @@ static struct folio >> *shmem_alloc_and_add_folio(gfp_t gfp, >>                   index + HPAGE_PMD_NR - 1, XA_PRESENT)) >>               return ERR_PTR(-E2BIG); >> -        folio = shmem_alloc_hugefolio(gfp, info, index); >> +        folio = shmem_alloc_hugefolio(gfp, info, index, order); > > Avoid order variable, we can directly use HPAGE_PMD_NR here. Yes, sure. Thanks.