From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89D8FC6FA83 for ; Tue, 27 Sep 2022 07:26:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 91E0D8E00B0; Tue, 27 Sep 2022 03:26:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A73E8E00AF; Tue, 27 Sep 2022 03:26:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 720578E00B0; Tue, 27 Sep 2022 03:26:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5D7048E00AF for ; Tue, 27 Sep 2022 03:26:47 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2DA1D80771 for ; Tue, 27 Sep 2022 07:26:47 +0000 (UTC) X-FDA: 79957033254.12.4C5D51A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf10.hostedemail.com (Postfix) with ESMTP id DA97DC0008 for ; Tue, 27 Sep 2022 07:26:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664263605; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W9ODtW5t5SdFcjBY6SIxecQUGUZ3KwRU79qXAI2vn/s=; b=DCLhUR2CbJNisa7OggIHHKIhyh/wbxz+hwJB9dFSD7CwgiE5z9pSAllz0DRlqNAiTFbORs fiHSz1RDcDtkU3rLgEeRsXaR+w6l4PTOKNEcUwfnJxNO3T9ZzIBLaQraYa2Rh86oinnSv1 qpwTGWOCToqeaFT+kCWAWoWHdIuxipM= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-531-kuebSonYMdWWoC3n-FlRbg-1; Tue, 27 Sep 2022 03:26:44 -0400 X-MC-Unique: kuebSonYMdWWoC3n-FlRbg-1 Received: by mail-wr1-f71.google.com with SMTP id q17-20020adfab11000000b0022a44f0c5d9so1843939wrc.2 for ; Tue, 27 Sep 2022 00:26:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:organization:from :content-language:references:cc:to:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=W9ODtW5t5SdFcjBY6SIxecQUGUZ3KwRU79qXAI2vn/s=; b=sq06gg4+vyioGxo0D1mjKn0H8n9+8u9WLeOIAD+OXdGac2JvSWxZ7rbRqEihZZSMT/ hU9p/cvVqA6Ynzz3Y86X/FvSuNWqqMMKwOpYDJBNHiNAbRZ8p/2gBsuNrx3o+l+BTUhY X8EfsByV2MSDwv4nMyy1mo/CnIM4BDLirKrrA1JtvRHsox+RUKqTRGwvr3iQvEnew71D gA6eRN+sjjdo3F+fmnqHN+vbu77vgaYkO5p3pJr/sOTMISFq8UcI3quj9Jjx/4/eAt8o c1+i48UcBHBGcFd+CHPUAuYpQBVD9DR5bip/g88Hn2uEfrJPlo+sDxef0LbUpi4Q9atW qdKg== X-Gm-Message-State: ACrzQf0GtOjI8eQcnGlhrfmpe5s/jjm3iBm0Kk7ND7+dRvmTbcXIb4Y9 gqIUWfKZE+E3qa5LxbcpH72u/mUbyieaTABn5RAc98yhgxRQfNroagCbfzCwGlwo58vQ1m8UXnl OMn96OF2Oypg= X-Received: by 2002:a05:600c:19cc:b0:3b4:adca:a821 with SMTP id u12-20020a05600c19cc00b003b4adcaa821mr1501645wmq.37.1664263602893; Tue, 27 Sep 2022 00:26:42 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5/u7dRyYkitd+pZfI4fWVynEDAa14tDXYouDfpjUugWODzpdBq08pRSKrBR8ZnTmXtzQFY8g== X-Received: by 2002:a05:600c:19cc:b0:3b4:adca:a821 with SMTP id u12-20020a05600c19cc00b003b4adcaa821mr1501630wmq.37.1664263602593; Tue, 27 Sep 2022 00:26:42 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:ff00:9ec2:6ff6:11a1:3e80? (p200300cbc705ff009ec26ff611a13e80.dip0.t-ipconnect.de. [2003:cb:c705:ff00:9ec2:6ff6:11a1:3e80]) by smtp.gmail.com with ESMTPSA id jb6-20020a05600c54e600b003a5537bb2besm885860wmb.25.2022.09.27.00.26.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Sep 2022 00:26:42 -0700 (PDT) Message-ID: <5b62011e-e41c-ffb8-68f6-80e55925498c@redhat.com> Date: Tue, 27 Sep 2022 09:26:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 To: Zhao Gongyi , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Cc: akinobu.mita@gmail.com, corbet@lwn.net, osalvador@suse.de, shuah@kernel.org References: <20220927032851.128174-1-zhaogongyi@huawei.com> <20220927032851.128174-2-zhaogongyi@huawei.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH -next v4 1/3] selftests/memory-hotplug: Add checking after online or offline In-Reply-To: <20220927032851.128174-2-zhaogongyi@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DCLhUR2C; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664263606; a=rsa-sha256; cv=none; b=rsNhl6MBmwKjkKXi49K9MwoPyVrZ+Akm+0VJT8nDrSQdNvzEhcCR442B5NuB+cDMSl7rUt WOQTM8Swss5KxFD8rI4s5bw2P+hnlPhmQj1gD0Dj5xpXijdDI2+Sw3k6LjUidGs8chhsX6 BH4GqfwCR5Q4NyoWHqVYOHMwD8hoANI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664263606; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=W9ODtW5t5SdFcjBY6SIxecQUGUZ3KwRU79qXAI2vn/s=; b=oU6toxTwcBr9R8xKFVb5HhXbUoFl3oA6l6XaVssYVj5Xsd+VvQj9miY0HIOEmQNjUUJfsJ zx8Mx5Bhrl1Av9Ajz6kLAVxqDRIbK5RIqSpybJOCDECOIH8+lC0T6QGjUfdUeBrPmz1n18 OB6w0GdJ9HEzcnTLVoZdeUjrAeoiN2U= X-Stat-Signature: xxdiaqugsd5sewmty1bcpfjtdwqagzap X-Rspamd-Queue-Id: DA97DC0008 Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DCLhUR2C; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1664263605-212861 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 27.09.22 05:28, Zhao Gongyi wrote: > Add checking for online_memory_expect_success()/ > offline_memory_expect_success()/offline_memory_expect_fail(), or > the test would exit 0 although the functions return 1. > > Signed-off-by: Zhao Gongyi > --- > .../selftests/memory-hotplug/mem-on-off-test.sh | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh b/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh > index 46a97f318f58..1d87611a7d52 100755 > --- a/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh > +++ b/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh > @@ -266,7 +266,9 @@ done > # > echo $error > $NOTIFIER_ERR_INJECT_DIR/actions/MEM_GOING_ONLINE/error > for memory in `hotpluggable_offline_memory`; do > - online_memory_expect_fail $memory > + if ! online_memory_expect_fail $memory; then > + retval=1 > + fi > done > > # > @@ -274,7 +276,9 @@ done > # > echo 0 > $NOTIFIER_ERR_INJECT_DIR/actions/MEM_GOING_ONLINE/error > for memory in `hotpluggable_offline_memory`; do > - online_memory_expect_success $memory > + if ! online_memory_expect_success $memory; then > + retval=1 > + fi > done > > # > @@ -283,7 +287,9 @@ done > echo $error > $NOTIFIER_ERR_INJECT_DIR/actions/MEM_GOING_OFFLINE/error > for memory in `hotpluggable_online_memory`; do > if [ $((RANDOM % 100)) -lt $ratio ]; then > - offline_memory_expect_fail $memory > + if ! offline_memory_expect_fail $memory; then > + retval=1 > + fi > fi LGTM Reviewed-by: David Hildenbrand I am questioning the stability of the offlining test, though. Offlining a random memory block can fail easily, because "->removable" is not expressive: # tools/testing/selftests/memory-hotplug/mem-on-off-test.sh Test scope: 2% hotplug memory online all hot-pluggable memory in offline state: SKIPPED - no hot-pluggable memory in offline state offline 2% hot-pluggable memory in online state trying to offline 2 out of 96 memory block(s): online->offline memory0 tools/testing/selftests/memory-hotplug/mem-on-off-test.sh: line 78: echo: write error: Invalid argument offline_memory_expect_success 0: unexpected fail online->offline memory10 online->offline memory11 I guess this test will almost always fail nowadays. -- Thanks, David / dhildenb