From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97C1DC3ABDA for ; Wed, 14 May 2025 08:53:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EB1DD6B0106; Wed, 14 May 2025 04:53:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E65676B0107; Wed, 14 May 2025 04:53:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D781F6B0108; Wed, 14 May 2025 04:53:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B48266B0106 for ; Wed, 14 May 2025 04:53:23 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5F7A81403CE for ; Wed, 14 May 2025 08:53:24 +0000 (UTC) X-FDA: 83440899528.20.11D732A Received: from out30-113.freemail.mail.aliyun.com (out30-113.freemail.mail.aliyun.com [115.124.30.113]) by imf07.hostedemail.com (Postfix) with ESMTP id 4B4104000D for ; Wed, 14 May 2025 08:53:21 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=ipMlIF4P; spf=pass (imf07.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.113 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747212802; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JJ/rSHDh81oBKwQroykvuLx9r2TIlV4SlOmwfKdL/s4=; b=urKszk9YSCO5XdVf0LNgiyBMnVBBcx63W8zg46DyWTpZwgrvJSA4WKCCAk9SZYVPgDVRW7 vDKbqtxsvaRjonUUr5JM2RmAWFZUNtZsp74EhaQzy2NRNXqTs6xBz8wdvrnvJWCwlUSlA4 icN9ifgHOFeZ4p9AyJ/ql9d0nemp82w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747212802; a=rsa-sha256; cv=none; b=2gdkmO+qXkDhHtcF1UhhhJviWv8xZwslLs/RxJKoWnvgNzBYLXY5Pp3wU+EEwv8g/gxmCm Pairpc3ksEnCGqX/AS7jSLZosGttxZqett/9qZFs6KyQN6X18MXA0dHfeIuvEQ6VS1FEub JYKT1eSk9YboesuQJzq999AsOl1/JUQ= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=ipMlIF4P; spf=pass (imf07.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.113 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1747212799; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=JJ/rSHDh81oBKwQroykvuLx9r2TIlV4SlOmwfKdL/s4=; b=ipMlIF4P6G2znkUMOci3tXxmbVp626JWthZ9j8NtOpcewk9a2A1Dtv79w6roPUAyRyOE3ziIYpD+mwlcxKuX+R8UUweFdXSj+282+Bfl7suBQZpu4iojURsIqzxRQCKm7ysvt1bX6aPKkDuS3Rux8a96ChBT20vkxYS0dXPOIMs= Received: from 30.74.144.106(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WalDO3f_1747212798 cluster:ay36) by smtp.aliyun-inc.com; Wed, 14 May 2025 16:53:18 +0800 Message-ID: <5b615ac3-6080-473f-a0ff-19c38de4ab59@linux.alibaba.com> Date: Wed, 14 May 2025 16:53:18 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/5] mm: shmem: add missing shmem_unacct_size() in __shmem_file_setup() To: Kemeng Shi , hughd@google.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250514165047.946884-1-shikemeng@huaweicloud.com> <20250514165047.946884-3-shikemeng@huaweicloud.com> From: Baolin Wang In-Reply-To: <20250514165047.946884-3-shikemeng@huaweicloud.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 4B4104000D X-Stat-Signature: n9z5j8hk8wgnphpqc1nzncwccczr5ne4 X-Rspam-User: X-HE-Tag: 1747212801-417896 X-HE-Meta: U2FsdGVkX18yagOlXILmA1642luF7+lEugakzfOVMc19CcKSbJDxNTUtaXfQF4q8B6ZHNFev/dAbaOLtrELtySXBJGdo0nBUJP6Enh/PufbLyXUNIqwBM8X4i/1GHzYeY3IYWllMDLXr5Tbw7WBekPLiNhJIFzmk+/y3ZqkOf70HEonhkjnDHdVaXikZYOfL5ZYVpaHxU4IZJO+HRPEXNO8kTpos9y1CFtK6CkglFb2vUdXCd4Ktfq0390ccGuK7kEnkQqzQkN5DTcwuWMd0UhnnB0YPQzslFU1irAAMv2qeV+73cj9QnykSLCxzOLdBSMZuOFkiBG+aHQ1dTDrfK4KAeM+z0FokUu5V7O2lBVNWEXT424AjdbuO57FdlcRZPOfBsAwcg6QtlRX/3PolmSTPax7w0c1a21Y57JeLbedfALX+fvClUcb3BOiBUZZ2m6zuSLixO0JPF5tXWilH80Jy93gic23LdBDuAi9UFKVcrRP6dxRsYzrTo866EZxWGDjG/bflRJksEKhekq3FfDP15S8NGVckWlRtQ3uJW5VLqg5g/F63f60f90XLPUSpZrFngkCITPYrrnBaDFcUjnQOoKyLqIvYFi6KauNRCOwgjiGHP6ZPlbtP6ZppIMWzrJw5rKv+0TNUj32tHpb5vjvr5Tl+5+1r+YNoX0/kRbRTCzW2oNnXUG0e8j81zyhn8tf5T/tPBbABFkjA1hpjmTGC6tXhkIaUx3CBBdnEt651mcizOhbKggz8Cz7QIubbxZllgZQx/x+cpu75lOoIqnmGx/mlkGutonyMcvk7wqZ3wO1+Qr+wtV3Vr8/sraM9qBwWifulOoY9F2rbURnl6EUXhJ5DBIq/sKBfl7Ol0ydVtZYsLCQsSWU1kzZGbACUseQSILviwA//61cpcXClBMaLnlzGK+sqS0Y58rRDhQFcyaWcGz2ws6GCP1l7DSTWCi7/fsGxs8DarBDWHxQ ohSy5od9 6xiQx4rBCZVv9M5KpHtb9tGdWtmlxEfeeMyNXe7GLK2I/zgoink64nL5Gboi1QzDc/XGXoDamyZxeHhzXok10Ad3djhd6r7/xFlYesAcWi+NSmpyDNpX1ReUJ5r9kAUihtuF6PvsjAUOLigLh0ucIafmt/flVIjCBfa8JYgOnY3oxaN7eGpgaFXQRtGruSCyqs4UDdo2agoHCdX7UmOrSlRwOSuvtML2HqQHeIqO6iFvUWaN8UqCH43S4RypcNd0bH7mVwxUa2vdNW9OMnSoIkonk0Xf+3rEcqb09RwochROiqY4rwNzxI9Et6Ghl4FC7jbybF+0N3ksmfifB/LZ8HoDfmw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/5/15 00:50, Kemeng Shi wrote: > We will miss shmem_unacct_size() when is_idmapped_mnt() returns a failure. > Move is_idmapped_mnt() before shmem_acct_size() to fix the issue. > > Fixes: 7a80e5b8c6fa7 ("shmem: support idmapped mounts for tmpfs") > Signed-off-by: Kemeng Shi LGTM. Reviewed-by: Baolin Wang > --- > mm/shmem.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/shmem.c b/mm/shmem.c > index 980fa15f393e..495e661eb8bb 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -5812,12 +5812,12 @@ static struct file *__shmem_file_setup(struct vfsmount *mnt, const char *name, > if (size < 0 || size > MAX_LFS_FILESIZE) > return ERR_PTR(-EINVAL); > > - if (shmem_acct_size(flags, size)) > - return ERR_PTR(-ENOMEM); > - > if (is_idmapped_mnt(mnt)) > return ERR_PTR(-EINVAL); > > + if (shmem_acct_size(flags, size)) > + return ERR_PTR(-ENOMEM); > + > inode = shmem_get_inode(&nop_mnt_idmap, mnt->mnt_sb, NULL, > S_IFREG | S_IRWXUGO, 0, flags); > if (IS_ERR(inode)) {