From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84D4CC00A8F for ; Tue, 24 Oct 2023 16:33:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 04E2A6B02C8; Tue, 24 Oct 2023 12:33:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F40326B02C9; Tue, 24 Oct 2023 12:33:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E07DA6B02CA; Tue, 24 Oct 2023 12:33:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D0B1C6B02C8 for ; Tue, 24 Oct 2023 12:33:01 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9EEE0C04C3 for ; Tue, 24 Oct 2023 16:33:01 +0000 (UTC) X-FDA: 81380899362.28.306C22B Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com [209.85.219.179]) by imf11.hostedemail.com (Postfix) with ESMTP id B8C0840014 for ; Tue, 24 Oct 2023 16:32:59 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=kxDXOjr6; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of hughd@google.com designates 209.85.219.179 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698165179; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CZPaVFmaQu36ybSH1tOD+8dMQ/zySnsYpid63BLeaO8=; b=Zcn7fg6J98jF7fCt/MwMoVNFkTmF9ixV8gXKCUqqKz4UhHHSSc0wfX1pZ3kmATRcXXpRTK 4S8jql28v7BX/TW8GhFvWM9HnKX9eUuKIp/IXF4/MfcTLDhBrnZ+cXIZ9RAxjz8ypGatVw 8vDBTaGG88b4ff0JfsPhLbLAcOotpG8= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=kxDXOjr6; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of hughd@google.com designates 209.85.219.179 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698165179; a=rsa-sha256; cv=none; b=0hdgRgsBbXmwplbE0AyISa1+hLwvZ0WjQd3QOB6XFwUQ1ECRxGYMRz36obVVrbJcfy2LA8 YkXakojgG9cB9jhmiwpiTI7LZwIz0B+k2kK4KvOqp5oCqXd4vNpA++lu7McJaIbC2xMjNR 0/LSCwJ2eAeTi04eE/uSNVmmVMnMwtc= Received: by mail-yb1-f179.google.com with SMTP id 3f1490d57ef6-d9a58aa4983so4464015276.0 for ; Tue, 24 Oct 2023 09:32:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1698165179; x=1698769979; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=CZPaVFmaQu36ybSH1tOD+8dMQ/zySnsYpid63BLeaO8=; b=kxDXOjr6zJDmu35ONLS/D90VtMeHW0T6nBap34VHj/o/la31dj8mwa4fRHH02PoHjd e7AoHRLnVsIw5S1EJEFGM+EFqwm75Cm79hfXNbILExjeVn4dZJDy9Rn3xtug2VrgYEyn v0xgqrCB72rM1VqykY5icTpKo91TyE6meekm/TJBlgBg+lSVE0fw97N90aEkNqXCeVzB lzd5BHnpbAy/VfKQ2KhAxi8nV/LW5DsdrlPULFjVqAdDzmXlRylamrVZau5fLpSf6DYQ yaYPds5PfdA05R7XU3bs7VTVPwxtXqfdPYm4Dzs4RgfZgT3pe3Mh50FOfW7eydGO33AO MFwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698165179; x=1698769979; h=mime-version:references:message-id:in-reply-to:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CZPaVFmaQu36ybSH1tOD+8dMQ/zySnsYpid63BLeaO8=; b=sgyXzN/XEOMrROraCqvkNjqztat5I/mqN7kupzcCCxQTbO3d+/8+rvjZGQlaJrtJVX SzQD5fy43CfgcWNXQsSQ7PXqT6yFIqmqL76c2HDrkO9gYKZMJWLfF0lxp1q4YLCTU6Wh sh6o90YC9TG3KjZqiuaxF561WEYig3xFOdvy4zrg+X0gvvtcfK/AbsibNwEBFbdB7vVZ OS8QLYL2z91dm6zMNZw6hX1WfDZRG1W6j+VTcgXcpLH6tWCBgC/1RRJ2nz+P2qdCnb5I XJQM4/G1OVHxR9alH+JmKDL8XWFOcTioBAGjf2UYMOqyaSn5I68joj6FFWY+XCPAIyZW TLMQ== X-Gm-Message-State: AOJu0YxjNX2m5ddTBgYKVG8brFZw1ut/eQzXPDxWL/TWqwbQHIwQucQQ 0Vk/J5Mnr9xHvr3vczpU0CsYrA== X-Google-Smtp-Source: AGHT+IG5cxpDFx0pwTrv4cdkOqCGMzhlQ+/6LRH3W8ygXnW19y/KuyT/3fCUVSO+WXmiXopiH78nNQ== X-Received: by 2002:a25:2302:0:b0:da0:50a9:a748 with SMTP id j2-20020a252302000000b00da050a9a748mr1775256ybj.11.1698165178508; Tue, 24 Oct 2023 09:32:58 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id d191-20020a25e6c8000000b00d0b0bbe574asm3699140ybh.44.2023.10.24.09.32.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 09:32:57 -0700 (PDT) Date: Tue, 24 Oct 2023 09:32:44 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.attlocal.net To: "Liam R. Howlett" , Hugh Dickins , Andrew Morton , Andi Kleen , Christoph Lameter , Matthew Wilcox , Mike Kravetz , David Hildenbrand , Suren Baghdasaryan , Yang Shi , Sidhartha Kumar , Vishal Moola , Kefeng Wang , Greg Kroah-Hartman , Tejun Heo , Mel Gorman , Michal Hocko , "Huang, Ying" , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mempolicy: migration attempt to match interleave nodes: fix In-Reply-To: <20231024151827.i7e2f6cheet4k5h5@revolver> Message-ID: <5b570bcd-e0fb-4473-7cfc-81b8b53d7712@google.com> References: <77954a5-9c9b-1c11-7d5c-3262c01b895f@google.com> <3311d544-fb05-a7f1-1b74-16aa0f6cd4fe@google.com> <20231024151827.i7e2f6cheet4k5h5@revolver> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: B8C0840014 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: jnfsgdguixefedjmtcw84ghmdhgdc41i X-HE-Tag: 1698165179-378124 X-HE-Meta: U2FsdGVkX1/kodlfWhAnlDfzi8qw1oj0FHOffh7vro6Cc/Gg+xa14kKARL5nQKn60PdNP08/JPpAanwLL9QP45ruZgN3egI0RJjsAzwoKavdUVBLtUyjQPdjFdvy0q81LWcZn2CuWdeGvmhhQwZLsy2jUmsfQIRh5Q8zbHDFAWlIXtA3Co6aroprnp4HICB9bhFA2SpF7sx3HrhM12qBeiaQEbHmqLS+fcVTIqE1Yg617Bp95P40lLNXX+abBTNVreUqSZu2zCpshj336Z8BWWZHBdlkWLJLulP3ukDLUDsLep7q0TW0VjefHpUhU3xyMQsNCNAzXige+P4+NKVKx0Samg2SIl5Jj9bcB/Jzl0DwSx8+GYlMBXMI479peKJXIKhnbR4udvF1VouSHVjvNUTDKMehq4xpeS4u0frb3Z6QFTezUfTxPhia5gTAQiIRUry98CWKYWpZ/xSNLIiPzTRtgfn5oP1NEZb3rV8HAP9o+FAWhF955JaJj57Fa6R/AHjEd68PXWyVLeGoFVkY9/NkfE3q62QX76IeauQvH9+Veyzb/2hPsqBCGqNfCct4i56vfd2H7EksUKgHVxNOerk/Jz+jCDEaLqwwD27CPlZWLgVTmGvBW4gYTGiyUSTg09Ze/fr7eid20FVLZdivtab9deAocAEbf0Xg29nmv7ydMS1sff0+K9TG8mWmY2vHaTP2E6opeHusSuXTouIVjc59cTKZgRnYEXDAFrVRLiwIiB+4bP8toTBqCgqVfVlTMLrX7LFb4gtxGGTXuvoQndjVmEEJrZd26fr8r2JhQdGTjLhUUIMMDxPI0UO4BJu3bXZFdm/PjqbitlHsXkbMnR+zluwBDc/YSvD5rJTlo8lp26is9AH1Elnyrn1SyuG7zYB6rflvnSJbb+3RO1nqV5t+PouMs+82Jz8jRDNADgcs1yrIVK7nHk2mOeqDiTfQmvdHgyJrAYt+7eZoZti 0tdpWw2X DnlaAykICmUi8uze2VeOqkwAPkCLQlGwZKUrtruy8ehinoFXnEKzYFKTJCaGZ5G7ppbHDO4dzCaj81uHHjdoCMpeKZI0O7fqPMqiQPjZAtZaLRCkILuElqiDE3oJ/NHp4yhVci5IOclyBHSGaDdwwiU1ae/siRp34goASH+necX+4cy8SmKXhytv8E8sPWqfSGpxl2Goxc9kgL+EWCKK40KvC2kr/RaZ4RNB9Tb/hmuTPRV8FfYGp3NNAmcBe/dwLcDiu4HKFXByAPr9e1+88N5ni2z4fmzMnZeJhbvrj9GI3KyvKxlkur1aa3mbRAL5R1NoFi31VUS6nZidtZBrL46KrJAn/FLvzeAuXNrHqH0GQO/VSvmZr9khZd6OoBbRorBmJXLaoVOEEKDwkddDqKQLNA3LdnQID8Gmuv77DUcWahejgD3LWWOFBOlJ0b6k+dW108FmlDh6kkPU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 24 Oct 2023, Liam R. Howlett wrote: > * Hugh Dickins [231024 02:50]: > > mm-unstable commit edd33b8807a1 ("mempolicy: migration attempt to match > > interleave nodes") added a second vma_iter search to do_mbind(), to > > determine the interleave index to be used in the MPOL_INTERLEAVE case. > > > > But sadly it added it just after the mmap_write_unlock(), leaving this > > new VMA search unprotected: and so syzbot reports suspicious RCU usage > > from lib/maple_tree.c:856. > > > > This could be fixed with an rcu_read_lock/unlock() pair (per Liam); > > but since we have been relying on the mmap_lock up to this point, it's > > slightly better to extend it over the new search too, for a well-defined > > result consistent with the policy this mbind() is establishing (rather > > than whatever might follow once the mmap_lock is dropped). > > Would downgrading the lock work? It would avoid the potential writing > issue and should still satisfy lockdep. Downgrading the lock would work, but it would be a pointless complication. The "second vma_iter search" is not a lengthy operation (normally it just checks pgoff,start,end of the first VMA and immediately breaks out; in worst case it just makes that check on each VMA involved: it doesn't get into splits or merges or pte scans), we already have mmap_lock, yes it's only needed for read during that scani, but it's not worth playing with. Whereas migrating an indefinite number of pages, with all the allocating and unmapping and copying and remapping involved, really is something we prefer not to hold mmap_lock across. Hugh