From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF167CFA779 for ; Fri, 4 Oct 2024 13:21:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4C0346B0405; Fri, 4 Oct 2024 09:21:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 449C46B0408; Fri, 4 Oct 2024 09:21:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 24D386B0409; Fri, 4 Oct 2024 09:21:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0A9456B0405 for ; Fri, 4 Oct 2024 09:21:33 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B29F21C3C8D for ; Fri, 4 Oct 2024 13:21:32 +0000 (UTC) X-FDA: 82635981624.16.02BE5D0 Received: from fhigh-a5-smtp.messagingengine.com (fhigh-a5-smtp.messagingengine.com [103.168.172.156]) by imf06.hostedemail.com (Postfix) with ESMTP id CC044180018 for ; Fri, 4 Oct 2024 13:21:30 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm1 header.b=Flt8R6ar; dkim=pass header.d=messagingengine.com header.s=fm2 header.b="I lD66og"; spf=pass (imf06.hostedemail.com: domain of arnd@arndb.de designates 103.168.172.156 as permitted sender) smtp.mailfrom=arnd@arndb.de; dmarc=pass (policy=none) header.from=arndb.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728047961; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9tkmmkT8aZFveB/04AxHCDNSFo41C5XPtA7E428DTNI=; b=4n8QeGYdWcxsS862qaxVPCJFPBkun5ERg6cnF5wJJA5CttvGC57oP1YHbEItjEq3y0qcgk U13EiFPsVIs2xSbDndaL1PIcJav7OTvTJuFht4rrvGfIvZLbCk0sVU+I+HvsgVYHw8MXYo FYWhRqT8WuGpv7u57IP/8aQBfrQ7CVA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728047961; a=rsa-sha256; cv=none; b=V3kUsRzc2M50YLIQ/Me0kjiCMPyiMy13+RMbOuHwqrRDIBhGxMZhhaqyWOUo18G8Bwem5x TG+itMqfh7vHyQleiyz5lNxn/Du3rKrsI7D3u+02KtEp/vY2wBZFmO6Mon5W3QybrAZ1kw yg6gPmchoUstPI86xMgqv2p516u4hKk= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm1 header.b=Flt8R6ar; dkim=pass header.d=messagingengine.com header.s=fm2 header.b="I lD66og"; spf=pass (imf06.hostedemail.com: domain of arnd@arndb.de designates 103.168.172.156 as permitted sender) smtp.mailfrom=arnd@arndb.de; dmarc=pass (policy=none) header.from=arndb.de Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailfhigh.phl.internal (Postfix) with ESMTP id 2B8091140140; Fri, 4 Oct 2024 09:21:30 -0400 (EDT) Received: from phl-imap-11 ([10.202.2.101]) by phl-compute-10.internal (MEProxy); Fri, 04 Oct 2024 09:21:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1728048090; x=1728134490; bh=9tkmmkT8aZFveB/04AxHCDNSFo41C5XPtA7E428DTNI=; b= Flt8R6ar41GP/CfssqrT+rga5rdhA8uT28QBZQ6KZa2VIogV/TJ3B+BktNcgjAlg r1rOI/bSkK/nOP/bXvGLMNDG6UG4qKSip/SfWedmZNFcQRr5a3kPDnunt7ucSFfF gflRikVjBdsS5gw20Kxv5V2Qrs+jlAPW8yUkaiaD84lSI4hXIhRj13pVLSQAJlQh NsTHESw4Yh1x+YxPfuQAEt3uAylmaHEBaxMPTeCqRySguhjHY8lFY/W05IyJGOAl 1wnjQfPU5I0kd28nRqWbAyWcbLZ431d4vZpMDUZIvhv+LI9BrIZgHaARgVh+UO16 To5IOUQWHDPVLQMrptozwQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1728048090; x= 1728134490; bh=9tkmmkT8aZFveB/04AxHCDNSFo41C5XPtA7E428DTNI=; b=I lD66ogTIB22KofW2jjY2mTLAwVKLSoYCruu76C6CMz1S9Qj/3gzXUL0tX1IZ3VLT ubKLuYGaS5H+jBh0efieq9UJvbJK2lSXjDrlCZtyrf1qRGqSzYfASlekhKQkClhK jdHzzS3kOjdxQSyWguErKY6aJOb8uNvFzlh8WHLyPuOhuXxxFJ3Pov/4E05MIvpF ceyG4pMPt1sWW75fHPjjKSRgTZAt5I/jdwhYGZDVKwVJz7XXMz/0c21ZYX5Xx7Ng yHtSyFe3u2037nEu6XnWqVFuDzwJHgBPx7eU8aGBh+ahBwW0EN3y/sv4Fm8+zq9I fAhaK3v35GfUmLv5Z1pew== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvddvfedgieefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepofggfffhvfevkfgjfhfutgfgsehtjeertdertddt necuhfhrohhmpedftehrnhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrd guvgeqnecuggftrfgrthhtvghrnhephfdthfdvtdefhedukeetgefggffhjeeggeetfefg gfevudegudevledvkefhvdeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomheprghrnhgusegrrhhnuggsrdguvgdpnhgspghrtghpthhtohepvddt pdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegsphesrghlihgvnhekrdguvgdprh gtphhtthhopehvihhntggvnhiiohdrfhhrrghstghinhhosegrrhhmrdgtohhmpdhrtghp thhtoheptghhrhhishhtohhphhgvrdhlvghrohihsegtshhgrhhouhhprdgvuhdprhgtph htthhopehmrghthhhivghurdguvghsnhhohigvrhhssegvfhhfihgtihhoshdrtghomhdp rhgtphhtthhopehmphgvsegvlhhlvghrmhgrnhdrihgurdgruhdprhgtphhtthhopehnph highhgihhnsehgmhgrihhlrdgtohhmpdhrtghpthhtoheprhhoshhtvgguthesghhoohgu mhhishdrohhrghdprhgtphhtthhopehluhhtoheskhgvrhhnvghlrdhorhhgpdhrtghpth htohepmhhhihhrrghmrghtsehkvghrnhgvlhdrohhrgh X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 155E42220071; Fri, 4 Oct 2024 09:21:28 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 Date: Fri, 04 Oct 2024 13:21:08 +0000 From: "Arnd Bergmann" To: "Vincenzo Frascino" , linux-kernel@vger.kernel.org, Linux-Arch , linux-mm@kvack.org Cc: "Andy Lutomirski" , "Thomas Gleixner" , "Jason A . Donenfeld" , "Christophe Leroy" , "Michael Ellerman" , "Nicholas Piggin" , "Naveen N Rao" , "Ingo Molnar" , "Borislav Petkov" , "Dave Hansen" , "H. Peter Anvin" , "Theodore Ts'o" , "Andrew Morton" , "Steven Rostedt" , "Masami Hiramatsu" , "Mathieu Desnoyers" Message-Id: <5b52dfcf-7b4c-4715-b1b2-6e41062302bd@app.fastmail.com> In-Reply-To: <20241003152910.3287259-2-vincenzo.frascino@arm.com> References: <20241003152910.3287259-1-vincenzo.frascino@arm.com> <20241003152910.3287259-2-vincenzo.frascino@arm.com> Subject: Re: [PATCH v3 1/2] drm: Fix fault format Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: CC044180018 X-Stat-Signature: ehk6bhyqdkohoa7x4tacefpz7ykpx553 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1728048090-154435 X-HE-Meta: U2FsdGVkX1/JgryK2VVUF4suhSoCpzTKYm6qi0kmRrR+rMyRfI6SzaAtTiUhnZaCxzifagfD5hvV6dN+9ssLlY1vpM+V322svXINKAidtsRVOeRWY7Z6jg7GGFlaLLjJQ39EiCvF2+6M18UFj0tM8+/jF8kclrYpc0/sH+wv0mMwFfGIso26J2Qr3befoL1pi/yMOJVqEBZNF6uEeg7YXnt5x17SDFvTMqOaMWuZ1hU0jMqiJeQWzoUt2oyRMwuV+2ZL8Ri8zi5ky+EWTBo991JEH/L+muF1fJn3AxcE81HzUbmRA6TmvJa0SWTEZ8d6adJuM2306hGDckvhYBN4PTOefqdgOFHEHt4mBf7TBdbygsSl4OLEMWsIZV9VlAnJ1zqBOXrRzL0LIQE1Eq7QzvJBBlz3jpvKny/aD6yCVDk0vfp+IP2UGSmGUmxQCk67UVjNIHyG/bQEGS6UW2h7ygkppi3Ba6+aP0aEDrWk4gZL1LVX5qyybkgVUJd4ZwVkXq7XVL35rhn8sjntl0rlQ23uGVgUz/5nzpg46ScjjuUPZg1KxBzfrXWhpxyZrmhHaMWi9q8SbBoWv19exuO3bn7iQBznsjOif2xjnPOG9lwiR3nRfRy8P98l015gRqiwtUgjL72nJtdvmbsHGuTmUXFD2EvlAL5OJpjoIcnraD0N4VG1UG7tB4tEeTW+eAxJFh/jQvZy6WWTY9AaGjEBogsvpWKc80k8uQTujkkwjgjEGWTz4L7KvtOjPwZoOPWW6ZWlMXVYL5wJDd7nDBt0ANAEojOiOvksX8boytFmxx/b7/kpqSI8VhvaSDg8DDGWTSYD+NbrzEaKLlyEWsmxDcGuzxhGS1mzHAl868l/H87NtJICfdDFsSff/2nvxTqRb7KVznTXzr4ULjpZnwVXaviJEi3+R6sV/odw5jkPFWRex1JasFzZKSsPdTTY+sNC5sKmIyEycnY8PJazN1o X1qGeWkK jHMsQtyr4yQWXDKDy0IZIF0qSjGJUB265b1by2kXr/IF6fPCRwLyUezS4qZIVwVEqa6tiEphPck8eg/bjYLoOYF00dg07kw29fiL0IdRLy79trqVyNwsMCbCGfP923/dgwNz9P1UD9KSwtajNDthnRIAA0QmAqNpavUbE2Mz+SxJfQvxr1vGqtYo21A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 3, 2024, at 15:29, Vincenzo Frascino wrote: > diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c > b/drivers/gpu/drm/i915/gt/intel_gt.c > index a6c69a706fd7..352ef5e1c615 100644 > --- a/drivers/gpu/drm/i915/gt/intel_gt.c > +++ b/drivers/gpu/drm/i915/gt/intel_gt.c > @@ -308,7 +308,7 @@ static void gen6_check_faults(struct intel_gt *gt) > fault = GEN6_RING_FAULT_REG_READ(engine); > if (fault & RING_FAULT_VALID) { > gt_dbg(gt, "Unexpected fault\n" > - "\tAddr: 0x%08lx\n" > + "\tAddr: 0x%08x\n" > "\tAddress space: %s\n" > "\tSource ID: %d\n" > "\tType: %d\n", Isn't the type of PAGE_MASK still architecture dependent? I think you need a cast to either 'int' or 'long' here to make the corresponding format string work across all architectures. With the current version of your patch 2/2, it looks like it has to be %x for architectures with 64-bit phys_addr_t, but %lx for the other ones. Changing the 'u32 fault' variable to 'unsigned long' would also work here. Arnd