linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Ryan Roberts <ryan.roberts@arm.com>
Cc: "David Hildenbrand" <david@redhat.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Shuah Khan" <shuah@kernel.org>,
	"Jérôme Glisse" <jglisse@redhat.com>,
	"John Hubbard" <jhubbard@nvidia.com>,
	"Florent Revest" <revest@chromium.org>,
	"Liam R. Howlett" <Liam.Howlett@oracle.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v1 9/9] selftests/mm: Run all tests from run_vmtests.sh
Date: Thu, 13 Jul 2023 16:43:29 +0100	[thread overview]
Message-ID: <5b4fcf62-98c3-458e-a0e7-8e86ec354cb9@sirena.org.uk> (raw)
In-Reply-To: <8d2e75e7-0d38-6e6c-a02a-b66a18515dfb@arm.com>

[-- Attachment #1: Type: text/plain, Size: 1315 bytes --]

On Thu, Jul 13, 2023 at 04:36:18PM +0100, Ryan Roberts wrote:
> On 13/07/2023 16:30, Mark Brown wrote:

> > The results parsers I'm aware of like the LAVA one will DTRT with nested
> > kselftests since that's required to pull see individual test cases run
> > by a single binary so it's the common case to see at least one level of
> > nesting.

> That's good to hear. But bear in mind that run_vmtests.sh does not use TAP. So
> you end up with a single top-level test who's result is reported with
> run_kselftest.sh's TAP output. Then you have a second level (run_vmtests.sh)
> using custom reporting, then _some_ of the tests invoked use TAP so you
> sometimes have TAP at level 3. But those tests at level 2 that don't do their
> own TAP output probably won't be parsed by LAVA?

I think that should mostly mean that all the tests that don't
individually produce KTAP output get ignored by parsers and those which
do produce KTAP output will be seen as nesting one level up from where
they are (ie, the individual cases will run directly from vmtest),
though there's likely to be confusion about expected run numbers for
things that actually pay attention to that.

> Since you agreed to put this into the CI, I was going to call this part "your
> problem" ;-)

It'll run, the results are a different story. :P

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2023-07-13 15:43 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-13 13:54 [PATCH v1 0/9] selftests/mm fixes for arm64 Ryan Roberts
2023-07-13 13:54 ` [PATCH v1 1/9] selftests: Line buffer test program's stdout Ryan Roberts
2023-07-13 14:16   ` Mark Brown
2023-07-13 14:32     ` Ryan Roberts
2023-07-13 14:45       ` Mark Brown
2023-07-17  8:36     ` Ryan Roberts
2023-07-13 13:54 ` [PATCH v1 2/9] selftests/mm: Give scripts execute permission Ryan Roberts
2023-07-13 14:39   ` David Hildenbrand
2023-07-13 17:32     ` SeongJae Park
2023-07-14  9:44       ` Ryan Roberts
2023-07-14 16:00         ` SeongJae Park
2023-07-14 16:11           ` Mark Brown
2023-07-14 16:26         ` Andrew Morton
2023-07-14 16:28           ` Ryan Roberts
2023-07-13 13:54 ` [PATCH v1 3/9] selftests/mm: Skip soft-dirty tests on arm64 Ryan Roberts
2023-07-13 13:56   ` David Hildenbrand
2023-07-13 14:03     ` Ryan Roberts
2023-07-13 14:09       ` David Hildenbrand
2023-07-13 14:12         ` David Hildenbrand
2023-07-13 14:16           ` Ryan Roberts
2023-07-13 14:14         ` Ryan Roberts
2023-07-13 14:29           ` David Hildenbrand
2023-07-15  0:04   ` John Hubbard
2023-07-17  8:23     ` Ryan Roberts
2023-07-13 13:54 ` [PATCH v1 4/9] selftests/mm: Enable mrelease_test for arm64 Ryan Roberts
2023-07-13 14:32   ` David Hildenbrand
2023-07-13 13:54 ` [PATCH v1 5/9] selftests/mm: Fix thuge-gen test bugs Ryan Roberts
2023-07-13 13:54 ` [PATCH v1 6/9] selftests/mm: va_high_addr_switch should skip unsupported arm64 configs Ryan Roberts
2023-07-13 14:41   ` David Hildenbrand
2023-07-13 13:54 ` [PATCH v1 7/9] selftests/mm: Make migration test robust to failure Ryan Roberts
2023-07-13 13:54 ` [PATCH v1 8/9] selftests/mm: Optionally pass duration to transhuge-stress Ryan Roberts
2023-07-13 13:54 ` [PATCH v1 9/9] selftests/mm: Run all tests from run_vmtests.sh Ryan Roberts
2023-07-13 14:50   ` David Hildenbrand
2023-07-13 15:04     ` Ryan Roberts
2023-07-13 15:25       ` David Hildenbrand
2023-07-13 15:30         ` Ryan Roberts
2023-07-13 15:30       ` Mark Brown
2023-07-13 15:36         ` Ryan Roberts
2023-07-13 15:43           ` Mark Brown [this message]
2023-07-13 15:46             ` Ryan Roberts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5b4fcf62-98c3-458e-a0e7-8e86ec354cb9@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=jglisse@redhat.com \
    --cc=jhubbard@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=revest@chromium.org \
    --cc=ryan.roberts@arm.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox