From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1AD3D2E01E for ; Wed, 23 Oct 2024 07:45:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 238396B007B; Wed, 23 Oct 2024 03:45:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1EA6A6B0082; Wed, 23 Oct 2024 03:45:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 061B16B0083; Wed, 23 Oct 2024 03:45:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DB91C6B007B for ; Wed, 23 Oct 2024 03:45:25 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 82E318059F for ; Wed, 23 Oct 2024 07:45:10 +0000 (UTC) X-FDA: 82704081516.11.5B8BFB4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 98780C001D for ; Wed, 23 Oct 2024 07:45:15 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QLHbDYhE; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729669370; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PRhyft7OV+xImgYU9toOVKehXn7IFWtNH0kZLXCKbw0=; b=LCYU+vR3F13zNy1hqF8+/p+tayjUG4xvRKaSxDyxKuqS/PlbnA2RDFdSWGh8rYQIVgiFFJ 0KkHHAW4jop+R0ik02v05rGz9UoiNwCGZzvilZptH/6i/fZ945ZeVHx97QGQJWzAcMutO0 Bc57Jyben7dBxDtSU4fRSPOsbnm67Yg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729669370; a=rsa-sha256; cv=none; b=xtOW0BlTTquO94OdS8/p9LTFVJjgtN3oTJOBHX2V9NVSYEwQUJI3kwOKM7R7iMonnc2+VR cTg2kOZ9ucoFSYzxufv5oGTrpPA8yfZc/6ykqwoWHljWAdfdjsxzW4H1Y16fn5BtGScoDn lkgOPJNCiej+DCRXESsl4ioGVrVRhY0= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QLHbDYhE; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729669522; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=PRhyft7OV+xImgYU9toOVKehXn7IFWtNH0kZLXCKbw0=; b=QLHbDYhEWvqOUFGeXgrmK3V5NM2bH7GmJ/3Vj1s8krRsDhjUlXnHR3s+KF8S9cIRFjKRnn Bk6yXgirl8Nx0FggUtgFs0FGyS2cQDCelorDgBP9cuHksjjuruIalRVJELYfZYducKd4Nn pMuoE7UdeLNGhZ3MR/sXYQnif1rdH5s= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-602-2am9vDD9MH-paOtucofsNw-1; Wed, 23 Oct 2024 03:45:21 -0400 X-MC-Unique: 2am9vDD9MH-paOtucofsNw-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4317391101aso21935125e9.2 for ; Wed, 23 Oct 2024 00:45:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729669520; x=1730274320; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=PRhyft7OV+xImgYU9toOVKehXn7IFWtNH0kZLXCKbw0=; b=IA4JGfsHuZ5oROSxWh1EQ+1RK18L74qCDGxQa1kuMILWMdlGUCCFfaPnO4gO3T1zaV l7B+mjLmp6WLccc1sKhthigptDxMch5s6I1is6pP8FBc8LY+8xhZVG8qjOj4UhCx1ecS 20Vn9QlY+cakmwBT9yodZV8U2n93o9FDfomtidKC/x129rIY3dBNm5qXj2mZgEECQxDo Q3uxy/4/+6CxMSzul345pAYGe/cVXi7XDBqs4Y2HLF10mC/fN0fwc61ENmZZUDgO74Jc 5AoADINUWRS06A1QOOLATqPN484+uL2nTip9c8QjHfzR5pzbMK3kpG3TnRMOpmwSKkkJ 8FoA== X-Forwarded-Encrypted: i=1; AJvYcCW+ZMmuELtZocPEGHI+QxXFFmAYO0HcIGtFekqTdO80T5cmQEGCh00/u6MhfCwsUZ7RX6Z4SNqVvw==@kvack.org X-Gm-Message-State: AOJu0YwolMi+pBG57IkIN7gWJd0ixw28Qi3arLt+sA+iOpCm8Fen6Bdn Oxn2QoY9sN6EF1MN0HXI0EPhHCH7c+XC1FhR2nud7EZCEu7iNaSpaN1sd+2B2/mZB7/I4S3h51K 0ibw2i4GFwLvoqNTQd+hbJORHUy2qvz5oI+60ByvLDEsxwvL9 X-Received: by 2002:a05:600c:1d22:b0:431:52a3:d9ea with SMTP id 5b1f17b1804b1-4318414298cmr14409075e9.0.1729669519893; Wed, 23 Oct 2024 00:45:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEKkBSnYGhbyqJBhbjw3xX7pJtL4HaYA3IrXCrgntZVKqGfpTYqI6qi5iFyJA8xNnEEoRcBYA== X-Received: by 2002:a05:600c:1d22:b0:431:52a3:d9ea with SMTP id 5b1f17b1804b1-4318414298cmr14408735e9.0.1729669519485; Wed, 23 Oct 2024 00:45:19 -0700 (PDT) Received: from ?IPV6:2003:cb:c70c:cd00:c139:924e:3595:3b5? (p200300cbc70ccd00c139924e359503b5.dip0.t-ipconnect.de. [2003:cb:c70c:cd00:c139:924e:3595:3b5]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43186c1e961sm8476525e9.44.2024.10.23.00.45.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Oct 2024 00:45:18 -0700 (PDT) Message-ID: <5b2b6528-ee48-4daf-9311-41323018064b@redhat.com> Date: Wed, 23 Oct 2024 09:45:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/7] s390/kdump: implement is_kdump_kernel() To: Heiko Carstens Cc: Alexander Egorenkov , agordeev@linux.ibm.com, akpm@linux-foundation.org, borntraeger@linux.ibm.com, cohuck@redhat.com, corbet@lwn.net, eperezma@redhat.com, frankja@linux.ibm.com, gor@linux.ibm.com, imbrenda@linux.ibm.com, jasowang@redhat.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, mcasquer@redhat.com, mst@redhat.com, svens@linux.ibm.com, thuth@redhat.com, virtualization@lists.linux.dev, xuanzhuo@linux.alibaba.com, zaslonko@linux.ibm.com References: <87ed4g5fwk.fsf@li-0ccc18cc-2c67-11b2-a85c-a193851e4c5d.ibm.com> <76f4ed45-5a40-4ac4-af24-a40effe7725c@redhat.com> <87sespfwtt.fsf@li-0ccc18cc-2c67-11b2-a85c-a193851e4c5d.ibm.com> <64db4a88-4f2d-4d1d-8f7c-37c797d15529@redhat.com> <20241023074237.8013-B-hca@linux.ibm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241023074237.8013-B-hca@linux.ibm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: by6p1um5jifdrok4ohez7wzgz8n9oasc X-Rspamd-Queue-Id: 98780C001D X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1729669515-670728 X-HE-Meta: U2FsdGVkX1+jFyqMZ3ZCjvR2QXjbktURvL6sxFjQNr29KZnGYw72EQbZJiykQ1GILLXajCXFnfuQD0AXIS/XDTM/Fp+pYY21pJwFk4yQ1kCM8YOUhkrKQjUtspBctGPNgHO2J7aIOHwi68xMntPNbsT84I7deI/NPG/RKDaNuD5M/ucHlBKk6cfNhATtEnQagrIgX5l4BMa4tJocRVmg7Try2WWlJsUzZuyNyGyjN+OtpJQJkb3j8D+Rrs6mWZrJo5PCRd8jVRSN+/VeSPTwnC+G8exNz7Qn9YDCtxRJ1JDTLkpKhnwPD5dcMtN4h/p+cOWwxXa7q4EYFO89w+e+vXUJAm2mf6P221GLM0yKRTV4ZFE4M0PG0Gfb50rL35zm2oK1l2ogr21scVjsg63+nxaX1prR9s9o/o8J3VlAMvdQzmh/psEP7VwNlp+cIgI8diRLErQPEPAP+OXYsgRJTrupGqKL8hfmSTcr3SZzujtbC12vm0rXHapSbjQVyhYg0V2x4lCXyLhZFt2EF1vuKIanwIa3913W1Evsso78DAXigKQ9njjrN1SK5x9dG0QEHqr3ZnnM9+7HCFomhb75eGGj8345pb85b9cz3Zac41NT+1yGSRxsrUXuz6zZry/9DcFSyEhO2KtjazSJaNKEY8+2YjhuXo0zAlOHYgyXMHdkkhd3dxt4EtIfPd8lyhP/pOKWgHWWIbfXA4ABOk6kb1n70cmFhhRNLapU7nS0X5i7OAfHvXB0+ruUiW0YRpkQC/cby8z7kOAd26HvMq3Nk21htNgvN8LcNFS2P0svHFrkYYEd5wRIFPFX05QeKI+ZNlQzEXeGsMah3gRtBG1IItZIEkmJg9a5eAH6Z3UKY+Gy/ft0xcCLV1yRaZnGxUeAbIwwY82+Rx/gjaEoOXQcpFiNHzIlsLfDjKEbRKArWC26s/WH6EckoqAXqlOU70oOoWiRlJ+/b/ng66DAZU2 vXmz59N7 3g0bXfyALPHb/lwM0hdjEsIHgweqMmqQsFWpns2cYgjzfKhP6Tnf0TW2ASmGOCQj4Wz8fKGQeeT7a2Cs/MQA2toVKXBV1AH9LIfcBfZW95iYzvpfYJHHMmFNwngt6T0bLyLNn63DI4igA3IeD/j/3vcFxPCvS10pwhIzuEGaS/XXgCEyb/VRoY0a/lj7tr6VShn8j4ffmWUUoiaCP2D7isLyUaYQZv/7Y+/AZj/Yalz90nAHcAutB19sPCj3pz9vTeG5f0I9cnHUVETnL9t/nBX5xBtq2NVqHog254G8Va4SjJ2hBloZenPF6Swef3TWVCC5C0cp+Xk9fr4tZKF0dkKZhtrPcjWL/snN6yt23lXpuuy11+fMiuQMl2vgJ0go3x6yJhk77gEWRBqD0UUw8Hm1d3XDJwhIi9xkua1NEKf8LLEEY9gHHjemj3sKajLRo6phJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.025656, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 23.10.24 09:42, Heiko Carstens wrote: > On Mon, Oct 21, 2024 at 04:45:59PM +0200, David Hildenbrand wrote: >> For my purpose (virtio-mem), it's sufficient to only support "kexec >> triggered kdump" either way, so I don't care. >> >> So for me it's good enough to have >> >> bool is_kdump_kernel(void) >> { >> return oldmem_data.start; >> } >> >> And trying to document the situation in a comment like powerpc does :) > > Then let's go forward with this, since as Alexander wrote, this is returning > what is actually happening. If this is not sufficient or something breaks we > can still address this. > Yes, I'll send this change separately from the other virtio-mem stuff out today. -- Cheers, David / dhildenb