From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 692E1C54FC6 for ; Mon, 2 Sep 2024 01:28:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E7FB8D005E; Sun, 1 Sep 2024 21:27:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9707A8D0052; Sun, 1 Sep 2024 21:27:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 85F268D005E; Sun, 1 Sep 2024 21:27:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 68C638D0052 for ; Sun, 1 Sep 2024 21:27:59 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0AF5E1217F3 for ; Mon, 2 Sep 2024 01:27:59 +0000 (UTC) X-FDA: 82518061878.11.E60DFB4 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf26.hostedemail.com (Postfix) with ESMTP id E4F62140007 for ; Mon, 2 Sep 2024 01:27:55 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=none; spf=pass (imf26.hostedemail.com: domain of lihongbo22@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=lihongbo22@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725240454; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SfoEwC6IJM+EF0AcDOPbcU8ba//TPYu4wPtaeXZ3Sw0=; b=HHkHlWeAAZfiz4YNzu7xZHypMKe5C0c0r/0kdJPeU2OxPso9PjZ9GVwsHQl+W9PCkYiU8R u9EOiAUjxPlbI4+QA6ywVs0PSO28h4zo9EQRoo8c8VaKFcB9nn8tFOA9/hkqvKpZc9ecK/ wYTPJM0xBmZ4nLgsip1d5anx87mexKk= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; spf=pass (imf26.hostedemail.com: domain of lihongbo22@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=lihongbo22@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725240454; a=rsa-sha256; cv=none; b=a0TipvvTKZjtrgwxG1mnMgtL7CeyCX4ON7cMa+ieBswYT92QPymsPeLswlc9CKtj1+n1Bh fveElpH+xSApCM0Fwym5PqmBLF5JgPah/IQE+r130qPWqeyIV4x1CZIPREBne9fzD1yBIy +O68Q8HmYwOgq1qILkHX3gPKrW2c/lE= Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4WxrhK5Dbdz1BFLk; Mon, 2 Sep 2024 09:26:57 +0800 (CST) Received: from dggpeml500022.china.huawei.com (unknown [7.185.36.66]) by mail.maildlp.com (Postfix) with ESMTPS id F04031800A7; Mon, 2 Sep 2024 09:27:51 +0800 (CST) Received: from [10.67.111.104] (10.67.111.104) by dggpeml500022.china.huawei.com (7.185.36.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 2 Sep 2024 09:27:51 +0800 Message-ID: <5b1b6fbc-6135-47ae-af32-60ef71595666@huawei.com> Date: Mon, 2 Sep 2024 09:27:51 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH -next 2/4] tun: Make use of str_disabled_enabled helper Content-Language: en-US To: Jakub Kicinski CC: , , , , , , , , , , References: <20240831095840.4173362-1-lihongbo22@huawei.com> <20240831095840.4173362-3-lihongbo22@huawei.com> <20240831130741.768da6da@kernel.org> From: Hongbo Li In-Reply-To: <20240831130741.768da6da@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.111.104] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpeml500022.china.huawei.com (7.185.36.66) X-Rspam-User: X-Stat-Signature: g45ij9dqb7k68az9f4ziu1sndxwgrdph X-Rspamd-Queue-Id: E4F62140007 X-Rspamd-Server: rspam11 X-HE-Tag: 1725240475-245294 X-HE-Meta: U2FsdGVkX1+dNRAWJI39vMqwacDbV1z9Hxd/kuahd738j6K7FBE9MzExGMHtHAQ1yWFsxuIeYNTKN9Uo80WWminz9YiMIpqSyhYQhNaBg2xvCdfkvV014GyLk9svM09mptlk37XpYGqFYKKj11U/lsa3G0aQ5dYVMSYSDlC9U7R/yypjyxSYlCuTkkpdn2g9u+B1abLN5hNtgejqCp7tTO1NwXtBTEuz6eQXd8qH+3MRfDo4TLWamNmHwTq4kDuMVz9KSrVxLaIN+yTrT/lb2MzDeJ1mgE2tAvklsn4yQ5Duw++FAxVUTDnrOxAo9e/m0Nn9P1mQHcsrkPuzt09lHXGlqUt8Vz4lODfxBFZnHVEt7/PuQK+cYZlJL/lX7+VNBMbveq5O6CNd23qYxCLc4omU18gzQmN9IjZUIqiG+CSg5FHUnMhFZi040CnMTTKO8DZfFm9El2dJ6yJUXEDZzwKV16tqYIDGjcnuoB9wzgvVxXS3Etx2C73frQk1cQb7bEIawqZuyzQ/qa9sDa+qpC4vsZEwapZ6obV7++LQSTu0i3656wvgCUD4zi4xsWEaVHCkF7mfbSHH/T7buSM86iTJGXjSuXwU13c/iRNX8KWgJ7pU938TBwZOllR/jECx2oIuYYWQo5ZZCslABTviumdOYyatkE20TQCXdm0diIbR6gHIqMGUMP8P/RD1BILlXHAcYvVTUC2EqPzlrTG5xOn6tqLzlSbHQa+c4t0IDs7tqdKhOxSuV6lDX5Ez/8CTlC/C5zhd7YC5PJAeXT6sdRWrpLWo7j/zDSjtgaxWyS5CQ8/L8Fg2QrkcKF5tO0wJfLhHvsg9IEgaZJ9gxI65KbFyxYKLbcGNa0phR3gbNQGmYvQHG4No+MwMyzEMjVraWRWllOW29o1s62Gcd8n+CUQveSKEoDeQF8fdPLqjPf6Z9x8qsSg9obMOSuC0ULJ2Cou/pwZiCvalh5rEfRC zGmKHSDU r1b6EwMlO2ihxuP4uglvEpw3dJSpuT/feySQBiku0Y2qC0kXud+RMPApk6v/py7FvUMUWCKTrlZ3QfHx6uQTqfgveWP/kZTwjBxdO88HdKvQ1D7FfnBm1BmCgP6OdAkffc+KjFmd+tc4ZzXDVpOOUyfCMABMJ/8ZXDBVO8gYC9G1SfANeCj9pgCwE4qK+aTO+Lpr7xnc2h0ZRaNGe8nUZ0O9w3qqUL5LfMPztPCCa8lQp9ZRThihk+kVrDUgpXhD7/6MOPnOKlQZq+oOIxrkUUQLgC6Nv2ZC1jYg9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/9/1 4:07, Jakub Kicinski wrote: > On Sat, 31 Aug 2024 17:58:38 +0800 Hongbo Li wrote: >> Use str_disabled_enabled() helper instead of open >> coding the same. > >> diff --git a/drivers/net/tun.c b/drivers/net/tun.c >> index 6fe5e8f7017c..29647704bda8 100644 >> --- a/drivers/net/tun.c >> +++ b/drivers/net/tun.c >> @@ -3178,7 +3178,7 @@ static long __tun_chr_ioctl(struct file *file, unsigned int cmd, >> >> /* [unimplemented] */ >> netif_info(tun, drv, tun->dev, "ignored: set checksum %s\n", >> - arg ? "disabled" : "enabled"); >> + str_disabled_enabled(arg)); > > You don't explain the 'why'. How is this an improvement? > nack on this and 2 similar networking changes you sent > This just give an example of using lib/string_choices' helper which prevents the function from being removed due to detection of non-use. These helpers are convenient. It's functionally equivalent, this avoids the dispersion of such writing styles( ? XXX : noXXX) everywhere. Thanks, Hongbo