From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 763B4D24461 for ; Thu, 10 Oct 2024 23:55:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB2A56B007B; Thu, 10 Oct 2024 19:55:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B62B46B0082; Thu, 10 Oct 2024 19:55:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A29F16B0083; Thu, 10 Oct 2024 19:55:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 86B726B007B for ; Thu, 10 Oct 2024 19:55:06 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CC3931C6853 for ; Thu, 10 Oct 2024 23:55:01 +0000 (UTC) X-FDA: 82659350970.06.0DEA586 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf14.hostedemail.com (Postfix) with ESMTP id 30598100008 for ; Thu, 10 Oct 2024 23:55:01 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=k5y2A0KT; spf=none (imf14.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=rdunlap@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728604321; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=snqs3EHvQQFe5TlwVU9Fqyfnun53AdSjkQFSmOW8rqg=; b=p1JSCFlf0twrx0lTMKany6GO0rgssNnMTFCUx61Nvcqc+Ksmr8ZCS5NGJP/08vfaHLWKag TKwjuRKqxvySu1FFUtHqgxm9YvHZDI9Nv2Zc5V/etx9CyXDpxyDeSuWEX1zB1MwUjquTex njE9F7kqt9ZNSk+bJzlf187dUhO9e74= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=k5y2A0KT; spf=none (imf14.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=rdunlap@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728604321; a=rsa-sha256; cv=none; b=ay0/PrO5rv1qOvrfeSPB3M8LccTC5PD8BxyOJzBAmhDY228EmEQyepx6KpB7NoNj9E3lKD eJ4JQXgG3VWRnK671h7Xhva0ojsXb7IxqY2K1krihWLvPWS0rVJ5aNzvSadH79YsiSTjJF WixRvvn2Ewlq5rAK/MJnrPBSIHkzq8g= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:References:Cc:To:From:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=snqs3EHvQQFe5TlwVU9Fqyfnun53AdSjkQFSmOW8rqg=; b=k5y2A0KTzzhh1N8FNtU6Rdqy7o Zi5Aw1wAZJ+Dw8nItthR3rpyIm+YsPBYhuFaZfsancwNjOqDFLMybm7ClX1L5YMEc37/0pyu00uLa Nr/d3Q+gZ2q9aeELopN6NbOgzpZZMNGJDqMaEJTUGAaokGoZfVzevvIHohmXXX4c1g9aoEVshRd1a mKtRz4vbCwnMKXnkS78s+UKdb9/qxKoFN+fiq2nlmCG0C09JuFWjFMRCUsbVaRE5b/CEdhoUUr6cj RqQ09iemAlqK0IB4hjEM++BfEzt3LF4trW75rxzE42i8o37ozPxXjNpZpi0MleQEfay+JwIcXV5X3 FY7x6UQA==; Received: from [50.53.2.24] (helo=[192.168.254.17]) by desiato.infradead.org with esmtpsa (Exim 4.98 #2 (Red Hat Linux)) id 1sz2za-00000005k0I-2q5f; Thu, 10 Oct 2024 23:54:51 +0000 Message-ID: <5b16b00f-749c-431b-baeb-7accb76b492b@infradead.org> Date: Thu, 10 Oct 2024 16:54:46 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [partial fix] Re: [PATCH] mm, slab: add kerneldocs for common SLAB_ flags From: Randy Dunlap To: Jonathan Corbet , Vlastimil Babka , David Rientjes , Christoph Lameter , Horia Geanta Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>, Roman Gushchin , Andrew Morton , linux-mm@kvack.org, linux-doc@vger.kernel.org References: <20241009142936.56092-2-vbabka@suse.cz> <878quxe2kw.fsf@trenco.lwn.net> <878quxb4rm.fsf@trenco.lwn.net> <8b0c1bb9-4a9a-4f8e-87df-275994df739d@infradead.org> <1406d498-84bf-49aa-9efd-6480ad618582@infradead.org> <46c52676-c402-4b39-b634-a401f7a7a571@infradead.org> Content-Language: en-US In-Reply-To: <46c52676-c402-4b39-b634-a401f7a7a571@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 30598100008 X-Stat-Signature: w9opgifx5nefmmciz5qjfrz9tfj6kymn X-Rspam-User: X-HE-Tag: 1728604501-679701 X-HE-Meta: U2FsdGVkX1/QKyVi0YaCpOuz4duwsjPex7pTMu7jHBHJ9GC+X+1JwgplFODbHOK+GqfeZUpQu7hj1hx74xXXHDkA2qUFfMZgym7v47CubSiPrC2H4fVh5ElRw5Wl1wH/L1w0iDoJQ0s5UX+Ai2fR5QxUO6QqiGaLk+rxGVcSIyOLDo3tdAnkOlxLxyUViV3Fz9mGVbe0YE5jPao61JjsJVizT8mGvV/1ToM4QZvZhXPH7PlsipRnkSzDD0a4OrDvXxvBK6doCqQAAa6x7X0oZDBpKkfs8eJNjv52EKzgnlusVhmwlGLFxJBtN8J5uG+OzgeyNOcwlmzqXBgaY54c0s/X3kwjlGkVqFhMt1jjvsT2CNP9YUzSvhYLnXvEbGUC/DOWFuTL6b04IiUC9UuNazxPIWkeQRHK+3508q4OgSA3vAHCOO0i9ToWJMQd8RZDringnzxx3nxqXGKvHCl0hjyN/OEEW+g3rwc3xMm+IEcBL9kVpk6UGJr1cQEnL756IZFeg2qGdPwtmR5J9J+J4t/y44hlcK4X2j2jq3AEIad+7vZccmtqGwZloxMJd4C9CJA81gkqwHHk2JMxEyEx7aX/8lyT1vs4xeFWOPv4kjS+LikBbRlPrEdE7RfWW74hOYxaZjWma5/5TGMoAm9kOuTV69ShXy67sI2LSGX0t5itfnm4UD0dET5jOwpzY481STl19e3XL04e2isYa830RkMKdhs/xF7k6IP7HfFv66+PzyvsYmHGkPbsmZ9PWgW5vBg9gAPXVJYX53CbDZDUEhh9ziuyqz6dFAsFXzsn0BAeUnb3iTqOtRaSkfct3CSur1EdDL0PBTI/XIk4aTYkj902RlRPyOB0lJPrc+i/3KAi3rD0Z8rgYUTmeYu0m/Vlca/Zw6pEVtSJ0xLsw6uybH4h9nTImMFGsoeRU3cJK0uHfhqcUDdFv7MaaPJxcFEPgQP/ZZ0P502qDaJ0SNN e9iLZl/a b2XMbO4JI5SWYdk+IQUFUl1B5rhIskS05tEj951642sya1UmgIkICZdXRvkcmLpA5GMfvTlrenOUUFGRlnFHkjscslrQJsBRDuF4ChREqXrvO5E0vig25bpYDVSxFSbPjIOZRNy6/HSO1YgiU2b4q0IwO7fgeseL5mfMx/u44lLg/T9MUzZcDmmgzhDCASgUR0xBVs30RqaVnGVd3CI1PGmmWNyWFoZNs7HHKPe7sfSBnBp1c1Nm2zA0rDPmIEHGVL1z8zqAKOXRx5A+n9HqH/8HmUygTPEdAOcjsKw1n0NA9BYIgFf36e48KXAaB13nevIsFU7DLx64kYif63o1el1Qw1SXkS2L259ng6L7OjG440gK5q2EkTFGoRlIVGliKIVOf00cOfdFUad3NgZS9s8FpRCnH+Ax8yIReZ04GBC7e0EbGth78W5hTt2XZ5/mkqCRYH1vQiDCrJCKPoOlOCI75XjZSNNrU3ynac8KBugDaRJqXl1lX+l5xQqyXKvyafgaXaofXEwdbLXPOKbx4ey6+dF2udZBA74HenvfBAZeNyTA3uSGYG1exulIcUA4b4cIpNvJ8Qj59WFATz2KYO7i4WA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/10/24 4:43 PM, Randy Dunlap wrote: > > > On 10/9/24 10:06 PM, Randy Dunlap wrote: >> >> >> On 10/9/24 3:02 PM, Randy Dunlap wrote: >>> >>> >>> On 10/9/24 9:49 AM, Jonathan Corbet wrote: >>>> Vlastimil Babka writes: >>>> >>>>> Thanks for the hints. I hope if we can agree that documenting the macros was >>>>> intended to be supported, doesn't break the build (there are users already) >>>>> and has only those minor rendering issues, it can be used? >>>> >>>> I'd totally forgotten that this was supposed to work. >>>> >>>> Yes it can be used... $WE just need to find a way to make it work >>>> properly. >>> >>> The code probably isn't expecting a macro on the right side. I'll take a look, >>> but no promises. >>> >> That would have been too simple. >> I haven't found the problem yet. Ran out of time. Will continue on it tommorrow/Thursday. > > The main problem is that output_function_rst() does not support object-like macros while > output_function_man() does. There is still a bunch of sphinx_version handling that I know > nothing about, so the present output (after my trivial patch) leaves more to be done. > > Well, the *main* problem is that the output is not consistent. Sometimes my tests don't fail > as they did at first. > > > This patch drops the trailing "()" for object-like macros in output_function_rst() > but there is still more to be done. > > --------------------- > From: Randy Dunlap > Subject: [PATCH] kernel-doc: allow object-like macros in ReST output > > output_function_rst() does not handle object-like macros. It presents > a trailing "()" while output_function_man() handles these macros > correctly. > > Fixes: cbb4d3e6510b ("scripts/kernel-doc: handle object-like macros") > Signed-off-by: Randy Dunlap > Cc: Horia Geanta > Cc: Jonathan Corbet > Cc: linux-doc@vger.kernel.org > Cc: Vlastimil Babka > --- > scripts/kernel-doc | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > --- linux-next-20241009.orig/scripts/kernel-doc > +++ linux-next-20241009/scripts/kernel-doc > @@ -822,10 +822,12 @@ sub output_function_rst(%) { > my $oldprefix = $lineprefix; > > my $signature = ""; > + my $noret = $signature eq ""; ^^^ That line is in the wrong location. Still working on it.... > + > if ($args{'functiontype'} ne "") { > $signature = $args{'functiontype'} . " " . $args{'function'} . " ("; > } else { > - $signature = $args{'function'} . " ("; > + $signature = $args{'function'} . " "; > } > > my $count = 0; > @@ -844,7 +846,9 @@ sub output_function_rst(%) { > } > } > > - $signature .= ")"; > + if (!$noret) { > + $signature .= ")"; > + } > > if ($sphinx_major < 3) { > if ($args{'typedef'}) { > > -- ~Randy