From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36BE9C54FB3 for ; Mon, 26 May 2025 09:33:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D02286B008C; Mon, 26 May 2025 05:33:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CB2D86B0092; Mon, 26 May 2025 05:33:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B7A246B0093; Mon, 26 May 2025 05:33:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 96ED36B008C for ; Mon, 26 May 2025 05:33:27 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 434F41A0837 for ; Mon, 26 May 2025 09:33:27 +0000 (UTC) X-FDA: 83484546054.02.A2DD3E0 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf12.hostedemail.com (Postfix) with ESMTP id 176334000A for ; Mon, 26 May 2025 09:33:24 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=VvPIebfd; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=SkXKhKJ5; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=VvPIebfd; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=SkXKhKJ5; spf=pass (imf12.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748252005; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JbubNeHtWJVe2F33QaV8s7k8BApXPhrbC0o3OqVKHQQ=; b=MCa2em/FY7SZBIZXFc34p+ikdl86ZY00AqiaNcxNpVH+HObtwAGzruNhWEH1yp+Ete9Bcq DzWwmKXDKfbkkqR1rxeRQwShZLQ7gekm63LIIw1ke0HSYMLT8CwtNmOoPGTHUP3Llo2Vuj ag60GkeeIoO1g43VnLZHRI9T5YE1GfM= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=VvPIebfd; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=SkXKhKJ5; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=VvPIebfd; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=SkXKhKJ5; spf=pass (imf12.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748252005; a=rsa-sha256; cv=none; b=vRpMfAGifFh/pkbp8V1nWXTgqzECsOWvUCfbpG/EXVAfuFhVJDoq/5Nt1UdAdEa1kwMVCk GmQaFqNO+mRgIfGFaHG16V5MgQ/e9snXKluGZWn4S+0RUUXnnvxMyDym6eBqE9ZKMxx09C ijfymkft8Dz5SVcl6rTUkXjCENX1GH4= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 672C3219D1; Mon, 26 May 2025 09:33:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1748252003; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JbubNeHtWJVe2F33QaV8s7k8BApXPhrbC0o3OqVKHQQ=; b=VvPIebfdab+tSGi1+aHrEqTVdzcDQaR3F70456T4bQ0CvVfqVxc2N653r5GQFh7pHPue85 Ls4g7xPKd0eshdhu4RENcuqC8G8VBp9aL+D2oUwlb/zyjrV6UQEZY4cKKw+IXiApI46vtb w/0J5d2v/9EfWLtW8BR9CXKGRvbOMw8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1748252003; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JbubNeHtWJVe2F33QaV8s7k8BApXPhrbC0o3OqVKHQQ=; b=SkXKhKJ5ZjjQSNGiqd+qiyrz+IgDTCZSALlpFGFLWEDU2/cMkYpTJYoGPp+cuwdlkca7Ag oLM65W8IrCAZ93AQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1748252003; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JbubNeHtWJVe2F33QaV8s7k8BApXPhrbC0o3OqVKHQQ=; b=VvPIebfdab+tSGi1+aHrEqTVdzcDQaR3F70456T4bQ0CvVfqVxc2N653r5GQFh7pHPue85 Ls4g7xPKd0eshdhu4RENcuqC8G8VBp9aL+D2oUwlb/zyjrV6UQEZY4cKKw+IXiApI46vtb w/0J5d2v/9EfWLtW8BR9CXKGRvbOMw8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1748252003; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JbubNeHtWJVe2F33QaV8s7k8BApXPhrbC0o3OqVKHQQ=; b=SkXKhKJ5ZjjQSNGiqd+qiyrz+IgDTCZSALlpFGFLWEDU2/cMkYpTJYoGPp+cuwdlkca7Ag oLM65W8IrCAZ93AQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4D6371397F; Mon, 26 May 2025 09:33:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id LfuJEmM1NGjqYAAAD6G6ig (envelope-from ); Mon, 26 May 2025 09:33:23 +0000 Message-ID: <5b0301cd-cc14-4dae-943a-6a300fb560d1@suse.cz> Date: Mon, 26 May 2025 11:33:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] mm: slub: only warn once when allocating slab obj extensions fails Content-Language: en-US To: Usama Arif , Andrew Morton , surenb@google.com Cc: hannes@cmpxchg.org, shakeel.butt@linux.dev, vlad.wing@gmail.com, linux-mm@kvack.org, kent.overstreet@linux.dev, cl@gentwo.org, rientjes@google.com, roman.gushchin@linux.dev, harry.yoo@oracle.com, linux-kernel@vger.kernel.org, kernel-team@meta.com References: <20250523165240.1477006-1-usamaarif642@gmail.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJnyBr8BQka0IFQAAoJECJPp+fMgqZkqmMQ AIbGN95ptUMUvo6aAdhxaOCHXp1DfIBuIOK/zpx8ylY4pOwu3GRe4dQ8u4XS9gaZ96Gj4bC+ jwWcSmn+TjtKW3rH1dRKopvC07tSJIGGVyw7ieV/5cbFffA8NL0ILowzVg8w1ipnz1VTkWDr 2zcfslxJsJ6vhXw5/npcY0ldeC1E8f6UUoa4eyoskd70vO0wOAoGd02ZkJoox3F5ODM0kjHu Y97VLOa3GG66lh+ZEelVZEujHfKceCw9G3PMvEzyLFbXvSOigZQMdKzQ8D/OChwqig8wFBmV QCPS4yDdmZP3oeDHRjJ9jvMUKoYODiNKsl2F+xXwyRM2qoKRqFlhCn4usVd1+wmv9iLV8nPs 2Db1ZIa49fJet3Sk3PN4bV1rAPuWvtbuTBN39Q/6MgkLTYHb84HyFKw14Rqe5YorrBLbF3rl M51Dpf6Egu1yTJDHCTEwePWug4XI11FT8lK0LNnHNpbhTCYRjX73iWOnFraJNcURld1jL1nV r/LRD+/e2gNtSTPK0Qkon6HcOBZnxRoqtazTU6YQRmGlT0v+rukj/cn5sToYibWLn+RoV1CE Qj6tApOiHBkpEsCzHGu+iDQ1WT0Idtdynst738f/uCeCMkdRu4WMZjteQaqvARFwCy3P/jpK uvzMtves5HvZw33ZwOtMCgbpce00DaET4y/UzsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZ8gcVAUJFhTonwAKCRAiT6fnzIKmZLY8D/9uo3Ut9yi2YCuASWxr7QQZ lJCViArjymbxYB5NdOeC50/0gnhK4pgdHlE2MdwF6o34x7TPFGpjNFvycZqccSQPJ/gibwNA zx3q9vJT4Vw+YbiyS53iSBLXMweeVV1Jd9IjAoL+EqB0cbxoFXvnjkvP1foiiF5r73jCd4PR rD+GoX5BZ7AZmFYmuJYBm28STM2NA6LhT0X+2su16f/HtummENKcMwom0hNu3MBNPUOrujtW khQrWcJNAAsy4yMoJ2Lw51T/5X5Hc7jQ9da9fyqu+phqlVtn70qpPvgWy4HRhr25fCAEXZDp xG4RNmTm+pqorHOqhBkI7wA7P/nyPo7ZEc3L+ZkQ37u0nlOyrjbNUniPGxPxv1imVq8IyycG AN5FaFxtiELK22gvudghLJaDiRBhn8/AhXc642/Z/yIpizE2xG4KU4AXzb6C+o7LX/WmmsWP Ly6jamSg6tvrdo4/e87lUedEqCtrp2o1xpn5zongf6cQkaLZKQcBQnPmgHO5OG8+50u88D9I rywqgzTUhHFKKF6/9L/lYtrNcHU8Z6Y4Ju/MLUiNYkmtrGIMnkjKCiRqlRrZE/v5YFHbayRD dJKXobXTtCBYpLJM4ZYRpGZXne/FAtWNe4KbNJJqxMvrTOrnIatPj8NhBVI0RSJRsbilh6TE m6M14QORSWTLRg== In-Reply-To: <20250523165240.1477006-1-usamaarif642@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: dirf1nfxymwxgux5u7q9tsuiwjf7twud X-Rspamd-Queue-Id: 176334000A X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1748252004-795512 X-HE-Meta: U2FsdGVkX1+6Hjci9sQHTrFzNl/izS7Hsvuk4X8eHasLrX9TVgEAkd5aC3zNL9HkfMGnwhZRpHth3VIlaQGRRG/7joGH31O8zSG1GdPtAvYpl+XH3PVa8c+Gus5RWfmiMT1XV2PTbppPGIrMBUf9A1J+N1A+E2KjtkVu7cfaStyXOtrUZ1hGusps4HlG15HTT5LHpz2eRZI5mWnimNm4JE16p6Qz6fTFzrATVFQRYtQT0zOyNKu2xU8FmVf7iti2yC5u2e8/UGsRcbsec/tGqUS2CtPVrXBcZOagBjeDlO8qi5sJ7aUpMnOOxwPMaIxavYUn2DxtAe72Y6QyzfofIZ7GDEc2uvKGn/VLuuxsqZl8qGihTfoXdJpa+IlzBiJg7nq1GTZGh2DZhtfeVS8qoAKM13ra8ga06ECbhVor68qpDqCB+ujcnt8R7wcu+tPuAHd+2uVKWlRVHN0CoE9VRrK7l+/EjEKuMlu2GW/jmtvQxHxsmR44+TYPeM3Asd5pMJx2LAJK9oDvJeuGYAPXMsvTbUicSORH7DuLpSIAoXRr8XaRE4QNGqHzHiyc1HYY97a7Y3Tal76X6BirkaFnLtKq7LfYt3UNW+n+NJBHVTVwEetWfQg/++m+3upMcC5ktfa2N9kNAH6DLAAEdGlv7M3x4sc8r8+IYzZ192npEgCFq7pnrry65INYnbmUPIakLt8kBZ09APtbaabFA/vFwa6FD5RQjCYtI/b4ZN8qAWEYGzMMQQaNzPk+kvQhTC3K0nZSwMPGObfFqa3kd1MxAOYoNW3SntTQgPfsT09U6VlcUkZLbu6LNpAX1Dgmx06EZXY5NTJYh51Eo1mJ4ofT/VD76iiHLzCk/pUOJQ7LgErr/NNk0/aNg5uH6dIJUwg0HkB+/Sh47UbmvJrMA7l/njpJdo31MLJtPVW+m3v4EwdMA/ZrZ9q0dLg6XtdqCq7qIlC54MLle6tyqahDiIm aw1SdrNm dRtY92Cc7uyuTOPmbVFXchxha38K+dD0pw4fY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/23/25 18:52, Usama Arif wrote: > In memory bound systems, a large number of warnings for failing this > allocation repeatedly may mask any real issues in the system > during memory pressure being reported in dmesg. Change this to > warning only once. > > Signed-off-by: Usama Arif > Reported-by: Vlad Poenaru > Closes: https://lore.kernel.org/all/17fab2d6-5a74-4573-bcc3-b75951508f0a@gmail.com/ > --- > v2 -> v3: > - Put warning back, but only warn once with pr_warn_once. > v1 -> v2: > - remove the warning completely. We will have a way in the > future to indicate that the mem alloc profile is inaccurate. > --- > mm/slub.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index dc9e729e1d26..36d7c43a6f2a 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -2102,10 +2102,12 @@ prepare_slab_obj_exts_hook(struct kmem_cache *s, gfp_t flags, void *p) > > slab = virt_to_slab(p); > if (!slab_obj_exts(slab) && > - WARN(alloc_slab_obj_exts(slab, s, flags, false), > - "%s, %s: Failed to create slab extension vector!\n", > - __func__, s->name)) > + alloc_slab_obj_exts(slab, s, flags, false)) { > + pr_warn_once("%s, %s: Failed to create slab extension vector!\n", > + __func__, s->name); > return NULL; > + } > + I've removed the extra line locally. Added to slab/for-next, thanks. > > return slab_obj_exts(slab) + obj_to_index(s, slab, p); > }