From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23557C52D7C for ; Mon, 12 Aug 2024 06:25:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AFA516B009E; Mon, 12 Aug 2024 02:25:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A816C6B009F; Mon, 12 Aug 2024 02:25:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8FC846B00A0; Mon, 12 Aug 2024 02:25:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6AB1D6B009E for ; Mon, 12 Aug 2024 02:25:03 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id DBFF3121120 for ; Mon, 12 Aug 2024 06:25:02 +0000 (UTC) X-FDA: 82442605644.18.EA406FE Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by imf12.hostedemail.com (Postfix) with ESMTP id 7098840014 for ; Mon, 12 Aug 2024 06:25:00 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=R1yGF8q8; spf=none (imf12.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 198.175.65.17) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723443889; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/3ZUxXx+bA5hbygCerpgLoe4kkpZ+FNMmKK2E6sS0hM=; b=p7Lt5f9B8rhIWQTTjNLVrZPQpST7Bk9E66xrYkGB/TzlfcEWz+cejSCT+dxc+xRDTm+VOM rLvSIb3/FFMt+E/NK30QZs5WVUurESA2RByeqBzeCIZmdJd+I4oCWWUsZXBZV20jKWXISw Gzc5KVjy4JHVU40RgU+KJISfL7ogPwY= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=R1yGF8q8; spf=none (imf12.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 198.175.65.17) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723443889; a=rsa-sha256; cv=none; b=SspWZPcO7uCgQg9Gyx6K8f9FPTRGGTgRXvgRBo1Sb3Abcuwc1qbmt9OMmniH2r8aPI5WXA VYArhP/4SuB8WITrKUEYPDjIlCc9JzTSknVsMGFGo8G37L5fURA88yXm/JTp/zO0G+/4MW yPrNezINZbh4DQ/MGjneGQyyIYOGbZo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1723443900; x=1754979900; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ZcHs4sGuK00d0/wvxniMPB/um4ek/IGJu2PumeOzbPQ=; b=R1yGF8q8juRKGmsDtbieJu0P1mPw1GsUyHrRz+nECaZibDMGm0GvIOSE GMn5t/m1r78W7b9b79k5jHmUl/X66ljhtc7inmZQeJHFPcIQhsO6brPZJ V8tMmHop9ad1Gco3e5eMtg9tzCFeNUav0oc1B99RHscxBegwccBnWAIRL JjotdUMgdKUiA6yRVvlSMy+92PgKiVAvldcffWRmr9rKjmtLDWZXllPVt zn/QW7orHfxtZ4a3diiuBe5Q3NeKnCsIKyA0sCySdgBmHJx0KDw/cZKuA iIEHLRIJ7CibimD+BgUw5OUrz+7jQidneMKIoRWAG22nne6AYEFUvK6ko w==; X-CSE-ConnectionGUID: VJ0/zVszTdu71POid2br8Q== X-CSE-MsgGUID: pPyFCp+3RpiaR3hr7u1UyQ== X-IronPort-AV: E=McAfee;i="6700,10204,11161"; a="21664993" X-IronPort-AV: E=Sophos;i="6.09,282,1716274800"; d="scan'208";a="21664993" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2024 23:24:58 -0700 X-CSE-ConnectionGUID: I+lUIlELTJKI6YHZtUa6Zg== X-CSE-MsgGUID: 5gfP+uEKS6uYmr3PjYROrg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,282,1716274800"; d="scan'208";a="81392471" Received: from black.fi.intel.com ([10.237.72.28]) by fmviesa002.fm.intel.com with ESMTP; 11 Aug 2024 23:24:55 -0700 Received: by black.fi.intel.com (Postfix, from userid 1000) id E81D11F8; Mon, 12 Aug 2024 09:24:53 +0300 (EEST) Date: Mon, 12 Aug 2024 09:24:53 +0300 From: "Kirill A. Shutemov" To: Tom Lendacky Cc: Andrew Morton , "Borislav Petkov (AMD)" , Mel Gorman , Vlastimil Babka , Mike Rapoport , "Matthew Wilcox (Oracle)" , David Hildenbrand , Johannes Weiner , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv2 3/8] mm: Accept memory in __alloc_pages_bulk(). Message-ID: <5aqorjb62kozvqehdw5ei6ov4gol6kcu72mteqso7v72jvnrgn@gdgpyjhhz65q> References: <20240809114854.3745464-1-kirill.shutemov@linux.intel.com> <20240809114854.3745464-4-kirill.shutemov@linux.intel.com> <8640d12f-e4b4-5bd1-b772-6aae5e5ef972@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8640d12f-e4b4-5bd1-b772-6aae5e5ef972@amd.com> X-Rspam-User: X-Stat-Signature: scmy7uqswrwgtr66a11qam3r1gghctc9 X-Rspamd-Queue-Id: 7098840014 X-Rspamd-Server: rspam11 X-HE-Tag: 1723443900-346272 X-HE-Meta: U2FsdGVkX19dlq30Jho2Vxj9LpIT+KkFjsWA9S0lVeSRQrWpgvuaHmpc7xK4+AyoQq5b1TGyKjo06Y6yxr4EdQbmATyjAAf1WqWjViTpPIrxc+Je/O+1oTSUBqhpECcVli6v2s7tnPiwYd4VSiYKXBfQMc1UO+MGQKXyjq6BB9QhdZ3JuHDBnhSv9B7CauJMIOzWfIiE7DJxjwKMq0osfbb8HGc+B1xmkAGtncZoiYSpVi3DmwhrLZKtbmq/5DJGvtj6K54dqK6nncC05wp13PaGML99b8IMP1X8jxEANNu7yD54IMA224Kbnek7GvdcJydZJnzZC5mSTThXWJXvV35OLrxpE/vRSZrJF6yaDPmwd/KNG+wIiNjNbKfxCGx3Lm44NMIr0orPqE4rMzRSpWG62dDk+g8ybpcbf2rpHDlaUyBxSvldYQDfX7HGxh1l7P9xTWd12csVVzinydl1rD7SSnz/QQjhouYO89YOxHcLd2n2/7Ll2vEPHCZltXMkkzmGnZgtZ10VhJvqYu7pTWRlXUscqPz+0bJQgvmyyd1RQZWlpr0k71v6Db+wl+cAHvqux7bQaGX/VaWfgDTpPQfWQo4DchMPPDcaLI43kAwXzJN2TrjvCSok8pB15iZ8XA4qifQrmwAG4ejXm7e5y0roWxP90icvx1BTg3vzR9y7Sg8e2e+hvSItwMEZB5m72NtuHxxCRo6ff/XZHGLKp3+GTLuXkpf+3WE9AnrwNkZbWl2UAVVYFn5Ss6vfgnJzbajuVjg/HRt5tbf25wObGhqQ3G4iiJb4GC/buUAoagsaWvZl942PJmMbmUWl8jKuv5+k/Vl2kWkc3LF7coqT0tjTxospoaK2PW/0K+knka1fZG+cylLiwi/pUJ9OVPznmvw5YoXepz6phYTDYE5rH7UOYD6KrKC3EiMT8JrYJUbLOe+myAJ/y1pBACNFKTZjfxSLtC8AyqFg0gUuTVW Pfrg/tDk qsddeQ6E9vgqhClWF2UFCxnCG2Zo0Cye47Movi37E9JvnQ2C87SKkvhegKbrE9ut4tqeCfPDxnVR8SpxLUHGJc1nRw/hHBaVm6K23VhJ1O1dEHx0J7Jj8BYZC9ge306dBQ9c0AbmgS5OAhTYQTR87DACIGVB9JOIt2Ft4pSJvsTT+cGHMz8IFAVVsr/v44wAU5oDuHdbrm6xQnyA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Aug 09, 2024 at 10:31:03AM -0500, Tom Lendacky wrote: > On 8/9/24 06:48, Kirill A. Shutemov wrote: > > Currently, the kernel only accepts memory in get_page_from_freelist(), > > but there is another path that directly takes pages from free lists - > > __alloc_page_bulk(). This function can consume all accepted memory and > > will resort to __alloc_pages_noprof() if necessary. > > > > Conditionally accepted in __alloc_pages_bulk(). > > > > The same issue may arise due to deferred page initialization. Kick the > > deferred initialization machinery before abandoning the zone, as the > > kernel does in get_page_from_freelist(). > > Is the deferred page init issue an existing problem? In other words, > should it be a separate patch with a Fixes: tag so it can go back to > stable kernels? Yes, it is existing problem, but the problem is transient (deferred thread will add more pages) and there's fallback to __alloc_pages_noprof() which knowns how to handle deferred pages. I don't think it is worth backporting. -- Kiryl Shutsemau / Kirill A. Shutemov