From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Borislav Petkov (AMD)" <bp@alien8.de>,
Mel Gorman <mgorman@suse.de>, Vlastimil Babka <vbabka@suse.cz>,
Mike Rapoport <rppt@kernel.org>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
David Hildenbrand <david@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 3/8] mm: Accept memory in __alloc_pages_bulk().
Date: Mon, 12 Aug 2024 09:24:53 +0300 [thread overview]
Message-ID: <5aqorjb62kozvqehdw5ei6ov4gol6kcu72mteqso7v72jvnrgn@gdgpyjhhz65q> (raw)
In-Reply-To: <8640d12f-e4b4-5bd1-b772-6aae5e5ef972@amd.com>
On Fri, Aug 09, 2024 at 10:31:03AM -0500, Tom Lendacky wrote:
> On 8/9/24 06:48, Kirill A. Shutemov wrote:
> > Currently, the kernel only accepts memory in get_page_from_freelist(),
> > but there is another path that directly takes pages from free lists -
> > __alloc_page_bulk(). This function can consume all accepted memory and
> > will resort to __alloc_pages_noprof() if necessary.
> >
> > Conditionally accepted in __alloc_pages_bulk().
> >
> > The same issue may arise due to deferred page initialization. Kick the
> > deferred initialization machinery before abandoning the zone, as the
> > kernel does in get_page_from_freelist().
>
> Is the deferred page init issue an existing problem? In other words,
> should it be a separate patch with a Fixes: tag so it can go back to
> stable kernels?
Yes, it is existing problem, but the problem is transient (deferred thread
will add more pages) and there's fallback to __alloc_pages_noprof() which
knowns how to handle deferred pages. I don't think it is worth
backporting.
--
Kiryl Shutsemau / Kirill A. Shutemov
next prev parent reply other threads:[~2024-08-12 6:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240809114854.3745464-1-kirill.shutemov@linux.intel.com>
[not found] ` <20240809114854.3745464-4-kirill.shutemov@linux.intel.com>
2024-08-09 15:31 ` Tom Lendacky
2024-08-12 6:24 ` Kirill A. Shutemov [this message]
[not found] ` <20240809114854.3745464-2-kirill.shutemov@linux.intel.com>
2024-08-12 22:12 ` [PATCHv2 1/8] mm: Fix endless reclaim on machines with unaccepted memory Jianxiong Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5aqorjb62kozvqehdw5ei6ov4gol6kcu72mteqso7v72jvnrgn@gdgpyjhhz65q \
--to=kirill.shutemov@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=rppt@kernel.org \
--cc=thomas.lendacky@amd.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox