From: Andrew Banman <abanman@hpe.com>
To: Peter Zijlstra <peterz@infradead.org>, linux-kernel@vger.kernel.org
Cc: x86@kernel.org, Linus Torvalds <torvalds@linux-foundation.org>,
Andy Lutomirsky <luto@kernel.org>,
Dave Hansen <dave.hansen@intel.com>,
Borislav Petkov <bpetkov@suse.de>,
Greg KH <gregkh@linuxfoundation.org>,
keescook@google.com, hughd@google.com,
Brian Gerst <brgerst@gmail.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Denys Vlasenko <dvlasenk@redhat.com>,
Rik van Riel <riel@redhat.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Juergen Gross <jgross@suse.com>,
David Laight <David.Laight@aculab.com>,
Eduardo Valentin <eduval@amazon.com>,
aliguori@amazon.com, Will Deacon <will.deacon@arm.com>,
daniel.gruss@iaik.tugraz.at,
Dave Hansen <dave.hansen@linux.intel.com>,
Ingo Molnar <mingo@kernel.org>,
moritz.lipp@iaik.tugraz.at, linux-mm@kvack.org,
Borislav Petkov <bp@alien8.de>,
michael.schwarz@iaik.tugraz.at,
richard.fellner@student.tugraz.at,
Mike Travis <mike.travis@hpe.com>
Subject: Re: [PATCH 5/9] x86/uv: Use the right tlbflush API
Date: Tue, 5 Dec 2017 15:09:48 -0600 [thread overview]
Message-ID: <5aed7d7f-b093-b65c-403e-46bdbcf9bc5a@hpe.com> (raw)
In-Reply-To: <20171205123820.134563117@infradead.org>
On 12/5/17 6:34 AM, Peter Zijlstra wrote:
> Since uv_flush_tlb_others() implements flush_tlb_others() which is
> about flushing user mappings, we should use __flush_tlb_single(),
> which too is about flushing user mappings.
>
> Cc: Andrew Banman<abanman@hpe.com>
> Cc: Mike Travis<mike.travis@hpe.com>
> Signed-off-by: Peter Zijlstra (Intel)<peterz@infradead.org>
> ---
> arch/x86/platform/uv/tlb_uv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/arch/x86/platform/uv/tlb_uv.c
> +++ b/arch/x86/platform/uv/tlb_uv.c
> @@ -299,7 +299,7 @@ static void bau_process_message(struct m
> local_flush_tlb();
> stat->d_alltlb++;
> } else {
> - __flush_tlb_one(msg->address);
> + __flush_tlb_single(msg->address);
> stat->d_onetlb++;
> }
> stat->d_requestee++;
This looks like the right thing to do. We'll be testing it and complain later if
we find any problems, but I'm not expecting any since this patch looks to
maintain our status quo.
Best,
Andrew
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-12-05 21:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 12:34 [PATCH 0/9] Clarify/cleanup/fix tlbflush API/usage Peter Zijlstra
2017-12-05 12:34 ` [PATCH 1/9] x86/mm: Remove superfluous barriers Peter Zijlstra
2017-12-05 12:34 ` [PATCH 2/9] x86/mm: Create asm/invpcid.h Peter Zijlstra
2017-12-05 12:34 ` [PATCH 3/9] x86/mm: Address feedback Peter Zijlstra
2017-12-05 12:34 ` [PATCH 4/9] x86/mm: Use __flush_tlb_one() for kernel memory Peter Zijlstra
2017-12-05 12:34 ` [PATCH 5/9] x86/uv: Use the right tlbflush API Peter Zijlstra
2017-12-05 21:09 ` Andrew Banman [this message]
2017-12-05 21:27 ` Peter Zijlstra
2017-12-05 23:04 ` Andrew Banman
2017-12-05 12:34 ` [PATCH 6/9] x86/microcode: Dont abuse the tlbflush interface Peter Zijlstra
2017-12-05 12:34 ` [PATCH 7/9] x86/mm: Clarify which functions are supposed to flush what Peter Zijlstra
2017-12-05 12:34 ` [PATCH 8/9] x86/mm: Clarify the whole ASID/kernel PCID/user PCID naming Peter Zijlstra
2017-12-05 12:34 ` [PATCH 9/9] x86/doc: Remove obvious weirdness Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5aed7d7f-b093-b65c-403e-46bdbcf9bc5a@hpe.com \
--to=abanman@hpe.com \
--cc=David.Laight@aculab.com \
--cc=aliguori@amazon.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=bpetkov@suse.de \
--cc=brgerst@gmail.com \
--cc=daniel.gruss@iaik.tugraz.at \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dvlasenk@redhat.com \
--cc=eduval@amazon.com \
--cc=gregkh@linuxfoundation.org \
--cc=hughd@google.com \
--cc=jgross@suse.com \
--cc=jpoimboe@redhat.com \
--cc=keescook@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=michael.schwarz@iaik.tugraz.at \
--cc=mike.travis@hpe.com \
--cc=mingo@kernel.org \
--cc=moritz.lipp@iaik.tugraz.at \
--cc=peterz@infradead.org \
--cc=richard.fellner@student.tugraz.at \
--cc=riel@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox