From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE012C531DF for ; Wed, 21 Aug 2024 02:00:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 21B716B00A2; Tue, 20 Aug 2024 22:00:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1CB8C6B00A4; Tue, 20 Aug 2024 22:00:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 092806B00A5; Tue, 20 Aug 2024 22:00:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D56EB6B00A2 for ; Tue, 20 Aug 2024 22:00:39 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7E34F1C32A0 for ; Wed, 21 Aug 2024 02:00:39 +0000 (UTC) X-FDA: 82474598598.25.86B2C2A Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) by imf26.hostedemail.com (Postfix) with ESMTP id 3AE77140004 for ; Wed, 21 Aug 2024 02:00:35 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=none; spf=pass (imf26.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.35 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724205575; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dclPoGKcQXuiYaa+3A4MQhG3ZYqgqx2EXk355VU9RO0=; b=Fhh0fA7GS3L3FzOjoE6WfC0vQoGl4Tlw6HmhlMUIjmHXyOeegAL8ew9WqXsITqhlz2xOyf LLTRmZ8xH57gzDql43NhiwJOwTrOktqpgbfevBJevAvkhWdc+ebrpLnkSi09M+/omXtsCA H1b+CdJDqwQ2EqWYQtA3rYJo6a05SiY= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; spf=pass (imf26.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.35 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724205575; a=rsa-sha256; cv=none; b=200IvDS/NN2upVyJ4VkQ6LJvGspOdrMAr3+dcf/wetExHgZ5JWh+H3cV9SSXD9+UBQZnFp A1hEcT8+56iNs19l5aAitWTbkBt4s0qtRpS9BbpTKIwMD9GekKq9imx5vtENIreeytw4uS FtV7vSDLXmqrA853TqTe5Q6Ks/TgXAI= Received: from mail.maildlp.com (unknown [172.19.163.17]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4WpV0Y23Vkz1S8Mg; Wed, 21 Aug 2024 10:00:29 +0800 (CST) Received: from kwepemd200019.china.huawei.com (unknown [7.221.188.193]) by mail.maildlp.com (Postfix) with ESMTPS id AE5EF1A0188; Wed, 21 Aug 2024 10:00:31 +0800 (CST) Received: from [10.173.127.72] (10.173.127.72) by kwepemd200019.china.huawei.com (7.221.188.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Wed, 21 Aug 2024 10:00:30 +0800 Subject: Re: [PATCH v2 4/5] mm: migrate: add isolate_folio_to_list() To: Kefeng Wang , Andrew Morton CC: David Hildenbrand , Oscar Salvador , Naoya Horiguchi , References: <20240817084941.2375713-1-wangkefeng.wang@huawei.com> <20240817084941.2375713-5-wangkefeng.wang@huawei.com> <6df49109-d39b-9852-b5b2-a5b88c9329e3@huawei.com> <927205ab-bd83-4765-b2bb-3fd311f5ac6d@huawei.com> From: Miaohe Lin Message-ID: <5aa2f835-0337-d7d9-5ad2-1c5ca2d439d9@huawei.com> Date: Wed, 21 Aug 2024 10:00:30 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <927205ab-bd83-4765-b2bb-3fd311f5ac6d@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.173.127.72] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemd200019.china.huawei.com (7.221.188.193) X-Stat-Signature: hwk9ae8ki1z88n3kx4fdhtzk8aebkcjm X-Rspam-User: X-Rspamd-Queue-Id: 3AE77140004 X-Rspamd-Server: rspam02 X-HE-Tag: 1724205635-772258 X-HE-Meta: U2FsdGVkX18rX6NsQ8sQHlTznF7/UAHseiJE2j0Q4aDpxy9xIfaWB12jt8efKOz5Jb1ACGgzowP25AMqKpCGIXvruSMYngS5774tNX4coHgYq2W5O7+XPR606owL/nQKFb3oV+2MK9X1qGxabYreH9r79FSXTAKTmM8lQc2G4L5faoopxrOZRl/iepDWAusKzvZbcwUqv0tiFkphPgAm3tLC31/4ft6tmFgTphDYQ3aAOu2jWNq4AtbaWQjxTbHBYbEpQRR8W1UbDFcnROKqnNVTbXMCPwyR846x/9T98XNCPLt+ICq5KkiN7OYDuh8TtaOzEoeuYid6rx+EK0K02iAbMshxVW3cDF67QJP1xYbqTHQZEMpC7+a6r91PD3ab3jJb8KevMzf8MFV1t505+CwttnjaIjhcLmT1E0YHN/drxigVCG/wZNI1txB2u7lJNP5/+Jk6bvYZsnQAubPP1r2v/bvL4RtoJ1Ztm7yqPDaV5NhONZBpUXnrz42Ar7iJ89/fAvtDizhND0CaLM76dyTjM5/j0Y+z0LZKP1xZg9wCwSGeHxMamrCdToQMgns2gondukSUkd+Rul4OM8hPtJvA7iJo4YBN8KFYMCQv0u6JWTNpWoo2qAD6SIE4zRiRsYecrUJ9JCZX81d9ivn2v0IQDrTEnBh+VcroehCkGrkWWi6cxZ5ye7TGEG3WuCVsr5kwrwRn3N+6syNR0jl9zL2pESkmXmNQ/91DSbvmjRAomPmVoqKmc91pdNeWW54TaqbvfZPDZWP0VgCYVStOO/cdOlc9yrqB/6bz5OJ85S3gCLNJpWU4/nqFpaU0t390ng6ToRAyI5tNdQ6LR8qW9JVCMkPBmeJV8pmkAxD9TBrCvCD8D6P9velHngHIRffBrcgPhaI41TAohggjZF37ur4B5CvhnqBdvKxaqwnCnfMvaECuZNlsD2sv9mdCRt648VgppKdRagY9Z4YYNST Cky40XQe CNffX3BBZeeS+5MqW1ZWm61hjp97ux2x+wNEpwnP+C2s5hNTrPX+S0eMxonqsJt9mRt5u7+h/ks855p4W6wL0snaQX2VY67m0Te7vGNgNY8swyYHtyk2Io1GKwDkGrx+YkJTJ0YWMQNCaKFBsTxp2viSz0fYEPe4Lc+PROPRucXWfJzZL9Bo4IG4jhBP1XSLT6IDbZXB9SWX6ULuaaWheV8/lqSY2cJ66Z2mjIEMCeuGNP2lE0PsNCwpYEeyIlEkxHgRcmjWcCaAFvVQljW3vFqAA7ar5wHbXLngtJlV83A6lBM/81w+UVGTPmADrgWdA7kSM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/8/20 17:46, Kefeng Wang wrote: > > > On 2024/8/20 17:32, Miaohe Lin wrote: >> On 2024/8/17 16:49, Kefeng Wang wrote: >>> Add isolate_folio_to_list() helper to try to isolate HugeTLB, >>> no-LRU movable and LRU folios to a list, which will be reused by >>> do_migrate_range() from memory hotplug soon, also drop the >>> mf_isolate_folio() since we could directly use new helper in >>> the soft_offline_in_use_page(). >>> >>> Acked-by: David Hildenbrand >>> Signed-off-by: Kefeng Wang >> >> Thanks for your patch. >>> > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index d8298017bd99..64a145a0e29f 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -2671,6 +2671,7 @@ static int soft_offline_in_use_page(struct page *page) >         struct folio *folio = page_folio(page); >         char const *msg_page[] = {"page", "hugepage"}; >         bool huge = folio_test_hugetlb(folio); > +       bool isolated; >         LIST_HEAD(pagelist); >         struct migration_target_control mtc = { >                 .nid = NUMA_NO_NODE, > @@ -2710,7 +2711,18 @@ static int soft_offline_in_use_page(struct page *page) >                 return 0; >         } > > -       if (isolate_folio_to_list(folio, &pagelist)) { > +       isolated = isolate_folio_to_list(folio, &pagelist); > + > +       /* > +        * If we succeed to isolate the folio, we grabbed another refcount on > +        * the folio, so we can safely drop the one we got from get_any_page(). > +        * If we failed to isolate the folio, it means that we cannot go further > +        * and we will return an error, so drop the reference we got from > +        * get_any_page() as well. > +        */ > +       folio_put(folio); > + > +       if (isolated) { >                 ret = migrate_pages(&pagelist, alloc_migration_target, NULL, >                         (unsigned long)&mtc, MIGRATE_SYNC, MR_MEMORY_FAILURE, NULL); >                 if (!ret) { > @@ -2733,15 +2745,6 @@ static int soft_offline_in_use_page(struct page *page) >                 ret = -EBUSY; >         } > > -       /* > -        * If we succeed to isolate the folio, we grabbed another refcount on > -        * the folio, so we can safely drop the one we got from get_any_page(). > -        * If we failed to isolate the folio, it means that we cannot go further > -        * and we will return an error, so drop the reference we got from > -        * get_any_page() as well. > -        */ > -       folio_put(folio); > - >         return ret; >  } This works to me. Thanks. .