From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29249C83F33 for ; Mon, 4 Sep 2023 19:37:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3CD5D8E0015; Mon, 4 Sep 2023 15:37:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 37CFD8E0009; Mon, 4 Sep 2023 15:37:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 244D38E0015; Mon, 4 Sep 2023 15:37:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 114BB8E0009 for ; Mon, 4 Sep 2023 15:37:39 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C2E7EC05E5 for ; Mon, 4 Sep 2023 19:37:38 +0000 (UTC) X-FDA: 81199924596.04.B1F2CD3 Received: from mail-io1-f51.google.com (mail-io1-f51.google.com [209.85.166.51]) by imf07.hostedemail.com (Postfix) with ESMTP id C59B440022 for ; Mon, 4 Sep 2023 19:37:35 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b="C/OiGl05"; dmarc=none; spf=pass (imf07.hostedemail.com: domain of groeck7@gmail.com designates 209.85.166.51 as permitted sender) smtp.mailfrom=groeck7@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693856255; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Q7crZJwRytTyyIdDEoCObBVMoTgADDmg//xC0edSFAc=; b=chc1idHjCWFkEEXBmZu5k/0TEkqnax+Y5yxy/IpDMtfdCLWPRyiUMR9pCfz2SR81x4IZUH Y+SpQItYF5JYfpn52aaLUi7pIHPEKFVU+yQvSI1MyFaxO3oW2bKcM6VoIKM94my3bBnFUV xgkhisp/tJejfpWK7uaxyRTdviqJxaI= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b="C/OiGl05"; dmarc=none; spf=pass (imf07.hostedemail.com: domain of groeck7@gmail.com designates 209.85.166.51 as permitted sender) smtp.mailfrom=groeck7@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693856255; a=rsa-sha256; cv=none; b=Hw0m9zyYq0iWwyV4nvlBeNb82hSW62sIXIRrQUKus3Ntf9optG+XLcpUQ6LIxV5XqpsssT TL2JLQ1MTTVCBxEUWr+0aNET4sbfRa9Sn9+X+WzxJOB5upB1gYTLDGcJXXGEbJaJb6WSjS tP/TMZ2qB0wD/JPWvLui0dIqP9lD+xo= Received: by mail-io1-f51.google.com with SMTP id ca18e2360f4ac-7926de0478eso52841739f.0 for ; Mon, 04 Sep 2023 12:37:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693856255; x=1694461055; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=Q7crZJwRytTyyIdDEoCObBVMoTgADDmg//xC0edSFAc=; b=C/OiGl05Re5yxe8q3xGIYlHzNrbdlnCe/iVg91V6mb78FQB9nidk6r84X5v95drRZS PgkZuOfHgd/du6rt84AoKhLZLMvVNGFJKt2iT6pQBGYb5ajHOCMek6X8ImZoZyHnvJur RXIl7A10obg+JoLXSbmX812Is8KzIui3eyOcfywXu0xXfLsiR1V6nlgjET6IgriClr7q /r0v0CgJP4QC1dQsm1rO16LaHjZyAlHqUGuOTPMQnPeFZuB5Vi7yay23r45Pe9e2LzQG Qxkygl8jkpotHLBPuSlKOxCnqL1BSs7hOF5D/j71cJJ4ckFxxVo4EEaiW8TED2Wb+ZLv vh7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693856255; x=1694461055; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Q7crZJwRytTyyIdDEoCObBVMoTgADDmg//xC0edSFAc=; b=cjoZ1zLlAsm1rZgCqUQ8/mNhkvGtHAG8X2J76FCvZZa+wHJsSyTMja/Glgl0yqpQdu 1XcG3jxtkHtex5RPr97wIBsNR8PUgXaV9kvPiLJFDk70xbZefb1QOJ9LMO73O6tRe6PO EL3YgF3GnVXVaRpVk1pWIySRkyABUZS7eXXufZsTLV4gZ8ED4Qa9LAcLXAfh4EYQUySe Asz6C59/Ylt7SXeslLc/ntIf3/Layj2xUOtMo1z3jZEt/CmZ9Pt8YE28Y5vmuALEU7Ko xZgPPfJc/rI+yvxJ3Q/O9nej907QiJhBJcQ79befxV8FNfjR4joRyCx+gvc5OXHIglE7 lpgw== X-Gm-Message-State: AOJu0YzU+9RthpeEf20U1vXWyyVCvH7YIZWoQ+VLETZG83EMlHJ4zkys Fp3Yp5ZOFLz3jU20Ng6/JCs= X-Google-Smtp-Source: AGHT+IFDurXHV+YzkGcDx9hZwXp6jjNXSTz4+sen5na4mkdEAIh/GoEp5EEWbtX+xgRfL4fx0ca7MA== X-Received: by 2002:a05:6e02:1568:b0:346:15f5:2667 with SMTP id k8-20020a056e02156800b0034615f52667mr13409607ilu.4.1693856254831; Mon, 04 Sep 2023 12:37:34 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id gg18-20020a056638691200b0042b57bbbaf2sm3604214jab.26.2023.09.04.12.37.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Sep 2023 12:37:34 -0700 (PDT) Message-ID: <5a85bd1e-18b1-080f-922c-b14372093035@roeck-us.net> Date: Mon, 4 Sep 2023 12:37:31 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v6 26/38] sparc64: Implement the new page table range API Content-Language: en-US To: Mike Rapoport Cc: "Matthew Wilcox (Oracle)" , Andrew Morton , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, "David S. Miller" , sparclinux@vger.kernel.org References: <20230802151406.3735276-1-willy@infradead.org> <20230802151406.3735276-27-willy@infradead.org> <2513a500-920d-4e32-8231-f428175c7182@roeck-us.net> <20230904174350.GF3223@kernel.org> From: Guenter Roeck In-Reply-To: <20230904174350.GF3223@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C59B440022 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: ah5r3r1aak8snp3ncnr7a49expd33uhe X-HE-Tag: 1693856255-596398 X-HE-Meta: U2FsdGVkX18weyG+U5dbB9X0Hr62a2OSTdqM6rcEw4vyst9mTwLRGK8vRx3eQ0MU/N+WSHhDH1ul7q8Uu3P7oYIuz3WAX0k2f2JKM7hgBMEFbBATR/77xc9S1skOHnkwHsgGT5imFL9jMfmldgJmaneqQAgPuh9gBKwWpr8aP1TzxrCZY+4m3lTMGoglmVgWSmZHo8BgWIPgdJtjR2TDJg+zF3Zp6qUqRKPc1FYkBI8QFN4/X40KP/kQ+ihnkRn8daoeU/VzllirW9kxTPZAJduqRW7vHqY1UC25VmU+9+n+2pC/l/D+RcZo7X1BCx1PoNq5sHnggSTBfXuuL7EOfeR/wUveOAfhLE+tACuhU5wUCkcjRGFYkILPzgsinIdRPC8j4Guz3onsI+47Qy5sDuOS032oPES5epmQ16Xl7gK8jdJcWIOmfS1RzjrUTsRv3+XqCeZLtq0hvbKazMeqA4x0GpamM8oaFBZ8+u4pPtljtjeNFbB/MoxGP/KCNIWhTS24MydT/CnQqLRsK0U3iTN2tX4Bf9PcN/VvUSdLbsE6wBhUk1G6PXmQeuOgqZ6B7QhSO2p/s83xIwft9VZbkCcxLOG6hH2leVCnZCJDu5M1ERy4XT1gFfqnspUnFrV7CWrSZlR+9QKE6N+CZCJAfY7C+ribS7l+BEQ+86q6CRgrJccQ2VDOyrALb/nFOggEcDOoBtcTo3ihEe95GYN74w+4BB1g6exK4pbOmjM4IcsnGAk829bFuiJr4Kg9ELUiskoSsQ/Iu8TmzUyomIHnH/5aV5z5kYK/7aDt9frJfNBZDb1Mrbp3wvlR4ij/GCRj/oCYYVF4LSnDOkvcll+itkQXMYGxlqnXLAz7aLho0HCsakrnFEM7ns1aSuc5qhCOeARbGc2IQ12AUvFpO3A2tDaUnGLmTTncKgp94jvMB2qRZsSGv5h/mSjES47fZ78qkq//OgmkpgHNn6i+AKR vU6lUn5x P62hU66PzEnc4ws6Qdo4d+hrPTYMWDL9Q7Z3qMDD4ZUOTLkvBbIhq4g9E2hVRyG08cjQzwGATLASR8W/gzjSbbyu525Mt4OI10WqOCi7G3az9UnuGEfj6jpDK4j3R6dCHcdr0bSsz9ckf2OIoozKqi/9LFW1GVe2l5DFF6ThUwLTJMGBIO8N335wC73kBtW6ozlfLjSRSzrCJTRS/eu4jITYPMaPxXd6dIGD/UnngGrfA/FRz9hvwQ1g7zUN+yAX49R/WOfLE1ePRaPqID73onPpYapQdJ6fhaNZlZmaRmjp9MabIQGTgeefGWCqw6t1SUfI+gMGm4OteTUb4jwx4kh0pavnzB0LPolTQJAK/Ezy6uXUWLR3jPZgLiL4Zb+zRr6+RJiM4y95RWFPQ3JrRqM776sf+Wn0kKStandWSZHGkezZk0UMYoWE2gjwFqZMJoWDDH3LdkRDuAKZZzu9OLCrpbF/ZTDrJ4JddjASDqCQM9IMR+Jcf/c6bFeGmCSKKYLl8eFVieg83pJWY3hR9tvcy4Ut+s/T7irMukjCbnL3ZEpnNJK6y6mX/PUb3ZfzyxsOz8MKYHreXMKYGy2pid71LhpR2eYiQNTDOMliw4c87fguLhC9jJhXVxMNaYRIO9uy+By5iE/d1MuHHmvypZrudA2X2y0dYCqfHof1ceh1jYsAX4t+JXwbmwf8RuoMe7e7T8CKDzy7N1CE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/4/23 10:43, Mike Rapoport wrote: > On Mon, Sep 04, 2023 at 08:36:44AM -0700, Guenter Roeck wrote: >> Hi, >> >> On Wed, Aug 02, 2023 at 04:13:54PM +0100, Matthew Wilcox (Oracle) wrote: >>> Add set_ptes(), update_mmu_cache_range(), flush_dcache_folio() and >>> flush_icache_pages(). Convert the PG_dcache_dirty flag from being >>> per-page to per-folio. >>> >>> Signed-off-by: Matthew Wilcox (Oracle) >>> Acked-by: Mike Rapoport (IBM) >>> Cc: "David S. Miller" >>> Cc: sparclinux@vger.kernel.org >> >> This patch causes all my sparc64 qemu boot tests to crash. >> >> [ 4.890744] Unable to handle kernel NULL pointer dereference >> [ 4.891273] tsk->{mm,active_mm}->context = 0000000000000001 >> [ 4.891475] tsk->{mm,active_mm}->pgd = fffff80005452000 >> [ 4.891660] \|/ ____ \|/ >> [ 4.891660] "@'/ .. \`@" >> [ 4.891660] /_| \__/ |_\ >> [ 4.891660] \__U_/ >> [ 4.892116] modprobe(45): Oops [#1] >> [ 4.892555] CPU: 0 PID: 45 Comm: modprobe Tainted: G N 6.5.0+ #1 >> [ 4.892949] TSTATE: 0000004411001601 TPC: 00000000004565d8 TNPC: 00000000004565dc Y: 00000008 Tainted: G N > > ... > >> [ 4.901535] note: modprobe[45] exited with preempt_count 2 > > This should fix it: > >>>From 8181d1f582a309b51fe4cb02a783628257b91c86 Mon Sep 17 00:00:00 2001 > From: "Mike Rapoport (IBM)" > Date: Mon, 4 Sep 2023 20:37:59 +0300 > Subject: [PATCH] sparc64: add missing initialization of folio in > tlb_batch_add() > > Commit 1a10a44dfc1d ("sparc64: implement the new page table range API") > missed initialization of folio variable in tlb_batch_add() which causes > boot tests to crash. > > Add missing initialization. > > Reported-by: Guenter Roeck > Fixes: 1a10a44dfc1d ("sparc64: implement the new page table range API") > Signed-off-by: Mike Rapoport (IBM) Yes, it does. Tested-by: Guenter Roeck Thanks, Guenter > --- > arch/sparc/mm/tlb.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/sparc/mm/tlb.c b/arch/sparc/mm/tlb.c > index 0d41c94ec3ac..b44d79d778c7 100644 > --- a/arch/sparc/mm/tlb.c > +++ b/arch/sparc/mm/tlb.c > @@ -128,6 +128,7 @@ void tlb_batch_add(struct mm_struct *mm, unsigned long vaddr, > goto no_cache_flush; > > /* A real file page? */ > + folio = page_folio(page); > mapping = folio_flush_mapping(folio); > if (!mapping) > goto no_cache_flush;