From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB2BEC2D0CE for ; Wed, 22 Jan 2020 02:25:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7D2A824655 for ; Wed, 22 Jan 2020 02:25:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="XhszVteo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D2A824655 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D654B6B0003; Tue, 21 Jan 2020 21:25:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D16356B0005; Tue, 21 Jan 2020 21:25:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C2BF36B0006; Tue, 21 Jan 2020 21:25:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0023.hostedemail.com [216.40.44.23]) by kanga.kvack.org (Postfix) with ESMTP id AD7C06B0003 for ; Tue, 21 Jan 2020 21:25:39 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 46F7740FB for ; Wed, 22 Jan 2020 02:25:39 +0000 (UTC) X-FDA: 76403679198.13.silk87_88a153ed8441b X-HE-Tag: silk87_88a153ed8441b X-Filterd-Recvd-Size: 4277 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Wed, 22 Jan 2020 02:25:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:To: Subject:Sender:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=9ZOGsttRmOTfzjL1ECAYcpfTSZoQqHHRoblxH4x0j4M=; b=XhszVteo70FgyKJG9DtA7o+hV lGwkANDHq2wJhjn1MqGcqwTJUma+irli294AufHU/9wJByJWODQdSMqejTOSp7RhswG4C+IA43k1S n09gLgOqssnByXkE/bCGX/JzPVZsdlMUPKHehIk88YKYk4VXLYMdJyxJwOE2zjMK15HrO0MeKnpLP R+ZH2c8rygQO5+8BKLrSfTwDNDrSlx35LEV6aBqhpnDwMSq93IYl/wDvEvmsBvo0kQ94ttkqvnI64 xqMCl2/SxHizEC8XYpRFJLxl9ufloOdrpXp3/aypAorvYDZGa7ybSY5N6rtXqrTT8zNwI+0rslWc4 tU4Da/UJg==; Received: from [2601:1c0:6280:3f0::ed68] by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1iu5i4-0001Bw-5r; Wed, 22 Jan 2020 02:25:36 +0000 Subject: Re: mmotm 2020-01-21-13-28 uploaded (convert everything to struct proc_ops) To: akpm@linux-foundation.org, broonie@kernel.org, mhocko@suse.cz, sfr@canb.auug.org.au, linux-next@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, mm-commits@vger.kernel.org, Alexey Dobriyan References: <20200121212915.APuBK%akpm@linux-foundation.org> From: Randy Dunlap Message-ID: <5a81ab98-4f02-f415-4da5-3d5685915a0e@infradead.org> Date: Tue, 21 Jan 2020 18:25:34 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <20200121212915.APuBK%akpm@linux-foundation.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/21/20 1:29 PM, akpm@linux-foundation.org wrote: > The mm-of-the-moment snapshot 2020-01-21-13-28 has been uploaded to >=20 > http://www.ozlabs.org/~akpm/mmotm/ >=20 > mmotm-readme.txt says >=20 > README for mm-of-the-moment: >=20 > http://www.ozlabs.org/~akpm/mmotm/ >=20 > This is a snapshot of my -mm patch queue. Uploaded at random hopefully > more than once a week. NULL seems to be misspelled as NUL in the proc-convert-everything-to-stru= ct-proc_ops.patch patch for kernel/sched/psi.c: static int __init psi_proc_init(void) { if (psi_enable) { proc_mkdir("pressure", NULL); - proc_create("pressure/io", 0, NULL, &psi_io_fops); - proc_create("pressure/memory", 0, NULL, &psi_memory_fops); - proc_create("pressure/cpu", 0, NULL, &psi_cpu_fops); + proc_create("pressure/io", 0, NULL, &psi_io_proc_ops); + proc_create("pressure/memory", 0, NUL, &psi_memory_proc_ops); <<<<<<<<= << + proc_create("pressure/cpu", 0, NULL &psi_cpu_proc_ops); also missing a comma above... } return 0; ../kernel/sched/psi.c: In function =E2=80=98psi_proc_init=E2=80=99: ../kernel/sched/psi.c:1286:37: error: =E2=80=98NUL=E2=80=99 undeclared (f= irst use in this function); did you mean =E2=80=98_UL=E2=80=99? proc_create("pressure/memory", 0, NUL, &psi_memory_proc_ops); ^~~ _UL ../kernel/sched/psi.c:1286:37: note: each undeclared identifier is report= ed only once for each function it appears in ../kernel/sched/psi.c:1287:39: error: invalid operands to binary & (have = =E2=80=98void *=E2=80=99 and =E2=80=98const struct proc_ops=E2=80=99) proc_create("pressure/cpu", 0, NULL &psi_cpu_proc_ops); ^ ../kernel/sched/psi.c:1287:3: error: too few arguments to function =E2=80= =98proc_create=E2=80=99 proc_create("pressure/cpu", 0, NULL &psi_cpu_proc_ops); ^~~~~~~~~~~ In file included from ../kernel/sched/psi.c:133:0: ../include/linux/proc_fs.h:64:24: note: declared here struct proc_dir_entry *proc_create(const char *name, umode_t mode, struc= t proc_dir_entry *parent, const struct proc_ops *proc_ops); ^~~~~~~~~~~ --=20 ~Randy Reported-by: Randy Dunlap