From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49301C36010 for ; Fri, 11 Apr 2025 17:13:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB2EA680014; Fri, 11 Apr 2025 13:13:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B5FCE68000F; Fri, 11 Apr 2025 13:13:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A0042680014; Fri, 11 Apr 2025 13:13:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 852D068000F for ; Fri, 11 Apr 2025 13:13:50 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0011FC0627 for ; Fri, 11 Apr 2025 17:13:50 +0000 (UTC) X-FDA: 83322410262.28.F8B9344 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 921B5C000C for ; Fri, 11 Apr 2025 17:13:48 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RLzATlU2; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744391628; a=rsa-sha256; cv=none; b=2GXtvHMX7XyCar03TMZyFWDXout2d49PJlkNqOfKnkN0msCOTBJ87RDppnsXnUXHRj3e2m 4yYGmz2+rCa0AI3l9bnJm3eEl3MD3E6CNNB8WNqR7vik3gY+TGMWctGvEKKuxomWzr1+Im AhMDPQCABD24OqNgLrnfNVk/JEBSHrg= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RLzATlU2; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744391628; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=neywMREG3kC+bngOS26dPsNzqIJnBC57g6tNRxTe/TM=; b=JYoL9iH09g7SXD1npT3BMmrKxJwgXtnO/0MuCRNk0DqETPLDYLLdjZ/IV24WnWPtyncxb7 pKUJwh51DqxaNrWZ6WW0iqLUkA9VOnEZuTv9OXpJRdP0DDzY+1ka3gAVcGVgf+KBdZfugd vEPa19PIUozsTcHyz1e19hBe221voh0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744391627; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=neywMREG3kC+bngOS26dPsNzqIJnBC57g6tNRxTe/TM=; b=RLzATlU2v/pzhdP3v1hLZml+hOAly+37P47R9In2BHtubAv1FrLdAc66TQVpQvMAPFLbxt qxlHZal/nrJ6Ocdr2rFsN4MbrBYPbnczQuJeqFHtTXQLbnriLzva0AjWB04PLgGCa+dsPb 32UsPeoo3TmW+yB7mlGkn4hZDi5vIoU= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-90-w2nsZbB8PXqeykrE87ykeg-1; Fri, 11 Apr 2025 13:13:46 -0400 X-MC-Unique: w2nsZbB8PXqeykrE87ykeg-1 X-Mimecast-MFC-AGG-ID: w2nsZbB8PXqeykrE87ykeg_1744391625 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43d007b2c79so15556535e9.2 for ; Fri, 11 Apr 2025 10:13:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744391625; x=1744996425; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=neywMREG3kC+bngOS26dPsNzqIJnBC57g6tNRxTe/TM=; b=iFRLx+h246h1LGWC/7/lrXSpD/+eDYu/s8iXTHueTk8unluADvtS630IWTqvI0O892 0odU1WZuA5GAZ9bMbMb13pHsKxFEVXdrcaoQGgeT+Zv+i8tQyNiMJrIR2WN1lPeZYjgS s91tYk0xC29dPUTe5FsYI01tZZC1JOi68Qkz+tgeeKHZHgONgtGgRebdUlGVNPdwwVsr LShLueVzivLHHJfScaEFJUD4RzH34F8XJ4zYv4cCpePKr/97e8gfqOLZL+fH8c153OFx wBBADLOzmiLhPUIBeDlfASGyPEEypF3CM53XSIqAIiZr7TnbRL9rr9Hhlqaew3Q828/D /7HQ== X-Forwarded-Encrypted: i=1; AJvYcCXz7PVZ3a3Z62mCpayuy4ELeDKLTcIWPMHVO3/ZFcpMepZ8/J9N37NY8mBisHmgAxJPhXg5ru4xRg==@kvack.org X-Gm-Message-State: AOJu0Yw4GPFWuOsL37sJnRXc/ZfpFDKwBmtajZ5KuwlkqpWZaTJNv1KI cggm5/OKM9hj89Rj1pTIt3HdWeuC7MVNrDcsJWCL8pqCGpXrVxyoagiDdTw6mXsQDtDn0s93spK L/TFk/EPPKPuSs4PsDQgeKJhIVQmjsnnyAKJDXlx78+UAnAelMUk2tLms4AE= X-Gm-Gg: ASbGncuP3ToW6Dmg9BMIwQGhbcHCGaN/eKYRhC6zs5oJpqdxd7vB/huGcbTKRKi+HU0 K3GWF+zZJHpNdQw60WnOEDeEc1bliO4Be38GVvzJdSgAXYkk7XSFFJYOTgwth41R6osqUyaOCmY LRY58KA9meVzFuXFOVNT5VrP6cYYUhmfAZOvEDkX4+jZE+iFy5hFyRbPOYdrM1x1dlbQ1yTPIM/ NCYWwtvlNOonV3tbW04Z765doBlxNc3ZGco41KV7GWxE0J132Tbpt4taBC/8lBBDT2PSNIsn4YP DAF+GGJf7R+N1h1NknNyjE6EUR3aaLrbVlNYJQDEthEpVtbG4HS97HfdLxtptotJudOUsnddG5q QnBxzuBmm5W4bro3IQcEmMrBhMKyxKRUq1pZg X-Received: by 2002:a05:6000:4285:b0:390:f9a5:bd79 with SMTP id ffacd0b85a97d-39ea5207243mr3240516f8f.26.1744391625170; Fri, 11 Apr 2025 10:13:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE5z9WPEm/LW3FUIiwo3WmsMkOxZZVOwmdjiMfPK51RUb5ALU9dZOgsH2MHB5VMYrn9P+iZ6Q== X-Received: by 2002:a05:6000:4285:b0:390:f9a5:bd79 with SMTP id ffacd0b85a97d-39ea5207243mr3240493f8f.26.1744391624722; Fri, 11 Apr 2025 10:13:44 -0700 (PDT) Received: from ?IPV6:2003:cb:c726:6800:7ddf:5fc:2ee5:f08a? (p200300cbc72668007ddf05fc2ee5f08a.dip0.t-ipconnect.de. [2003:cb:c726:6800:7ddf:5fc:2ee5:f08a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39eaf445515sm2536028f8f.89.2025.04.11.10.13.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Apr 2025 10:13:44 -0700 (PDT) Message-ID: <5a7d427c-c729-47c7-b851-9c49a30af279@redhat.com> Date: Fri, 11 Apr 2025 19:13:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm,hugetlb: Allocate frozen pages in alloc_buddy_hugetlb_folio To: Matthew Wilcox Cc: Oscar Salvador , Andrew Morton , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vlastimil Babka References: <20250411132359.312708-1-osalvador@suse.de> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 7MqteV_ffYRE5WnNF2HX0Z9FvCBV-RmVS5Wr_S23N_U_1744391625 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 921B5C000C X-Stat-Signature: xideim78ag3hatwt3swpo7zcidsmjqdb X-HE-Tag: 1744391628-665474 X-HE-Meta: U2FsdGVkX187O44wO4OCrA3UJeUc1/6RJNr97TxWeED3UQgWVPPYUH0hXQsX+IPVorYtW8b1K4+7xSU5l7e9sFSgjlz4ehXiQrMSRRH/+bN4PzftT4F/6izMyls22Z9ey9VEefoRd3YK7MyUAIEJ3kBZoA7P7JPwRul4MlZgt3+UD41TJgAqUMIHz9+Z0DeosvnAbWJvCR3zo3Hpjh8TlCFnLRyg3Lxl5tSK35O8bplqVIObnCqchg8fB5UbBbMnbzdKApLhq1ySxKsDFkkXrRsDciVrnX3wAIwmN1fN89l1zL6IOoYFt5EBfWnKfp7H7/Yc415vajgV3VMGibM5vURh/F5zG2tlfkwbOt7pAZRymUOrmKQ791a1+ZihmS05WTQ/4lfakgkPLq76b1bnHWoSdcRDkqShK7T04yXP204hXMC2PgejJQ663oczrst3OJKkaFaevVSU16Ei/9cUl5gihAd/EMGVuaaOq272dHSdi6JJ605x1+BDWEB3TkkIzfZqVmqKtIQAim/z1ch8AhWfJbcbVHlAeWFvTKzldwiRKudzdU47H8/ps02lPh1dBQtVNkRI4MRcR0hKkfyqtLMiYx5GBNG3tB0rIZE4HVg32zPJtXTtFJ1l2X1IHkQwoTvUGA1eymU5FHZ9WvmS+uz0OuQaJfrsxPXhmRB3L+BJ6MZPVEqIOpeI/Vbr0s1PQJeRKYJ1eUxlnIUAI6xOK/YUNGCAQkD79y0F/y3iODMIrMaq78COY+1w1swKcIxs2KOWcIj3F4E+jkdQvpMEOfhA9SzQ+l8zaj9EhdjUaeyviVDSfjGlBNbzPuXHn7f4282OT/pUQDC53KhJs9Ga9VW/7SRr9NXIT0Waba9LgO6m8bIqxTKo6Dkj0TW29Hdwe8G9MRvk3AffcL/9ce+ZOEAdaK7emIXyKMA5zJFxwvQna+7wd9we2m6gn3OZhIpiMZm3LXfueyQZI67V2+X gFo/mu1T IxD6z97921YX1FjhTLRvh1wF7h5wYQ8Zuxb/UpPca0eq/2kvZtV7UM90a9x93pgGyHCgwF3M6IUGdTB+jku43hNynG70Rj1yXKvrZgPmkGfqEg7hB5Yuc1Tk+mnQtNWNo4PlCiBS8iKGKN3Lw5DgjDAvW6RKHToE7rgHKTAjje94hoZA0XfehszzHe1W6v4NAwNpbGWxOw+XSDcXHSkFp3IwT8cS5ih4OA8c3dEFy87b0KXICeEZXjUNzIs0T5UCWsql4HN8e/BNxg+3INZ3pwRRnp8lEaYVO9FJKoNrPpWps6607CEuWQCfZFkJLP7df9Dfq4Xm6sfIiJws6OAGKmvsbFfT/jQjtJNGaahUJZDjXtADGvLwFeNXPE3yRTzZS9rv+UaObM5NKgktangaf77zASZ0l/upKYgeYvesEDc/jlSeCjfS2hd1LL0MDHy5PNHETfJ9P3J8hbakkLrGhtdGFq2tMXGQ+mtq6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11.04.25 16:21, Matthew Wilcox wrote: > On Fri, Apr 11, 2025 at 03:44:31PM +0200, David Hildenbrand wrote: >> I assume htlb_alloc_mask() will always include _GFP_COMP. > > static inline gfp_t htlb_alloc_mask(struct hstate *h) > { > gfp_t gfp = __GFP_COMP | __GFP_NOWARN; > I checked that as well and actually meant to say the I assume that we will here always have __GFP_COMP because the gfp_mask we get here will always be derived from htlb_alloc_mask(). >> But semantically, it might be wrong: __folio_alloc() will in the memdesc >> world also make sure to allocate the memdesc, __alloc_frozen_pages() not. >> >> Maybe one would want a __alloc_frozen_folio() .... @willy? > > This is fine. Yes, it'll need to be modified when we get to the > separately allocated memdesc, but there's a number of places that > cast the freshly allocated page to a folio, and I'll have to come up > with a way to catch them all. Okay, thanks for clarifying. Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb