From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45DBED17138 for ; Mon, 21 Oct 2024 21:15:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D65E56B009D; Mon, 21 Oct 2024 17:15:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D15976B009E; Mon, 21 Oct 2024 17:15:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BDD816B00A1; Mon, 21 Oct 2024 17:15:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9D0AE6B009D for ; Mon, 21 Oct 2024 17:15:08 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 34238121B27 for ; Mon, 21 Oct 2024 21:14:54 +0000 (UTC) X-FDA: 82698864276.22.244049A Received: from mail-oi1-f173.google.com (mail-oi1-f173.google.com [209.85.167.173]) by imf30.hostedemail.com (Postfix) with ESMTP id B245C8000E for ; Mon, 21 Oct 2024 21:14:36 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=EvtDVMLp; spf=pass (imf30.hostedemail.com: domain of hughd@google.com designates 209.85.167.173 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729545229; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pl+1OXeS3jjCVGi9wB4DNdDzJV71eNiyACNOmRjgT+o=; b=AR28bBCvv9NH+YFlw5fXMGmvU1UbJTNFYV3Iu5urwPt6thlIg5KHulK0QD8Pwvs8bo8Xud TZE4CQ2K962HanZSQGV8HWdktTS3CRbSwIhWXkji1/AwwArCLghPc9VT1Sqr8vD5cty948 sJU94CHv4kdE9gK3T48pNGbd9U0sack= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=EvtDVMLp; spf=pass (imf30.hostedemail.com: domain of hughd@google.com designates 209.85.167.173 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729545229; a=rsa-sha256; cv=none; b=4rGKbY8lKPWp+MS52bEL8y/8dLLoem9RjK8LphCHPiqV34jA29HMv/Amnmku5L5A82ez+S FrVS2rN/9JThhKTYDlwIMzT2bTQHrj1gsdV+NhYUhs2EchVzaKaJqXpBxfKm7fzdf0rTTc I1bJc0ReOQL9OafsO3UJzYa+T9AHOo0= Received: by mail-oi1-f173.google.com with SMTP id 5614622812f47-3e5f9712991so2425548b6e.2 for ; Mon, 21 Oct 2024 14:15:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1729545304; x=1730150104; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=pl+1OXeS3jjCVGi9wB4DNdDzJV71eNiyACNOmRjgT+o=; b=EvtDVMLp0ZbYkvIEwcyAO/SbBSAgE66CrspTnnYmfifqrRcbCoodKpIzJGTn/H1z00 GfEm5sN6xV9YNL41CVZB+eCrqkNI+TJdtXQiQ6K+cvG0UK3a+pg+/EDCUv7xe7VXw8Wi 1hC+yjOlrjvlnpM5GvJExYzz1+qPC29RnHYOKsFEqsnARVwYbCGkp/THZs4QagQgy6gr qbQFNdtHE8Bs/CTHfz63JNWBE+UBE2okeSs/USX6z45wFGnF+jfG4r7Xsyyyzpcw46yK G1rQMKmi+yC+K0XLqZD86N/CnKNjFdIOllWou2xL1oEqvV8nv40IkqfXQs1qPpju9Ihn nw+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729545304; x=1730150104; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pl+1OXeS3jjCVGi9wB4DNdDzJV71eNiyACNOmRjgT+o=; b=AuMju12liRDQm8X5M53SBkd3F8yvPJ8FQHhu02WUygldgZvN22jSWxfpgkLTIsgb11 uHaJCKf9ckL2d7NMRrF934ppnlHP15YOxnrd2pCt3HGPhcqG5OgAwazT3wKBZqO5EvQo T3G8/xFFkko571iiqW+FZz294//G2+YOassCAt9x+9EyxSnDe++LT7W7YNRZq1CB7B0p 7WON/7zVQHHqPlF9VtLtshWCHxwRMImIoH7wH7GGjSzbaUQ2EbpqY4JFG3LnYHXTxORR 4YUePsvszT3h/tvfZL3cgcCWJ1GNGRnKv3tefcWKYfIy4S17w8H3O+xT1odgLzwrTvfU Hy9g== X-Forwarded-Encrypted: i=1; AJvYcCUeLwy64XKNFF1NA3ypx/6ahnEgojqjeXXOZ3xQx18sDY8HtB2TRDN0+WHmGgYNctRpAA2Bnj4fWg==@kvack.org X-Gm-Message-State: AOJu0Yweg/rY4XrZsYAfb7XZ8/VMtzzi1yBIpyikBGJ/Bl2NWuktFNYu nQtRGY+4+TiQt26yaXYptHt3DyWbz56KgGILecbEvYRK08UaMHLcOyKS7FH93A== X-Google-Smtp-Source: AGHT+IGhmMLh8kMBM7/zn2z4jyFvwJfyOpg4/BrLJOLeBH5m10Rp7qrILHmCRyf0QZdt7co0ILfoug== X-Received: by 2002:a05:6808:191c:b0:3e5:fd5a:c39b with SMTP id 5614622812f47-3e602c64e79mr10377280b6e.4.1729545304410; Mon, 21 Oct 2024 14:15:04 -0700 (PDT) Received: from darker.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3e610d10207sm878832b6e.53.2024.10.21.14.15.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Oct 2024 14:15:03 -0700 (PDT) Date: Mon, 21 Oct 2024 14:14:38 -0700 (PDT) From: Hugh Dickins To: Matthew Wilcox cc: Roman Gushchin , Andrew Morton , linux-mm@kvack.org, Vlastimil Babka , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Hugh Dickins Subject: Re: [PATCH v2] mm: page_alloc: move mlocked flag clearance into free_pages_prepare() In-Reply-To: Message-ID: <5a793bff-acf0-86c4-cf4b-159f176c8103@google.com> References: <20241021173455.2691973-1-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: B245C8000E X-Stat-Signature: rgq11mx315so4unyhr5e65swxnjbdhcf X-HE-Tag: 1729545276-196117 X-HE-Meta: U2FsdGVkX1+RokqQx/HKH7gCQjVKmL2KvrAvbk/he1+sI+4fPnILcVuW8pyDNQVoe4PuA8bU1PVfohJIU/FMGhSgmAldyig7bW3xzWysBICTcAm3UUFhVvlFSTyNn0eTguzm6G3XKgDM58LBF2KmkOblC+9htzSE03NV55YxcjPHMr7KJSr4CSLvYhTCtXwEdVyW5i3xmmXQchC9AAqv3+ykyngmMbexpOaZsJNczi4ngjOwv6jVWJ1InMic/xJY4R6tMgBANDVUaVNcp7W23RdLcyGNR2lD7OpWGWYhPwy7n8W+kEylAwa7DvW5/Egym43PqQAX/+u+n+Itic4aIUouJb74SuQHT2NSsg3GvBb9YJ7SJ1QcNLFno+zi1ygbox5ZIxHHQzC14f+b7CgEQsyjkhr6UM7QFeXXS23QUwWNyXY2h9Ifng0hHwvsf0IDhYaBXUxF0da5KCds6TgXuh5CTVFIYkFwydoQMnsD9VdOXgCH/9C4B8Z7tWZ9bojvYgFUU/QsYaCoNTxb37bgYhQ0lcX23hp26KXPJL+t8ZIgwEdkB4X/CMkrM+0F0RJZ+6QcaBU+7sMLVkP4bB9wiBBL4p5Q3H3r9rNsddPIgC5LfJOMeLE1E2+4TWNHpwDCwB9CeOWTSGYKuKxxtjuaKXi5D10ug6BK43h+JwfsUTGAb4UadA/rnjguem1HLaos6IYBoewQSfjmB9LtkP3IoMcwNniPsVic+TxaWFhC5kp39UVPCOK8O83OLPPLlD2Vg+FoXlazUOolmYj9+WMuSGYL1vYAjGuzsJWu+vM9911iq9ZMPeOqYu2kRGZyqB9FGUBMmdlkQbytACJkgwAist9YwU0lkEPqNvsgAlEY410nRQdgWxIAH+VQnw8wqDbgRFiBUw2/ps93TuDAcV/9gOh4auukRkOc7kUDEA6vJ6381fGZVsBh7oCscihMIzfpMseEp8pylZaoCuAIJJP 4sPogZxw 0MlyaUHE1IubToWSEJX58/lwV+UuHE5Z+l8sH9T9JOttfoStQt7R2l2jXF11lbLwM5hDP1DNNUlW5p8lTzBDlrz2xWzpMNeZNUH2I/qsGnSQ3oJmfll9u5ywt4xLIo61xrm8pc0KnQBzP8Wz7ZBV7fKD9HyHwVXRctwysA0cbBcY8yOufp1p/W8G+Dior5LSLbv8J8sQs0nyaebMLpwqM86SxWo1iFn9/oLVv/3w0AQvzqGkq2ZGsXvHaD7vM13jGvOG2+p1kUnvKYnk9s6+OviT6Ih2ZiXFrflG2gcqMhE6oYALZVBK4fj3JmFE7V2dZ/CxTDFNRrha1HYq8dux9JCU1UCVWtM96zUSxxxr3Dn1xW0bGdl8QQJvhn0rONuLdRc/1yY6OFFTm5CG2MOxb8+gPUQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000121, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 21 Oct 2024, Matthew Wilcox wrote: > On Mon, Oct 21, 2024 at 05:34:55PM +0000, Roman Gushchin wrote: > > Fix it by moving the mlocked flag clearance down to > > free_page_prepare(). > > Urgh, I don't like this new reference to folio in free_pages_prepare(). > It feels like a layering violation. I'll think about where else we > could put this. I'm glad to see that I guessed correctly when preparing my similar patch: I expected you to feel that way. The alternative seems to be to bring back PageMlocked etc, but I thought you'd find that more distasteful. Hugh