From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEAF4C3DA64 for ; Thu, 1 Aug 2024 13:34:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5D4986B00B5; Thu, 1 Aug 2024 09:34:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 584776B00B6; Thu, 1 Aug 2024 09:34:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D70B6B00B7; Thu, 1 Aug 2024 09:34:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1BA866B00B5 for ; Thu, 1 Aug 2024 09:34:55 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C4551A7533 for ; Thu, 1 Aug 2024 13:34:54 +0000 (UTC) X-FDA: 82403772108.06.F3FD40C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 75B33140017 for ; Thu, 1 Aug 2024 13:34:52 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EO5rXL8J; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722519287; a=rsa-sha256; cv=none; b=WNqopcAywiedGiPMTfUU64LEWG23Ca5d5ZV/fAQwPFXlAZxhuus+qrIvIOGl8Buz2cKQJG kRyhHDtQ7qXAKjr4MRn/B/LxyBc17jFzM5a+0qsYP+XoTvif3awDuXF12qc5axHDhjnQ3l a5IlnL3MjKMRYEigDWRUnHn6lDwODzs= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EO5rXL8J; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722519287; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7VeraTL2UmLwQLKRE3xd5PLNoj7213HAaM5a3WpSzq0=; b=lkBfsbKExE07z77oWdmeIabNo+QJ5Rz+7bAsy+As0aNyE0qzKUXqtZA5urEVpKI4GFd9CX wLxO5JO6LsP2GVzqVtQVdsHriqvGA7+it7rTlzZZFOF0OGfMgJ8yzrRSO+3jND7VA6nAcz byxl1YaX/lhsP7ArFO9UFaN71h1lj4g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722519291; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7VeraTL2UmLwQLKRE3xd5PLNoj7213HAaM5a3WpSzq0=; b=EO5rXL8JrEPhkATeK6OuFVPchRA+uFjMCIPfCXF5hzEyep7yIouz3G1qjz7wm0mLyNqbMJ fOmxBQYc7vjtT/2e8Nsoi1Og3nE6OsD+5sM4A7sbU/QN5f30S8mllDVwsC8bGbi3/vRJVJ O2BDlT8+plMJNeQE47pKItoKKlnCgQs= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-99-ctRclkxCNOec-9EKBiEquQ-1; Thu, 01 Aug 2024 09:34:50 -0400 X-MC-Unique: ctRclkxCNOec-9EKBiEquQ-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-42820c29a76so30982675e9.2 for ; Thu, 01 Aug 2024 06:34:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722519289; x=1723124089; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=7VeraTL2UmLwQLKRE3xd5PLNoj7213HAaM5a3WpSzq0=; b=S46E/ybSYyD1kGBx7jv/v9KpTda6z/4t5wXhVBx6yzv1QbF4OwjWeNOMDUzLIbyM2L gFwaCk8YBb1zPrxJ1f52m4dCfY02LSSoTz6ghsO7l11mWUrYuSNw2hCDDnDUDJDdQ2cA o1P0/u6IprSFHMOQS3MJMoLwdoiWLp0bv6OeI7S/l+fzNVlStL70GCDqJxl4VqWmO1VX GiSmu5ANGgDCUkaEv8L1fqPZQtG/ciKUD60yKzJPhhsMs/N57skRRAmnyHVBT/hSupkE 9AtCISDwvv618LsXa57Un3eI//PWHqE+TV/4MhRZ0EE6Dq8zjwPguN2iMJnKbZMs1Ptu pLPQ== X-Forwarded-Encrypted: i=1; AJvYcCU97L7dLauDY4B6Ty0IheT64WBmvnBOuwg7s2zCLu0+OeJ1M+eTr4sLimo3/WRn32ZeZcljI5ayHw==@kvack.org X-Gm-Message-State: AOJu0YwT5JtYBRn2wXZPdWKnCUyjsUgv56AKOO7ExYYs/vmiooq8RWZr GpvKp+7zjHTlXSWoFaULKYiXR3GmTeSZ2HkFLzAkUZ36Y/Ahh1g/NUb4QQ0YFW50qq3sIQ6W4gT dhF0qrB4vcyLHVq+73bGcGJjVnt63kXp5JhEzuMjWsVXt2T1Y X-Received: by 2002:adf:cf01:0:b0:368:41e0:16c0 with SMTP id ffacd0b85a97d-36baacc9cf4mr1699713f8f.22.1722519289200; Thu, 01 Aug 2024 06:34:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH/SOOHnHhQ5pnvHku631UHMTVOde3FFGLZS0ii1teG5jLkSNlSy6IqxyN2GNL2VavXkLC4Wg== X-Received: by 2002:adf:cf01:0:b0:368:41e0:16c0 with SMTP id ffacd0b85a97d-36baacc9cf4mr1699680f8f.22.1722519288671; Thu, 01 Aug 2024 06:34:48 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:5c00:e650:bcd7:e2a0:54fe? (p200300cbc7075c00e650bcd7e2a054fe.dip0.t-ipconnect.de. [2003:cb:c707:5c00:e650:bcd7:e2a0:54fe]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36b36857d66sm19403937f8f.83.2024.08.01.06.34.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Aug 2024 06:34:48 -0700 (PDT) Message-ID: <5a67c103-1d9d-440d-8bed-bbfa7d3ecf71@redhat.com> Date: Thu, 1 Aug 2024 15:34:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [linus:master] [mm] c0bff412e6: stress-ng.clone.ops_per_sec -2.9% regression To: Mateusz Guzik Cc: "Yin, Fengwei" , kernel test robot , Peter Xu , oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org, Andrew Morton , Huacai Chen , Jason Gunthorpe , Matthew Wilcox , Nathan Chancellor , Ryan Roberts , WANG Xuerui , linux-mm@kvack.org, ying.huang@intel.com, feng.tang@intel.com References: <202407301049.5051dc19-oliver.sang@intel.com> <193e302c-4401-4756-a552-9f1e07ecedcf@redhat.com> <439265d8-e71e-41db-8a46-55366fdd334e@intel.com> <90477952-fde2-41d7-8ff4-2102c45e341d@redhat.com> <6uxnuf2gysgabyai2r77xrqegb7t7cc2dlzjz6upwsgwrnfk3x@cjj6on3wqm4x> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <6uxnuf2gysgabyai2r77xrqegb7t7cc2dlzjz6upwsgwrnfk3x@cjj6on3wqm4x> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 75B33140017 X-Rspamd-Server: rspam01 X-Stat-Signature: z8rfcjep576nnsnj45gm48egxecfurqu X-HE-Tag: 1722519292-33014 X-HE-Meta: U2FsdGVkX18aOsRX58qz08aMyHvHD2EjVu0iYwx4fanzjJe6mK/Dihhel3vMH9sMhLWir8dt1s9fE4C4c23Bj0Gnd+P0ycaNFaJcCmXLO29OOCmlRt1Pakh95460szxh9pi38C9SJMFo2C2P5D3xGvz9u4VWcMttQJml2K00qrpOXA0OhIYbjR/xL8KSRxYZ4BHW5Voh3BhUL/2HL7ugTY3nrvZ8WmQcRJEIpClaMnFaKN4dvo1k4jxKJUSljZ7K3AUbqjz4H1jeR7UVz8fIEjybFI7/viFsOiKWOKOHcBzREsdWSkvDL9GFKOGnnob0ThlkzPpbfSdnXrG9iSZ3WHz3LaJI1gxoexFXhR6XvknNAuAQH46uI+GYnRpwAnkHBY6/utde2it7TD9xFOw4ahIx1Dh7+inGQNkW6mnBbjp24CdEfFjooe632IKjtC/4QsNxX0D+kzECXnBUBsVhN1ugkXHYgRyblaXL8PvYtc88UU5Yq0Sp6jnIXhCLh3Cv91OFmVH6WrSfgA05Yed3b71wfcfa+Aa6UuCdHmpHPsUT7QZrihLznWYuJbkF0c9QPuOOI+qqXV4udzX7O9DlNSpEVIYUYF0iOUZoOjMd2yBmhfDBl3q2i8lZgnBefkAZIdJFs4Cz1ghSm8iaZgVCGq53nWijAlXbyyVZI95YEw3ubAputGwyX17mb1Uq2E6szPY2qmE4sGnIbdQsgZbfhSTNNf/9ooq2jc3fVRqA7+9wIFTBTKcpaaoyUi5Kitt+SW8WGIxsxz1PsMKObtS77oaOBEyCYm3Cuq0U20+kFtmw24kfNwUPN9HP0EggCazpgL6xMxa8i7eXhcKTG8UJmulfOcE6zrZOGsYKKHXDr1x4lwwBlGswYqmIF+Tuib8JtEmhWgb6mWZNs5Y9Bl3G83ma1JcM+yLcnkXT1qMjotxppgxO703vCDGV37wJ8ZLM12c/UgG6CgorLPP5VT2 5uXk0MGw XKhc1oZDCRtRg/bLR75ukwP6QvThjV2ID8D25vl/Fy785pEwsmbVolF+MFhEQPDL3Qz+wy4onhgiDiRHzjCt2QMVJ+HlHoGZUlgfQ6X2k3jH6yYtDNLErn4H+4MS+ncz6dcTXbylfMIoyWfkMG2u5hVvej4hsLaCH0nySoeho+2Ua0WSlkWNWWa4x+DcthfTl7zLASWL96xy5Gmk+11qPWUwqZJg3M3zNt9xnvXcIxaaG61otxadmmAjYfYUJImUXF7lwFZBWtg81kvcoe0Xru2PL2ozCPzPK1oZCXtKvjeFm97nUl+osF6ioYyQAyJgELm7r6BJY02Pt19TplhShCVTKGiYqGJ4cCj35voYTO+zURk93F/xkCmyuH8SGL/VZtjfQSvIxKRsXTT60l8BZKqdsPnoLBT2mfcUoJH5kip4pHEY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 01.08.24 15:30, Mateusz Guzik wrote: > On Thu, Aug 01, 2024 at 08:49:27AM +0200, David Hildenbrand wrote: >> Yes indeed. fork() can be extremely sensitive to each added instruction. >> >> I even pointed out to Peter why I didn't add the PageHuge check in there >> originally [1]. >> >> "Well, and I didn't want to have runtime-hugetlb checks in >> PageAnonExclusive code called on certainly-not-hugetlb code paths." >> >> >> We now have to do a page_folio(page) and then test for hugetlb. >> >> return folio_test_hugetlb(page_folio(page)); >> >> Nowadays, folio_test_hugetlb() will be faster than at c0bff412e6 times, so >> maybe at least part of the overhead is gone. >> > > I'll note page_folio expands to a call to _compound_head. > > While _compound_head is declared as an inline, it ends up being big > enough that the compiler decides to emit a real function instead and > real func calls are not particularly cheap. > > I had a brief look with a profiler myself and for single-threaded usage > the func is quite high up there, while it manages to get out with the > first branch -- that is to say there is definitely performance lost for > having a func call instead of an inlined branch. > > The routine is deinlined because of a call to page_fixed_fake_head, > which itself is annotated with always_inline. > > This is of course patchable with minor shoveling. > > I did not go for it because stress-ng results were too unstable for me > to confidently state win/loss. > > But should you want to whack the regression, this is what I would look > into. > This might improve it, at least for small folios I guess: diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h index 5769fe6e4950..7796ae116018 100644 --- a/include/linux/page-flags.h +++ b/include/linux/page-flags.h @@ -1086,7 +1086,7 @@ PAGE_TYPE_OPS(Zsmalloc, zsmalloc, zsmalloc) */ static inline bool PageHuge(const struct page *page) { - return folio_test_hugetlb(page_folio(page)); + return PageCompound(page) && folio_test_hugetlb(page_folio(page)); } /* We would avoid the function call for small folios. -- Cheers, David / dhildenb