From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FA97C36008 for ; Wed, 26 Mar 2025 14:54:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D1A028008C; Wed, 26 Mar 2025 10:54:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 459C3280088; Wed, 26 Mar 2025 10:54:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3226728008C; Wed, 26 Mar 2025 10:54:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 10B6B280088 for ; Wed, 26 Mar 2025 10:54:33 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 592C0140724 for ; Wed, 26 Mar 2025 14:54:33 +0000 (UTC) X-FDA: 83263998426.17.B33284D Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf09.hostedemail.com (Postfix) with ESMTP id 7150C14000D for ; Wed, 26 Mar 2025 14:54:31 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; spf=pass (imf09.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743000871; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FwgZQtPkOLtb0xChb4D3pCq0xHrRPfr9yUxlDmlpYbY=; b=HRSWQr1XMBU5mbpSWBvmz6MY3tD8KyPKQo/SJ0nptgKb6Rnri1/H7K+x/0DlSOMCtopB5A QiRVAa4+j3xhSM0/2q7twHbbZsZofMoEzp4lJQ9tiVQYQglrnDRyGLKJe5Aykv30d5w4Eh 9Vom4UzHNX0oWr9fQODBuH76QzK44tk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743000871; a=rsa-sha256; cv=none; b=fKqyr0HgHnELbLL0vbru/zhTUupCSBDWHPZ0L9YBgaEPMNOyDxuZMFn3hVjMRF+G7huM6t i4YzH/rWndDs5Rfv0bUUqzyyqw1thVmTmUUOzoEjgLJUS+2z0ERAAVDNA+WLUjZYzNdNJG NHidNvOjzpiQGlrsNZF1++1SBwl842g= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; spf=pass (imf09.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F099D1424; Wed, 26 Mar 2025 07:54:35 -0700 (PDT) Received: from [10.57.82.15] (unknown [10.57.82.15]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E974F3F63F; Wed, 26 Mar 2025 07:54:26 -0700 (PDT) Message-ID: <5a5f22cb-1bd7-4dcb-85cc-f412de79b87b@arm.com> Date: Wed, 26 Mar 2025 10:54:24 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 03/11] mm/page_table_check: Batch-check pmds/puds just like ptes To: Pasha Tatashin Cc: Catalin Marinas , Will Deacon , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , David Hildenbrand , "Matthew Wilcox (Oracle)" , Mark Rutland , Anshuman Khandual , Alexandre Ghiti , Kevin Brodsky , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250304150444.3788920-1-ryan.roberts@arm.com> <20250304150444.3788920-4-ryan.roberts@arm.com> Content-Language: en-GB From: Ryan Roberts In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 7150C14000D X-Stat-Signature: q5ja14khof7utqd9y5ernomucww9fj39 X-HE-Tag: 1743000871-79417 X-HE-Meta: U2FsdGVkX1/f9dyCuOBx2NJtS5IO6G2n5n8F8WHk0C5Ux17NZYke5fb+WTFicv0SO3HhwPE2QUcgTAHjoD02g2RBuwxltZ9YECDiTvdL4jWNPOfChdR9QK+1YQJLOK69XSDPIs6mKu4gWpjgqWlgRN3H0wluprm2M/9LIQK1y/CdNKG3cyqlmeku9izQ4yR0Eye379jMU4nLyM1TLY7wVb5uKfX12N/iffoY0z7A4tgrvQAtcb4CFKybYgwdLXnXkZR+uOWO+fAnd5F/aXeSnp0NaXCtJgfXSqs1PoY5INKjXTL9LqHyme2kqFtetCwY+L7xQ1yKi15BxZ9fykqxLpsXcqHI149wxZV5vJFr+7BTrrHY6K6MbTXCkrvwkya+nOfWHADbRoPRrZzxBbD2hBwASQGpHoPH3rRiw1eHXltAe1rPdW8z66BNzuo75gyGi2Se9xkNBW2l7EPGiHQXa8K4600EkS3tH7sYAQ6yxCWqYp6am/LxBHycuYCuGx+yl8HsFFrZe/TOmT8WUYJT9mprr+d0reaAuWqScgadZ/vkEyPIDlBA/U4ld9U999sHno93fcEGPvGqvuzK0PNhk5ery58TJKU7a+KZsGV5kk2Jk50pyXBb7m62rRCqNZUEKUjt1kT7zi7Gp5Bg74n5Hrs1bzXvsK6BkcIWW/BGicRjWbrxl0YJPO+I8BAm0vhybIpLjbiXBKe+sC5+Ipc1WnsASqZYfI+oHfRya5YIIsgX8Bwl2OynaNqnN5iEG350SOLB4AmtrrylCSNfoIMh2SmUTgU4GBPn26BE0ImAHZtnnz5fbPvVPfp/aNHiW9syV+En9ZFePTW3qKnYla6v/SMvqvWU1sS6Kw0qFr1HqGR6cJFcnuoIOAB9TTj5pAdPKVDj37perDs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26/03/2025 10:48, Pasha Tatashin wrote: >> -void __page_table_check_pud_set(struct mm_struct *mm, pud_t *pudp, pud_t pud) >> +void __page_table_check_puds_set(struct mm_struct *mm, pud_t *pudp, pud_t pud, >> + unsigned int nr) >> { >> + unsigned int i; >> + unsigned long stride = PUD_SIZE >> PAGE_SHIFT; > > nit: please order declarations from longest to shortest, it usually > helps with readability. (here and in pmd) Noted, I'll fix this. > > Reviewed-by: Pasha Tatashin Thanks! > > Pasha