From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 091D0ECAAD3 for ; Tue, 6 Sep 2022 01:07:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 997B680242; Mon, 5 Sep 2022 21:07:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 946CF80224; Mon, 5 Sep 2022 21:07:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8362880242; Mon, 5 Sep 2022 21:07:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7603D80224 for ; Mon, 5 Sep 2022 21:07:22 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 51AB6120F44 for ; Tue, 6 Sep 2022 01:07:22 +0000 (UTC) X-FDA: 79879872324.11.F5AE5A1 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf23.hostedemail.com (Postfix) with ESMTP id 431DF140077 for ; Tue, 6 Sep 2022 01:07:21 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4MM6Z05knLzZchG; Tue, 6 Sep 2022 09:02:48 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 6 Sep 2022 09:07:17 +0800 Subject: Re: [PATCH 2/6] mm, hwpoison: use __PageMovable() to detect non-lru movable pages To: Andrew Morton CC: =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBICjloIDlj6Mg55u05LmfKQ==?= , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" References: <20220830123604.25763-1-linmiaohe@huawei.com> <20220830123604.25763-3-linmiaohe@huawei.com> <20220905052243.GA1355682@hori.linux.bs1.fc.nec.co.jp> <1f7ee86e-7d28-0d8c-e0de-b7a5a94519e8@huawei.com> <20220905071542.GA1364147@hori.linux.bs1.fc.nec.co.jp> <20220905145322.42d218d0d7d32d3c5f515027@linux-foundation.org> From: Miaohe Lin Message-ID: <5a4fd4a3-da5c-5e83-c36b-4de0d9dce903@huawei.com> Date: Tue, 6 Sep 2022 09:07:16 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20220905145322.42d218d0d7d32d3c5f515027@linux-foundation.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662426442; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NXth5h994ur+dtEyFIG86zjvBDJ7MvehqmdJ5iiDAHE=; b=S1F76nq3r00y1cVnZ6fOZIbDjYQ6pFpiN239PNO12rphUC+ZtK2+084ep8s3l3LEbki9i5 wexr4yNRY3Afgx1n55tUhsyVY35bb0y9ZtAQ2zW0OBjtk2AAaNBIhuh+C+BZbnw9b46Evi rDClwEph5PAgd8/ejuvG0EQcivntlhE= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662426442; a=rsa-sha256; cv=none; b=l38PYE9Yst1pf/wCqMtgyN2kJLcnIMTugXQakQOs+Rli9EkUY9NoH00h4hGLbJ1c3pNeC/ v7zgq8h8VJzsuNgeSSJHDiN6lZdifN66Y+I6UaTs6VwcdITmKppj0FffaMYTiqX1fiA3pT SzTwGpJ2THG7IFA8MZevAaavdB5bPPI= X-Rspam-User: X-Stat-Signature: hshssynias6o5unga7uixxm871ky5zw6 X-Rspamd-Queue-Id: 431DF140077 Authentication-Results: imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspamd-Server: rspam04 X-HE-Tag: 1662426441-389945 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/9/6 5:53, Andrew Morton wrote: > On Mon, 5 Sep 2022 15:29:34 +0800 Miaohe Lin wrote: > >> The above code change could be applied to the mm-tree directly. Or should I resend >> the v2 series? Which one is more convenient for you? They're all fine to me. ;) > > I got it, thanks. Many thanks for doing this. That's very kind of you. Thanks, Miaohe Lin > > From: Miaohe Lin > Subject: mm-hwpoison-use-__pagemovable-to-detect-non-lru-movable-pages-fix > Date: Mon, 5 Sep 2022 14:53:41 +0800 > > fixes per Naoya Horiguchi > > Link: https://lkml.kernel.org/r/1f7ee86e-7d28-0d8c-e0de-b7a5a94519e8@huawei.com > Cc: Naoya Horiguchi > Signed-off-by: Andrew Morton > --- > > mm/memory-failure.c | 16 +++++++++------- > 1 file changed, 9 insertions(+), 7 deletions(-) > > --- a/mm/memory-failure.c~mm-hwpoison-use-__pagemovable-to-detect-non-lru-movable-pages-fix > +++ a/mm/memory-failure.c > @@ -2404,24 +2404,26 @@ EXPORT_SYMBOL(unpoison_memory); > static bool isolate_page(struct page *page, struct list_head *pagelist) > { > bool isolated = false; > - bool lru = !__PageMovable(page); > > if (PageHuge(page)) { > isolated = !isolate_hugetlb(page, pagelist); > } else { > + bool lru = !__PageMovable(page); > + > if (lru) > isolated = !isolate_lru_page(page); > else > - isolated = !isolate_movable_page(page, ISOLATE_UNEVICTABLE); > + isolated = !isolate_movable_page(page, > + ISOLATE_UNEVICTABLE); > > - if (isolated) > + if (isolated) { > list_add(&page->lru, pagelist); > + if (lru) > + inc_node_page_state(page, NR_ISOLATED_ANON + > + page_is_file_lru(page)); > + } > } > > - if (isolated && lru) > - inc_node_page_state(page, NR_ISOLATED_ANON + > - page_is_file_lru(page)); > - > /* > * If we succeed to isolate the page, we grabbed another refcount on > * the page, so we can safely drop the one we got from get_any_pages(). > _ > > . >