From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A43E2C36010 for ; Fri, 11 Apr 2025 08:15:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 44354280187; Fri, 11 Apr 2025 04:15:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F29928017D; Fri, 11 Apr 2025 04:15:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26EBE280187; Fri, 11 Apr 2025 04:15:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 076B328017D for ; Fri, 11 Apr 2025 04:15:49 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 38AB68219A for ; Fri, 11 Apr 2025 08:15:50 +0000 (UTC) X-FDA: 83321054460.03.B6A67F8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id D9E5CC0003 for ; Fri, 11 Apr 2025 08:15:47 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=azQtzDFa; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744359348; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ivVEpFmmqTmXbovQzDT60ia4DtfARluaUZ+HrEwHddc=; b=ywHEk5bkfqVXCuuODomJxiIUfdipl38Q+MT6fGSPWYnTtg2q2a2QluCMjN8BJYWC50x1Th 77jpXGdnW4/BiJYGrH+kwAV8poRpb5PhTYPa/VFPZ+Bn7awlwCG+gHU74nMt5IzOOvzSzk itpLCMZMy0tMfAWnR9zAj1qYeo5AxUE= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=azQtzDFa; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744359348; a=rsa-sha256; cv=none; b=3CPeKEYy5+BgbbVMcmMhjCoYDvKYuAgobDe1tglMMRVLqQwFOoStpK9Fmn+TalFYChc6BU AiPST+ZB8m0zU492NeTFADR2zXWmfzfyOj3aJlsIKdxTyx2FAT0HwNAukpWMC//wLeE5QH eR5BXNuAAVztCrn8r4SoC4m8X8rkvg0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744359347; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ivVEpFmmqTmXbovQzDT60ia4DtfARluaUZ+HrEwHddc=; b=azQtzDFaA1zHhzDREKCuHkIilnFGajcV0npmtPXHtY7G46DjsY9fSFoBWHbIehe3O4n0Ir 8NxbaQ35v8nn1Xgl9tHFyFptrF8BgTVm80C9TDFi9YfUoChBhz79fLololJJ00i7CaY3fr hc+ZN21CHx2hQeWl+pjV+g9HM368jOQ= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-321-t0pyfoZJMnuGiBNGg3vvHw-1; Fri, 11 Apr 2025 04:15:45 -0400 X-MC-Unique: t0pyfoZJMnuGiBNGg3vvHw-1 X-Mimecast-MFC-AGG-ID: t0pyfoZJMnuGiBNGg3vvHw_1744359344 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43e9a3d2977so14035015e9.1 for ; Fri, 11 Apr 2025 01:15:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744359344; x=1744964144; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ivVEpFmmqTmXbovQzDT60ia4DtfARluaUZ+HrEwHddc=; b=eLrcGcEkit/wk6HwUMXhl8dYp69crsbUFhXUkaemFEjPQ4jl7kPc4Df0seT7rfW8gI WxphsErbRzIxVuZYzBZPFnBI9PhvwP5jVNj9RfHJ0zow446baxfYNUDjKyLeC54hQleV ll/aCfuYidFuk8aOwxXskGPwjTqSdW9hQ42ARSdfb4UchlmSNv/2Ng/rRTFfPpg9nPt5 OTeEZb/u040CH+k2gyF3PuNXBh+svZuk+i4LOiVPz8+UaR+2H82pOB6bxu4qAawgTTw7 y2VpvfKy5ySygMyiiH+HIBqOv4d79ixRqe7WRbKyCXOKGUZeqCubtJ3mfUpNMAxRmXdH f6EA== X-Gm-Message-State: AOJu0YxKnievG6kIgP0GUamnGfFhVougOfmHcsdcJ3nYOe69MuqAfOBG PsNXrJ76g6Hre4Bxkhg3VGkXbCaaA1L9zkkoQnwbCOrayE07WBv87mI4M6bfIHax4BrgVWi+BQj rGNeh1RiVnDwQ9GZpG4FfiJTVq2m7D5AVzBXYTXWuXBTCNSG3 X-Gm-Gg: ASbGnctR1MXXKbc58y0tKwZiRV710bxmX8EHxgJiOp2LpVmvRtnU134aGGd56tP23NS hZbaqXbm7Lrc1Gh3d/I5CJ5525UXrdVx9ccr2W+P7Q+Z6YuwprJFC/fWHZRGyVlQQqjLIYYcmuc dqUrOzdy5n3pS1hQ7Xr90gNOWB1dBP/DhStOQsVB8YGs5hu6L3Y2UwarC/g8306ARdpV+vzGcIx Sdr1VSR9CcTwtoqpTi+92ImezAR0922W7F9IiTbNXnLVp/fNwbcdIMPeGWJMpRYXEFzVqhP9JCG +S7yDF0/HMjo2yRKqFWMxNrwWEVqHHpA83kxrd6/Y9rx5g4GRq87o8N9sDMbBx9fyq9AFWVS+I1 rrHgAygMaEpUuB9FZ0JL9usVomSizD5qMY7F4 X-Received: by 2002:a05:600c:3848:b0:43d:988b:7732 with SMTP id 5b1f17b1804b1-43f3a94d9bbmr13972005e9.14.1744359344319; Fri, 11 Apr 2025 01:15:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHYbwrYzF5ACvieHvZ2EasQcPng/7b1Zy3Ik2suvtSEqmT/HL1se3+khlqkbA4OGA8iyPfXvQ== X-Received: by 2002:a05:600c:3848:b0:43d:988b:7732 with SMTP id 5b1f17b1804b1-43f3a94d9bbmr13971715e9.14.1744359344003; Fri, 11 Apr 2025 01:15:44 -0700 (PDT) Received: from ?IPV6:2003:cb:c726:6800:7ddf:5fc:2ee5:f08a? (p200300cbc72668007ddf05fc2ee5f08a.dip0.t-ipconnect.de. [2003:cb:c726:6800:7ddf:5fc:2ee5:f08a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f20625ea4sm79131475e9.12.2025.04.11.01.15.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Apr 2025 01:15:43 -0700 (PDT) Message-ID: <5a37ec06-ff98-475a-8998-0330dc8073c0@redhat.com> Date: Fri, 11 Apr 2025 10:15:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drivers/base/memory: Avoid overhead from for_each_present_section_nr() To: Gavin Shan , Oscar Salvador Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, adityag@linux.ibm.com, donettom@linux.ibm.com, gregkh@linuxfoundation.org, rafael@kernel.org, dakr@kernel.org, akpm@linux-foundation.org, shan.gavin@gmail.com References: <20250410125110.1232329-1-gshan@redhat.com> <9deb3725-8991-43d1-8c3d-56523fabff28@redhat.com> <44dff493-9d79-4343-ba81-0c262d7a5b4e@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <44dff493-9d79-4343-ba81-0c262d7a5b4e@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: a2Plf9WHQAxE3jInCSPSsXHb_YTOdRLtpoq_AL7YbQE_1744359344 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: D9E5CC0003 X-Stat-Signature: 7jo1yoq53f9h56caqhfxnuz69gutaqdt X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1744359347-484724 X-HE-Meta: U2FsdGVkX18gx6CqmiEiMBAWxPWYZDIZRd50OlCVk5KAIvmgNLEyI2pLwiUIvDWDUs3l3zkHK2vAc6FsEq60psdP9DDglwtfIokKeBkzTMEAAe6b2BBwtKhye+xBCd60WPOI2Rao3neIS9ysX1IocBnFmwktMOZowOZ4O3qHk+4P8wQQvstutbBhNkDBUSYUFzUVG+B26xpPMaattkTLCZXmnduwkAd/bhxnjBWe4Gmy9MEhKk5ioIsuVax6fh2Sp67/beLWpi2eQ+EzYhZOSIVULCWI/39UJGK+ZpWFUHO6/tpIpOOcOs//uHYGP5heVI8AIABaMRw90fYOK+KVsxmvaJLO+Ffdu9F8mW7egN+zxdXGVNJhcJnuNt3w6d4J9jVgBuzRjClFgEMI+ThyYf5n4BDZJ+xdcxwZXEesz7lKPQzBku2SJ69xkxZVVb8x4DixrxPSNmsLV+yym0MYRvnlQ/8dRJvUs8d2IgbsbV9TBqSRZHH6LZQ7BSbnlBqR4YqZ1OcnOePzU+YnWrFD8/uaiPm9JBnghD5D131A1yKkZ6rWQOpTwOW0bm2UeLrEK5a0BvlS1mBNZzzZ8zcalpEPcKcuOHOo/IneoaIr/ksbe1eiEH2Nacz/Ajuw5gchBBjzIiX+yNLm8ruyEdAgf/QcgtJ6Unx1+MaN3EmGI5lCMNEXpGDuJ9VdJN5D7lKCHrBDpoWBnowZEUY8bjXu0T4kttfsiSBOiBZondD/RsNg56MDqVwcI+dbA5EdH+ApJflOZBvq64XzBLMGmOB8az/bJ19Pck8YPQn+fbz6msxSBZL5pjmpYYkVrx/OdvstpRIO6qCnpnRYEMZyrG460VgugXzZXSHvDGJDAx+1KZExoT3z5w3PSOhfcDNgEKCuhSSIJVpWqnV3nG0USEg/Dj3Zzp2DerHoFnQBDGsYemssD7LMDvxDMM4YywMTt4tylbseI9TnTr7bF8+P8BS z+MHZzOy g/fwAGnC0YMdLiAAcBgqpWICIBUZSwEEDKVI91lSInD77mDN9/yvWtiLrkKq1PFQhKOXylNs0p46HpUaqBZrmQTUUPbhmFUhtz93EvE4oSp5EwFofeeODr2LEFFd0IgDEDGREaB8jduj5xMozlH09+gy8nGYDq9doo8pZ2gtLfqNyEITv5g/zDPn9YJwSIrnhDxTC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11.04.25 07:04, Gavin Shan wrote: > On 4/11/25 12:25 AM, David Hildenbrand wrote: >> On 10.04.25 16:12, Oscar Salvador wrote: >>> On Thu, Apr 10, 2025 at 03:55:19PM +0200, Oscar Salvador wrote: >>>> All in all, I think we are better, and the code is slightly simpler? >>> >>> One thing to notice is that maybe we could further improve and leap 'nr' >>> by the number of sections_per_block, so in those scenarios where >>> a memory-block spans multiple sections this could be faster? >> >> Essentially, when we created a block we could always start with the next section that starts after the block. >> > > I think it's a good point. Tried a quick test on a ARM64 machine whose memory > capacity is 1TB. Leaping 'nr' by 'sections_per_block' improves the performance a bit, > even it's not too much. The time taken by memory_dev_init() drops from 110ms to 100ms. > For the IBM Power9 machine (64GB memory) I have, there are not too much space to be > improved because the time taken by memory_dev_init() is only 10ms. I will post a patch > for review after this patch gets merged, if you agree. > > for_each_present_section_nr(0, nr) { > - if (block_id != ULONG_MAX && memory_block_id(nr) == block_id) > - continue; > - > - block_id = memory_block_id(nr); > - ret = add_memory_block(block_id, MEM_ONLINE, NULL, NULL); > + ret = add_memory_block(memory_block_id(nr), MEM_ONLINE, NULL, NULL); > if (ret) { > panic("%s() failed to add memory block: %d\n", > __func__, ret); > } > + > + /* Align to next block, minus one section */ /* * Forward to the last section in this block, so we'll process the first * section of the next block in the next iteration. */ > + nr = ALIGN(nr + 1, sections_per_block) - 1; Yeah, that should work. -- Cheers, David / dhildenb