From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CD55CD1288 for ; Thu, 4 Apr 2024 02:56:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 023716B0087; Wed, 3 Apr 2024 22:56:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F15D26B0089; Wed, 3 Apr 2024 22:56:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DDD156B008C; Wed, 3 Apr 2024 22:56:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C15C26B0087 for ; Wed, 3 Apr 2024 22:56:04 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3934F160DB7 for ; Thu, 4 Apr 2024 02:56:04 +0000 (UTC) X-FDA: 81970335048.03.9C8066E Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf17.hostedemail.com (Postfix) with ESMTP id 3CF1940009 for ; Thu, 4 Apr 2024 02:56:00 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=DOYOq1kt; dmarc=none; spf=none (imf17.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712199362; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b2H16tqCkJ6i90mQLPDpV1ZsYZDW4KEWWz9R9e+0Oig=; b=pqbwChu8gF0T2W79IYcRX/jSUJUhde2QS8H+D4HWQ7ZotTuBdeuv+FcWP0NKyjeGwzZ2Yn ZSEPzXsxcQp+ym6duWuvpEuxbNhCWYPhVXfa0MBXiGmcVobGDdBU/t5pHcS7iElRSq7QCA A2QZeUyx4ViAjHMhflu5edneMhUQ4Yg= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=DOYOq1kt; dmarc=none; spf=none (imf17.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712199362; a=rsa-sha256; cv=none; b=HIjVXoG2vrGUXU2Wmq1NmGjqmMVOS2g5seXpL2131bmITSfiYWNLbKpKwJK2IEtdEP0CO4 AlC23DPhnMHHuU5B+ENms+02oYvcosUq3whWZx8hLyBBgi84JDfbPG4TJkDR18/8GCdcg6 JE3AzUJ+YmSCyLx6mo6USTkONRdp22c= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=b2H16tqCkJ6i90mQLPDpV1ZsYZDW4KEWWz9R9e+0Oig=; b=DOYOq1ktip9OrPqyMbwDoNqDtq VB6HauYA/GGMAstDHOFp3X/FsrrMKv6YfXGD+QUD67yFNWCAcxzrPxwIanfV6S3L97X/TEZcue6x1 DEi6bN9guWRaHhck/D7JnDVcfH/ggNwDsVGjKVdBzXBBK0zM3jPjOcv259vAlag3vudS0kmURSzoM aJYzWCso5E+7of2Er2nfWcoIvHsHbXLcHILwObAIYPaSB1QJuojxjuRFiDBF8ddzqHDVt2GWbVL/+ xR+0t7YyOlbaQgK6MbdXjKGC7weqzQ++wCpmLrtM1OisyiYiLNHGQ3qfa4nDy1kb8yHh9fC1vn6Yz GUTgK+bw==; Received: from [50.53.2.121] (helo=[192.168.254.15]) by bombadil.infradead.org with esmtpsa (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsDGA-000000012Up-3OOS; Thu, 04 Apr 2024 02:55:27 +0000 Message-ID: <5a349108-afd9-4290-acb6-8ec176a80a84@infradead.org> Date: Wed, 3 Apr 2024 19:55:22 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 01/37] fix missing vmalloc.h includes To: Kent Overstreet , David Hildenbrand Cc: Nathan Chancellor , Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, dennis@kernel.org, jhubbard@nvidia.com, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, songmuchun@bytedance.com, jbaron@akamai.com, aliceryhl@google.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org References: <20240321163705.3067592-1-surenb@google.com> <20240321163705.3067592-2-surenb@google.com> <20240403211240.GA307137@dev-arch.thelio-3990X> <4qk7f3ra5lrqhtvmipmacgzo5qwnugrfxn5dd3j4wubzwqvmv4@vzdhpalbmob3> <9e2d09f8-2234-42f3-8481-87bbd9ad4def@redhat.com> Content-Language: en-US From: Randy Dunlap In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: f4xypfgm3p14ju8fz6t5zmdxbun7ras5 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3CF1940009 X-HE-Tag: 1712199360-866927 X-HE-Meta: U2FsdGVkX18IArycCkenYF0WR1dNCimybVL1ZivHAneQRXkNCB9V4ck49JWUab2cJTk9xO2oxTJBqxdRU+dKAdrlUtFdYl6ngDFTyb3DIbzs7NNDGJ1UpDUonjNVaSuEKE6Md85SBhPaRBCXL4+tNL5CgFscnKXvPzhqr/7Iv56KfZkR/tnCZpZt3Ul8tPIx3Tb46GXlHcpJba+EVBwRczkCAE+mY3/dPre/mGLcBK8FKoIlqn2MktSWjKOoa6M7yhwZ4Q6pcjaYM+Mb4/xyome61IefG/Q2URwgA8te6+1LH3XC0p+kG+6VCfv6nBo8fzVew0XDVz3lvumZHEZ69uugK9cOyKHaQiXjro+wwq9Lp7lpzVlrmdVfOWWsAeXMG9If04zX0Od6IUA3CkeA1iUyS4VCzpkrMcsilW8cD+53Giph6fJx+ta0gInJv4yC8g/i1yihwYCMruCah/TX0AJicody/c7cUsb3jAVanTghGY4mbcLyBC0nSqYbIdG+vzZGfrvn4m/IPBQyuM/PlCej1iySyl1CZiAQKASvvjygb9dQzmtRrME0Shf6q6lEMiuB58S7fujSFK9Z8AOjIknNalN5GblWbOoLuc2JM6u8Y4Wou3cK+pnhO1GbUn2G3H8Gvnb47NC73Qqfn6KEJh+ZCm5ruxuVr1Xcv59hC6OVuImV+k6RcnejiOTBVYqmVkpIt7iv6N3Qokorihpe3TxlQ+EIa8d6m7RhNni+XJf8tO3ThXB29lRrIBoJhBXXd0/Hn6NNMky2GnmKenwFHIIwP9HHncEDA+o21tCgpmoBPp4pQbpi3V37qVOLnteS4quseVBIEOS3DvVCoxhjUJdQIJePRWxYlRsi1ETR6S93N/dCur+P1WX1PDiSqVtozafjL//rSPvYida7yT7znIe2FWe0BJtPQCAfrSnhJ7vTTv1sJluuuOEX/rqXcD/Xl6rsfL5kodQJqBH+EEP Vm+wQqPR oHCeAcxuhl5OzJb41/h/5NQrbAtj90s8zoEQM/6G8DrTsvPa7os3vhQhpg76S0ILha5+F0sAq7QvXBUlE/Onaq6V1xu+bCtEwkEs/g8qK4WpURorRW2JylTIyWTeaLlyLc5idCJM99IY8DTDg3V+DUNDbzX+cIPiD6rVSB3LoFDQcPDODfBEHZEAupcjU5cldT2IYvc3h9D+bMXoV1dSx7rEN5q7GaMvDVexH3CpsAweX0MYdUQM3k2iu38PUPgXxorqVPiku+vDuQr18lKzpL4YGFt6vI+2oI2JIt9jJzR/wVDBW3nWz9uq97Q2S9NMNGd4ygNTT8L/pL35WLKHbWMudafr1Q6Q3Kq3ixzOBEsc9rFPjkmbRFrT5A2R4sICqBupUlKZrs9qoUaSSc50FcXnDhVoncfH42+28+bhQxL3k+Tg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/3/24 3:57 PM, Kent Overstreet wrote: > On Wed, Apr 03, 2024 at 11:48:12PM +0200, David Hildenbrand wrote: >> On 03.04.24 23:41, Kent Overstreet wrote: >>> On Wed, Apr 03, 2024 at 02:12:40PM -0700, Nathan Chancellor wrote: >>>> On Thu, Mar 21, 2024 at 09:36:23AM -0700, Suren Baghdasaryan wrote: >>>>> From: Kent Overstreet >>>>> >>>>> The next patch drops vmalloc.h from a system header in order to fix >>>>> a circular dependency; this adds it to all the files that were pulling >>>>> it in implicitly. >>>>> >>>>> Signed-off-by: Kent Overstreet >>>>> Signed-off-by: Suren Baghdasaryan >>>>> Reviewed-by: Pasha Tatashin >>>> >>>> I bisected an error that I see when building ARCH=loongarch allmodconfig >>>> to commit 302519d9e80a ("asm-generic/io.h: kill vmalloc.h dependency") >>>> in -next, which tells me that this patch likely needs to contain >>>> something along the following lines, as LoongArch was getting >>>> include/linux/sizes.h transitively through the vmalloc.h include in >>>> include/asm-generic/io.h. >>> >>> gcc doesn't appear to be packaged for loongarch for debian (most other >>> cross compilers are), so that's going to make it hard for me to test >>> anything... >> >> The latest cross-compilers from Arnd [1] include a 13.2.0 one for >> loongarch64 that works for me. Just in case you haven't heard of Arnds work >> before and want to give it a shot. >> >> [1] https://mirrors.edge.kernel.org/pub/tools/crosstool/ > > Thanks for the pointer - but something seems to be busted with the > loongarch build, if I'm not mistaken; one of the included headers > references loongarch-def.h, but that's not included. > That file is part of gcc plugins. If you disable CONFIG_GCC_PLUGINS, it should build without having that issue. Of course, there may be other unrelated issues.... -- #Randy