From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A1FBC71136 for ; Mon, 16 Jun 2025 11:11:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D00AF6B0088; Mon, 16 Jun 2025 07:11:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CB1186B0089; Mon, 16 Jun 2025 07:11:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B790C6B008A; Mon, 16 Jun 2025 07:11:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A50A56B0088 for ; Mon, 16 Jun 2025 07:11:32 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5BE4F140F54 for ; Mon, 16 Jun 2025 11:11:32 +0000 (UTC) X-FDA: 83560998024.27.6D655BE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id E06C0C000D for ; Mon, 16 Jun 2025 11:11:29 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=i61a8DaJ; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750072290; a=rsa-sha256; cv=none; b=uKtyLUPgObpEmFkBiteGMYe/FInpwp3AQ938+m7WNvASQ4KvwlxyOUEGdaD9DGbyeXuCqV 3kZnQWQggG+vDJB+jXmT9Vksg3r1tlH1U+UaFNhXJvBB5NkD8ZLo/tgfdKW1JNXGS+oDAl MNrrVy/oWsaAHLxHQYaMUalkRNy5jKA= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=i61a8DaJ; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750072290; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BERX747lEinIdEXTdcIA4KAA7Mg7HKBQ4b7ZuczQJbs=; b=H6F+elgoZmGB03y3OTKO/9Nv1nAptK5zlKOhi5uyusw5n+Ue2Dre0KmvR4QNpoA0y63ehF 3BFWlfC/fwu3cZs4t/zCJ+gIKgn8EDptFLxJJr4Vavy9Uzh8+TfdgLV5DgGvF+2v33QwkH MImnzSSohGczhLJzO7CeI1B6K5TPERw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750072289; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=BERX747lEinIdEXTdcIA4KAA7Mg7HKBQ4b7ZuczQJbs=; b=i61a8DaJtfZGWyS92taC3p0obOu1zIW06yYOOlFMnk7xQV/ayeES0++fshdN69bYKGEU54 He90ZclrMNoMuJ1t4La5SdpdlMrEYQ0+qT+P5iaj2JLD5DIBtRirV4QLyS01pLkXBQDGMB 1/UsOMVXfmsy5qpFLZhn/YGN2KMkJs8= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-561-TAZa5cRUM_2p_oZmY1mK_g-1; Mon, 16 Jun 2025 07:11:28 -0400 X-MC-Unique: TAZa5cRUM_2p_oZmY1mK_g-1 X-Mimecast-MFC-AGG-ID: TAZa5cRUM_2p_oZmY1mK_g_1750072287 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-450cb8f8b1bso8808175e9.3 for ; Mon, 16 Jun 2025 04:11:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750072287; x=1750677087; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=BERX747lEinIdEXTdcIA4KAA7Mg7HKBQ4b7ZuczQJbs=; b=ZHtRjPXBfUOE9j7ANCwnrQAPTfKW3JyJokNgn1kIV87Af8mN7vv3jjJ3GCtHpvSL0D vMyR1PMTlbXeacLarhr7tYty8guUnvCUBnZU4gcve2dIiIBmUf6dYaW2glA3AT+lwiUe OmaXZ06pL6AiuS3ct6ltYcXMqGds3MbL2fqd6BbRki2+Cc+vF2+TvT6XigCENukS6VVC 2ff4/6Pa8NkdFapIC6ujUviyOsQRj+yxfCkTyWZ+acFrIeQgaMyOBlzrGQ5wQhkc5P8Y FZNpKk/l3VRNO7Kt5SikzBv33bBUeAoD3QkEP57EA3eaDpZCPjQxMG+ROuLC50iTUkOk Yhfw== X-Forwarded-Encrypted: i=1; AJvYcCXpZ69r7pUqO7pD2bcXk4tUO+tD/NuZ6kvk+fOaOcs26gA9Mrwn+DO+sNuWCxd+ouUKkSeLgtoTEg==@kvack.org X-Gm-Message-State: AOJu0YzCaihzVehMfOsGIxlXdoXbCisrsfhRxG0EzHRtHqZAIWNxEg+b 2v3o9+hLKnnrHURsiUM/jmZgEz+3QBSefzMpbmDgK6EIR79OWppbLndxDD1z9TUabQ97b76twhC wSaC1vQb47ZAyXIKFwn9qyFe8BOOjWgU8AHK6mYHp+5TBgGJRNqNY X-Gm-Gg: ASbGncuzw/K1YoIwvVal+Ti5yfHRjYHHHmyt2pB1EYYQnwvbzvd232zsmixL14t7uSA c4yamZwTV3wTHeSRLr0OnMfXzMPKZP03OHeYyYOUECTzLCZyPCKZ37apkINFZ5x4hWdQbqeNm3F dlWybjVIkMWuJUYi32iz9QICSX7M94tKAVYESYRupev/ggs5OcKaBTyy99R9093pxcJ0i006oBm mgXjGtb1UOtibeUpZeGX6J/JuU1Ny0Xv2tDPm8/5eDAu6TAEuIJD5VBsfYnPUcy+7F/kiaazb62 Lxq3NoYc9AB1SFDDbLSDQGJ377nY0SUsiQuXKyfMqZ5OufEL2WVzw9KWjmuTncstYUwC9A8f3vU 9N01Q5Ar72glx4UfktYUy3zxd3XTzwqTmlRn31g289PiEyvw= X-Received: by 2002:a05:600c:8b2a:b0:440:61eb:2ce5 with SMTP id 5b1f17b1804b1-4533cb488b5mr82128495e9.17.1750072286783; Mon, 16 Jun 2025 04:11:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEwywYqr0Arb313QzJn3MB1mjdrc64cA2pYWJ8AYs0j5Ak1u4ZO1B1Tt0fiAumeV4DVXw72Fw== X-Received: by 2002:a05:600c:8b2a:b0:440:61eb:2ce5 with SMTP id 5b1f17b1804b1-4533cb488b5mr82128125e9.17.1750072286381; Mon, 16 Jun 2025 04:11:26 -0700 (PDT) Received: from ?IPV6:2003:d8:2f25:bd00:949:b5a9:e02a:f265? (p200300d82f25bd000949b5a9e02af265.dip0.t-ipconnect.de. [2003:d8:2f25:bd00:949:b5a9:e02a:f265]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568a54a36sm10916076f8f.15.2025.06.16.04.11.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Jun 2025 04:11:25 -0700 (PDT) Message-ID: <5a331053-0777-4426-b0da-4d813cbe0a9a@redhat.com> Date: Mon, 16 Jun 2025 13:11:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 1/4] mm/mempolicy: Expose policy_nodemask() in include/linux/mempolicy.h To: "Huang, Ying" Cc: Bijan Tabatabai , linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, sj@kernel.org, akpm@linux-foundation.org, corbet@lwn.net, ziy@nvidia.com, matthew.brost@intel.com, joshua.hahnjy@gmail.com, rakie.kim@sk.com, byungchul@sk.com, gourry@gourry.net, apopple@nvidia.com, bijantabatab@micron.com, venkataravis@micron.com, emirakhur@micron.com, ajayjoshi@micron.com, vtavarespetr@micron.com, damon@lists.linux.dev References: <20250612181330.31236-1-bijan311@gmail.com> <20250612181330.31236-2-bijan311@gmail.com> <5a50eeba-b26d-4913-8016-45278608a1ee@redhat.com> <87plf43q6s.fsf@DESKTOP-5N7EMDA> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <87plf43q6s.fsf@DESKTOP-5N7EMDA> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: V6ILTvzEDM56V0xQcwt1fkWvZCln9dQVriitaBK-E60_1750072287 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam01 X-Stat-Signature: zntiziw57c65fpc5bc8tbsq95ajcxtjm X-Rspamd-Queue-Id: E06C0C000D X-Rspam-User: X-HE-Tag: 1750072289-493214 X-HE-Meta: U2FsdGVkX18+macQGWUz8k/DjweSV0MnfyZEr7/d1pYlSwVP+mLSFTS1dnYV4HoJGMuysfia+In3f5kFqE7BF5/E9t9QQsw4nYekN1hrZjU85rSkjNd1QjO+O+tNbvnZDlCEE2cYly6V+PwDtNkqqcRjwIE2g8BF4VIiMcIlzwrZTLOSyxYlYK4tQVWe6Cv6CJIk4/r79x88pWgTgfPUbdqJhjSl2GMcmdq3rqbC1g7wAOFEntO7j8nmDtJavUYLqCHY5H1Ol0vKjb2KfX3gyfEOmojCHoAbtGYPuiH1it8HpG/xWULTd2co19neAYYAu37VrHSJ7bfNeBZSQaHn48wcKhNIfDJGh07B4q4t3hFwB1XH2LtkF6D9JeYcUWDUx2D7X5Qu7hSc0XQSgbHdx/CP/Lcin2NN5v9YUQh+1HJCB/MOJG2rcH4Q3E6GzG+r8rT3drRHj6XMEoQU2C2ef3YBh0ujeX4i41UTy5FjvG+NfPzh1dk8fgDkQq0UiGz7zNxbcHUV8+4q7pgAxzpabpKgpuzsOg67LFbbwDXdr4m5yjyBoLAaxwzR6gJQCJbh8DkqdoOs86eZ1DyUMEGUo0KATvy8DsdTt8M4XEoPG+TlUWUZS2tLrmZ4SsTGqTdKmaV3UaAgw80cdvT/I9rmrWQ71z7mitjarbH5DJ3tbVPqAroNATlEZBzo26wUMZe34S4fiieodJllUzJ2jXqOF1/5vooKPcMeSUASbVkqkyFfjDJhIm/48g6iYxOU0bRp+HJySmLxMXvaMjFxy0wF7HkhP2Jy/R4OHaGor/5UGJkWcbib8ihYmQqobI3ZnDNE3kE+9bj2oMQECsVGrirVbP4OIfrqfCpslFSoYoa1teUAOKWwkyVWOslFYU7U41M/7FldDxtJdFwoMyg8p2n1W/yd1lcIvYtk0118uMBln1yxUO36o9EiqCEr4K8hHt7OGgX/dgwaEhj6YXHgolf y/e5x+pM U0yxLOcchDzWnb3EaVZ0UmgZJ4SLrZr/lLgSHygea+QFx7n16ATRF0mHvSY5K2l7A+TihcFX5iKYvMTkB1sbROJ0HaLC7I3ILwB1h+VI7h+U3LZi7ST8fWW2e9su6UnaPqADASSerhUtOeVqD0bW7QLiMIBNd0ttKWZ1rlML0FQpZ7Hc6aHI62x8b7vottqHVuo3B5ZZ4Hg4MFdDXI+jxx95MUIj57pzhBdKc16KXRdWWNiErxu3hqBpm65Cfl1K4ZIt3UDHmUYdR05me6e0BtRZ02vPBDt1hCWDlMmCH7O41evcpXFo5O1cDb9Wz00ppufrmFey0wg8TBFyFa8Cxr/GxvUtwkQPuNfL8zpi7d8pILTj2YmtcmRjXDWZwVhTEpxeiEU1m77mZ6OtRlrQyjEIyQ+zEo+D+v+BLVxywdeISmusH98yKLnF2QAtWc8hqAdebwJe5bGCO3pm01eovd4/lQ/1vIDkqQq/GCYSBdZwcRgxzuhHc3pEDnqEo91wS6jDhAJhgoNwe9IKRPJbWY965+o+SP0YTFl+m9XHlVBL3S9B509+x9KZT7RUFEV6rEkTkFMy/YIj4gI0H6iv2PfMYhv42rgXlkF3qMoIicwt9jeAuPJX09ZAuMV7YVVMn701W X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.06.25 13:02, Huang, Ying wrote: > David Hildenbrand writes: > >> On 13.06.25 18:33, Bijan Tabatabai wrote: >>> On Fri, Jun 13, 2025 at 8:45 AM David Hildenbrand wrote: >>>> >>>> On 12.06.25 20:13, Bijan Tabatabai wrote: >>>>> From: Bijan Tabatabai >>>>> > > [snip] > >>> I did not use get_vma_policy or mpol_misplaced, which I believe is >>> the >>> closest function that exists for what I want in this patch, because >>> those functions >> >> I think what you mean is, that you are performing an rmap walk. But >> there, you do have a VMA + MM available (stable). >> >>> seem to assume they are called inside of the task that the folio/vma >>> is mapped to. >> >> But, we do have a VMA at hand, so why would we want to ignore any set >> policy? (I think VMA policies so far only apply to shmem, but still). >> >> I really think you want to use get_vma_policy() instead of the task policy. >> >> >>> More specifically, mpol_misplaced assumes it is being called within a >>> page fault. >>> This doesn't work for us, because we call it inside of a kdamond process. >> >> Right. >> >> But it uses the vmf only for ... >> >> 1) Obtaining the VMA >> 2) Sanity-checking that the ptlock is held. > > 3) update NUMA balancing per-folio cpupid state (via should_numa_migrate_memory()). How is the vmf used for that ("it uses the vmf only for ...")? But yes, anything that relies on "thiscpu" and "thisnid" might be fault-specific as well (what I mentioned further below) -- Cheers, David / dhildenb