From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65110109022C for ; Thu, 19 Mar 2026 14:21:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC5556B04D4; Thu, 19 Mar 2026 10:21:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A9B976B04D6; Thu, 19 Mar 2026 10:21:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B1E66B04D7; Thu, 19 Mar 2026 10:21:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 888346B04D4 for ; Thu, 19 Mar 2026 10:21:05 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 29CE416060C for ; Thu, 19 Mar 2026 14:21:05 +0000 (UTC) X-FDA: 84563024490.03.F0BEAA9 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf05.hostedemail.com (Postfix) with ESMTP id A7806100011 for ; Thu, 19 Mar 2026 14:21:03 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=MRcM9xy6; spf=pass (imf05.hostedemail.com: domain of ljs@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=ljs@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1773930063; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kfSXr4urRrjcj/S/mrZbqRGT5j7GhC0125qWzQv+Krs=; b=O1fIXcKT21J9gz/KxLpd47QpN1OYUJ0PKLw6mXvFVYQD5P0C93JaDLlOOBkRNp5znV9aPS kG/jjo1OBquA8q9EdbwQBfglXtqfboRAamihUdqQcIjhr3Bq3U8hkV4peHjTDm1ARtsLnU 5FbEDBIJhGbgMBgbMlYaKdH72TxLNR0= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=MRcM9xy6; spf=pass (imf05.hostedemail.com: domain of ljs@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=ljs@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1773930063; a=rsa-sha256; cv=none; b=gOkfBydscKvrNB+Wr5WtzaJMir7ovWs7/gbzdz+fxekAwXGD4b/5FdvYcvWlAjQcizIGRM ex6ZvFUHH3kFKIKr9OrSvoPwnEthIZoeVO5V1/XFHKoorwlj3bDlHcOuFJzFSvHhfl9M7V x5JihUp5OI8apgnL0CsavpTTHVvQXso= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 06DE260054; Thu, 19 Mar 2026 14:21:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E157C19424; Thu, 19 Mar 2026 14:20:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773930062; bh=hloQh1pJoXmEXMOlDUXK84ib0nwYZGczcXxlM+VCi2k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MRcM9xy67Fted5xe37sVxp3BmyygXrtfYkz5/iutI0Xh1wW8POLhKiNYc7CLq5IG0 P+GSBCqz9kM8/7Od0B6KytgitXAJ7Zyqwn7ebBlIFSTlHRGIJn+VnWHhEeSX6VtMX1 5FPxCVVE1JP1OIJSCGs1nIk9yrRFmXBCHOL1AshTFbmU3neog5MQ1gTe/zPJOpZr97 vARSX45iEnijjaIuarm4PLvKi8UcHylPi5lk/T7f9QrT63vNBpTJQUtQiK8vpZ0JcE sQqUfbqG+6w1VOGr336sjvrPQcFlGKNBcua4fZ+FR8vD6IXSsmyOkb4oT31wV/PmJI h31d3KgoEfAxg== Date: Thu, 19 Mar 2026 14:20:48 +0000 From: "Lorenzo Stoakes (Oracle)" To: "David Hildenbrand (Arm)" Cc: linux-kernel@vger.kernel.org, Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Sebastian Andrzej Siewior , Clark Williams , Steven Rostedt , linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-mm@kvack.org, linux-rt-devel@lists.linux.dev Subject: Re: [PATCH 2/2] mm: introduce CONFIG_NUMA_MIGRATION and simplify CONFIG_MIGRATION Message-ID: <5a31d1ed-7972-4d73-a39d-b1c7ed593a02@lucifer.local> References: <20260319-config_migration-v1-0-42270124966f@kernel.org> <20260319-config_migration-v1-2-42270124966f@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260319-config_migration-v1-2-42270124966f@kernel.org> X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: A7806100011 X-Stat-Signature: fy66nzdg5twmxhgxx688af81ew5u4d8d X-Rspam-User: X-HE-Tag: 1773930063-926766 X-HE-Meta: U2FsdGVkX1+assbOLoITzk3uEOOLJPfCcl4c6rCvjreWYPqPad/Y6/C7Xu3rKXAj7/OBNfcIrJlnj/GPpADG1gChBMaCYHaf9LDcMBwiWnwJR084A64LwQ/BVIXVWV/0ovWB+gBgCS3nPsshpYSYqkllQde6sYfObhHUii3lf18n7SInP4aIqjz/d8nJwf17HKztdX/RfzF01W3F2d0NiqUts1qk/Rf52QMLIGA2cExNwGaF1Mi+UkauRzL6viEPa8u20xZUOQ7U/PgJDwPv0dLmcTJjyxhk1lXDIn4n870e55xmeibTQQbejWWoNBH3ggvIpf97uE14HYw0NZ+7RVr5S3lrOEllPKR/eQrEuVl9TQT6ZvXgy5l8L2TtHuHX8n6qNQ3PgK+d7qHkSbgucpoxfoBjXhhuUH0AeQPkagqFptuBIAd5KfIUf1z/pGf53dkrZIaQR612bmwZICGHNR51LfxKog9Qu8xe+av4ENDC4tB719tUNyEQWBV3yQ+kVPtjuPld+l4u2miuou3/Yn/87vErDWTXPObAP7uvZJyBktB1igEQfdkTMexB526YnpzEWt/pZPiy0D2IqeYMDdNoz3xTU8MiNoJvyIyD/gMmJ0hsX28LlM7UyjcX/+Wo4nmGMMjh1842UA+f2jSwYeUlusnrargWDVEClz8KeiA1qgDE2phbR33EuYqsOcaAK28EK1YPN2VLzoIekmjpPFwUMK3CFNzOrQTyo21hDojVviCmLzlw8NNWXMneo7ovMJga34AMndVUd12vvTmF9EtLd6TYxJnQApKScWP+7Umt6TZUGvhsOr+wfVMrN0aNsmU3OE07/QlXtEzBTGEseo35GIyfGhZZAs4oZPgO/PXFqxkTGilWrCIE1J4t7YJ7Y87xZ5sReZaBuXDJQHHhQ8PP/uPNx3/i2lPTGO3iiTtOeILo86RMC7FZvb6dlH+ZZXqd8Fr9gFJXWzVk7QZ qEkgVEBt zePx16YnHRABzJQKbEeFPCbaeW4c7jjyXyiJY Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 19, 2026 at 09:19:41AM +0100, David Hildenbrand (Arm) wrote: > CONFIG_MEMORY_HOTREMOVE, CONFIG_COMPACTION and CONFIG_CMA all select > CONFIG_MIGRATION, because they require it to work (users). > > Only CONFIG_NUMA_BALANCING and CONFIG_BALLOON_MIGRATION depend on > CONFIG_MIGRATION. CONFIG_BALLOON_MIGRATION is not an actual user, but > an implementation of migration support, so the dependency is correct > (CONFIG_BALLOON_MIGRATION does not make any sense without > CONFIG_MIGRATION). > > However, kconfig-language.rst clearly states "In general use select only > for non-visible symbols". So far CONFIG_MIGRATION is user-visible ... > and the dependencies rather confusing. > > The whole reason why CONFIG_MIGRATION is user-visible is because of > CONFIG_NUMA: some users might want CONFIG_NUMA but not page migration > support. > > Let's clean all that up by introducing a dedicated CONFIG_NUMA_MIGRATION > config option for that purpose only. Make CONFIG_NUMA_BALANCING that so > far depended on CONFIG_NUMA && CONFIG_MIGRATION to depend on > CONFIG_MIGRATION instead. CONFIG_NUMA_MIGRATION will depend on > CONFIG_NUMA && CONFIG_MMU. > > CONFIG_NUMA_MIGRATION is user-visible and will default to "y". We > use that default so new configs will automatically enable it, just > like it was the case with CONFIG_MIGRATION. The downside is that > some configs that used to have CONFIG_MIGRATION=n might get it > re-enabled by CONFIG_NUMA_MIGRATION=y, which shouldn't be a problem. > > CONFIG_MIGRATION is now a non-visible config option. Any code that > select CONFIG_MIGRATION (as before) must depend directly or indirectly > on CONFIG_MMU. Nice. I always found it odd that it was optional. > > CONFIG_NUMA_MIGRATION is responsible for any NUMA migration code, which is > mempolicy migration code, memory-tiering code, and move_pages() code in > migrate.c. CONFIG_NUMA_BALANCING uses its functionality. > > Note that this implies that with CONFIG_NUMA_MIGRATION=n, move_pages() will > not be available even though CONFIG_MIGRATION=y, which is an expected > change. > > In migrate.c, we can remove the CONFIG_NUMA check as both > CONFIG_NUMA_MIGRATION and CONFIG_NUMA_BALANCING depend on it. > > With this change, CONFIG_MIGRATION is an internal config, all users of > migration selects CONFIG_MIGRATION, and only CONFIG_BALLOON_MIGRATION > depends on it. > > Signed-off-by: David Hildenbrand (Arm) AFAICT this all LGTM, so: Reviewed-by: Lorenzo Stoakes (Oracle) > --- > include/linux/memory-tiers.h | 2 +- > init/Kconfig | 2 +- > mm/Kconfig | 26 +++++++++++++------------- > mm/memory-tiers.c | 12 ++++++------ > mm/mempolicy.c | 2 +- > mm/migrate.c | 5 ++--- > 6 files changed, 24 insertions(+), 25 deletions(-) > > diff --git a/include/linux/memory-tiers.h b/include/linux/memory-tiers.h > index 96987d9d95a8..7999c58629ee 100644 > --- a/include/linux/memory-tiers.h > +++ b/include/linux/memory-tiers.h > @@ -52,7 +52,7 @@ int mt_perf_to_adistance(struct access_coordinate *perf, int *adist); > struct memory_dev_type *mt_find_alloc_memory_type(int adist, > struct list_head *memory_types); > void mt_put_memory_types(struct list_head *memory_types); > -#ifdef CONFIG_MIGRATION > +#ifdef CONFIG_NUMA_MIGRATION > int next_demotion_node(int node, const nodemask_t *allowed_mask); > void node_get_allowed_targets(pg_data_t *pgdat, nodemask_t *targets); > bool node_is_toptier(int node); > diff --git a/init/Kconfig b/init/Kconfig > index 444ce811ea67..3648e401b78b 100644 > --- a/init/Kconfig > +++ b/init/Kconfig > @@ -997,7 +997,7 @@ config NUMA_BALANCING > bool "Memory placement aware NUMA scheduler" > depends on ARCH_SUPPORTS_NUMA_BALANCING > depends on !ARCH_WANT_NUMA_VARIABLE_LOCALITY > - depends on SMP && NUMA && MIGRATION && !PREEMPT_RT > + depends on SMP && NUMA_MIGRATION && !PREEMPT_RT > help > This option adds support for automatic NUMA aware memory/task placement. > The mechanism is quite primitive and is based on migrating memory when > diff --git a/mm/Kconfig b/mm/Kconfig > index b2e21d873d3f..bd283958d675 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -627,20 +627,20 @@ config PAGE_REPORTING > those pages to another entity, such as a hypervisor, so that the > memory can be freed within the host for other uses. > > -# > -# support for page migration > -# > -config MIGRATION > - bool "Page migration" > +config NUMA_MIGRATION > + bool "NUMA page migration" > default y > - depends on (NUMA || MEMORY_HOTREMOVE || COMPACTION || CMA) && MMU > - help > - Allows the migration of the physical location of pages of processes > - while the virtual addresses are not changed. This is useful in > - two situations. The first is on NUMA systems to put pages nearer > - to the processors accessing. The second is when allocating huge > - pages as migration can relocate pages to satisfy a huge page > - allocation instead of reclaiming. > + depends on NUMA && MMU > + select MIGRATION > + help > + Support the migration of pages to other NUMA nodes, available to > + user space through interfaces like migrate_pages(), move_pages(), > + and mbind(). Selecting this option also enables support for page > + demotion for memory tiering. > + > +config MIGRATION > + bool > + depends on MMU > > config DEVICE_MIGRATION > def_bool MIGRATION && ZONE_DEVICE > diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c > index 986f809376eb..54851d8a195b 100644 > --- a/mm/memory-tiers.c > +++ b/mm/memory-tiers.c > @@ -69,7 +69,7 @@ bool folio_use_access_time(struct folio *folio) > } > #endif > > -#ifdef CONFIG_MIGRATION > +#ifdef CONFIG_NUMA_MIGRATION > static int top_tier_adistance; > /* > * node_demotion[] examples: > @@ -129,7 +129,7 @@ static int top_tier_adistance; > * > */ > static struct demotion_nodes *node_demotion __read_mostly; > -#endif /* CONFIG_MIGRATION */ > +#endif /* CONFIG_NUMA_MIGRATION */ > > static BLOCKING_NOTIFIER_HEAD(mt_adistance_algorithms); > > @@ -273,7 +273,7 @@ static struct memory_tier *__node_get_memory_tier(int node) > lockdep_is_held(&memory_tier_lock)); > } > > -#ifdef CONFIG_MIGRATION > +#ifdef CONFIG_NUMA_MIGRATION > bool node_is_toptier(int node) > { > bool toptier; > @@ -519,7 +519,7 @@ static void establish_demotion_targets(void) > > #else > static inline void establish_demotion_targets(void) {} > -#endif /* CONFIG_MIGRATION */ > +#endif /* CONFIG_NUMA_MIGRATION */ > > static inline void __init_node_memory_type(int node, struct memory_dev_type *memtype) > { > @@ -911,7 +911,7 @@ static int __init memory_tier_init(void) > if (ret) > panic("%s() failed to register memory tier subsystem\n", __func__); > > -#ifdef CONFIG_MIGRATION > +#ifdef CONFIG_NUMA_MIGRATION > node_demotion = kzalloc_objs(struct demotion_nodes, nr_node_ids); > WARN_ON(!node_demotion); > #endif > @@ -938,7 +938,7 @@ subsys_initcall(memory_tier_init); > > bool numa_demotion_enabled = false; > > -#ifdef CONFIG_MIGRATION > +#ifdef CONFIG_NUMA_MIGRATION > #ifdef CONFIG_SYSFS > static ssize_t demotion_enabled_show(struct kobject *kobj, > struct kobj_attribute *attr, char *buf) > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index e5528c35bbb8..fd08771e2057 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -1239,7 +1239,7 @@ static long do_get_mempolicy(int *policy, nodemask_t *nmask, > return err; > } > > -#ifdef CONFIG_MIGRATION > +#ifdef CONFIG_NUMA_MIGRATION > static bool migrate_folio_add(struct folio *folio, struct list_head *foliolist, > unsigned long flags) > { > diff --git a/mm/migrate.c b/mm/migrate.c > index fdbb20163f66..05cb408846f2 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -2224,8 +2224,7 @@ struct folio *alloc_migration_target(struct folio *src, unsigned long private) > return __folio_alloc(gfp_mask, order, nid, mtc->nmask); > } > > -#ifdef CONFIG_NUMA > - > +#ifdef CONFIG_NUMA_MIGRATION > static int store_status(int __user *status, int start, int value, int nr) > { > while (nr-- > 0) { > @@ -2624,6 +2623,7 @@ SYSCALL_DEFINE6(move_pages, pid_t, pid, unsigned long, nr_pages, > { > return kernel_move_pages(pid, nr_pages, pages, nodes, status, flags); > } > +#endif /* CONFIG_NUMA_MIGRATION */ > > #ifdef CONFIG_NUMA_BALANCING > /* > @@ -2766,4 +2766,3 @@ int migrate_misplaced_folio(struct folio *folio, int node) > return nr_remaining ? -EAGAIN : 0; > } > #endif /* CONFIG_NUMA_BALANCING */ > -#endif /* CONFIG_NUMA */ > > -- > 2.43.0 >