linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Raghavendra D Prabhu <raghu.prabhu13@gmail.com>
To: fengguang.wu@intel.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	akpm@linux-foundation.org,
	Raghavendra D Prabhu <rprabhu@wnohang.net>
Subject: [PATCH 1/3] mm/readahead: Change the check for PageReadahead into an else-if
Date: Sun, 10 Jul 2011 01:11:18 +0530	[thread overview]
Message-ID: <5a2186efeb299af150b1bef10f1c3a428722b3de.1310239575.git.rprabhu@wnohang.net> (raw)
In-Reply-To: <cover.1310239575.git.rprabhu@wnohang.net>

>From 51daa88ebd8e0d437289f589af29d4b39379ea76, page_sync_readahead coalesces
async readahead into its readahead window, so another checking for that again is
not required.

Signed-off-by: Raghavendra D Prabhu <rprabhu@wnohang.net>
---
 mm/filemap.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/mm/filemap.c b/mm/filemap.c
index a8251a8..074c23d 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -1115,8 +1115,7 @@ find_page:
 			page = find_get_page(mapping, index);
 			if (unlikely(page == NULL))
 				goto no_cached_page;
-		}
-		if (PageReadahead(page)) {
+		} else if (PageReadahead(page)) {
 			page_cache_async_readahead(mapping,
 					ra, filp, page,
 					index, last_index - index);
-- 
1.7.6

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-07-09 19:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-09 19:41 [PATCH 0/3] Readahead fixes Raghavendra D Prabhu
2011-07-09 19:41 ` Raghavendra D Prabhu [this message]
2011-07-09 20:47   ` [PATCH 1/3] mm/readahead: Change the check for PageReadahead into an else-if Wu Fengguang
2011-07-09 19:41 ` [PATCH 2/3] mm/readahead: Remove file_ra_state from arguments of count_history_pages Raghavendra D Prabhu
2011-07-09 20:47   ` Wu Fengguang
2011-07-09 19:41 ` [PATCH 3/3] mm/readahead: Move the check for ra_pages after VM_SequentialReadHint() Raghavendra D Prabhu
2011-07-09 20:53   ` Wu Fengguang
2011-07-10 12:59     ` [TOME] " Raghavendra D Prabhu
2011-07-10 15:59       ` Wu Fengguang
2011-07-11 23:02         ` Re. Revised [PATCH 3/3] mm/readahead: Remove the check for ra->ra_pages Raghavendra D Prabhu
2011-07-12 18:09           ` Wu Fengguang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5a2186efeb299af150b1bef10f1c3a428722b3de.1310239575.git.rprabhu@wnohang.net \
    --to=raghu.prabhu13@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=fengguang.wu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rprabhu@wnohang.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox