From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1096EC10F1A for ; Fri, 10 May 2024 01:55:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 951C06B0083; Thu, 9 May 2024 21:55:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9018D6B0087; Thu, 9 May 2024 21:55:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CA5D6B0088; Thu, 9 May 2024 21:55:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5BE436B0083 for ; Thu, 9 May 2024 21:55:31 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 10984A02D7 for ; Fri, 10 May 2024 01:55:31 +0000 (UTC) X-FDA: 82100819262.12.84CB5AC Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by imf28.hostedemail.com (Postfix) with ESMTP id 22AA9C0013 for ; Fri, 10 May 2024 01:55:27 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715306129; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xh0KpMkDVzoP9h7beG2HlY4zc33dBBaeT8VoohTS630=; b=lrm8q5j4KzrDcSFORBwqn7Q4R2ACgx9A1dTVm6EYD01TRw/JUcyUhH26L6MDVke1A8HiDH HwD4fsgl0HghV1qFel/KlP3NP5UYGiC8qaCZcUWuMNo/hKWyKd5o4rcRSCv02XuMYb8+aS b6gPojagxjNoBYuwDIgRf0QsY1xQXpw= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715306129; a=rsa-sha256; cv=none; b=WiA3XzKQdkZ1DuM9UWi2jTJ8ZAlDaeLJlG+v1IoC06dJusPBEN5nrCh5WKoZhY8hWy0NQi qz6natt4sP4EiksWhy1S4//PoQOKn0LEQo1bRGpAUhPwebXQ8kaEZXLiibdEXxPBWl+gL8 XfVYAcHARs+U4wL8OT7AfDL6KyPPZCg= Received: from mail.maildlp.com (unknown [172.19.88.163]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4VbBhQ3lrDz1j4cY; Fri, 10 May 2024 09:52:06 +0800 (CST) Received: from dggpemm100001.china.huawei.com (unknown [7.185.36.93]) by mail.maildlp.com (Postfix) with ESMTPS id 57DC0180045; Fri, 10 May 2024 09:55:24 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 10 May 2024 09:55:23 +0800 Message-ID: <5a1eb9ca-663c-4d38-855a-c29297ecbeab@huawei.com> Date: Fri, 10 May 2024 09:55:23 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH rfc 4/4] mm: filemap: try to batch lruvec stat updating Content-Language: en-US To: Johannes Weiner CC: Andrew Morton , David Hildenbrand , Michal Hocko , Roman Gushchin , Shakeel Butt , "Matthew Wilcox (Oracle)" , , , Muchun Song References: <20240429072417.2146732-1-wangkefeng.wang@huawei.com> <20240429072417.2146732-5-wangkefeng.wang@huawei.com> <411eb896-56c6-4895-a2ba-6c492f8b51fd@huawei.com> <20240509140149.GA374370@cmpxchg.org> From: Kefeng Wang In-Reply-To: <20240509140149.GA374370@cmpxchg.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm100001.china.huawei.com (7.185.36.93) X-Rspamd-Queue-Id: 22AA9C0013 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 49npodwj39ffjg3ic6ntas6x7bm1nm9d X-HE-Tag: 1715306127-680048 X-HE-Meta: U2FsdGVkX1+lCsKbwhJWXkhW5oJNjigWDJq2xKrcOOWyM1S7N1iusyV5coy5stQpP7uI+Ok1cAENo/yVmHIahMZ7WqOHyEkJTrroKJNDMeIEZ4Gv661jNrw25jfP8NuF821bsOhVcDvQulCt8aAKvP0eFnw0mSUPwQ6NzwfAzYgpb9V+nNhNuR4t8Oy5IGmfgodqQUdwlnMjfWgfOOB02KUdBy2TW+163UPBV6MR363n97x3i/UD/bEC6kVPRQqC55p6Ft0OAHLjUFd0XGzmc7yejEuC9FAb0lqXQmFc551DZ5hJEj1wiqDib1X8kGNWwyEy0qbHiqIjMGrD4d88OChUb7fVW3t1KPFRgnys5yd5jrB5qurMEppR3N9915359v+xHMd7iISzxMFWNU2rE/26T7mmrHjyMu7N9TMokKMgPxwGLxDU3qfGpHD4w3PNuJZ2Bs5VGRiN1cATmXjeyRvL5mhi4rp7ZIlJUqU1N/5uZz0/K1MoUmSmbr8kcigRyJkJbD/Szng0+Rzn8zIENegGi3qcUgAdEs5wbx49b6ShFLzEU/5eyqmxZi9n4eU1gjOIhEZMKPErmRg05vBYUcY11Rm59Iu9YHNKyDvLjuNsbufpKxuVDW6Otpjey+/BqmfHSpOb3ki1ucWDFMhbuL7E3uAszcB1r0xW9gk0wuH+J0HariG1/RWx0BU/sx87hpVfmB93hg8e8p8SsmXjulfkiZ9WqHI7e1ApZH8VjuUy7TtLpjBkF4m6c5h7p2B4XM6/UH/+RUnL7LIZHnHPtPsKREjg0djB7cya342oY6dmcpFY4jzmxkppr01jrH1G7sijZzTZpzqmEJxFUIxTcr/1lkTJAjgx0yVG/ojmoYzpu/8Rg4XSCuJzMg9shj6JLpu7CeAmY2oJxxOji0tv5e5dnim8E4lfoU9R23oJ4ql0qJCCXe5LDDkZ9YAllXeHi4Diii2+avpaudtfDBM Q847oIHM +lep/DKKvX8T7G5k744gEBZT8Pr+K0pucmddKYRuuuz26H0fyLv6e1sYcy+lIS2zXj894yNhvT+RxWJ3CnF+P1/NPh/5lPcWoBtKFFtFNcTW17rDj2owIsehvt2bM6pc/muU9XqAd3w+Lnv7JC3alcg4cK7cgA+f1ho4iV8j4VSg12Zg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/5/9 22:01, Johannes Weiner wrote: > On Tue, May 07, 2024 at 05:06:57PM +0800, Kefeng Wang wrote: >>> +static void filemap_lruvec_stat_update(struct mem_cgroup *memcg, >>> + pg_data_t *pgdat, int nr) >>> +{ >>> + struct lruvec *lruvec; >>> + >>> + if (!memcg) { >>> + __mod_node_page_state(pgdat, NR_FILE_MAPPED, nr); >>> + return; >>> + } >>> + >>> + lruvec = mem_cgroup_lruvec(memcg, pgdat); >>> + __mod_lruvec_state(lruvec, NR_FILE_MAPPED, nr); >>> +} >>> + >>> vm_fault_t filemap_map_pages(struct vm_fault *vmf, >>> pgoff_t start_pgoff, pgoff_t end_pgoff) >>> { >>> @@ -3628,6 +3642,9 @@ vm_fault_t filemap_map_pages(struct vm_fault *vmf, >>> vm_fault_t ret = 0; >>> unsigned long rss = 0; >>> unsigned int nr_pages = 0, mmap_miss = 0, mmap_miss_saved, folio_type; >>> + struct mem_cgroup *memcg, *memcg_cur; >>> + pg_data_t *pgdat, *pgdat_cur; >>> + int nr_mapped = 0; >>> >>> rcu_read_lock(); >>> folio = next_uptodate_folio(&xas, mapping, end_pgoff); >>> @@ -3648,9 +3665,20 @@ vm_fault_t filemap_map_pages(struct vm_fault *vmf, >>> } >>> >>> folio_type = mm_counter_file(folio); >>> + memcg = folio_memcg(folio); >>> + pgdat = folio_pgdat(folio); > > You should be able to do: > > lruvec = folio_lruvec(folio); > > and then pass that directly to filemap_lruvec_stat_update(). It's obviously better, will update and address David's comment in patch3, thank you.