From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3D1CD44D51 for ; Wed, 6 Nov 2024 11:34:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3CA866B008C; Wed, 6 Nov 2024 06:34:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 352026B0092; Wed, 6 Nov 2024 06:34:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 17E336B0096; Wed, 6 Nov 2024 06:34:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id EB72D6B008C for ; Wed, 6 Nov 2024 06:34:56 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8C4A4ACCF9 for ; Wed, 6 Nov 2024 11:34:56 +0000 (UTC) X-FDA: 82755462384.23.D8C4571 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf22.hostedemail.com (Postfix) with ESMTP id 9E2E9C0008 for ; Wed, 6 Nov 2024 11:34:11 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=d2yTKQWt; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="/4qpIzVt"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=d2yTKQWt; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="/4qpIzVt"; dmarc=none; spf=pass (imf22.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730892770; a=rsa-sha256; cv=none; b=kYlSrf87A2ULjOeIORWE29lv2PvG3Xfuz7K5LVI24awnI5CkrxAIV5N8EkVl/njbkHafcr WkRakH/uGtdt425h4YNad72z15+zz/N6HhU3Eh7AKSIB3qL+0FHGZttZm5MHzOJUukgYt7 5V1li5W50DO9AAQuRGwcf9xaToEMuv4= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=d2yTKQWt; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="/4qpIzVt"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=d2yTKQWt; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="/4qpIzVt"; dmarc=none; spf=pass (imf22.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730892770; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VChFcxMjZBWpc6S97dcYJOhNqqKS2GBMQFw3nKiQzdQ=; b=3gTQTfMED+kshAgiGFf130k4unZ+HRWDIxp20lbFKPnHoVfR80fHScecthjJJJYZEErDg5 CgFCx0Ogm4OwMXhXH6SbDhkKvmzdWdkcUy53dIh25sD89v7QrdIrm8Tcj8pXHxayvFHi7s oW4S0k31kyb7cBdqGf+XI6UT9qFOksg= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 70B4F21A52; Wed, 6 Nov 2024 11:34:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1730892892; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=VChFcxMjZBWpc6S97dcYJOhNqqKS2GBMQFw3nKiQzdQ=; b=d2yTKQWtgKT5+sCaqNX+y8wx0hImNH1+EM5iHz38O9GYGgsYdB3vQq2XAgfn6lCEh1q4Gq zviUjb7XACWlNWaYbt5ixiWZqG0IY0TTO5LA9nYKB0NMh6CFTJXglakMQ6uXnneu3dq0GP +0Sw7SrikXUoVUOCTub6Jmc4CHe2d8Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1730892892; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=VChFcxMjZBWpc6S97dcYJOhNqqKS2GBMQFw3nKiQzdQ=; b=/4qpIzVtslx/m2aZ8r2psAEdHSHE5O28idOYYi+CGkm5vnBn02/qAI3ThCmANgVoIkOriM c1+EEX4ko5OtehCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1730892892; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=VChFcxMjZBWpc6S97dcYJOhNqqKS2GBMQFw3nKiQzdQ=; b=d2yTKQWtgKT5+sCaqNX+y8wx0hImNH1+EM5iHz38O9GYGgsYdB3vQq2XAgfn6lCEh1q4Gq zviUjb7XACWlNWaYbt5ixiWZqG0IY0TTO5LA9nYKB0NMh6CFTJXglakMQ6uXnneu3dq0GP +0Sw7SrikXUoVUOCTub6Jmc4CHe2d8Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1730892892; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=VChFcxMjZBWpc6S97dcYJOhNqqKS2GBMQFw3nKiQzdQ=; b=/4qpIzVtslx/m2aZ8r2psAEdHSHE5O28idOYYi+CGkm5vnBn02/qAI3ThCmANgVoIkOriM c1+EEX4ko5OtehCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 578EB137C4; Wed, 6 Nov 2024 11:34:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id +q8BFVxUK2e0fAAAD6G6ig (envelope-from ); Wed, 06 Nov 2024 11:34:52 +0000 Message-ID: <5a1e67c3-481e-4c6e-8507-5a8ea0bd9f28@suse.cz> Date: Wed, 6 Nov 2024 12:34:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: slab warning: kmem_cache of name 'dm_bufio_buffer' already exists Content-Language: en-US To: Mikulas Patocka , Pedro Falcato , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton Cc: zkabelac@redhat.com, Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org References: <9c3fecc3-19dc-42d4-6c89-4a48e9ad19cc@redhat.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <9c3fecc3-19dc-42d4-6c89-4a48e9ad19cc@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 9E2E9C0008 X-Stat-Signature: 9hbfccggkp166t3exdp8q4dq3ojnng6b X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1730892851-105881 X-HE-Meta: U2FsdGVkX1+0MjmkAtIeqRscKY/eOcj36n3pqvhK1ckyLykfvhb1NjT39OXvjsUVDxDw1tmuTL9uw9E3vgMw2ZdL6UlYs+JHNDaJlr2MKaK7NRs+3hRRNFNcOX++8o7WcIlu+A1+jr4GPZ9QcVJCFyV2V3Zu7eN7EdH4d+PmCqvbayddI+ChEh4SsHaGSw1EJgxINpFkH790w3Yl8cpZ7ij3B1B1zT9flDkm2Hhr0VvFmoe+/0n/jsueiVk2X8pOlXpRgv25ph/RDu6KJ3gVT6kTRRT0teoEjrR5lbJlg7/mAzxObrsXQflZNZ97Y9nlTBfPz2en4W52se+h4jC3ok7HMB7lF57fl8qJkdOoavEWXhn3xP7tz/iybVABVTtsiGeGpSp4aMYlHPBtS4TTiT9FzY5NQq/+GIMV1NpSm2W78sgbqlElJD1V2JOLRYzCP82kGwBzrF0t2R9F3THs2pdxqR0s0l8xsvTH7QKxcP9APFIhIi1pYQw+cPHei/WrXcCTfw+BzafJs3sq482ydBM2whrlYERuz16e5Wgf1jpyUOpOBIWP7G2kmSgWJZXzjUkBtnAOXbI6jLWaIVNEWI7A8kDm5JtbemnSpjfp7GD2bQ5q0pAZ4u9f3zMhDCgviygiwELWCgiNDTiuY0loCwY8719X0cGJ7So09mpqOjyNcFhgWmvrsz89FIDhVo5S4WxhA8+vZl4Q0W2ZanMu+K694g0OZFCFjlaYoDb2fATIJBCHtGOK6cbMd8uhUxNuKKxAk3lXG9+VLBgf309Gh/I8dJH0SF1CyPNBhE6QnGMIzCEy7v0nJvMYq70du5KBCxwJshpHTJ1HcEFeht3c1CGCcD7aWy70ITtrF9HavwGBwXSj9V83m3SP/xyVcV0qDNwoZDS6sjdq8CG/sIUfoxcyDMf1chH6Muiwif9uWPFVmrZvwGMBNlgUJ2nYlMMwk4G0reDrhyR8rdHEizw J0hpZdMA fpkrK1SmOcZ6z2yUHMDMW0FhJnZ8PfdRi47ZA5SsVEkNm5QpivQ8ehPFV5Km23Ar+cAaA9p2LXPUWfWl/MIMWnMLHLfOQLH02S13UF+T+dHW4DJFY2WBxZUafgjbTrE3kTRRIIgdxmPXeQT9EyJ0XmqoZrV3Xhq42j0Qcsp68v8BJn/KKoJ+4+UthkmSiFgpIS7MRWEzDUA9PSA2kSDAK2blSCQWkKbqsCevgVam5aloMIhXkqvCRNU5KS33hkZa+ebfn68wrbAJjGIPJ8BsGzuHO6lyZlTMaOneYky9tICsvthgS6ZXLlZ/phL+w8Ug0CizVXfpmpfAuUq9NNkfbUbR8i55d35yyThedLgTskeerVQ1rIhyNB7yzqTon28g9bzpHV5ZaVfhA5rSeH3StXgppiw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/6/24 12:19, Mikulas Patocka wrote: > Hi Hi, > The commit 4c39529663b93165953ecf9b1a9ea817358dcd06 ("slab: Warn on > duplicate cache names when DEBUG_VM=y") is causing large number of > warnings about "dm_bufio_buffer", "dm_bufio_buffer-%u" (and other) device > mapper caches. Hmm wonder why nobody run into this before. We thought the code that would cause the warning would be all fixed before introducing it, but we missed some, sorry. > I'd like to ask - how to properly fix it? > > We create a "dm_bufio_buffer" or "dm_bufio_buffer-%u" cache with every dm > bufio client. It used to work (and the duplicate caches are merged), but Note the merging can be disabled so then it's really several caches with exactly same name in /proc/slabinfo and inability to create their sysfs/debugfs directories. > now it warns. > > Should I append a pointer to the dm_bufio structure to the slab cache name > to make them different? Or is there any other preferred solution? Anything that uniquely identifies the client should be ok, but beware e.g. device names that can have slashes, see commit a360f311f57a36 (also for the simplest possible fix that is an incremented number). > Note that it is not possible to pre-create the cache "dm_bufio_buffer-%u" > in the module's init function, because the size of per-buffer auxiliary > data is not known at this point. Looks like some chose to solve this the harder way, see 4d784c042d164f > Mikulas >