From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77CADEB8FA5 for ; Wed, 6 Sep 2023 07:25:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F0558440009; Wed, 6 Sep 2023 03:25:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E8EC48E0014; Wed, 6 Sep 2023 03:25:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D082A440009; Wed, 6 Sep 2023 03:25:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BDBD78E0014 for ; Wed, 6 Sep 2023 03:25:11 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9AA671CA905 for ; Wed, 6 Sep 2023 07:25:11 +0000 (UTC) X-FDA: 81205336422.13.039098B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 804B7A000C for ; Wed, 6 Sep 2023 07:25:09 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fDh457oC; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693985109; a=rsa-sha256; cv=none; b=tTQ1vKr9DIRl+AVCoeCECE/uFvFqiIff1jc73GC8JPcl6oijwF4KFHb5n7v7MkmluUorrS 01BBYXl73VlrtacXN/juYWSNF+mj54qemmgKb3PN1tg+fvMVNzJ3iTfYGGFBSJwbrKQvLN oAIjkgsYN5HA+DgzmjLdrczu9bhTaXc= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fDh457oC; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693985109; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0Uz0kkibCEdCa1bHtL8NWEjsr8N03quGywOaB0uDPzg=; b=u2UutAOhyQ1Q/XIhNapX/S32F1UduABAJIHHK7LsVqF/ywZEANkijCq0w8BAIiDLVnefjy g1qQJfsgVKlD+qjwPq2kbkSiaVIqEx+z/9zW5HMeScHIQUeWQg8pVi0soRmQPKHmV0Ysr/ VWOQxxSJtlBGG7eAqusYfwUvK7MN14M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1693985108; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0Uz0kkibCEdCa1bHtL8NWEjsr8N03quGywOaB0uDPzg=; b=fDh457oCahgk/jj08aL2oE/+x9CEaxzNFOHQDOnXDRaDtoKiApPWIdcmi4CDCjHPkHdrnY hsy4qqAN5S+81iMlqcdJs8K2NWmSOxOCxjQY/Tlg7jUkJJD95HOZXW/np7i/hc2aawJTW1 8XygQqKbq8ix/nEqjsTOU04qxchMTxs= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-329-FLDiMJCkPkmID3Dpib6c7Q-1; Wed, 06 Sep 2023 03:25:07 -0400 X-MC-Unique: FLDiMJCkPkmID3Dpib6c7Q-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3fef5403093so2870365e9.0 for ; Wed, 06 Sep 2023 00:25:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693985106; x=1694589906; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0Uz0kkibCEdCa1bHtL8NWEjsr8N03quGywOaB0uDPzg=; b=amyJCn9WDA3zOvF8TqzXQrBtpAFwMpq6JDtK10ZKew9d4DqRFVbwkCITHtqXpMBkj9 /I99DOQYSYC4l513mnqeWREpJFZkwhuloX4IlpihFbP5yTICTWmuxx3BnoZlIcqAfShn KCMkNoc3HmakmtBr1KrvSpmgMNBOxiaXUt2pQheThZc20ip0ke/0uDDtbZx/t0B0q1HL DjJ79pLKByXDVmqXUaG63A5bgK3NQ6yXUKt01eLBD7kXFWFcMNWUTrIVPpUSZpJ71ZR5 6+fV1kWgJ8jhYPM5jL78COjFNPI6RFSWe2DdtmWNAc1oTZdYg9VwOd4OTJprW0oBi4L0 4/6w== X-Gm-Message-State: AOJu0YxcaJ/h1ABJY90wfeFISDGnGJIV+7GipaYJZclMfif2izkrcOGT MtSUXAu0boDHy+ju6oltOLk8+p7PlkgXZ0fjrD8Hplb5Q4DhLd6QURmsLxRT9P6LSjGP/4TX/Ba DB1cx2i+TF8k= X-Received: by 2002:a05:600c:2611:b0:3fe:da37:d59 with SMTP id h17-20020a05600c261100b003feda370d59mr1719928wma.4.1693985106668; Wed, 06 Sep 2023 00:25:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF+U+pBqPoHI/LZw69+mAg/vr+OEOuGiL2cZqK7t7C214K5S1R3TRk8tFPLVbuvKjBprb1YGg== X-Received: by 2002:a05:600c:2611:b0:3fe:da37:d59 with SMTP id h17-20020a05600c261100b003feda370d59mr1719912wma.4.1693985106301; Wed, 06 Sep 2023 00:25:06 -0700 (PDT) Received: from ?IPV6:2003:cb:c70c:6c00:92a4:6f8:ff7e:6853? (p200300cbc70c6c0092a406f8ff7e6853.dip0.t-ipconnect.de. [2003:cb:c70c:6c00:92a4:6f8:ff7e:6853]) by smtp.gmail.com with ESMTPSA id l8-20020a05600c1d0800b003fef6881350sm19681458wms.25.2023.09.06.00.25.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Sep 2023 00:25:05 -0700 (PDT) Message-ID: <5a166236-fc05-b7f1-1054-8cf7d7352641@redhat.com> Date: Wed, 6 Sep 2023 09:25:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 1/2] mm: hugetlb_vmemmap: fix hugetlb page number decrease failed on movable nodes To: Mike Kravetz , Muchun Song Cc: Yuan Can , Andrew Morton , Linux-MM , wangkefeng.wang@huawei.com, Michal Hocko References: <20230905031312.91929-1-yuancan@huawei.com> <20230906002814.GA3740@monkey> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230906002814.GA3740@monkey> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 804B7A000C X-Stat-Signature: jrrgy7hoy914aubiitcyi9rg8fwf7zcg X-Rspam-User: X-HE-Tag: 1693985109-724698 X-HE-Meta: U2FsdGVkX199rS0JvYcJfE/UOhkPaWRcTsIdgTf82kKPOk20bWTO+2osyPTU+BMbaL8CPHPpXhLBnPBzuLLIlkVROrgVoX8sG2Dx0Ae4HNacMFdOcLRg3Tc/iAfce+O+KzyTwyS+HrC2tyx/MFORZgwD6OP3KQxAPANwFn3rLbRG2anLdW2iQMP0BzT1mkoqmUo6mUk8TKzv+21Y5cIJqZYDQRBPDFFq9lL52xcsOqjoJhePoaCf4Vo/xShPayKSDPXlucsgEcoXL77YNrK5GODcHxaFdUITPe4cBjzvvMKA5APyrRepckOk84Q/4rlF6Muabwl0xu7bJ2S05WkzkpcKqyvZ1WDUcbvhh3IGJ9g2WgpcwWzVohm48oo1cNW1bA0BtIizP/PsKC0b3sdIFyUo85Yss5z8ElNi71BkSVXBbAzM/2aJlyHtAljLdlPAFpLzABo6aifyMw137Exg0H5Qg7DfHuBsbzalq6xAamjBE8ybMDg0sPohjlMtBRapzsvRAac60Q60r2MUsm3YksO8k9sTfTnZABkDYluFTw+x18I8MBoIBOEqzgYPzS/rGdwgMbnv1cfqYrDA0wyYoo257ontBOnzx1EpduFe8DnRCZvt4ZGW1bvi9UCyfRXKThh7PJ6V/oJE1cW73WgKsHlGFmtb6o2azM9ly3pdzoyJVxeh0GLXvp4CMExRRfefOyKXRoSnRs6C57gDW4sTMYSddsvMkJOO/SVr+KhSbimbsPcKDWz8H7UPyl3MHFtAFnxH07zCwYlObW/2rweqBF3XyMg9U0yhV09bxhz14bRjxq50Ex4kjg++Q00btB0ip9LAznj9aUBcogKNij8cRFhe1ktbC7OWl0uMJqkky5QvAFtyF9wK6qo2oHmPyPQSPJTYmCLCl4qFIrd5XfcKN7Ml87Z7Z9ZsjEqI8iw1Vaun94aJCD/GxJEzV0PHsjdFkAK7o5P+qUCAPFEq5Al PRCoP561 tLZMv/Loq0EtiFjiUJ+lUSVqCcA7nEa4tqUUI/AP14pW3PDkGWmrnWD7TUq1J3yZyiJOnHaqbnrcqlzwwXWJC+fvZ+GobF+V1Xg/MkKRtNScb73bPkHYHIpGBQVfcxE2PH4GaLKdnNS6gaHZIsc995kzpWNB48W2YZnhl2OAT4CZSoMRRj1FbsWiW3gdkZNi8Gc71g0QbhzSAuCN3Dy/oKrpHirw8CUx9zB4QJ2lvhh7tg9w7aZUrqGTnywb+v57Qatxw3DCnzXETLBpaVJseTWxVAIQHcD0bfb7I9kSr8hPEwPN6Fk72TYPuDk7pICB/mcn2+9veEx+uxWMygWkDSAIxrZ96pWkLwRuQVY99gK47/+/NUAu5KE5U6n3bGmG6/zjDnlOoB1ETi4LxOB/1ty6LkgkDl5M/ENaOHFvhoubgtuJWI8hhhplCfiM5/1ZIkotO39UlGPJ/69U3KDqeCQKACm+pQDJG3PjTPdth1+JA52oAKlWLE8GrSsHaApteGUlJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: >>> releasing. With GFP_KERNEL and __GFP_THISNODE set, allocating from movable >>> node is always failed. Fix this problem by removing __GFP_THISNODE. >>> >>> Signed-off-by: Yuan Can >>> --- >>> mm/hugetlb_vmemmap.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c >>> index c2007ef5e9b0..0485e471d224 100644 >>> --- a/mm/hugetlb_vmemmap.c >>> +++ b/mm/hugetlb_vmemmap.c >>> @@ -386,7 +386,7 @@ static int vmemmap_remap_free(unsigned long start, unsigned long end, >>> static int alloc_vmemmap_page_list(unsigned long start, unsigned long end, >>> struct list_head *list) >>> { >>> - gfp_t gfp_mask = GFP_KERNEL | __GFP_RETRY_MAYFAIL | __GFP_THISNODE; >>> + gfp_t gfp_mask = GFP_KERNEL | __GFP_RETRY_MAYFAIL; >> >> There is a little change for non-movable case after this change, we fist try >> to allocate memory from the preferred node (it is same as original), if it >> fails, it fallbacks to other nodes now. For me, it makes sense. At least, those >> huge pages could be freed once other nodes could satisfy the allocation of >> vmemmap pages. >> >> Reviewed-by: Muchun Song > > This looks reasonable to me as well. > > Cc'ing David and Michal as they are expert in hotplug. IIUC, we still won't allocate from ZONE_MOVABLE / MIGRATE_CMA (due to GFP_KERNEL), so it should be fine. -- Cheers, David / dhildenb