From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 07949CAC58E for ; Mon, 15 Sep 2025 06:29:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 501E88E0008; Mon, 15 Sep 2025 02:29:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D8DD8E0001; Mon, 15 Sep 2025 02:29:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C7518E0008; Mon, 15 Sep 2025 02:29:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 262298E0001 for ; Mon, 15 Sep 2025 02:29:43 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B9F8111A281 for ; Mon, 15 Sep 2025 06:29:42 +0000 (UTC) X-FDA: 83890508604.01.17A34F9 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf12.hostedemail.com (Postfix) with ESMTP id 41F5C40006 for ; Mon, 15 Sep 2025 06:29:40 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=jaZLS26l; spf=pass (imf12.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1757917780; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=M/xuln62q5zfY1XqnOkzluoH/jhmqhYNwkmp3WpUxjM=; b=K5oxOOT90eb/xTlz52pHxZ/Y/QeFuyXgKTlWktfMTdL6Fms6I/7FTsn0VrFgJC8THOhpY7 i7n31ERxWTrWXIfab+zv0KU25gm30whCpN8lZ3rXAWZjowhMWIqWrax/Lgn3gUFSfU/YwB J3wFxaxXB/72UzdgByHgz5An95H4LZ0= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=jaZLS26l; spf=pass (imf12.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1757917780; a=rsa-sha256; cv=none; b=hAw+W9CUfdcW1nDiXR2GlUvh6DZyTeUBe3h4v3/uIXoWTI3MPeODJup7ShV9HuhnM9uBXa wcEjwhOWk2yWCfLbUMZw2098BxMlswbwYnoEEmvWDTH/wKftqQLaMAObSjbBo+a6Gr15c5 I5O2t6txfS5uoPD5GroefTc6snAzrJs= Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58EH2k6T008844; Mon, 15 Sep 2025 06:29:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=M/xuln 62q5zfY1XqnOkzluoH/jhmqhYNwkmp3WpUxjM=; b=jaZLS26lBDtzg2fecSZHqg vv5wXs+Q/QWPzoKutrrQc6JlTQgh9S++0kG1xYTEEhhACxrSaEwrVcmFNUrm5aqi OtK0MYRXJHIvOwUxdJDVmGllntU+dWQ/n1X9T0qND7U13HpIsA/bx3E95xS6zSiA G61SjiM2ehKgCwcxj/d9UyDG2/tPRNmRQ1Hbt9E+RCa/4Ymom5k7ti/+qmaBBf+f VEyzVGOhzGaTidXPVx4X8SSv3dIj5Oxjs0qsGj5K8mF92mOvsSCfHnnElObmQvvm y7XvEJjXSIurhHceuMaFZFx9Txg7BTX7q6CqqSlAH22dER7OpbB+bhODUu/v3N6w == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 49509y0tk9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Sep 2025 06:29:00 +0000 (GMT) Received: from m0353729.ppops.net (m0353729.ppops.net [127.0.0.1]) by pps.reinject (8.18.1.12/8.18.0.8) with ESMTP id 58F6NRje019684; Mon, 15 Sep 2025 06:29:00 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 49509y0tk4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Sep 2025 06:29:00 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 58F2ZLlc029484; Mon, 15 Sep 2025 06:28:58 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 495kb0n5uq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 15 Sep 2025 06:28:58 +0000 Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 58F6SuNA58458606 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 15 Sep 2025 06:28:56 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8B80F20043; Mon, 15 Sep 2025 06:28:56 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5171820040; Mon, 15 Sep 2025 06:28:54 +0000 (GMT) Received: from li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com (unknown [9.87.136.34]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTPS; Mon, 15 Sep 2025 06:28:54 +0000 (GMT) Date: Mon, 15 Sep 2025 08:28:52 +0200 From: Alexander Gordeev To: Kevin Brodsky Cc: David Hildenbrand , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andreas Larsson , Boris Ostrovsky , Borislav Petkov , Catalin Marinas , Christophe Leroy , Dave Hansen , "David S. Miller" , "H. Peter Anvin" , Ingo Molnar , Jann Horn , Juergen Gross , "Liam R. Howlett" , Lorenzo Stoakes , Madhavan Srinivasan , Michael Ellerman , Michal Hocko , Mike Rapoport , Nicholas Piggin , Peter Zijlstra , Ryan Roberts , Suren Baghdasaryan , Thomas Gleixner , Vlastimil Babka , Will Deacon , Yeoreum Yun , linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, Mark Rutland Subject: Re: [PATCH v2 0/7] Nesting support for lazy MMU mode Message-ID: <5a0818bb-75d4-47df-925c-0102f7d598f4-agordeev@linux.ibm.com> References: <20250908073931.4159362-1-kevin.brodsky@arm.com> <20250908191602.61160a7990b9ea418de758c7@linux-foundation.org> <338ef811-1dab-4c4e-bc5f-8ebd8cb68435@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <338ef811-1dab-4c4e-bc5f-8ebd8cb68435@arm.com> X-TM-AS-GCONF: 00 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTEzMDAyMCBTYWx0ZWRfX4Cx2ngBEYL5c roZzmS41YuVlUSpSRef2KxL4WggODwY/soRMJpx2gg7kNLdYMyZvXNoqxYULYholGjNDiAVT4t6 ukIUbG+OX0a4imqOK2lAsyx5041sIs8EVQMQ06NsJGnBzkaxygCee6tTvsutuzI9wnG+eg3PA/v F5e7gPnCVAvuDEchpnbMPDdE4TzdeZAArCZTLOmkY9Xd7mYwn00cbVETqAT3ckHgDdrWLphTxSN y5ALHiTawyw3ojSiUQHSaHqzU+geaiqg5gb2LGGBqmnxp5igHqNKf3fjoaJ0BgJ2I38Ya10WbMS bYUlmQ5btypMVlGwBcuKVUODKwIOxTQn2bBDW8olvvXBnB4V+w9kPSd+TVwMJmnqFMZo71QBQkH T1vGkEV/ X-Authority-Analysis: v=2.4 cv=OPYn3TaB c=1 sm=1 tr=0 ts=68c7b22c cx=c_pps a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17 a=8nJEP1OIZ-IA:10 a=yJojWOMRYYMA:10 a=nkFB8puKy1KDrdvMtSoA:9 a=3ZKOabzyN94A:10 a=wPNLvfGTeEIA:10 X-Proofpoint-GUID: dbH_inTMwHRH6BHBdGMtY8_aObQAr3rR X-Proofpoint-ORIG-GUID: XMRhk7th-c6XacqgLmk45pWkcqEsR17O X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-15_02,2025-09-12_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 phishscore=0 suspectscore=0 spamscore=0 bulkscore=0 malwarescore=0 impostorscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2509130020 X-Rspamd-Queue-Id: 41F5C40006 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: y3fsbtdco9wgybntpd1iihtf88c7k6ac X-HE-Tag: 1757917780-318664 X-HE-Meta: U2FsdGVkX195Y2VVI4cAfNAag7CVuRSzlvXelgP7Kry6M4z5Jh+EljvQklXtehINMA3hd8PdXQXgk9TZK0WuNA0FaZ5i/zn5b/BVuqZtFnuZVaM4i4MQnK1HEpVaM5cWjaRwKBQHj38WQ4v3bgCsTOqOB730cJdCYTO5XoVpG5J/sGb9j0mdcOxKDF1ME4/9s8FbRwHHrr39T36zSCrSt1s9RU15K+th0hRPX976baB3/rqTzMNbuBWwr2s0FzJF+LdiKWhZSGPj6+4wJEAju0R7jpy0WmKuXK/3wswnjyqjsgnmHp5C+816seMFvmDTFEKxSUysJ5AXKv3+otA2gpBUds9G/yfyc3p5nN/RXHHtOHlGnTqNoO9q+VdFcyuJPwKBjknkbjPRgnmuls/TxNdljqGMli3kcxGTzYFwO8NJX7Xz+rrL1IcFDUoyhy7xa/BA4InRMf2LMNX43tI2YCLDfPHRvB7tB0crrXwB7ZR4UwIGzP/F2RzAVCmKtS3ehJJirkK2BqZs5S6ej94wAGTiJ6kF823gw4XXCD7etNUJWLFFdGg+B2NRM7P2XxRUjre1Cz/AzcfwCHleOUnEA7f/BBmbVJrNqqcdPE93fnUb9rnMyRrWEhlbHL7Vk1gdDGF3D+8bObLZor7mvzesLnY57uhEEM81cZ2HtfLoolHCpTmYJKuH02GTV/AML4ykstz40oa0i+Iwpmkf/0jkIP0wGvtSuJRAhECiY2nBopHJpknx1NZcTEro85xw3kut0Yj8uF0xZBqYGG5/oJyEhjaGFveRptk6PoqUoTRhJQoqyxOlUIwpbTE0FFJUUuKUbWeQIsW7O3Vo/UD0Bt+Juqa5tldQo9umWfOLgo9Yhj42mufyI8tahWa0Osrb6gHGvPJLCvknpmSu2HNGxu6NmWyNIsoHpY/ebj4yzp+IchpyJ95W6tSBEZCmS6nQRxcCreH/mp3lIp/ALkzc8h7 cQRmiqSs bqH3DxwukkXbG2hVch+GATunYB80T3z+2WkbUcjRSbuUBFF5Guf9eQCPKKAdi7h5Eth922RLpUHx/HKCu+yZ1unnaVXnQJf40cU6j9LDBdEjm3c0Nq7KoZPltP7flu6Ip84ZVft94yumgn0hQsmPzFPZKUgKlrJiTy+maJrppbJM7HPuA1E8hjCHzlzoHgi1pwX8kZNApg6usQ/tplklq1zkfyhkZC8NZcNBf3WN7rycIMjrwLZ5fEEw76Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Sep 12, 2025 at 05:25:27PM +0200, Kevin Brodsky wrote: Hi Kevin, > Based on the outcome of the discussion with David on patch 2 [1p], there > is indeed an alternative approach that we should seriously consider. In > summary: > > * Keep the API stateless, handle nesting with a counter in task_struct > * Introduce new functions to temporarily disable lazy_mmu without > impacting nesting, track that with a bool in task_struct (addresses the > situation in mm/kasan/shadow.c and possibly some x86 cases too) > * Move as much handling from arch_* to generic functions > > What the new generic infrastructure would look like: > > struct task_struct { >     ... > #ifdef CONFIG_ARCH_LAZY_MMU >     struct { >         uint8_t count; >         bool enabled; /* or paused, see below */ >     } lazy_mmu_state; > #endif > } > > * lazy_mmu_mode_enable(): This helper is parameter-free, assuming the MMU unit does not need any configuration other than turning it on/off. That is currently true, but (as I noted in my other mail) I am going to introduce a friend enable function that accepts parameters, creates an arch-specific state and uses it while the lazy mmu mode is active. That does not impact your design (AFAICT), except one change below. >     if (!lazy_mmu_state.count) { >         arch_enter_lazy_mmu_mode(); >         lazy_mmu_state.enabled = true; >     } >     lazy_mmu_state.count++; > > * lazy_mmu_mode_disable(): >     lazy_mmu_count--; >     if (!lazy_mmu_state.count) { >         lazy_mmu_state.enabled = false; >         arch_leave_lazy_mmu_mode(); >     } else { >         arch_flush_lazy_mmu_mode(); >     } > > * lazy_mmu_mode_pause(): >     lazy_mmu_state.enabled = false; >     arch_leave_lazy_mmu_mode(); This needs to be arch_pause_lazy_mmu_mode(), otherwise the arch-specific state will be lost. > * lazy_mmu_mode_resume(); >     arch_enter_lazy_mmu_mode(); Conversely, this needs to be arch_resume_lazy_mmu_mode(). And it can not be arch_enter_lazy_mmu_mode(), since a lazy_mmu_mode_resume() caller does not know the parameters passed to the lazy_mmu_mode_enable(...)-friend. >     lazy_mmu_state.enabled = true; ... Thanks!