From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0818CC4345F for ; Thu, 25 Apr 2024 09:32:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 954046B00A1; Thu, 25 Apr 2024 05:32:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8DD1A6B00A2; Thu, 25 Apr 2024 05:32:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7572B6B00A3; Thu, 25 Apr 2024 05:32:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 57E676B00A1 for ; Thu, 25 Apr 2024 05:32:06 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 015161604D0 for ; Thu, 25 Apr 2024 09:32:05 +0000 (UTC) X-FDA: 82047537852.28.D6E23BD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id AC8E4C0023 for ; Thu, 25 Apr 2024 09:32:03 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ehvbpZOu; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714037523; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mnmbtryFAkUEZBg67jmxurFPcm0tT5vjHgjHviKbo7I=; b=at3PAfvcvKf8mfmlYJ3hw73E4sKM69lkoTuJ4Rs/xFNex18aRR4YgirAWrPVXhl80WLWL/ 6V3uLEYn31efRvL5uB4fS7rQ+pECk2Q65lBbBQLfMNSxiYEIvAaUjqbUt6nX3D84BQC4tk qfrpxL326zcuGbHlcQ2cIPTFIh/6ZmI= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ehvbpZOu; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714037523; a=rsa-sha256; cv=none; b=k3eHdXq670MA+CMUsokF7h6y+UFby2L+zSW4ubazBXbO3V0gzsdfy07YFqJpjvX+DEZ6Dl XraUQpvAVj4cYYTL/eOfaeFUR6FaZ98VL7nImWosQDgvmA62MUIh6xA9Sk4j2qcymFMnxK KPrFAa9JzTmyvrcBix5dyX9jhlTCOTk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714037522; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mnmbtryFAkUEZBg67jmxurFPcm0tT5vjHgjHviKbo7I=; b=ehvbpZOu49T1gBUmvK9YZRVSRB7IzPV8wP4MjrNcZ1uD7SLekAHUhUqLMwG807UgySHf7q ud/D3la00sjLsLgEI9f5ZHhuh9tQBL8AZwZfln3Dub1D5XdNmN3kY1ulHr6O24buywJ/bZ qWJPdn6jmfBUknt1h2oao0klUUbC9Bo= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-77-WOgSL-_3NzWmQ3OXBBxuLA-1; Thu, 25 Apr 2024 05:32:01 -0400 X-MC-Unique: WOgSL-_3NzWmQ3OXBBxuLA-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-34bf4e9ae01so526879f8f.2 for ; Thu, 25 Apr 2024 02:32:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714037520; x=1714642320; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=mnmbtryFAkUEZBg67jmxurFPcm0tT5vjHgjHviKbo7I=; b=afsN8+4rKImdnoo5GsrQTj96G6uiq8dFpYu6E4H3TbmA1lGsjlDtzAdU9m++VOg1Rp 5xpnPCFKTg6MBb+tsA11PWby4oOxsuswR1k3hA7masNytDdgep9/VrxuAAeDrvmx7tF4 5DqLVhytseLjbRiR3051Qmpmw5Xqjke8KE230P+rwXc4hV+RhIMBbRl4fklOa+HWhT53 nK8kVL2BJjtuewq4dj+aCmL3ZbovW8HHLGycmCOtE/0eGukRxGG1BWX4YUnVepjBgH4u 6krbNuV4poxbMlzLBL3tsO6IC9c+kEvIuHDOpwnE9tDsRyeJLw5Z1MYlLCQztGSahBle xtxQ== X-Forwarded-Encrypted: i=1; AJvYcCVV2y1wyuB8ExO0YSKXW1JhM1EwE+l7x8fcYlUPgT2/blPUW7eRe0pvjqWVtjlt2YUcBprxD44Yl766YopwNhF7PhE= X-Gm-Message-State: AOJu0Yy0ZoOOIrCsEKGJ7VMXkk9ufxuf9I1Ti6g/HfBbgtKsZ+SI6e1Q DCvhX7DaxvjlgbHHbqiFjlGWxEkifjDx66UPTmLyy0djXL8ifV7edaoC4w1Y3AOnzN5ANFipRVM Lsiz1bQT6lb+nj3hM0HCjmgqTnwLPzA6rFezx3WOU2XEc01tr X-Received: by 2002:a5d:4251:0:b0:34a:b499:2c21 with SMTP id s17-20020a5d4251000000b0034ab4992c21mr4344461wrr.11.1714037520120; Thu, 25 Apr 2024 02:32:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IErBPGkyChGwvuxqNv2t6xLeSm7P34YzID8rqmaGt1K7CM5rPUxCULX5YookeBMDhG/K8uvoA== X-Received: by 2002:a5d:4251:0:b0:34a:b499:2c21 with SMTP id s17-20020a5d4251000000b0034ab4992c21mr4344440wrr.11.1714037519733; Thu, 25 Apr 2024 02:31:59 -0700 (PDT) Received: from ?IPV6:2003:cb:c719:8200:487a:3426:a17e:d7b7? (p200300cbc7198200487a3426a17ed7b7.dip0.t-ipconnect.de. [2003:cb:c719:8200:487a:3426:a17e:d7b7]) by smtp.gmail.com with ESMTPSA id k6-20020a5d6286000000b0034c124b80f7sm956644wru.61.2024.04.25.02.31.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Apr 2024 02:31:59 -0700 (PDT) Message-ID: <5a05d9be-6b7f-4b1f-88cd-cad17caf63ed@redhat.com> Date: Thu, 25 Apr 2024 11:31:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 09/10] mm: migrate_device: use more folio in migrate_device_unmap() To: Kefeng Wang , Andrew Morton Cc: willy@infradead.org, Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Zi Yan , Hugh Dickins , Jonathan Corbet , linux-mm@kvack.org, Vishal Moola References: <20240425084028.3888403-1-wangkefeng.wang@huawei.com> <20240425084028.3888403-10-wangkefeng.wang@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240425084028.3888403-10-wangkefeng.wang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: AC8E4C0023 X-Rspam-User: X-Stat-Signature: rf6ub5aseyjzp6b1nqzphfo9ryfsdcpi X-HE-Tag: 1714037523-83541 X-HE-Meta: U2FsdGVkX19bm719GeJHARmMaLlDoP1vf2kHPZSDy5iwf9GTwcFTdlaiVIRyHVJRTD8NKB6/d+EEDHuz9cO67fYY9BygepTRaFepM3+IadukXkoamRyPjMtFfiJoIvOU5lQp1ClRDvRsHJhuxvXJ7HVWrc78KL7xypiWP1QWFoqNJjJWLtAfjjUaAFpecO0kaP5ete5aGZbRv4PZg/TI2/NGapqHFA/bszywEFvLBA14AZdrjk5dcxd8NgxRiNWoTyn7UDUlKFRDcNQioAQ7HkMhfaTgatwsDX2TXReQfca4rMorliTnX5WnieN7JO3ugsakPlw/HYhTuoIqZa38Nx/+UgKIerVX0vTyKy37ZbbZgQGStve4RxYrtLDXdewr8XR+McTernudPltilceIoNCwzWIjFdn9qx/cRfx2iieqtAIM/1GTaqf3RWf5EEqEaku9Ngj3wAQq9taJOHysB8hMplAyE1U0NM3MimkgCvNf2a7njgUeTPPQ65Iz1x7KlAJQi2dpXIbIQO/8ChM0+Z/Dm26O1LPD78m7/SyTs7RCKGwtGkKCWz4G2s3MYIRmDgjb/pTHL4E6yWv9qT9nGuWtwLc85HwLH205yIpGcJDGRJIdXCS9mD3iLHlBLUz6gR/Q8cqqoIwRWjlRo5DiIVHi/iEI3uVh795kI/+w49WeFNefODpuVZh2zuTL2SvES2c3JwywOtEiv3sqcaJa0UU29u6HjIElSCY3BPz/mVEAZ8y+BlbKoGcodaV3KUpHWtqTsDmbrAI8+0PXhvdNAECOTsZtN4P+9wyUuXnKXqZHp8d3TeIkAeUleb4IYW38jtMUPm/ReRRCYGdEuMBdoMwYrEybZLxd0hx7pgCqmC1UggIo95e+1DY1BftDno+Zfv5CNV0wZdj7GeEGpmE7hlmnq27YiX36lENFDUP87aKTq/LsP63RU1DMYX2bgCZYNZKDSNOnkSGc3j8N1Ve MDp5K0A7 mrBNCADtKJXo+2LWd9TLDgbiNvP44afGLvPpF8FB32tW7vAFjFMk9fdQ5MbxJyd5FsJOXHcyFpT3qSeXXTTg2SKqaagK4EyJBAJiqyJk/g7Yu2sGddxzTaFbgWOC/QRgt4A8SDULs+k002Pm9grq4kRyD/AV+Gq/Wj3XbiPNWTCfTEHC8NTha4CZlA+v/J0JAPw7WY8nx+Mdcbox3SYc5ezhdLvcCJu2VS0nMpt/ujg6A/gcU3IpjNEqGWPRpqV2R2BbRuoCjRHk0rx3ggUMD+Eh4fTe/+PsuJ8LrPtvgkckX6iHpItSxV2CJbXT3frU1tnyRDKAL3HJw/czuITgoemaF8maYh/qOuzoWTC/acTMRGu85eJZsxgbEbVdNH2Qhnqkllw+frv1Dx8q1PV0nokU+Mwq/dljAyauU5wQDClPGYj/QgMR9dkTE1MYElCDVf7/kTiEGorP3jET+soriC63Q8A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25.04.24 10:40, Kefeng Wang wrote: > The page for migrate_device_unmap() already has a reference, so it is > safe to convert the page to folio to save a few calls to compound_head(), > which removes the last isolate_lru_page() call. > > Signed-off-by: Kefeng Wang > --- > mm/migrate_device.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/mm/migrate_device.c b/mm/migrate_device.c > index a68616c1965f..423d71ad736a 100644 > --- a/mm/migrate_device.c > +++ b/mm/migrate_device.c > @@ -379,33 +379,33 @@ static unsigned long migrate_device_unmap(unsigned long *src_pfns, > continue; > } > > + folio = page_folio(page); > /* ZONE_DEVICE pages are not on LRU */ > - if (!is_zone_device_page(page)) { > - if (!PageLRU(page) && allow_drain) { > + if (!folio_is_zone_device(folio)) { > + if (!folio_test_lru(folio) && allow_drain) { > /* Drain CPU's lru cache */ > lru_add_drain_all(); > allow_drain = false; > } > > - if (!isolate_lru_page(page)) { > + if (!folio_isolate_lru(folio)) { > src_pfns[i] &= ~MIGRATE_PFN_MIGRATE; > restore++; > continue; > } > > /* Drop the reference we took in collect */ > - put_page(page); > + folio_put(folio); > } > > - folio = page_folio(page); > if (folio_mapped(folio)) > try_to_migrate(folio, 0); > > if (page_mapped(page) || folio_mapped(), just as above -- Cheers, David / dhildenb