From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BD60C02181 for ; Mon, 20 Jan 2025 17:51:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4878A6B007B; Mon, 20 Jan 2025 12:51:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 40FA16B0083; Mon, 20 Jan 2025 12:51:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 28A606B0085; Mon, 20 Jan 2025 12:51:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 08DFB6B007B for ; Mon, 20 Jan 2025 12:51:03 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 86CF4801D4 for ; Mon, 20 Jan 2025 17:51:02 +0000 (UTC) X-FDA: 83028571164.02.7B0A6B9 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) by imf28.hostedemail.com (Postfix) with ESMTP id 6B65AC0008 for ; Mon, 20 Jan 2025 17:51:00 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=VY6NGt86; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.208.48 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737395460; a=rsa-sha256; cv=none; b=CjvxyUGAeAxR5X1GaMc6nHZVn9YlL6GWDl500CSKdwZ6GiZeYWmFHJ6U9eK6skd9Flszer raoN1eDH6JJjlM4KJZ4f4abJRuueJaCWuaQBSjCKjfHjQmKgk40BO6V2XqJLMfIslJY9mC UsCRuz3OFRPVIBcRKrpFFIVuvsm875A= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=VY6NGt86; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.208.48 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737395460; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Exmjcn6lh6wauJHBqfM/TCM16K2/QQBQEZN0i+kSpqI=; b=JUpJUNaD8pEnMPYpSktY9aYpEyB53QYLrRQ79j83W8vNaKrWXCtCg6CKSmluJhkBBC+5AE K9DSDAC5MdrdaJ8JaCGExoMPjXXj7AW69R7yTOGMyUUwtYq9LjtSGBscwYR52xNem2Jgqb i8vlPo3roIhzjOZZ/obJIylR/4V9nOw= Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-5da12190e75so9715819a12.1 for ; Mon, 20 Jan 2025 09:51:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737395459; x=1738000259; darn=kvack.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Exmjcn6lh6wauJHBqfM/TCM16K2/QQBQEZN0i+kSpqI=; b=VY6NGt86jKLeGHHa95kPxrRCCgQHtlRvqtj0DBJ3rDzjiDWRG3UNytZyigsmxRiOeC aubmRMNTbjhrtgyI2RZinBbQRjYwSRrvufJ7rkk6/CAXvbMuY+fDqlynfA1t/kLKkXWw Xm5UO8kyfbKMQywHXmQOpAZ2+esnDmaV1bI3o5+Z8Mlk/7nJHLsqiq0G1liyz7F0RKnH MU2/l/wQF5aSY0QouBVqY4jjcYtekzyliuMcVEhCW2zLIXmOZ40ogv6hLS9T+yJ05I09 YTi77P6QTQui/5rZ8NY0YuQoEE8SaVIpKr7JPMMQVVAJM7KvNC4W7L/8GlAV9Gz4Y9k4 cIoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737395459; x=1738000259; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Exmjcn6lh6wauJHBqfM/TCM16K2/QQBQEZN0i+kSpqI=; b=YSASDkrNsnhfoKb453vdi/9TWr/JvJw9LaLw9MFN/7wJRe+Vv1pTF2DS0Ae+GmFhwT 98gfQQVo60Eo6sN0aHaus2tRal+ZpqXEDYn0HZOMJhXKWmiefmixMeXy9axa7eO/SONk hAhUZdxjNUX0kxuM23wGgfIWAI6vQB6z6t+7tOrrdAv5KaPkgeLv4njGZop9S0IBR2WG XeFaFffNgMJ4BIJQVz9ViGZlvf/wfsp2Q1OxzpnS4+gxupJyOLYwUStOOWHCZWzu+7SU ELoZAb6toEaHGoXXu1MkpczAdwNf6t8lqQxlBw4zRM/XB2DqSRH8F8j4bZ8BOFlbrXqg HKrw== X-Forwarded-Encrypted: i=1; AJvYcCVU6lGH4rxr/JoYvc8venER4nxrCMZoSKrrsXEjgXnvv6Gx1iB1T5jmEmQWtnDxW5CGpth+M1vBbg==@kvack.org X-Gm-Message-State: AOJu0Yz9718b52XzPQAJh3MpyfnMMtB7o9gSUo5hqClKaKRDoc5Jmvad 8ey5JmJu/MG1Cm6jC032tK4+NsKxnBapSyzGvF5TSC5gg573tleP X-Gm-Gg: ASbGncvEIGP8VR33qb/DoeHwmMunL/OrzDxLpHtURHcUvdBaNGXe/bJBUUU55y38KFa QHNhRL1e+K2hLDWPQ3H7c6DjWnwoLekGNrjw5MXZowJcXPO1YJ8bXOjtKL17e2XZGPEI9fxH2Yi UCpPCA4xrsvUYTEE9LPH5l/ADgxLyqh2TIl+qVJw/AVtGm6XQzu1h2qMc/XsZ+2Fo19VYc5Jci+ M6U3o1rShjjXncfkkFAF2DP8S0ojRgcWdrBGLccz7AqNwPdju9qgVdAU3UJt8sjzE2WfgK+VACX /f14w8/a5A== X-Google-Smtp-Source: AGHT+IFbYq+Ft5rH6pT9zSbxDQnDtz7c/Xvt+8NX7LYSVi+AeSkfJyDRRGG1V6UenjLIrxM/xZqOUQ== X-Received: by 2002:a17:906:f6cd:b0:ab6:3704:5f0b with SMTP id a640c23a62f3a-ab637046235mr75406366b.10.1737395458663; Mon, 20 Jan 2025 09:50:58 -0800 (PST) Received: from smtpclient.apple ([132.68.46.60]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5db750293aesm5915723a12.71.2025.01.20.09.50.55 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Jan 2025 09:50:57 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.300.87.4.3\)) Subject: Re: [PATCH v5 10/12] x86,tlb: do targeted broadcast flushing from tlbbatch code From: Nadav Amit In-Reply-To: Date: Mon, 20 Jan 2025 19:50:44 +0200 Cc: the arch/x86 maintainers , Linux Kernel Mailing List , Borislav Petkov , peterz@infradead.org, Dave Hansen , zhengqi.arch@bytedance.com, thomas.lendacky@amd.com, kernel-team@meta.com, "open list:MEMORY MANAGEMENT" , Andrew Morton , jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com Content-Transfer-Encoding: quoted-printable Message-Id: <5F51AFA6-EA48-42BF-8E24-10FAAAA7BE4B@gmail.com> References: <20250116023127.1531583-1-riel@surriel.com> <20250116023127.1531583-11-riel@surriel.com> <13bc0c49-09a4-434e-bd35-1ea50be38e25@gmail.com> <4dcf2b4ecaede883e2c7f6af3db58a4f6afaf4ad.camel@surriel.com> <2975f6a4-58ef-4499-b177-4b73ead4c670@gmail.com> <2c93b3f17e658483e3ea03ca3f0a717668fd117d.camel@surriel.com> <11d9f41a-eae3-43a1-90bc-eb5c69020002@gmail.com> To: Rik van Riel X-Mailer: Apple Mail (2.3826.300.87.4.3) X-Rspam-User: X-Rspamd-Queue-Id: 6B65AC0008 X-Rspamd-Server: rspam10 X-Stat-Signature: ufi51axfe4qjzjnhszacdger9pwf7tsi X-HE-Tag: 1737395460-231657 X-HE-Meta: U2FsdGVkX1+xDNn8xkP9I/OrsClvL5/tk2z0GOCUoPA0UtnCOIgJe4qb4o+QPb5UU8gjbsqIIamJeVJd35Iwy3yKeG2C6xtWxhW/0zRKjkQ6nXNNLlTMctIqwS4oxzWtw8W0EgbyBB6U4F7CBzLC66SwC6H6X/t69lyl/gy2EtiBszm9fClIGbXWxXPS4DrnRAezgyE+1i85Po8HtgIvf2ODzEHF3ginyyAFBg8fWbAnUsTxYDdgiuTdoLYuLush/ZU5+MHqxL5pZMp42fyHSy/vv3qcPR4e9rOAtc3WMbNj+goYCVSbk9nncxPcPeGp52DBUTfUet74//GZSz1NAn+VgPfpFdM0xHDC9le+LOR+dG/uy0FGSbYXRefjYnuB4825r/H43xQsW5VVQYlJP8fbS3EJEEX3O/tZ5U4SQ6S8Dq+RqGy9doqIx7ql57OW2ZpJq4WWr0ikeh69eHu6fes/sEcHXWRqn7nbV/zFE9NxU6ZOr7T8HKN3KmN2KIVFF0FyCR9cgJoGA+BaCy1wAKUXj9l5mHQfMWofxEE1WiFzSaWvqjuBixKxSwP/O6HoHs7dkEChwhSnh4A41xrxHd9WMb6mwmic+DHn4xOa+nhH+O03uHHQSXYXh+HtT9C4duVjQDC/u8eXfjpZuuHB6XTkXZ79zaupTrraHN17yGKv/bHotD+R9MzKXOI2DOEoLyhPt0RgKB7l3wRHtIKBBZeoieZrYw2Cq93hlWNqULeQLc8hfaz8UBaOQVZ42GI2JZc93dWtGzg37O4tjPbzIcP/N9o3o4QUhN04vu7etzPlC5SOY/OSyKYOfgPa1pVGCWqT8iprB6teezDO2a8G1k8YTOTrVtNVrlSr13UlyT/Q1sxfNFfBuwDB2faOMCmFfkxVL+D1rtF+j5yKZnlHjcDPxp55MNgICJz4YgnjONiX+g7AKjUfcjGpVKUGV9JqU1kUoCAj5g0qpBMxTpw U1QOFLvC TWxXpQrTHKShxMPZxCJEcuvkLjL6ZE83hmWL2YP8iLSdWdvsOAmPwqZQJ0Z6bdCfKy4AS2vkWFNp6IGAz+2e85dLHDpINoqL+UGlGMjgp1hvjE+UIB0wxf2mXq9RIPe7FSQNXKkiMNexAGZguSce5oN5PaSTvYcAJO1xJM5muaG8GAD1CpLPrCUp2hTkaNbDA3V2sAGu5D990D2YkvDfpxdyJLa3Wh29AJTXQoOPLSMX/w1c00nU68LbNa3UNgO9Wfx41Zjcicn6IEnEAD6CLJHSpQBaWEiKDtdiXnUoL2pD6xFcjAPC9M91/N3cxDeQKqZAZrE4l4dg8K2q9HJh9BBjCAt+tNrF+TnvLpZE3vbFbhxf4S+h75lBzLJWJQGTqWeT6b5k6dJTqSNVfcgwtU5a0ufmtkVuCRv/1U+Ib5TJVzs5kpA4k/PCk4uQlO+C5GtJ5cYe+HhmcxARA86WfJYcafl9iAXOoeh7Q X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: [ Thanks for your patience. ] > On 20 Jan 2025, at 19:11, Rik van Riel wrote: >=20 > On Mon, 2025-01-20 at 19:09 +0200, Nadav Amit wrote: >=20 > This is the page reclaim code. >=20 > The process that has those other pages mapped might be > running on other CPUs simultaneously with the page > reclaim code. >=20 > Even if we were invalidating one of our own pages this > way, there could be other threads in the same process, > running while we are in the page reclaim code. Of course, but there is nothing new here. Let me see where we lose each other by first stating the goal, what you propose, and what I suggest. We are issuing invlpgb and we need to ensure tlbsync on the same core that initiated invlpgb before arch_tlbbatch_flush() finishes. That=E2=80=99= s all that matters for our discussion (correct me if I miss something). You solved it by disabling migration and running tlbsync at the end. I suggest *not* to disable migration, to keep running tlbsync at the arch_tlbbatch_flush() as you do, and if context-switch happens after arch_tlbbatch_add_pending() and before arch_tlbbatch_flush(), to run tlbsync during the context switch.